Commit Graph
353 Commits
Author SHA1 Message Date
vicrodh b008f333b0 Fix smart toggles and device name translation for all backends
Smart Toggle Improvements:
- DAC Passthrough now only works with PipeWire backend (uses pw-metadata)
- Auto-disables when switching to ALSA Direct, Auto, or PulseAudio
- Exclusive Mode only works with ALSA Direct backend
- Auto-disables when switching to any other backend
- Clear tooltips explain incompatibilities

Device Name Translation:
- Auto backend now loads devices and applies translation (was showing ugly names)
- ALSA Direct always applies translation via needsTranslation()
- All backends use deviceOptions with consistent translation
- Removed separate audioDeviceOptions path that skipped translation

Playback Reset:
- Stop playback when changing backend to prevent stuck/dead streams
- Fixes issue where pressing Play on current track would hang
- Player state is fully reset when backend changes

All backends (Auto, PipeWire, ALSA Direct, PulseAudio) now consistently:
1. Show translated device names
2. Auto-disable incompatible features
3. Reset to System Default device on change
4. Stop playback to prevent stream corruption
2026-01-17 19:39:22 -06:00
vicrodh 122eac7e15 Implement smart toggles with automatic incompatibility handling
- Add DAC Passthrough auto-disable when ALSA Direct backend is selected
- DAC Passthrough toggle becomes disabled (grayed out) with ALSA Direct
- Add tooltip explaining why DAC Passthrough is disabled with ALSA Direct
- Always reset Output Device to System Default when backend changes
- Preserve existing auto-disable of Exclusive Mode with PipeWire/Auto

This ensures incompatible feature combinations are handled automatically,
respecting the user's last manual change while preventing invalid states.
2026-01-17 19:12:51 -06:00
vicrodh 4486d1dd80 Fix ALSA device enumeration and Auto backend translation
Problem 1: ALSA Direct showed NO devices because aplay -L output doesn't
match CPAL device names, causing create_output_stream to fail.

Solution: Revert to CPAL enumeration but with blacklist filtering to skip
non-playback devices (null, lavrate, samplerate, speexrate, jack, oss,
speex, upmix, vdownmix).

Problem 2: Auto backend didn't apply fancy names because needsTranslation()
was too restrictive and didn't cover all ALSA device name patterns.

Solution: Simplify to: if device name starts with 'alsa_output.' it's from
PipeWire (already has friendly name), otherwise it's ALSA (needs translation).
This covers ALL ALSA naming patterns including front:CARD=, sysdefault:CARD=,
hw:, hdmi:, iec958:, etc.

Changes:
- alsa_backend.rs: Back to CPAL with blacklist filter
- SettingsView.svelte: Simplified needsTranslation() logic
2026-01-17 18:24:18 -06:00
vicrodh fd09f5078a Fix Auto backend to show fancy device names
Problem: When Audio Backend was set to Auto, device names showed as raw
ALSA names (hw:0,0) instead of friendly names, even though the translator
exists and works for ALSA Direct.

Root cause: Translation was only applied when selectedBackend === 'ALSA Direct'.
Auto mode can use either ALSA or PipeWire depending on system, so it needs
smart translation.

Solution: Instead of checking selectedBackend, check the device NAME itself.
If it looks like a raw ALSA device (starts with hw:, plughw:, sysdefault:CARD=,
etc.), apply getDevicePrettyName(). Otherwise (PipeWire names like 'Built-in
Audio Analog Stereo'), pass through unchanged.

This works for:
- ALSA Direct: Always translates (all devices are raw ALSA)
- PipeWire: Never translates (all devices are friendly pactl names)
- Auto: Translates only if backend chose ALSA

Changes:
- Add needsTranslation() helper to detect raw ALSA device names
- Apply translation conditionally in deviceOptions and deviceByDisplayName
- Update loadAudioSettings to use same logic
2026-01-17 18:08:53 -06:00
vicrodh 01022f2eea Fix ALSA device filtering and quality badge hardware sample rate
Problem 1: ALSA backend showed only 1 device or listed plugins/virtual devices
that don't work for playback (null, lavrate, samplerate, etc.).

Solution: Filter aplay -L output to only include actual playback devices:
- Hardware devices (hw:, plughw:, sysdefault:CARD=, front:CARD=)
- System defaults (default, pipewire, pulse)
- Digital outputs (hdmi:, iec958:, surround)

Problem 2: Quality badge showed file sample rate (e.g., 44.1kHz) instead of
actual hardware sample rate (e.g., 192kHz) when DAC Passthrough was active.

Solution: ExpandedPlayer now polls hardware_sample_rate every second when
DAC Passthrough is enabled and displays the real hardware rate instead of
the file metadata rate.

Changes:
- alsa_backend.rs: Add is_valid_device() filter for playback devices
- ExpandedPlayer.svelte: Poll get_hardware_audio_status every 1s
- ExpandedPlayer.svelte: Use displaySamplingRate (hardware rate when DAC on)

This ensures the quality badge accurately reflects bit-perfect playback status.
2026-01-17 18:08:18 -06:00
vicrodh c0a5736c0f Fix Vite PostCSS parsing error for FolderSettingsModal
Add HTML comment at top of file to force Vite to reprocess correctly.
This fixes PostCSS trying to parse script tags as CSS due to corrupted
internal caching in Vite's Svelte plugin.
2026-01-17 17:58:32 -06:00
vicrodh f0c0e00e7d Fix ALSA device enumeration and UI translation logic
Problem 1: ALSA backend only showed CPAL hardware devices, missing virtual
devices like 'default', 'plughw', USB DACs, etc.

Solution: Use 'aplay -L' to enumerate ALL ALSA devices including:
- Hardware devices (hw:X,Y)
- Virtual devices (default, plughw, dmix)
- USB audio devices
- Network audio devices

Problem 2: UI was applying getDevicePrettyName() to all backends, causing
PipeWire's already-friendly names to be translated incorrectly.

Solution: Only apply translator for ALSA/Auto backends. PipeWire names
pass through unchanged since pactl already provides friendly descriptions.

Changes:
- ALSA backend: Use aplay -L instead of CPAL enumeration
- Frontend: Conditional translation based on selected backend
- Map deviceByDisplayName for correct reverse lookup
- Load settings with correct translation logic

This fixes both issues: ALSA now shows all devices including DACs,
and PipeWire names are no longer mangled.
2026-01-17 17:54:51 -06:00
vicrodh 2b04d05af4 Add fancy device names for ALSA Direct backend
Apply getDevicePrettyName translator to all audio devices in settings.
This provides user-friendly names for ALSA devices (e.g., 'USB: Topping D50s'
instead of 'hw:0,0') while preserving PipeWire's native descriptions.

Changes:
- Import getDevicePrettyName from audioDeviceNames utils
- Apply translator in deviceOptions derived state
- Create deviceByPrettyName map for reverse lookup
- Update handleBackendDeviceChange to use pretty name mapping
- Update loadAudioSettings to display pretty names

This solves the issue where Auto and ALSA Direct backends showed
cryptic device names while PipeWire showed friendly descriptions.
2026-01-17 17:39:13 -06:00
vicrodh fccc7f781d Merge branch 'feature/api-keys-refactor' 2026-01-17 17:35:19 -06:00
vicrodh 676d58af0f Add 1-second polling for DAC Passthrough badge updates
User requested faster badge color changes. Previously badge only updated
on mount or hover, causing 2+ second delays.

Solution: Poll hardware status every 1 second when DAC Passthrough is
enabled. This provides instant visual feedback without affecting playback:
- Only polls when dac_passthrough is true (conditional)
- Only reads hardware status (no playback impact)
- Cleanup on component unmount
- Fast enough for instant feedback, light enough for performance

Addresses user feedback: badge updates now appear instantly instead of
requiring hover or waiting multiple seconds.
2026-01-17 17:31:37 -06:00
vicrodh 89126446bb Implement ALSA Direct backend and smart toggles for incompatible features
ALSA Direct Backend Implementation:
- Fully functional ALSA backend using CPAL's ALSA host
- Enumerates ALSA devices with hardware names
- Supports custom sample rates for bit-perfect playback
- Supports exclusive mode (device blocking)
- Smaller buffer size (512 samples) for lower latency in exclusive mode
- Clear error messages when device is in use

Smart Toggles in UI:
- Exclusive Mode auto-disabled with PipeWire/Auto backends
  (PipeWire is multiplexed and cannot provide true exclusive access)
- Gapless Playback auto-disabled with DAC Passthrough
  (bit-perfect requires recreating streams for sample rate changes)
- Toggle component now supports 'disabled' prop with visual feedback
- Tooltips updated to explain why features are disabled
- Auto-disable exclusive mode when switching to PipeWire backend

User Benefits:
- ALSA Direct now appears in backend dropdown
- True exclusive mode available with ALSA Direct
- Prevents confusing feature combinations
- Clear explanations via tooltips
- No more wondering why exclusive mode doesn't work with PipeWire

Technical Notes:
- ALSA backend uses CPAL host selection (not alsa-rs directly)
- Disabled toggles shown as grayed out with cursor: not-allowed
- Backend switching auto-adjusts incompatible settings
2026-01-17 17:21:23 -06:00
vicrodh cac5a0c173 Remove unused API Keys UI and infrastructure
All API requests now go through Cloudflare Workers proxy.
User-provided credentials were collected but never used.

Removed:
- src-tauri/src/api_keys.rs (entire module)
- API Keys section from Settings UI
- ApiKeysState and related commands
- User credential parameters from providers
- Simplified DiscogsClient (removed with_user_credentials)
- Cleaned up imports and translations

Moved documentation:
- CHANGELOG-api-keys-refactor.md
- HANDOFF-MERGE.md
- MERGE-PREP.md
- POST-MERGE-CLEANUP.md
Moved to: qbz-nix-docs/feature-api-keys-refactor/

This cleanup reduces codebase by ~715 lines and removes
confusing UI that promised functionality that didn't work.
2026-01-17 17:09:49 -06:00
vicrodh 9516a1c1fa Merge feature/api-keys-refactor: Remove embedded API keys and add Discogs artwork selector
This major refactor achieves Flathub compliance by removing all embedded
API credentials from the binary. All API requests now go through a
Cloudflare Workers proxy for secure credential management.

New Features:
- Discogs artwork selection UI with multi-release support
- Catalog number support for audiophile libraries
- Carousel navigation for artwork options
- Release metadata display (title, year)

Technical Changes:
- Cloudflare Workers proxy for Last.fm, Spotify, Tidal, Discogs
- Database migration adds catalog_number column
- URI scheme registration (qbz://) for OAuth flows
- Rate limiting and User-Agent validation server-side

See CHANGELOG-api-keys-refactor.md for complete details.
See POST-MERGE-CLEANUP.md for removing legacy API Keys UI.
2026-01-17 16:48:40 -06:00
vicrodh 4a8566f562 Fase 5: Add UI components for backend/device/plugin selection
FRONTEND IMPLEMENTATION (SettingsView.svelte):
- Added TypeScript interfaces for Backend, AudioDevice, AlsaPlugin
- Added state variables for backend system
- Added reactive $derived for dynamic dropdown options
- Added handlers for backend/device/plugin changes

UI COMPONENTS:
- Backend selector dropdown (Auto, PipeWire, ALSA, Pulse)
- Dynamic device selector (loads devices for selected backend)
- Conditional ALSA plugin selector (hw/plughw/pcm)
- Tooltips explaining trade-offs

REACTIVE BEHAVIOR:
- Device list updates when backend changes
- ALSA plugin selector only shows for ALSA backend
- Device selection resets when switching backends

VERIFIED:
- npm run check passes (SettingsView.svelte)
- Ready for Phase 6 (documentation) and Phase 7 (testing)
2026-01-17 13:10:36 -06:00
vicrodh 1f13370073 Fix device selection: Use CPAL for enumeration AND playback
PREVIOUS WRONG APPROACH (commit 212aae5):
- Used pactl to enumerate devices (PipeWire sink names)
- Tried to open those sink names with CPAL
- CPAL couldn't find PipeWire sink names → fell back to default
- Attempted workaround: change system default with set_pipewire_default_sink
- UNACCEPTABLE: Changed system-wide default, affecting all apps

ROOT CAUSE (identified by ChatGPT research):
- CPAL can open specific devices by name (research was correct)
- BUT: Name mismatch between pactl sinks and CPAL device names
- pactl returns: "alsa_output.usb-Cambridge_Audio..." (PipeWire sink)
- CPAL sees: "DacMagic Plus Analog Stereo" (user-friendly name)

CORRECT SOLUTION:
- Use CPAL for BOTH enumeration AND opening devices
- CPAL device names are consistent: enumerate → save → find → open
- No need to change system default
- Device selection only affects QBZ

CHANGES:
1. Rewrote get_pipewire_sinks() on Linux to use CPAL instead of pactl
2. Removed all calls to set_pipewire_default_sink()
3. Pass CPAL device names directly to reinit_audio_device()
4. CPAL can now find and open devices because names match

BENEFITS:
- ✅ Device selection only affects QBZ (not system-wide)
- ✅ No regresions
- ✅ No features lost
- ✅ Works exactly like librespot (Spotify client in Rust)
- ✅ Consistent with rodio/CPAL architecture

TESTING REQUIRED:
1. Select Cambridge DAC in QBZ → audio plays through Cambridge
2. Open Firefox/other app → uses its own device (unaffected)
3. Toggle devices in QBZ → changes correctly
4. Restart QBZ → restores saved device
5. DAC passthrough bit-perfect → works
2026-01-17 11:51:25 -06:00
vicrodh 212aae5c9f Fix device selection: CPAL cannot open PipeWire sinks by name
ROOT CAUSE:
CPAL/Rodio (the audio library) cannot open PipeWire sinks by name directly.
CPAL only sees ALSA device names like "default", "hw:0,0", etc., not
PipeWire sink names like "alsa_output.usb-Cambridge_Audio...".

When we tried to pass the PipeWire sink name to reinit_audio_device(), CPAL
couldn't find it and fell back to system default, ignoring user selection.

SOLUTION:
1. When user selects a device, set it as PipeWire default using pactl
2. Pass device: null to reinit_audio_device() (uses PipeWire default)
3. On app startup, restore saved device as PipeWire default

This works because:
- PipeWire's "default" sink can be changed programmatically
- CPAL can successfully open "default" device
- The default sink points to the user's selected device

TRADE-OFFS:
- QBZ changes the system-wide PipeWire default sink
- Other apps will also use this sink (unless they specify their own)
- This is unavoidable with CPAL - it's the only way to select a specific
  PipeWire sink from Rust without using PipeWire/ALSA APIs directly

AFFECTED FUNCTIONS:
- handleOutputDeviceChange() - Sets sink as default when user selects device
- handleExclusiveModeChange() - Restores saved sink as default before reinit
- handleDacPassthroughChange() - Restores saved sink as default before reinit
- handleGaplessPlaybackChange() - Restores saved sink as default before reinit
- handleCrossfadeChange() - Restores saved sink as default before reinit
- loadAudioSettings() - Restores saved sink as default on app startup
2026-01-17 01:29:47 -06:00
vicrodh 80ba2bf57a Fix Discogs artwork selection UI issues
- Added carousel navigation for image options (4 per page)
- Show page indicator and navigation buttons only when >4 images
- Homogenized button sizes (Change Cover now matches Fetch from Discogs)
- Fixed Save functionality with better error logging
- Reset Discogs state when modal closes
- Import ChevronLeft/ChevronRight icons for carousel navigation

Users can now navigate through all available artwork options
and successfully save selected images from Discogs.
2026-01-17 00:57:56 -06:00
vicrodh 732a489a3e Improve Discogs artwork selection with multi-release images
- Added /release/{id} endpoint to Cloudflare proxy for detailed release info
- Modified search_artwork_options to fetch full image sets from top 2 releases
- Interleave images: up to 4 from release #1, 4 from #2, 2 from others
- Added release_title and release_year metadata to each image option
- UI now displays release title and year for each artwork option
- Better image diversity and context for users

Users now see which release variant each artwork comes from,
making it easier to choose the correct edition.
2026-01-17 00:42:18 -06:00
vicrodh 279d433b77 Add catalog number support for precise Discogs searches
- Added catalog_number field to LocalTrack and LocalAlbum models
- Extract catalog_number tag from audio files using lofty
- Database migration to add catalog_number column to local_tracks table
- Modified Discogs search to prefer catalog number over artist/album
- Updated UI to display catalog number in album details
- Pass catalog_number to discogs_search_artwork command

For audiophile users with well-tagged libraries, catalog numbers
provide more precise Discogs search results than artist + album.
2026-01-17 00:34:27 -06:00
vicrodh 2a5c181618 Fix Discogs artwork selection to show unique images
- Modified search_artwork_options to return unique images from different releases
- Only take one image per release (prefer cover_image, fallback to thumb)
- Use HashSet to track and filter duplicate URLs
- Process up to 20 results to get more diverse options
- Adjusted grid layout from minmax(100px, 1fr) to minmax(80px, 1fr) to fit at least 4 items per row
2026-01-17 00:21:23 -06:00
vicrodh dab5c28727 Add Discogs artwork selection UI in album edit modal
Backend:
- Add DiscogsImageOption struct for artwork options
- Add discogs_search_artwork command to search multiple images
- Add discogs_download_artwork command to download selected image
- Extend DiscogsClient with search_artwork_options() method
- Extend DiscogsClient with download_artwork_from_url() method
- Register new commands in lib.rs

Frontend:
- Add Discogs image selection to album edit modal
- Add 'Fetch from Discogs' button with Discogs logo
- Display grid of artwork options from Discogs search results
- Allow user to select preferred artwork option
- Download and save selected artwork on Save
- Add comprehensive CSS styling for Discogs UI elements
- Adjust Discogs logo color filter for proper contrast

User can now click 'Fetch from Discogs', browse multiple artwork
options, select one, and save it as the album's cover art.
2026-01-17 00:12:14 -06:00
vicrodh 586a0de358 Fix device selection changing system default instead of only QBZ
PROBLEM:
When selecting an audio device in QBZ settings, the app was changing
the system-wide PipeWire default sink, affecting all applications.

ROOT CAUSE:
handleOutputDeviceChange() was calling set_pipewire_default_sink(),
which changes the PipeWire default for the entire system.

FIX:
Removed set_pipewire_default_sink() call. The backend reinit_audio_device()
already handles opening a specific device for QBZ without changing the
system default.

Now QBZ uses the selected device independently from the system default.
2026-01-16 22:25:20 -06:00
vicrodh 13e2ea708a Fix critical device selection bug in audio settings
PROBLEM:
When user selected a specific audio device (e.g., Cambridge Audio DAC),
audio would always play through system default device (laptop speakers)
instead of the selected device.

ROOT CAUSE:
All calls to reinit_audio_device() were passing device: null instead of
the actual selected device name. When device: null is passed, the Player
falls back to system default regardless of user selection.

Affected functions:
- handleOutputDeviceChange() - Primary bug, selected device ignored
- handleExclusiveModeChange() - Reset to default when toggling
- handleDacPassthroughChange() - Reset to default when toggling
- handleGaplessPlaybackChange() - Reset to default when auto-disabling DAC
- handleCrossfadeChange() - Reset to default when auto-disabling DAC

FIX:
Created getCurrentDeviceSinkName() helper that:
- Returns the internal sink name for selected device
- Returns null only for "System Default" selection
- Used consistently across all audio setting changes

SECONDARY CHANGES:
Improved DAC Passthrough warning messages in AudioOutputBadges:
- "ERROR: PipeWire is resampling" instead of generic warning
- Clearer tooltip guidance for fixing resampling issues
- Better distinction between active/warning/disabled states

This ensures device selection persists across all audio setting changes
and provides clearer feedback when bit-perfect playback is compromised.
2026-01-16 21:57:41 -06:00
vicrodh 40cd6d7303 fix: improve tooltip UX and enforce mutual exclusion on load
Tooltip improvements:
- Consolidate duplicate tooltips into single unified tooltip
- Show device info + DAC status + sample rate in one place
- Remove native 'title' attributes that were causing conflicts
- Add visual indicators (colored dots) for setting states
- Display resampling warning with actual rates when detected
- Better structured tooltip with sections

Mutual exclusion enforcement:
- Validate settings on load in loadAudioSettings()
- Auto-disable Gapless and Crossfade if DAC Passthrough is enabled
- Prevents invalid state from persisted settings

This fixes the issue where users could have incompatible settings
active simultaneously after app restart.
2026-01-16 21:39:48 -06:00
vicrodh a95575b7df fix: remove invalid currentTrack import from AudioOutputBadges
AudioOutputBadges was importing currentTrack from playerStore, which doesn't
export a reactive store. This caused the app to crash with a 500 error.

Solution: Pass samplingRate as a prop from NowPlayingBar instead of trying
to import track data directly. This matches the existing pattern used by
other components like QualityBadge.
2026-01-16 21:26:16 -06:00
vicrodh c810663c6f feat: implement 3-state DAC badge and hardware sample rate detection
Backend changes:
- Add audio_diagnostics module to read actual hardware sample rate from /proc/asound
- New command get_hardware_audio_status() parses hw_params for real-time monitoring
- Add glob dependency for file pattern matching

Frontend (AudioOutputBadges):
- Implement 3-state DAC badge system:
  - Green: DAC passthrough working correctly (rates match)
  - Yellow: DAC passthrough ON but resampling detected (warning)
  - Gray: DAC passthrough OFF (intentionally disabled)
- Dynamic tooltips showing actual hardware sample rate
- Compare file sample rate vs hardware sample rate
- Increase tooltip z-index to 9999 to prevent occlusion issues
- Add pointer-events: none to tooltip to prevent interaction issues

Frontend (SettingsView):
- Replace hardcoded "192 kHz" with dynamic hardware sample rate
- Load and display actual hardware audio status
- Show format details (e.g., S32_LE) when available
- Display "No active playback" when no audio is playing
- Add muted styling for inactive state

Frontend (QualityBadge):
- Add native tooltip showing tier and format
- Add cursor: help to indicate interactivity

i18n:
- Add "noActivePlayback" translations (EN/ES)

This allows users to verify bit-perfect playback is working and detect
resampling issues that would compromise audio quality.
2026-01-16 21:14:22 -06:00
vicrodh 09881856d0 fix: DAC badge now activates based on setting alone
Remove isExternal requirement for DAC Passthrough badge activation.
The badge now lights up when DAC Passthrough setting is enabled,
regardless of whether the device is detected as external or internal.

This fixes the issue where the badge would remain off even when
DAC passthrough was working (confirmed by 192kHz reaching hardware).
2026-01-16 20:56:02 -06:00
vicrodh 791ff7a73b feat: implement mutual exclusion for incompatible audio settings
Add auto-disable logic to prevent incompatible settings from being enabled simultaneously:

Frontend (SettingsView.svelte):
- DAC Passthrough ON → auto-disables Gapless Playback and Crossfade
- Gapless Playback ON → auto-disables DAC Passthrough
- Crossfade > 0 → auto-disables DAC Passthrough
- Added handleGaplessPlaybackChange() and handleCrossfadeChange() handlers
- Modified handleDacPassthroughChange() to disable incompatible settings

Backend (player/mod.rs):
- Only recreate OutputStream on format change when DAC passthrough is enabled
- When DAC passthrough is OFF: reuse existing stream for gapless transitions
- When DAC passthrough is ON: recreate stream for bit-perfect playback
- Added detailed logging for stream recreation decisions

This fixes the issue where Gapless Playback was enabled but gaps still occurred
due to DAC passthrough forcing stream recreation on sample rate changes.
2026-01-16 20:41:53 -06:00
vicrodh 33c5e00da0 Fix audio device selection to show friendly PipeWire names
The previous implementation tried to map ALSA device names (from cpal)
to PipeWire descriptions, but the naming schemes are completely different:
- cpal returns names like "plughw:1,0"
- pactl returns sink names like "alsa_output.usb-Cambridge_Audio_..."

This fix changes the approach:
1. Use PipeWire sinks directly for the device dropdown (already filtered
   to real outputs and have friendly descriptions like "DacMagic Plus")
2. Store the PipeWire sink name when user selects a device
3. Set the PipeWire default sink using pactl when device is selected
4. Use rodio's default device (which follows PipeWire's default)

This ensures users see 4-5 meaningful devices with friendly names
instead of 30+ raw ALSA device names.

Backend changes:
- Add set_pipewire_default_sink command (pactl set-default-sink)
- Register new command in lib.rs

Frontend changes:
- Use pipewireSinks directly for device dropdown
- Display sink description (friendly name)
- Store sink name (for pactl)
- Call set_pipewire_default_sink when device changes
- Remove unused AudioDevice interface and getDevicePrettyName import
2026-01-16 19:52:51 -06:00
vicrodh e92ca494d4 Add Playlists tab to FavoritesView for favorite playlists 2026-01-16 14:39:41 -06:00
vicrodh 432b4e5f97 Add favorite heart indicator to PlaylistManagerView items 2026-01-16 14:35:26 -06:00
vicrodh 1537b2de7f Add favorite heart button to PlaylistDetailView header 2026-01-16 14:33:25 -06:00
vicrodh a68230fadc Make scrobbling options mutually exclusive in offline settings
Immediate and Accumulated scrobbling cannot be enabled at the same
time, but both can be disabled. When one is turned on, the other
is automatically turned off.
2026-01-16 10:07:05 -06:00
vicrodh 8a5d3e8971 Fix column alignment for unavailable tracks in playlist view
Show favorite and download indicators for unavailable Qobuz tracks
to maintain column alignment. The elements are already non-interactive
due to pointer-events: none on the wrapper.
2026-01-16 10:02:49 -06:00
vicrodh 3984f5b9a0 Fix track row alignment for unavailable tracks in playlist view 2026-01-16 09:56:25 -06:00
vicrodh 9499203c69 Refine offline mode UX for unavailable tracks and playlist filters
- Remove wifi-off icon from unavailable tracks in playlist detail view,
  keeping only the disabled styling for a cleaner look
- Rename "Available Offline" filter to "Fully Available Offline" to
  clarify it shows only playlists where all tracks are available
- Update filter logic to only show all_local playlists in the fully
  available filter, not partially available ones
- Fix visible filter in offline mode to respect showPartialPlaylists
  setting by using isPlaylistAvailableOffline function
2026-01-16 09:35:40 -06:00
vicrodh 93d886e1dd Fix partial playlist detection for offline mode
The hasLocalContent field was never being calculated - it was just
read from settings (always undefined). Now calculate it dynamically
from actual data:

- localTrackCounts.get(playlistId) - number of local tracks
- playlist.tracks_count - number of Qobuz tracks

Status calculation:
- 'no': localCount === 0 (not available offline)
- 'all_local': localCount > 0 && qobuzCount === 0 (fully available)
- 'some_local': localCount > 0 && qobuzCount > 0 (partially available)

This fixes Show partial playlists toggle and Partially available
filter in playlist manager.
2026-01-16 09:13:55 -06:00
vicrodh 94d7d78a22 Fix buffering UX when transitioning from local to Qobuz tracks
- Stop playback immediately when starting a Qobuz track to prevent
  previous track from continuing during download
- Show buffering toast while downloading Qobuz audio
- Skip buffering UI for local tracks since they load instantly
- Add is_local field to QueueTrack for prefetch optimization
- Update prefetch to skip local tracks (no network needed)
- Update all queue track builders to include is_local flag
2026-01-16 07:58:13 -06:00
vicrodh 3e3f89b6a8 Fix effect_update_depth_exceeded infinite loop in playlist loading
Remove reactive effect that was causing infinite re-renders due to
inline callback function recreation. Replace with imperative calls
to notifyParentOfCounts() after data loading completes.

The effect was reading onPlaylistCountUpdate which got recreated
on every parent re-render, triggering the effect again in a loop.
2026-01-16 07:48:34 -06:00
vicrodh aeb13b9ffc Connect playlist count callback for single source of truth
Wire onPlaylistCountUpdate from PlaylistDetailView to Sidebar's
updatePlaylistCounts method in +page.svelte. This ensures the
sidebar displays accurate track counts from the database instead
of calculated values that could drift out of sync.
2026-01-16 07:19:34 -06:00
vicrodh 7292635210 Fix displayTracks to handle local track positions beyond simple sum
Calculate totalCount as max of (qobuz+local count) or (highest local
position + 1) to ensure all local tracks are included regardless of
their position value
2026-01-16 07:13:09 -06:00
vicrodh 16486e4591 Fix playlist track ordering to respect insertion order
- Add PlaylistLocalTrack struct with playlist_position field
- Add playlist_get_local_tracks_with_position command
- Update PlaylistDetailView to merge tracks by position instead of
  appending local tracks at the end
- Update PlaylistModal to calculate correct position when adding local
  tracks (total count = qobuz + existing local)
- Local tracks now appear in the order they were added, interleaved
  with Qobuz tracks
2026-01-16 07:04:21 -06:00
vicrodh 24c9df3bce Fix TrackMenu z-index and edge clipping issues
- Use portal pattern to render menu in body (escapes stacking context)
- Increase z-index to 99999/100000 for menu/submenu
- Update click outside handler to work with portal
- Menu now properly appears above all track rows
2026-01-16 06:56:36 -06:00
vicrodh 9366388041 Fix local tracks not being added to queue from playlists
- Update handlePlayAll to include both Qobuz and local tracks
- Update handlePlayAllNext and handlePlayAllLater similarly
- Add onSetLocalQueue prop to mark local tracks in queue store
- Connect prop to handleSetLocalQueue in +page.svelte
2026-01-16 06:51:59 -06:00
vicrodh 825534621a Add login timeout mechanism and fix premature API calls
- Add 60-second timeout to login initialization in LoginView
- Show retry/offline options when login times out
- Move loadFavorites() to handleLoginSuccess to prevent API calls
  before authentication is complete
- Prevents errors when auto-login is slow or stuck
2026-01-16 06:49:03 -06:00
vicrodh 688d798b9d Fix local track quality badge showing Hz instead of kHz
Convert sample_rate to kHz in localTrackToDisplay function so local
tracks display correctly as 16bit/44.1kHz instead of 16bit/44100kHz
2026-01-16 06:40:23 -06:00
vicrodh 3297257a24 Fix tooltip updates and change Song to Track terminology
- Update onPlaylistUpdated callback to also refresh local track counts
- Change all Song/Songs references to Track/Tracks in Sidebar tooltips
- Ensure tooltip cache is properly invalidated when tracks are modified
2026-01-16 06:39:08 -06:00
vicrodh 5f4cfa5888 feat(playlists): include local tracks in counts everywhere
- Add playlist_get_all_local_track_counts command to get local track
  counts for all playlists efficiently
- PlaylistDetailView: show combined track count and duration in header,
  style local count with muted color, remove redundant count below
- Sidebar: load and display local track counts in tooltips
- PlaylistModal: show combined counts when selecting playlist to add to
- PlaylistManagerView: show combined counts in both grid and list views
- TrackRow: move local indicator to download column position, add
  placeholder for favorite column to maintain alignment, update tooltip
- Remove local tracks notice banner (info now in tooltip)

cc
2026-01-16 06:32:13 -06:00
vicrodh d731805eca refactor(playlists): unify track row appearance and add remove option
- Move local track indicator from quality column to favorite button position
  for consistent row alignment with Qobuz tracks
- Remove explicit delete button from playlist track rows (was easy to
  accidentally click)
- Add "Remove from playlist" option to TrackMenu for all tracks (local and
  Qobuz)
- Qobuz track removal uses playlist_track_id from API response
- Clean up unused CSS and imports from PlaylistDetailView

cc
2026-01-16 06:18:32 -06:00
vicrodh 3915abd3bb fix(playlists): add local tracks to playlists correctly
- PlaylistModal now uses playlist_add_local_track command for local tracks
  instead of the Qobuz-only add_tracks_to_playlist command
- Added isLocalTracks prop to PlaylistModal and wired it through uiStore
- Updated LocalLibraryView to pass isLocal=true when adding tracks to playlists
- Added HardDrive icon indicator next to quality badge for local tracks in TrackRow

cc
2026-01-16 06:03:09 -06:00