Commit Graph
1602 Commits
Author SHA1 Message Date
vicrodh a69491a49e feat(player): re-wire the low-memory profile into qbz/qbzd (#660)
The system_capabilities profiler (Normal vs LowMemory, built for #331)
lost all its consumers in the Tauri removal; 2.0.2 shipped it as dead
code and qbzd got OOM-killed (exit 137) on 1 GB Pi hosts at track
transitions. Phase A wiring:

- Frontends read memory_profile() at startup and push it down via the
  new player memory_tuning (initial-buffer cap, L1 budget, low-memory
  gate) before the Player is created.
- L1 audio cache sized from the profile (400 MB Normal / 50 MB
  LowMemory; was hardcoded 400 MB).
- Oversized tracks (>L1/4 = 12.5 MB on LowMemory) skip the promotion
  clone and the parallel CMAF RAM accumulator entirely; the finished
  track is streamed to the L2 disk cache in 1 MB chunks straight from
  the playback buffer — no second in-RAM copy. Gapless degrades to a
  small gap for those tracks (a gap beats an OOM kill).
- Stream buffer preallocates total_size up front (try_reserve_exact,
  1 GiB cap, dynamic fallback) — no more ~8 doubling reallocs + memcpy
  per track (weak-CPU relief).
- New memory-pressure watchdog (15 s): critical pressure evicts the
  L1 (L2 disk kept) and halts prefetch; low pressure pauses HiRes
  prefetch (downgrades to Lossless). Spawned by both frontends; qbzd
  aborts+joins it for the #521 shutdown ordering.
- Prefetch honors the profile (depth cap, HiRes->Lossless downgrade).

Normal-profile behavior is byte-identical (every behavioral change is
gated on the LowMemory class; profile values equal the old hardcodes).

Phase B (follow-ups): tempfile spill of the live stream buffer for
giant tracks, POLLERR flood rate-limit, desktop kick_prefetch halt
check, L2-read on the play_track cache-hit path.

km
2026-07-26 23:56:39 -06:00
vicrodh 96acc4386a test(qbz-app): install the rustls CryptoProvider in shell tests
Follow-up to #663: with reqwest no longer pulling a rustls provider,
QbzCore::new (MusicBrainzClient) panicked "No provider set" in 6
shell tests. The test ctor now calls ensure_crypto_provider(), exactly
like the real binaries do at startup.

km
2026-07-26 23:56:38 -06:00
vicrodh ad6c98ff7d feat(queue): Play later everywhere — every context menu and bulk bar (#442)
Extends Play later (end of the manual block) from track rows to every
surface that already offered Play next / Add to queue:

- playback.rs: enqueue_album_later, enqueue_playlist_later (mixed
  sidecar interleave), enqueue_artist_top_later, enqueue_tracks_later,
  enqueue_local_tracks_later — all NATURAL order (each add_track_later
  appends, no reverse), QConnect controller routing via
  play_later_batch_on_peer_if_active, and post-add queue sync.
- local_playlist::enqueue_later_by_id (source-aware rows, offline-only
  stamp preserved), myqbz_play RowMode::PlayLater + BulkEnqueueMode.
- 19 dispatch arms in main.rs (album/playlist/artist/label/mix/
  favorites/local-library/album-page/disc/myqbz dialects).
- 12 context menus + 10 bulk bars in .slint: list-plus icon between
  Play next and Add to queue, popup heights bumped.

The immersive tap-action dropdown is deliberately untouched (it is a
configurable single-tap behavior setting, not a context menu).

km
2026-07-26 21:08:12 -06:00
vicrodh 09380d4634 Merge branch 'pre-release' into chore/internal/smoke-2026-07-25 2026-07-26 16:45:03 -06:00
b0bbywan 82fea6257c fix(qbz-audio): use alsa::pcm::Frames for ALSA buffer and period sizes
HwParams::set_buffer_size_near and set_period_size_near take alsa::pcm::Frames, which is libc::c_long: i64 on 64-bit targets but i32 on 32-bit ones. The three buffer_size computations in alsa_direct.rs cast to i64 explicitly, so the crate does not compile for any 32-bit target.

Casting to the alsa type instead is a no-op on 64-bit, where Frames already is i64, and correct on 32-bit. No behavioural change on any currently supported target: every value involved is a sample rate divided by 2, 4 or 8, so at most 96000, far below an i32 overflow.

Verified with cargo check -p qbz-audio:
  x86_64-unknown-linux-gnu       passes before and after
  arm-unknown-linux-gnueabihf    6 x E0308 before, passes after
2026-07-26 16:42:38 -06:00
vicrodh 6ca5813fb1 feat(mpris): expose xesam:url with the public Qobuz track link (#658)
playerctl scripts/widgets can now identify the exact song:
https://open.qobuz.com/track/<id> on every Qobuz catalog row (offline
qobuz_download keeps the real id, so it qualifies too). Local/Plex rows
omit the field — QueueTrack carries no file path to map to file:// and
a synthetic local id would mint a bogus Qobuz link. Wired in both the
app (refresh_now_playing_meta) and qbzd (track_meta).

km
2026-07-26 16:38:38 -06:00
vicrodh def93528bc fix(audio): open ALSA mixer on the card ctl id, not the PCM alias (#659)
set_hardware_volume attached the mixer to the stream's raw PCM id
(iec958:/hdmi:/front:/DEV-qualified hw:) — snd_mixer_attach needs the
per-card ctl device, so hardware volume silently no-oped on plugin-alias
devices (HiFiBerry Digi as iec958:CARD=sndrpihifiberry,DEV=0). Derive
hw:CARD=<name> / hw:<n> first. With this, qbzd's 'Hardware volume'
toggle reaches the DAC's mixer control (e.g. 'Digital') as intended;
with the toggle off, ALSA Direct stays fixed-volume by design
(bit-perfect, no software gain).

km
2026-07-26 16:32:30 -06:00
vicrodh 4d2ddec66e fix(ui): heart-crack icon for Remove from Library/favorites actions
Replaces the trash can (Favorites bulk bars, tracks + albums) and the
plain heart (Local Library bulk bar) with Lucide heart-crack — trash
reads as file deletion, not as un-favorite.

NOTE: touches .slint, so the next build recompiles qbz-ui (long path).

km
2026-07-26 16:26:58 -06:00
vicrodh 64fe89cf52 feat(qconnect): play-later positional insert on peer + queue sync on add
Controller mode: play-later now routes to the peer's manual-block tail
(insert_after steered via a new ControllerManualBlock tracker that
confirms echo positions) instead of degrading to play-next; play-next
inserts also feed the tracker. Single + batch variants.

Local renderer mode: every queue ADD (enqueue/play-next/play-later,
album/playlist/artist/favorites/local batches) now pushes the queue to
the session immediately via sync_local_queue_if_changed, so controllers
see new items at their position instead of waiting for the next track
transition. Adds containing local/plex rows skip the push (all-or-
nothing admission would refuse the whole queue anyway).

km
2026-07-26 15:45:00 -06:00
vicrodh 449f2470f6 fix(ui): mixtape row menu play-next/add-to-queue icons (list-start/list-end)
km
2026-07-26 15:45:00 -06:00
vicrodh 3f1a7d074a fix(build): move the bulk-unfav toast closure (E0373)
km
2026-07-26 15:00:50 -06:00
vicrodh 5dc4d553dc fix(favorites): bulk un-favorite without the UI freeze, with feedback
- Local Library bulk un-favorite was O(selected x visible) on the UI
  thread and froze on big libraries (owner: 'se ciclo'). Now: one model
  pass (hearts hollow instantly), store mutations on a blocking thread,
  'Removing…' info toast up front and a success toast at the end.
- Favorites > Tracks bulk remove: 150 ms courtesy delay between Qobuz
  API calls (no burst) + the same progress toasts.

km
2026-07-26 14:59:29 -06:00
vicrodh 8c1750a78f fix(ux+audio): #661 pause-during-load, anti-alias ring, menu icons, bulk unfav
- #661: a pause issued during the load window fell into the toggle's
  resume branch and got swallowed — the track started anyway and the
  sleep inhibitor stayed held. stop() now cancels the in-flight play
  (PENDING_PLAY_ID), so nothing plays and no inhibitor is acquired.
- Accent ring on the playing row: 1px -> 1.5px border (femtovg 1px
  stroked circles alias; CircleAction's header rings use 1.5px).
- Menu position hints (#N) removed from the track context menu (owner).
- Icon mapping across menus: list-start = Play next, list-end = Add to
  queue, list-plus = Play later; new list-start.svg +
  list-indent-increase.svg (queue manual-block section marker).
- Local Library > Tracks multi-select gains bulk Remove from favorites
  (local-favorites store, live heart flip, toast).

km
2026-07-26 13:22:53 -06:00
François Laignel 62cc4f9200 remove ring from the dependency tree
The crate `ring` was transitively pulled due to the feature `rustls-tls` being
selected for `reqwest`. In order to ensure `ring` is not pulled,
`rustls-tls-webpki-roots-no-provider` must be used instead.
2026-07-26 21:12:44 +02:00
François Laignel a01097708e qbzd: install the rustls process-level CryptoProvider
The rustls crypto provider was not installed for `qbzd`, which caused the
process to panic:

> thread 'tokio-rt-worker' (15737) panicked at [...]/rustls-0.23.37/src/crypto/mod.rs:249:14:
>
> Could not automatically determine the process-level CryptoProvider from
> Rustls crate features.
> Call CryptoProvider::install_default() before this point to select a
> provider manually, or make sure exactly one of the 'aws-lc-rs' and 'ring'
> features is enabled.
> See the documentation of the CryptoProvider type for more information.

The function `ensure_crypto_provider()` was defined in the `qbz-cast` crate
which is obviously not a dependency of `qbzd`.

This commit moves `ensure_crypto_provider()` to `qbz-app`, calls it from `qbzd`
and updates `qbz` accordingly.
2026-07-26 21:12:44 +02:00
vicrodh 51b5f3bec7 fix(build): compile errors from the round
- with_db closures return the raw Result (not Option) in the all-local
  feed loader.
- build_tree takes sort_asc (its own scope, not rebuild's).
- reconcile_sidebar_after_import captures first/single before the
  closures move ids.

km
2026-07-25 20:45:03 -06:00
vicrodh cb1ae7db6f i18n: strings for the round (8 locales)
Library-All scope selector + settings rows, play-indicator/swipe
toggles, sidebar/manager sort carets, Play later + queue sections +
menu hints.

km
2026-07-25 12:05:56 -06:00
vicrodh efa486ba4f feat(packaging+log): standalone qbzd packages, IP masking in logs
- nfpm-qbzd.yaml (deb/rpm, libasound-only dep) + release workflows build
  the standalone qbzd packages per arch; dual dispatch to the future
  qbz-rpm repo (continue-on-error until token scope lands).
- Gentoo overlay templates: qbzd (source build) + qbzd-bin (tarball
  repack) with systemd user unit + completions.
- Log redaction layer 3: IPv4 -> *.*.*.<last>, IPv6 -> *:*:<last>, with
  version/timestamp false-positive guards (qbz-log 10/10 tests).

km
2026-07-25 12:05:56 -06:00
vicrodh a8919cbadf feat(app): the round's wiring — gamescope, watchdog, geometry, hearts
- Steam PR1/PR3/PR4 wiring: apply_gamescope_quirks at the top of main(),
  tray + miniplayer suppression, gilrs spawn, UiFocusState OSK hook.
- #558 watchdog arm at window-ready; #654 monitor-DPR geometry clamp;
  local-heart routing in the favorite arms; play-later media-action arm;
  sort-flip handlers with direction (#657/Library All pattern); gilrs +
  wayland-data-control deps (#514).

km
2026-07-25 12:05:56 -06:00
vicrodh 953ba39e77 feat(playlists+queue): sort directions (#657), import refresh, Play later (#442)
- Sidebar + playlist manager sorts gain both directions with a caret on
  the active row (re-select flips); 'recent' keeps the API order
  (newest-first — the old reverse was the #657 bug).
- Import now inserts the new playlist optimistically and bounded-retries
  until the API lists it (read-after-write lag forced a manual refresh).
- Play later: tracks land at the end of the manual block (after every
  play-next/later, before the source resumes); Play next and Add to
  queue are untouched. The queue sidebar shows the section divider
  (Next in queue / Next up) with drag-math compensation, and the context
  menu shows the landing position of each queue action.

km
2026-07-25 12:05:27 -06:00
vicrodh d99419f22d fix(renderer+ux): frame-liveness watchdog (#558), dup-add button (#655)
- #558: a backend can be alive yet wedged (zero presented frames forever
  on legacy stacks). Vendored femtovg counts presented frames; a watchdog
  8s after window-ready re-arms the renderer sentinel and restarts, so
  the existing ladder degrades wgpu -> alt adapter -> GL -> software on
  its own instead of stranding the user on a blank window.
- #655: 'Add only new tracks' stays enabled with all-dupes (adds zero
  and closes) instead of disappearing as the primary action.

km
2026-07-25 12:05:27 -06:00
vicrodh f1eeaf9126 feat(steam-deck): game mode support (plan PR1-PR5)
- PR1: gamescope detection at boot — X11 backend, scale 1, kiosk
  fullscreen; tray + miniplayer suppressed (click-offset fix).
- PR2: full keyboard navigation for the kiosk (3 zones, focus ring,
  scroll-into-view; typing never navigates).
- PR3: native gamepad via gilrs — D-pad/stick/A/B to synthetic Slint
  keys with hysteresis, repeat and debounce; B suppresses Escape while
  a text field is focused (closes the Steam OSK).
- PR4: Steam OSK via the steam://open/keyboard deeplink on text focus.
- PR5: scripts/qbz-add-to-steam (stdlib-only, 19/19 unit tests) with
  artwork assets + pure-gamepad controller layout.

Spec: qbz-nix-docs/steam-deck/STEAM_DECK_GAME_MODE_PLAN.md

km
2026-07-25 12:04:58 -06:00
vicrodh 55caada4c4 feat(ui): play-indicator toggle, swipe inversion, accent-ring row mark
- Appearance > Play indicator animation (default OFF): static play glyph
  in an accent ring on the playing row, pause on hover, accent edge pill;
  the 8fps eq-bars clock no longer runs while playing with the pref off
  (CPU complaint on some machines).
- Appearance > Invert swipe navigation direction for the two-finger
  touchpad back/forward gesture (#653 follow-up).

km
2026-07-25 12:04:57 -06:00
vicrodh 54c2779eb5 feat(library-all): windowed feed, show-local default + scope, local hearts
- Viewport windowing for the All grid + list (AlbumGrid-class sampler);
  thousands of items no longer mount eagerly (owner's 2200-item library
  was unscrollable, even typing in search lagged).
- Artwork is id-keyed (kind:id) + generation-guarded + band eviction,
  ending wrong-cover races and per-keystroke image churn; covers persist
  on the full model across derives.
- show-local defaults ON (persisted) with the filter toggle kept in the
  view toolbar; Settings gains the scope selector (hearted items vs the
  whole local library, loaded with Local-Library query parity).
- Cards respect favorite/followed state; hearts of local/Plex items route
  to the local-favorites store instead of the Qobuz API.

km
2026-07-25 12:04:22 -06:00
vicrodh a31d3abf13 Merge branch 'bugfix/internal/touch-gestures-share-url-sandbox' into chore/internal/smoke-lyrics-discover 2026-07-23 09:35:09 -06:00
vicrodh 5b525b9e89 fix(settings): correct the #652 Sandbox row — device access is already granted
The published Flathub manifest has shipped --device=all since 2026-05-30
(flathub/com.blitzfc.qbz@11d38546), so /dev/snd IS exposed in the sandbox;
the device-override row added earlier on this branch was diagnosed against
the stale pre-repack local manifest clone and would have users grant what
they already have. The likely #652 mechanism is the ReserveDevice1 name
(qbz-audio device_reservation): PipeWire holds the DAC and Flatpak can't
own org.freedesktop.ReserveDevice1.* (Flathub linter blocks it), which is
exactly what the pre-existing Sandbox row fixes. Drop the device=all row
and make that row's note name the #652 symptom explicitly.

km
2026-07-23 09:35:09 -06:00
vicrodh 9db8bfd762 Merge branch 'bugfix/internal/touch-gestures-share-url-sandbox' into chore/internal/smoke-lyrics-discover 2026-07-23 09:23:32 -06:00
vicrodh cfa88098ee i18n(settings): translate the Flatpak ALSA device-access row (#652)
Hand-added the new Sandbox settings msgids (title + description) to all
8 locales; en msgstr = msgid. msgfmt --check passes on each.

km
2026-07-23 09:20:49 -06:00
vicrodh 3dca29fc62 feat(settings): document the Flatpak ALSA device-access grant (#652)
The Flathub manifest grants wayland/x11/pulseaudio/dri only, so /dev/snd
is not visible inside the sandbox: opening an ALSA hw:X,0 output fails
and exclusive mode silently falls back to PipeWire (other apps keep
mixing through the DAC). Per owner decision the manifest stays as-is
(Flathub reviewer friction); instead the Sandbox settings page gains a
third Flatpak row with the manual one-time grant
`flatpak override --user --device=all com.blitzfc.qbz`, following the
existing copyable-command-row pattern, and notes the required restart.

km
2026-07-23 09:20:49 -06:00
vicrodh 97adf3d3cf fix(share): use open.qobuz.com for track/album share links (#514)
The copied track and album links now use the canonical open.qobuz.com
form. Artist, label and playlist links are unchanged.

The builders also feed the Odesli (Song.link/Album.link) URL fallback;
that fallback never resolves Qobuz URLs anyway (every qobuz.com form
answers 400 could_not_resolve_entity, verified in-tree 2026-07-16) and
the working path stays ISRC/UPC -> Deezer, so the resolution machinery
is unaffected. open.qobuz.com is already accepted inbound by
qbz-qobuz's link_resolver.

km
2026-07-23 09:13:25 -06:00
vicrodh d6ed93280c feat(nav): two-finger touchpad swipe for back/forward history (#653)
Extend the AppShell bottom-layer TouchArea (the one already catching the
mouse back/forward buttons) with a scroll-event handler that accumulates
horizontal touchpad deltas and fires one NavState.request-back/forward
per gesture — the same callbacks the header nav buttons drive, so entry
swap, scroll restore and nav flags all follow the existing path.

Delivery is front-to-back, so a horizontal carousel Flickable consumes
horizontal deltas before they reach this layer (carousels keep scrolling
and never trigger navigation); a vertical-only page scroller rejects
horizontal-only deltas as an orthogonal direction, letting them fall
through to the gesture handler. The handler always returns reject, so
scroll routing is untouched everywhere. One navigation per gesture via
an idle-timeout/direction-flip reset and a fired latch; 70px threshold;
fingers-right = back / fingers-left = forward under libinput natural
scrolling (commented in code).

km
2026-07-23 09:10:28 -06:00
vicrodh e61318b286 Merge branch 'feature/internal/lyrics-translation' into chore/internal/smoke-lyrics-discover 2026-07-23 08:31:44 -06:00
vicrodh 6a7784366d feat(ui): restyle the lyrics translate toggle as a ghost square
Owner 2026-07-23: drop the mobile-parity circle — square, no border, no
shadow; bg lights up on hover, matching the Discover configurator gear
(GearButton in HomeView.slint). Glyph swapped to the owner-picked
translate-svgrepo icon (translate.svg; the Lucide languages.svg added
earlier on this branch is removed). Accent tint remains the ON state.

km
2026-07-23 08:31:20 -06:00
vicrodh d7a5c83c67 feat(lyrics): make the translation toggle per-track
Owner decision 2026-07-23: enabling translation applies only to the song
it was toggled on, in that playback — not a session/album-wide switch.
Every track change now resets the translation session and fetches
original-only (was: track-change requests rode the resolved target so
the translation followed across tracks). enable_translation/disable and
the fail-soft toast paths are unchanged.

km
2026-07-23 08:31:20 -06:00
vicrodh 7e40ff71db fix(deep-link): import ComponentHandle for Weak::as_weak
Static-review miss (qbz crate can't be check-built without the 30 GB
qbz-ui unit): as_weak() is a ComponentHandle trait method, so the trait
must be in scope. Found by the owner smoke build (E0599, qbz/src/
deep_link.rs:153) — the sole error in the crate.

km
2026-07-23 00:33:38 -06:00
vicrodh 3eb93ec4cb Merge branch 'bugfix/internal/discover-reco-follow-state' into chore/internal/smoke-lyrics-discover
# Conflicts:
#	crates/qbz-ui/translations/de/LC_MESSAGES/qbz-ui.po
#	crates/qbz-ui/translations/en/LC_MESSAGES/qbz-ui.po
#	crates/qbz-ui/translations/es/LC_MESSAGES/qbz-ui.po
#	crates/qbz-ui/translations/fr/LC_MESSAGES/qbz-ui.po
#	crates/qbz-ui/translations/ja/LC_MESSAGES/qbz-ui.po
#	crates/qbz-ui/translations/nl/LC_MESSAGES/qbz-ui.po
#	crates/qbz-ui/translations/pt/LC_MESSAGES/qbz-ui.po
#	crates/qbz-ui/translations/ru/LC_MESSAGES/qbz-ui.po
2026-07-22 23:05:16 -06:00
vicrodh 299a7c3237 chore(packaging): drop dead x-scheme-handler/qbz registration
qbz:// resolves nowhere in the link resolver, so the registration
advertised a scheme the app never handles. Keep
x-scheme-handler/qobuzapp (handled by the resolver) in all 7 desktop
files.

km
2026-07-22 22:56:14 -06:00
vicrodh 537cabbb99 fix(deep-link): forward Qobuz links to the running instance over D-Bus
A second launch carrying a deep link exited after a bare Present(),
taking the URL with it — focus worked, navigation didn't. Add
OpenUrl(url) to the SingleInstance D-Bus interface: the primary stashes
the URL, presents itself, and dispatches through the same pending/drain
path as a cold-start link (stays pending while no shell is up).
acquire_or_raise calls OpenUrl when argv carried a link and falls back
to bare Present() when the method is missing on an older primary
(version skew), then to MPRIS Raise as before; no-link launches keep
plain Present().

km
2026-07-22 22:56:00 -06:00
vicrodh fd8f8f4064 fix(deep-link): navigate Qobuz links passed via argv on cold start
xdg-open https://open.qobuz.com/album/<id> raised/focused QBZ but never
navigated: main() never read argv, so the desktop files' Exec=qbz %u URL
was silently dropped (Tauri parity gap — the old app scanned argv on
cold start and in its single-instance callback).

New deep_link module: capture_argv() at the top of main() stashes the
first Qobuz-link argv entry (legacy is_qobuz_link prefixes) BEFORE the
single-instance guard runs — a second launch must read its own argv
before deciding to raise+exit. enter_shell binds a shell context
(runtime, window weak, tokio handle, image cache; cleared on logout) and
drains the pending URL at its very end, after the startup-page/view
restore, so the restore can't re-root over the deep link. Session is
active and the AppWindow exists there, so no readiness sleep hack.
Dispatch is the existing Ctrl+L machinery (link_resolver::resolve ->
apply_resolved_link); failures surface as toasts. At the login screen or
in offline mode the URL stays pending for the next successful online
enter_shell.

km
2026-07-22 22:55:47 -06:00
vicrodh c8e37f937d refactor(discover): borrow-free upsert in the reco-dismiss store
position() + index instead of an iter_mut().find() borrow held across a
match arm — no NLL subtlety, and the lifecycle test passes against the
verbatim file (scratch-crate run, since the qbz crate itself is not
built here).

km
2026-07-22 22:31:00 -06:00
vicrodh 2b0cf33d2e i18n(discover): Not interested + Recommendations-tab strings (8 locales)
New msgids hand-added to all 8 qbz-ui catalogs: the tab description, the
empty-state heading + hint, and the dismiss/undo toasts. "Not
interested" and "Recommendations" reuse the pre-existing msgids
(PlaylistView / Discover). en msgstr = msgid; es/de/fr/pt/ru/ja/nl
translated. msgfmt --check clean on all 8.

km
2026-07-22 22:25:01 -06:00
vicrodh 6adb33fcef feat(settings): Recommendations tab in the Blacklist Manager
Manage the reco-scoped Not-interested dismissals: a third tab in
Settings > Blacklist lists dismissed artists (search-filtered like the
other axes, count badge, empty + no-results states) with a per-row undo
that removes the entry from the reco_dismiss store — the artist becomes
eligible for the Recommendations rails again on their next paint. Row
click reuses the existing artist-select navigation. No bulk Clear-All on
this tab (undo is per-row); the modal stays scoped to the blacklist axes.

km
2026-07-22 22:18:59 -06:00
vicrodh a181fb7aa9 feat(discover): Not interested menu action with live removal + backfill
ArtistGridCard's context menu gains a 4th item (Not interested,
thumbs-down icon; popup height bumped for the extra row) that emits
("artist", id, "not-interested") through the existing media-action
chain. The new central arm persists the dismissal to the reco_dismiss
store and, when the artist is in a reco rail, removes the card live and
backfills the freed slot from the rail's retained overflow (already
Qobuz-validated — no network; the pop re-checks live exclusions and
cross-rail visibility). Dismissed from a non-reco surface, the display
name is resolved via get_artist before persisting, so the management
list and toast still read well.

km
2026-07-22 22:11:58 -06:00
vicrodh 465f8627eb feat(discover): filter, cross-rail dedup, and overflow backfill for reco rails
The two Recommended-Artist rails showed artists the user already follows
or blacklisted, and the same artist could appear in both rails at once.

Builders now retain the full validated pool (rotated, not truncated at
DISPLAY_CAP); the pools ride the results blob as before, so old blobs
simply have no overflow until they expire. A new pure compose step in
qbz-external-reco (unit-tested: exclusion, within/cross-rail dedup with
common-wins ordering, visible/overflow split order) runs at the single
paint choke point in external_reco.rs — covering BOTH the fresh build
and the cached-blob paint. Exclusions fold followed (fav_cache) +
blacklisted + reco-dismissed ids, each source independently fail-open.
The past-cap survivors are retained as overflow for the Not-interested
live backfill (no extra network).

km
2026-07-22 22:08:38 -06:00
vicrodh 2c162b6925 feat(discover): per-user reco-dismissal store for Not interested
Reco-scoped dismissal (NOT the app-wide blacklist): a dismissed artist
only leaves the Recommendations rails and stays visible everywhere else.
One small JSON store per user (the light discovery_dismiss precedent)
bound at session activation next to fav_cache (login / restore /
offline) and dropped on logout. Fail-open: unbound or corrupt file reads
empty and mutations no-op. Unit-tested lifecycle (roundtrip, idempotent
dismiss with snapshot backfill, re-bind persistence, undo, junk/unknown
format tolerance).

km
2026-07-22 22:02:25 -06:00
vicrodh da3a5553e0 fix(discover): seed artist follow state in the Recommendations rails
slim_from_artist hardcoded following: false, so reco artist cards never
reflected the current follow state at build time (the pinned carousel
already seeded from fav_cache). Seed from fav_cache::is_artist_favorite
and extend the shell-entry favorite-artists warm walk to the three
ExternalRecoState artist models, in place (no model swap, no flicker).
Live toggles were already propagated by search::mark_artist_followed.

km
2026-07-22 21:59:26 -06:00
vicrodh accdef5a02 fix(qobuz): merge the translation-only v10 lyrics document with the original
Live wire (verified 2026-07-22, track 266725027 with language=es): when a
translation is requested and available, lyrics_url points at the TRANSLATED
document (<id>-<lang>.json) carrying ONLY 'translation' — no 'original' —
and 'translation_requested' is absent. get_lyrics rejected such documents
('without original content -> no lyrics'), so every translation toggle
ended in the unavailable toast. Now get_lyrics fetches the original-only
document in a second round trip and merges both into one bilingual doc
(merge_translation_into); requested-but-unavailable still 403s the CDN
URL -> typed miss (fail soft).

km
2026-07-22 21:34:39 -06:00
vicrodh 9cc7307616 feat(about): add TerminalTilt to the contributors list
Owner request; rides the lyrics-translation branch. Appended after the
existing Slint-era external-PR contributors.

km
2026-07-22 20:00:03 -06:00
vicrodh f86b0f7386 i18n: lyrics translation strings in all 8 locales
New msgids: Show/Hide lyrics translation (toggle tooltips), Translation
language + Auto (account language) (flyout row), and the fail-soft toast
"Translation is not available right now. Please try again later.".
Register-matched per catalog (de/nl informal, fr/pt formal); en follows
its msgstr = msgid convention. msgfmt --check clean on all eight.

km
2026-07-22 20:00:03 -06:00
vicrodh b4ead674d8 feat(qbz): wire the lyrics translation toggle end to end
The commit push now carries translation-available (doc translation_langs
non-empty) and per-line translation-text, aligned 1:1 with the rendered
lines (the core filters translation lines like the originals; a missing
entry degrades to empty). Toggle ON resolves the target (explicit setting,
else Auto: account language_code -> UI locale) and refetches the current
track with LyricsRequest.language set — show-translation flips only when
the response actually embeds a translation; any gap toasts the Android-
parity error string and reverts, never putting the lyrics view in an
error state. Toggle OFF is pure UI (no network). While ON, track-change
requests ride the resolved target so the translation follows across
tracks; prefetch stays original-only. A doc that already carries the
target's translation flips locally without a refetch. The miniplayer
mirrors show-translation so the mini lyrics surface follows the sidebar.

km
2026-07-22 19:59:47 -06:00