Commit Graph
1200 Commits
Author SHA1 Message Date
vicrodh def821bd33 fix(download): add User-Agent header and remove stale timeout
download_audio() was sending bare GET requests without User-Agent,
while all other CDN request paths (probe, streaming) sent Mozilla/5.0.
CDNs commonly reject or truncate responses from requests without
User-Agent, explaining the "1 byte then EOF" failures on tracks
that work fine in the web player.

Also removed the 120s total timeout that contradicted the comment
saying "no total timeout" — Hi-Res+ files can be 200MB+ and need
more than 120s on slower connections.

cc
2026-04-06 11:42:02 -06:00
vicrodh 9f2c423cd4 fix(offline-cache): prevent HTTP/2 connection pool poisoning
StreamFetcher used a persistent reqwest::Client for the entire app
session. When a CDN connection broke mid-transfer, the HTTP/2 pool
kept reusing the dead connection, causing all subsequent downloads to
fail after 1 byte ("end of file before message length reached").

Changes:
- StreamFetcher now creates a fresh client per download attempt,
  matching the pattern used by download_audio() which never had
  this issue
- Added retry logic with exponential backoff (3 retries, 1s/3s/5s)
  — offline cache previously had zero retries for multi-hundred-MB
  downloads
- Clean up partial .tmp files on failure before retrying
- Extracted try_download() for clean retry loop

Root cause: issue #268 / reported in #270 testing

cc
2026-04-06 11:14:41 -06:00
vicrodh 09fcb5eb7b chore(deps): upgrade alsa crate 0.9 -> 0.10
Remove dead alsa dependency from src-tauri/Cargo.toml (code lives in
qbz-audio since V2 migration) and bump qbz-audio to alsa 0.10.
Eliminates duplicate alsa versions in Cargo.lock.

Breaking changes in 0.10 (Format/ChmapPosition reorder) do not affect
QBZ — we use catch-all matches and never rely on PartialOrd.

Closes #260

cc
2026-04-06 09:18:27 -06:00
AdamArstall 14f7d4d7d5 Removed change to library playback caching behaviour not necessary for fix 2026-04-06 11:07:33 +01:00
AdamArstall 130a127c8d Get repeat mode from bridge instead of app_state to avoid using deprecated type and having to set repeat mode in two places 2026-04-06 10:43:49 +01:00
AdamArstall 4c786c86fd Moved logic to repeat current track gapless from backend to frontent 2026-04-06 10:24:43 +01:00
AdamArstall 0c0ea645a8 Merge remote-tracking branch 'origin/pre-release' into bugfix/external/local-library-gapless 2026-04-06 08:35:18 +01:00
AdamArstall 151351a2b7 Fail silently if track not found in local library 2026-04-06 08:30:32 +01:00
AdamArstall 3feaed5e42 Removed comment noise 2026-04-06 08:19:31 +01:00
vicrodh 96967e8112 chore: regenerate lockfiles for tauri-plugin-os dependency
PR #265 added @tauri-apps/plugin-os (npm) and tauri-plugin-os (cargo)
but did not commit the updated lockfiles.

cc
2026-04-05 21:23:41 -06:00
Victor RH 5a4f014b79 Merge pull request #265 from afonsojramos/gate-flatpak-snap-macos
Reviewed: clean platform detection refactor, no audio code touched, all gates correct. Lockfiles will be regenerated post-merge.
2026-04-05 21:18:31 -06:00
Afonso Jorge Ramos e4462dfefd fix(macos): ad-hoc sign app bundle to fix Gatekeeper rejection 2026-04-06 01:35:08 +02:00
vicrodh 1934d501ed feat(audio): make quality fallback opt-in via allow_quality_fallback setting
Off by default. When disabled, if the requested quality is unavailable
the download/stream fails instead of silently downgrading. Persisted
to audio_settings DB. Applied to offline cache downloads.

cc
2026-04-05 10:44:05 -06:00
vicrodh d474a55d70 lore(changelog): auth changes
Updating docs for tag release.
2026-04-05 09:39:51 -06:00
vicrodh 12b8b3491a fix(auth): disable basic auth in bootstrap and legacy commands
Bootstrap no longer attempts email/password login — only OAuth token
restore. v2_manual_login and v2_auto_login now return immediately with
deprecation errors. Users with old saved credentials will see the
login screen instead of hitting Qobuz's deprecated endpoint.

cc
2026-04-04 21:13:41 -06:00
vicrodh 648f690a0b feat(auth): add system browser OAuth login and extract shared finalize_oauth_login
Refactor: shared finalize_oauth_login() handles code exchange, CoreBridge
injection, session activation, and token persistence. Frontend-agnostic,
reusable by GUI, TUI, and headless clients.

New command: v2_start_system_browser_oauth spawns a local axum listener,
opens the user's default browser for Qobuz OAuth, and captures the
redirect code automatically.

cc
2026-04-04 21:03:11 -06:00
vicrodh a8e6d151dc fix(security): remove sensitive values from log lines flagged by CodeQL
session_uuid and user_id removed from log output entirely.
CodeQL does not recognize custom sanitizer functions as sufficient.

cc
2026-04-04 20:38:09 -06:00
vicrodh 83e43949b7 feat(audio): add skip_sink_switch option for JACK/DAW routing (#263)
When enabled, skips pactl set-default-sink on stream creation.
Preserves external audio routing (JACK, qjackctl, Reaper).
Mutually exclusive with DAC passthrough.

cc
2026-04-04 12:08:22 -06:00
vicrodh ee019851ef chore: bump version to 1.2.2
cc
2026-04-04 11:15:15 -06:00
Victor RH 4aed668bbb Merge pull request #255 from vicrodh/dependabot/cargo/src-tauri/pre-release/tempfile-3.27.0
chore(deps): bump tempfile from 3.26.0 to 3.27.0 in /src-tauri
2026-04-04 11:04:16 -06:00
Victor RH 9e2fa8943e Merge pull request #258 from vicrodh/dependabot/cargo/src-tauri/pre-release/env_logger-0.11.10
chore(deps): bump env_logger from 0.11.9 to 0.11.10 in /src-tauri
2026-04-04 11:04:12 -06:00
Victor RH b05d0773a9 Merge pull request #259 from vicrodh/dependabot/cargo/src-tauri/pre-release/uuid-1.23.0
chore(deps): bump uuid from 1.22.0 to 1.23.0 in /src-tauri
2026-04-04 11:04:10 -06:00
Victor RH 2c75ee776c Merge pull request #264 from afonsojramos/macos-config-compat
fix(macos): gate Linux graphics CLI flags and crash handler
2026-04-04 10:57:41 -06:00
Afonso Jorge Ramos adfc390009 fix(notifications): use released notify-rust 4.13.0 instead of fork 2026-04-04 15:31:58 +02:00
Afonso Jorge Ramos 7a1890ad57 fix(audio): use released coreaudio-rs 0.14.1 instead of fork 2026-04-03 14:01:25 +02:00
Afonso Jorge Ramos 5d115277a5 feat: add @tauri-apps/plugin-os for platform detection 2026-04-03 13:58:04 +02:00
Afonso Jorge Ramos b1000cb9f0 fix(macos): gate Linux graphics CLI flags and crash handler with cfg 2026-04-03 03:19:52 +02:00
dependabot[bot] 32923d3fc3 chore(deps): bump uuid from 1.22.0 to 1.23.0 in /src-tauri
Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.22.0 to 1.23.0.
- [Release notes](https://github.com/uuid-rs/uuid/releases)
- [Commits](https://github.com/uuid-rs/uuid/compare/v1.22.0...v1.23.0)

---
updated-dependencies:
- dependency-name: uuid
  dependency-version: 1.23.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-04-02 07:11:31 +00:00
dependabot[bot] 88b5df19a9 chore(deps): bump env_logger from 0.11.9 to 0.11.10 in /src-tauri
Bumps [env_logger](https://github.com/rust-cli/env_logger) from 0.11.9 to 0.11.10.
- [Release notes](https://github.com/rust-cli/env_logger/releases)
- [Changelog](https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rust-cli/env_logger/compare/v0.11.9...v0.11.10)

---
updated-dependencies:
- dependency-name: env_logger
  dependency-version: 0.11.10
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-04-02 07:11:13 +00:00
dependabot[bot] c346861db0 chore(deps): bump tempfile from 3.26.0 to 3.27.0 in /src-tauri
Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.26.0 to 3.27.0.
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Stebalien/tempfile/compare/v3.26.0...v3.27.0)

---
updated-dependencies:
- dependency-name: tempfile
  dependency-version: 3.27.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-04-02 07:10:47 +00:00
Victor RH e56b0cbb6a Merge pull request #238 from afonsojramos/fix/macos-x86-build
fix(macos): enable x86_64 cross-compilation
2026-04-01 16:29:13 -06:00
AdamArstall 28bcfeba73 Fix loop one mode when using gapless playback 2026-04-01 19:58:00 +01:00
AdamArstall f99dbe9fd1 Try local library for gapless playback if not in any cache 2026-04-01 13:13:33 +01:00
Victor RH 1b10f6c132 Merge pull request #246 from afonsojramos/feat/macos-rich-notifications-pr
feat(macos): add album artwork to notifications
2026-03-31 20:27:23 -06:00
Victor RH 4a8f2e5562 Merge pull request #244 from afonsojramos/fix/macos-gate-idle-inhibit
fix(macos): gate idle_inhibit module for Linux only
2026-03-31 20:27:09 -06:00
Victor RH b2f75cc85c Merge pull request #239 from afonsojramos/feat/macos-deep-link
feat(macos): add deep link support for qobuzapp:// URLs
2026-03-31 20:27:02 -06:00
Victor RH eed692a852 Merge pull request #236 from afonsojramos/feat/coreaudio-device-probing
feat(macos): add CoreAudio device probing and sample rate switching
2026-03-31 20:26:29 -06:00
Afonso Jorge Ramos b8af1763ef feat(macos): add album artwork to notifications via image_path 2026-04-01 03:35:34 +02:00
Afonso Jorge Ramos a4a591e73c feat(macos): switch to notify-rust fork with image_path support 2026-04-01 03:35:27 +02:00
Afonso Jorge Ramos 9823dfb680 fix(macos): enable x86_64 cross-compilation
- Upgrade rust_cast 0.18.1 → 0.21 (switches from openssl to rustls,
  removing the openssl-sys dependency that blocked x86_64 cross-compile)
- Split mupdf sys-lib features to Linux-only (on macOS there are no GTK
  symbol conflicts, and system libs don't support x86_64 cross-compile
  from Apple Silicon)
- Update release-macos workflow to build both aarch64 and x86_64 DMGs
  using a matrix strategy
2026-04-01 02:40:55 +02:00
Afonso Jorge Ramos 478353055c fix(macos): gate idle_inhibit module for Linux only 2026-04-01 02:27:21 +02:00
vicrodh 1e019becfd fix: resolve correct artist and country for MusicBrainz metadata
Three fixes:
- resolve_artist now prefers exact name matches over highest score,
  fixing "The Warning" resolving to "Fates Warning" (score=100 but
  wrong name vs score=97 exact match)
- resolve_area_country now returns ISO country code alongside name,
  fixing flag display (was showing US flag for German artists)
- country_code updated in location metadata for correct flag rendering

cc
2026-03-31 17:23:00 -06:00
vicrodh 1953774d03 fix: resolve birth country from area hierarchy instead of MB country field
Add resolve_area_country() that walks the MB area hierarchy up to
the country level (e.g., Frankfurt -> Hessen -> Germany).

Use it in v2_musicbrainz_get_artist_metadata to get the real birth
country instead of MB's "country" field (which is where the artist
is active, not where they were born).

Hans Zimmer now shows "Frankfurt am Main, Germany" and clicking
the location shows German composers, not American ones.

cc
2026-03-31 17:17:01 -06:00
vicrodh 305cffa08e fix: don't append country to birth location display
MB's country field is where the artist is active, not where they
were born. When begin_area exists (city-level), display only the
city name to avoid incorrect attribution (e.g., Hans Zimmer born
in Frankfurt showing "United States").

cc
2026-03-31 16:57:13 -06:00
vicrodh f702622e0e fix: correct artist birth/formation location display order
Two bugs in location_discovery.rs:
- Display format was "Country, City" instead of "City, Country"
- Country was derived from area (where artist is active) instead
  of country code (where artist was born/formed)

Hans Zimmer now shows "Frankfurt am Main, Germany" instead of
"United States, Frankfurt am Main"

Closes #235

cc
2026-03-31 16:54:07 -06:00
vicrodh d19c142d4f fix: switch log upload to paste.rs (dpaste.org returns 403/405)
paste.rs accepts raw POST body and returns URL directly.
Simpler API, no expiration config needed.

cc
2026-03-31 16:45:07 -06:00
vicrodh 527d63ca2c fix: migrate log upload from 0x0.st to dpaste.org
0x0.st disabled uploads. Switch to dpaste.org with 15-day expiry.
Use form POST instead of multipart, update all 5 locale files.

cc
2026-03-31 16:43:28 -06:00
vicrodh 6acd843891 feat: add streaming buffer progress indicator to seekbar
Show a subtle buffer progress bar in the seekbar when streaming
tracks (before they are fully cached). The bar disappears once
the track is fully buffered.

Backend: expose buffer_progress from BufferedMediaSource through
SharedState -> PlaybackEvent -> playerStore.
Frontend: render .seekbar-buffer bar behind the playback fill.

cc
2026-03-31 16:02:07 -06:00
victorrhgap 080b916c64 feat: prevent system sleep during playback via XDG portal
Add idle_inhibit module using ashpd's Inhibit portal to prevent
screen blanking and system suspend while audio is playing.

- Acquires Idle+Suspend inhibit when playback starts
- Releases when paused, stopped, or track cleared
- Works on GNOME, KDE, Sway, XFCE
- Works inside Flatpak/Snap (no extra permissions needed)
- Graceful fallback if portal unavailable

Addresses #229

cc
2026-03-31 12:41:21 -06:00
victorrhgap 2900fb882c feat: add log sanitization for sensitive IDs and UUIDs
Add log_sanitize module with mask_uuid() and mask_id() functions to
prevent security scanners from flagging user IDs and session UUIDs
in log output.

- mask_uuid: 123e4567-e89b-12d3-a456-426614174000 -> 123e4567-****-****-****-****14174000
- mask_id: 12345678 -> 1234****
- Applied to offline_user_id in session_lifecycle (CodeQL alert #50)
- Applied to session_uuid and command uuid in qconnect_service

cc
2026-03-31 12:05:24 -06:00