Commit Graph
6943 Commits
Author SHA1 Message Date
vicrodh e9b02cdedb fix(player): never panic the audio thread when the loudness cache cannot open
LoudnessCache::new failing (full disk, read-only profile, corrupt
loudness_cache.db) used to panic inside the audio thread, which is created
once in Player:🆕 playback was dead until restart while the log promised
the opposite. The cache now degrades to an in-memory session cache, then to
a disabled cache, and normalization keeps running.

cc
2026-09-13 03:36:50 -06:00
vicrodh c25ae457c1 fix(artwork): restore the shared image cache eviction lost with the Slint frontend
ImageCacheService::evict had no caller since 69ed61207 retired the Slint
app's spawn_evict, so ~/.cache/qbz/images grew without bound in 2.1.0 and
2.1.1. housekeeping() now trims it to the same 200 MB budget once per run,
in 64-row batches so the GUI thread is never parked behind the cache
mutex. evict is batched and covered by unit tests.

cc
2026-09-13 03:27:56 -06:00
vicrodh 5e739f658e merge: integrate 2.1.2 playback and library stabilization
cx
2026-09-13 02:57:34 -06:00
vicrodh e291eb3af4 fix: stabilize playback memory, local library sync and Qt settings
Add shared playback memory profiles, bounded disk-backed playback and storage
selection for desktop and daemon. Preserve gapless during streaming-only playback
and provide explicit cache eviction with playback confirmation.

Stop watcher read events and unchanged scans from rebuilding the local catalog.
Restore playlist/sidebar updates, folder availability feedback and player layout.
Add appearance presets and a radio-based cache settings panel with translated
trade-offs, plus consistent clipboard menus across visible Qt text editors.

Validate with Rust regressions, QML interaction tests, isolated release startup
and idle-library checks; extend the shared local and CI gates.

cx
2026-09-13 02:57:21 -06:00
vicrodh 3cf1f32177 merge: integrate updater recovery and installer into pre-release
cx
2026-09-12 16:25:14 -06:00
vicrodh 7a22fd6867 feat(updater): add native update channels and one-line installation
Support Flatpak portal updates and signed Windows MSI upgrades. Add the Linux/macOS installer for 2.1.2, release signing, translations and regression coverage.

cx
2026-09-12 16:25:08 -06:00
vicrodh 64ec3e2bc8 fix(updater): restore Qt release checks and signed installation
cx
2026-09-12 15:20:23 -06:00
vicrodh 6a02dcdd67 merge: integrate Orbit foundations into pre-release
cx
2026-09-12 13:02:38 -06:00
vicrodh 74e1610433 feat(orbit): add shared library foundations and gated host tools
Extract the HTTP host and catalog layer into qbz-control, preserve the
existing daemon API, and keep private session credentials out of SSE.

Scope library stores and scan workers to their host. Share bounded source
search and show Local results alongside Qobuz in the Qt search page.

Add the launch-gated Qt Orbit laboratory and persistent remote-context
banner. Let qbzd run --orbit own and administer its file library through
instance-scoped API and CLI operations. Full remote UI control remains
pending.

Validate library/control/daemon suites, Qt search and QML regressions,
two isolated daemon processes, Qt release build and final cargo check.

cx
2026-09-12 13:02:29 -06:00
vicrodh 6394ef176c chore: bump flake to 2.1.1
qbzVersion 2.1.1 and both tarball hashes from the published v2.1.1 assets
(nix-prefetch-url / sha256 at their final URLs).

cc
2026-09-11 17:19:05 -06:00
vicrodh 3a8c31339e Merge pre-release into main for 2.1.1
flake.nix: take pre-release's prebuilt-tarball flake (#744); main's
source-build variant with the 2.1.0 srcHash is superseded.

cc
2026-09-11 15:34:47 -06:00
vicrodh 456e12e114 docs(release-2.1.1): add the 2026-09-11 batch to the notes and metainfo
Resizable panels (#771), collapsible My QBZ sidebar, artist identity
matching (#768), album-card editions, queue ordering (#442), custom artwork
on cards, GNOME clipboard (#684) and dock icon, MPRIS after restore (#683),
and the prebuilt-tarball flake (#744). Release date moved to 2026-09-11.

cc
2026-09-11 15:34:08 -06:00
vicrodh f334fbcf45 Merge bugfix/internal/wayland-app-id-desktop-file into pre-release
cc
2026-09-11 15:30:07 -06:00
vicrodh 0a0322e18d fix(linux): publish the desktop-file name so Wayland windows match their launcher
GNOME Shell pairs a live window with its launcher through the Wayland app_id,
and Qt sends the executable's name (`qbz`) unless the application sets its
desktop-file name. Every Linux package installs the entry as
`com.blitzfc.qbz.desktop`, so the dock painted the generic icon while the app
grid, which reads the .desktop directly, showed the right one; the D-Bus
notification `desktop-entry` hint had the same gap. StartupWMClass covers
X11 only.

Set `QGuiApplication::desktopFileName` to `com.blitzfc.qbz` right after the
application exists (Linux only). Verified the mechanism on an Ubuntu
GNOME/Wayland VM: a `qbz.desktop` symlink made the dock icon appear.

cc
2026-09-11 15:30:07 -06:00
vicrodh 1032974358 Merge bugfix/internal/windows-gate-temp-dir-fixture into pre-release
cc
2026-09-11 14:49:31 -06:00
vicrodh e99a5e0fa1 fix(ci): compare editor directories against a fixture the Windows gate can match
Two tag_editor_qt tests compared editor_directory() — the parent() of a
file inside std::env::temp_dir() — against temp_dir() itself. On Windows
temp_dir() ends in a separator ("C:\...\Temp\") and Path::parent never
yields one, so the strings differ and the Windows Qt gate failed on every
run since 2026-08-28, the v2.1.0 tag push included. Linux never saw it.

Both tests now use a created subdirectory of temp, which normalises the
two sides on every platform.

cc
2026-09-11 14:49:31 -06:00
vicrodh 743d68fda4 fix(ci): give the early-exit smoke fixtures a window a slow runner cannot miss
test_core_then_signal_crash_is_rejected_without_core_dump flaked on the
2026-09-11 pre-flight: its fake child (a fresh Python interpreter that
prints the startup marker and SIGSEGVs itself) has to reach the crash
inside a 250 ms observation window. On a loaded runner it did not; the
deadline expired with the child alive, the shutdown SIGTERM raced the
self-inflicted SIGSEGV, and the smoke rejected the run as "unexpected
process exit status -11" instead of the "exited before" the test asserts.

The early-exit fakes now get a 5 s window — free, since observe() returns
the moment the child exits — while the four live-process fakes keep their
explicit 250 ms so the suite still runs in ~2 s.

cc
2026-09-11 14:43:01 -06:00
vicrodh 6e25a4ea45 Merge bugfix/internal/684-683-clipboard-mpris into pre-release
cc
2026-09-11 13:53:27 -06:00
vicrodh 8cad9c7ca7 fix(mpris): publish Paused after a session restore (#683)
A restored session runs `refresh_now_playing`, whose MPRIS push is the
optimistic `Playing` at position 0 — correct for the real play path, where
a stream is about to open and the poll loop's play/pause edge corrects it.
Nothing opens on restore, so `playerctl status` answered "Playing" from
boot until the first real play, and the sleep inhibitor was armed for a
paused app. Publish Paused at the resume position once the restore is done.

Verified: playerctl reports Paused on a restored, unplayed session.

cc
2026-09-11 13:53:27 -06:00
vicrodh 6b81cfa84d fix(share): copy links through QClipboard, not arboard (#684)
Copy link failed on GNOME + Flatpak: arboard's Wayland path needs the
wlr/ext-data-control protocol, which Mutter does not implement, so it fell
back to X11 — reachable natively through XWayland, unreachable inside the
sandbox ("clipboard unavailable: X11 server connection timed out"). KWin
has the protocol, which is why the failure never reproduced on Plasma.

Replace it with a C++ shim (cxx/clipboard.cpp) that queues the write onto
the GUI thread and hands it to QClipboard: the base wl_data_device protocol
every compositor implements, no extra sandbox permission, and the offer
lives as long as the application (the #514 lifetime rule, without the
long-lived arboard instance). arboard is dropped from the crate.

Verified on Plasma/Wayland and on an Ubuntu GNOME/Wayland VM with DISPLAY
unset (the sandbox condition), where the copy now lands.

cc
2026-09-11 13:53:27 -06:00
vicrodh 8b1941d9ad Merge feature/internal/771-resizable-panels into pre-release
cc
2026-09-11 13:09:47 -06:00
vicrodh dc158bd9b6 feat(shell): resizable playlist sidebar and queue/lyrics column (#771)
Both panels were fixed-width (240 / 300); playlist names elided on wide
monitors. Each panel's visible edge (the content pane's edge, 8px past the
panel — the bezel between them shares the panel colour) now carries a 5px
grab strip with a 2x28 notch, split cursor, and a one-shot accent pulse when
a drag lands on a snap point.

Rules live in `panel_resize.rs` (pure, unit-tested), the bridge applies them
live and persists on release (`ui_prefs` `sidebar_width` / `queue_panel_width`,
clamped on read):
- sidebar: 240..480 while open; below 200 it snaps to the mini rail, below 24
  it closes through the same state the header button uses (with the Large-NPB
  fallback); the mini rail reopens at 220 — a 20px hysteresis band so no
  pointer x can flip open<->mini on every move (the flapping seen in the
  2026-09-11 screencast). The stored width never drops below 240, so
  reopening restores the last open width. A state snap during a drag still
  animates: the bridge raises `sidebarSnapping` before the state change and
  Sidebar's width Behavior honours it while the drag otherwise disables it.
- column: 300..600; below 260 it closes queue and lyrics as their X would.
  With the queue in the column and the width parked at 600, the notch shows a
  steady larger glow toward the content; pushing 60px further opens the
  Listen List (queue-view) and the queue leaves the column, lyrics staying
  if open. A lyrics-only column never pushes through.

The Large-NPB dock is untouched: it is mounted with absolute x/width in
AppShell and reads nothing from the sidebar width.

Verified: panel_resize 9/9, qmllint + the six qt-run.sh audits, release
builds v1-v4, four owner smoke rounds.

cc
2026-09-11 13:09:47 -06:00
vicrodh f9795e3c18 Merge bugfix/internal/2.1.1-card-version-and-768-identity into pre-release
cc
2026-09-11 09:46:02 -06:00
vicrodh 7e30ad769d fix(musicbrainz): identity-based artist matching, never an unrelated first result (#768)
Swim Deep's Artist page showed Deep Purple's founding year and members. Two
defects combined: `search_artist` emitted `artist:Swim Deep` unquoted (the
second word leaks into the global query; Deep Purple ranks first at 100,
Swim Deep second at 88), and `resolve_artist` fell back unconditionally to
the first result when no exact name scored >= 90. Name-keyed caches then
made such guesses durable and shareable across homonyms.

New `qbz-integrations::musicbrainz::identity` — pure decisions plus
orchestration over injected fetcher/store/catalog boundaries:
- query `artist:"<lucene-escaped name>"`, URL-encoded once;
- containment rule: exactly one exact-name candidate with score >= 90, else
  None — the first-result fallback no longer exists;
- source direction (Qobuz artist id -> MBID): the page's own Popular-Track
  ISRCs (max 3, guests excluded) vote among the exact-name candidates using
  every credit of every recording that carries the ISRC; ties, conflicts and
  failures fail closed;
- scene direction (MBID + catalog scope -> Qobuz id): a unique exact-name
  Qobuz artist is provisional; several homonyms are split by their own
  top-track ISRCs (max 2 each); no evidence omits the row instead of taking
  max(albums_count);
- four `*_v2` cache tables keyed by the stable identifier + matcher version,
  carrying evidence kind, expiring at read time (verified 30 d, provisional
  7 d, search windows 7 d, ISRC credits 30 d); legacy name-keyed rows are
  neither read nor written; scene cache key bumped to v2 with the real
  account territory (no scope -> no cache), rows re-derived on replay.

Core: `catalog_scope()`, `musicbrainz_resolve_source_artist`, store/catalog
adapters; `musicbrainz_resolve_artist` and the musician resolver go through
the containment rule. Artist page passes {qobuz id, own ISRCs} to core and
keeps its generation guard; QML, playback, auth and reco crates untouched.

Tests: qbz-integrations 59 (query encoding, #768 ordering fixture, ISRC
voting incl. collaborations/dupes/conflicts, cache keys/TTL/version/legacy,
bounded fan-out with request counting), qbz-core 40, qbz-qt 782.

cc
2026-09-11 09:46:02 -06:00
vicrodh baed7bb785 fix(cards): carry the Qobuz album version in card titles + tooltip when elided
Every album card producer copied `title` raw although the model carries
`version` ("50th Anniversary", "Deluxe"); the album page, info modal and quick
view already used `format_album_title`. The Artist page listed two identical
"All Things Must Pass" cards for two different editions.

- Route the 8 card producers through `album_qt::format_album_title`
  (artist page buckets, album carousels, label grid, Home rails, Library ALL
  feed, Artist Scene); search_qt drops its private duplicate of the helper.
- AlbumCard.qml: the title is always the full string, elided at the card
  width; when Qt reports `truncated`, hovering shows the whole title in a
  Controls ToolTip (QualityBadge pattern, no character counting, no ticker).

Verified: qmllint clean, qbz-qt suite 782/782, release build.

cc
2026-09-11 09:45:47 -06:00
vicrodh cab68c9209 fix(queue): play-next/play-later ordering + Q-mix multiselect/queue/create-playlist (#442)
Split the manual insertion block into two tiers so "Play later" no longer
behaves identically to "Play next":
- add a `manual_later_count` to InternalState tracking the trailing
  "Play later" sub-block: [now][play-next block][play-later block][source].
- play-next inserts at the FRONT of the manual block; play-later appends at
  its END (after any earlier play-later tracks), in order.
- fix the idle + shuffle case: with no current track, both actions anchor at
  base 0 instead of the end of shuffle_order, so an idle-built queue plays
  play-next first and play-later right after, and does not collapse the rest
  of the queue on the first transport play.
- next()/remove_at()/jump decrement drain the play-next tier before the
  play-later tier; set_queue/clear/shuffle-enable dissolve both.
- the public QueueState.manual_next_count exposes mnc+mlc so both tiers render
  inside the single "Next in queue" visual container.

NorinB's shuffle-randomization report keeps a debug log in next() to capture
a repro if it recurs; the temporary INFO instrumentation is lowered to debug.

MixView Q-mixes reach transport parity with playlists: functional multiselect
(SelectionModel + multi-select bar), header queue menu (play next / later /
add to queue via bulkTracksAction), and create-playlist-from-selection.

Queue engine covered by 86 passing tests (play-later ordering non-shuffle,
under shuffle, and idle-shuffle cases added).

cc
2026-09-11 08:51:38 -06:00
vicrodh ef74cde3d8 test(myqbz): align tracks_text test with the #766 empty-column contract
The stale test still asserted the pre-#766 behavior (em-dash for an unknown
album count, "1" for a track). #766 made the tracks column empty for a track
and empty for an unknown album count (filled only once resolve_items backfills)
— the shipped, smoke-validated behavior. Update the test to match; the CI qt
gate was red on this alone.

cc
2026-09-10 23:20:38 -06:00
vicrodh 6047a9ee0d fix(artwork): show custom album cover / artist portrait on cards app-wide
A user-set custom cover (add_custom_cover) or artist portrait (add_custom_image)
showed only on the album/artist page, never on the grid cards. The card
builders emitted the source artwork URL and skipped the override map.

Library album and artist cards now prefer the override; Home (all tabs) and
recommendations pick it up at the shared attach_cached choke point — one store
read per pass, skipped entirely when a profile has no overrides — keying albums
by id and artist rails by display name; and Search artist rows prefer the
portrait too. Albums already routed through prefer_album_cover on the album,
artist, playlist and search-album surfaces.

cc
2026-09-10 20:55:08 -06:00
vicrodh c82e624188 release: bump workspace version to 2.1.1
The About modal reads CARGO_PKG_VERSION, so it showed 2.1.0. Bump the workspace
version (and the Cargo.lock members) to 2.1.1 and add the 2.1.1 metainfo release
entry.

cc
2026-09-10 20:33:15 -06:00
vicrodh dbb4d849d3 fix(flake): install the prebuilt release tarball instead of building from source (#744)
The source build failed under Nix at cxx-qt / qt-build-utils with "Could not
find qmltyperegistrar": the Qt host tools live across several outputs and the
sandbox PATH did not carry qtdeclarative's. Rather than chase that, the flake
now repacks the published bare-binary tarball (the same asset AUR-bin / Gentoo
/ Flathub consume) — matching the project's binary-repack packaging doctrine and
dropping the whole Rust/Qt toolchain from the closure.

autoPatchelfHook rewrites the binary against nixpkgs and wrapQtAppsHook wires
the Qt plugin/QML paths; qt6-base/declarative/svg/wayland mirror the qbz-bin
depends. Per-arch tarball hashes for x86_64 and aarch64, computed from the
published v2.1.0 assets. Verified: nix build succeeds and the wrapped binary
launches against nixpkgs Qt 6.10.2. Bump version + hashes post-tag.

cc
2026-09-10 20:33:15 -06:00
vicrodh 9e6992c066 merge: collapsible My QBZ sidebar (tree, per-element hide, header toolbar)
cc
2026-09-10 20:22:38 -06:00
vicrodh ae9f1c2679 docs(release-2.1.1): tag details and changelog
First 2.1 maintenance release: scroll response/perf in heavily populated
sections plus a broad round of bug fixes (#764, #766, #748, #745, #660).

cc
2026-09-10 20:20:26 -06:00
vicrodh d025e92160 chore(about): add Ko-fi supporter Olivier
Cumulative thank-you list update from the maintainer's Ko-fi records; no
GitHub changes this round.

cc
2026-09-10 20:20:26 -06:00
vicrodh e402fa250a feat(myqbz): collapsible My QBZ sidebar with per-element hide and toolbar
Opt-in collapsible My QBZ tree in the sidebar (Settings > Navigation): a
branding-titled parent over Mixtapes and Collections sections, each header a
link to its grid with a chevron that only collapses. Header text and icon on
the left, a Playlists-parity toolbar floating right (search, new, sort A-Z/Z-A,
refresh, collapse) with the chevron aligned to the playlist carets. The tree
feed rides QbzShell (QbzMyQbz is not reliably registered in the shell context)
and is published through publish_sidebar, so it lands reliably at startup.

Per-element visibility reuses the mixtape hidden flag (repo::set_hidden): a
row's right-click hides it from the sidebar, and the detail hero menu toggles
"Hide from sidebar" / "Show in sidebar". Collapse state for the playlist tree
and all three My QBZ sections is persisted. The collapsible tree and the flat
My QBZ entry are mutually exclusive — the classic row is suppressed whenever the
tree is on. Settings gains a Navigation section (Navigation + Search moved out
of Appearance). Detail view also gains a discreet, column-aligned sub-header
over the inline track list. Eight locales updated.

cc
2026-09-10 20:19:48 -06:00
vicrodh 66cd5fb1da merge: mixtape/collection detail fixes and importer reduction (#766)
Song-to-album routing, source-aware "Remove from Mixtape", per-source glyphs,
tracks count, "Add to mixtape" from the playlist header with live update, and
stop importing mixtapes/collections until their ids remap. Validated by owner
smoke.

cc
2026-09-10 16:11:57 -06:00
vicrodh ee66a21457 fix(migration): stop importing mixtapes and collections until ids remap
Mixtape/collection items reference playlist and album ids that change during an
account import, so copying mixtape_collections / mixtape_collection_items
verbatim left garbage rows pointing at ids that no longer exist. Drop them from
both copy paths (fast and remapped) and drop the collection view-state JSON,
with a note on how to re-enable once the importer remaps ids (import elements
first, note the new ids, then import + update the collections). Elements
(playlists, local albums) still import.

cc
2026-09-10 16:11:44 -06:00
vicrodh 0297dfcee9 feat(myqbz): add a playlist to a mixtape from its header, update live
- PlaylistView's header menu gains "Add to mixtape" (source-aware: local vs
  qobuz), matching the cards and the sidebar which already had it.
- Adding an item to a mixtape now re-derives and republishes the OPEN detail
  (reload_if_open), so a just-added playlist appears without reopening. (#766)

cc
2026-09-10 16:11:44 -06:00
vicrodh cc50b01dca fix(myqbz): mixtape/collection detail row corrections (#766)
- A song row opens the album it is on (its resolved, source-aware albumId)
  instead of a blank page; the album id is plumbed from the first resolved track
  through the resolve pass, and an unresolved click is ignored like the artist
  link. (#766 problem 1)
- The row menu says "Remove from Mixtape" on a mixtape, "Remove from collection"
  elsewhere. (#766 problem 2)
- A playlist inside a mixtape hides its quality cell (per-track quality is
  varied); collections keep it.
- The source column shows one glyph per DISTINCT source across the item's
  tracks, so a mixed-source playlist shows them all.
- The tracks column is empty only for a track; an album or playlist shows its
  resolved track count instead of a dash.

cc
2026-09-10 16:11:44 -06:00
vicrodh 95d5d532f3 chore(packaging): jack makedepends and Flathub runtime 6.11
- AUR qbz and qbzd: makedepends jack2 -> jack, so pipewire-jack can satisfy the
  build-time JACK dependency (both provide `jack`; only jack2 provides `jack2`).
- Flathub: bump runtime/SDK from the EOL org.kde.Platform 6.9 to 6.11 (verified
  available in the KDE flatpak-kde-runtime branches). The binary is built
  against Qt 6.8 and loads on 6.11 by forward ABI compatibility. (#755)

cc
2026-09-10 13:24:24 -06:00
vicrodh 435098b981 merge: MusicBrainz 503/transport resilience + scene loading UX
Retry 503s and transient transport hangs behind a shared per-process rate
limiter, cache resolved artists, drop the redundant scene backoff, and add a
scene loading heads-up + 5-minute retry timeout. Client tuning and scene
verified by owner smoke.

cc
2026-09-10 13:24:24 -06:00
vicrodh 89da9bbd13 feat(scene): loading heads-up and a 5-minute retry timeout
The ArtistScene discovery fans out many MusicBrainz requests, so a throttled MB
can keep it loading a while. After ~10s the loading screen shows a "this can
take a few minutes" note; after 5 minutes it swaps the spinner for a Retry (a
late success still swaps in the grid on its own). Both derive from the existing
pulse-driven clock, so no new Timer and the repaint law holds. Two new strings
across all eight locales.

cc
2026-09-10 13:23:53 -06:00
vicrodh 8e8efb00fa feat(mb): cache resolved artists in the core, drop the redundant scene backoff
- musicbrainz_resolve_artist is now cache-first + write-after via
  MusicBrainzCache::get_artist/put_artist (resolved_artists), the same shape as
  the metadata path, so reopening an ArtistPage no longer re-runs a live
  artist?query= search. Negatives are never cached; the existing cleanup(ttl)
  governs expiry.
- Remove the scene's one-shot Retry-After backoff: the client already retries
  503s, so stacking another wait could push the total past ~10s.

cc
2026-09-10 13:23:53 -06:00
vicrodh 857cb16e87 fix(mb): retry MusicBrainz 503s and transport failures behind a shared limiter
- Route every endpoint through a new send_with_retry: it waits on the rate
  limiter, GETs, logs the x-ratelimit budget, and on a 503/429 backs off the
  server's Retry-After (capped 8s) and retries, up to 3 attempts. get_artist_tags
  and get_recording_isrcs, which skipped status handling entirely, now go
  through it too.
- Also retry transient TRANSPORT failures (a hung connection to the request
  timeout, a drop or refusal). MusicBrainz under load hangs instead of returning
  503, which surfaced as "error sending request for url". Capped at 2 attempts
  with a 6s request timeout so a total failure is ~13s, not ~33s, while a hang
  that clears still recovers on the second try.
- Share ONE process-wide direct rate limiter across every client (core, the tag
  editor, remote metadata) so several clients on one public IP pace as one 1.1s
  stream instead of each pacing itself.
- Log MusicBrainz's x-ratelimit-limit/remaining/reset headers (debug on 2xx,
  warn on 429/503) as the only signal of whether the bucket was ours or MB's.

Tests: 503-then-200, a dropped connection, and shared-limiter serialization,
each red-to-green. Dev-only deps (tokio test features + rustls/aws-lc-rs to
install the crypto provider); no runtime dependency added.

cc
2026-09-10 13:23:53 -06:00
vicrodh 4216bdb6cc merge: 2.1.x UI polish, playlist row fixes (#764) and sponsor update
Bundles the header-select homologation, seekbar fluidity, per-platform app-menu
and keyboard shortcuts, per-tab Library filter persistence, the local track-info
routing, the playlist removal and remote-cover-art fixes, and a Ko-fi credit.
All verified by smoke test.

cc
2026-09-10 11:22:36 -06:00
vicrodh 4a52c66385 chore(about): add Ko-fi supporter Miguel
New named one-time Ko-fi supporter. Anonymous entries are not recorded.

cc
2026-09-10 11:22:08 -06:00
vicrodh d9d5cd0771 fix(qt): playlist row removal and remote-source cover art
- Remove from playlist did nothing for a Qobuz row. The membership-id split
  made a row's display id (the catalog id QML sends) differ from its
  playlist_track_id (the membership id), but remove_track still matched the
  open document and called playlist/deleteTracks by the catalog id, so the
  lookup found nothing and the endpoint got a non-membership id. Resolve the
  catalog id to the row's membership id, remove exactly that row, and delete by
  membership; same-catalog duplicates keep their other copy. The local and
  mixed-sidecar arms were already correct. Verified by smoke test. (#764)
- Media-server rows (Jellyfin, Subsonic/Navidrome and Plex) showed no cover in
  the playlist TrackRow while the queue and NowPlayingBar did. The row fed
  cached_path the raw artwork token, which classify cannot resolve, whereas the
  queue namespaces it through portable_artwork_ref. Build the row cover from
  that same ref, and warm uncached covers on the local-playlist load (the Qobuz
  loader already did) so the cover appears without playing the track.

cc
2026-09-10 11:22:08 -06:00
vicrodh 04f6ef44e4 feat(qt): 2.1.x UI polish round — header selects, seekbar, shortcuts, per-tab filters
- Homologate the three Library header selects to the ambient Group style; Sort
  gains an arrow-down-up glyph, a "Sort" placeholder and an explicit Default,
  and every select's border clears when it returns to its default value.
- Seekbar fluidity: a drag scrubs locally and commits a single seek on release;
  the time readout is a floating opaque tooltip reparented to the overlay so the
  content-frame shadow no longer bleeds noise over it.
- Route the NowPlayingBar info button and title to the LOCAL track-info modal
  for a local row, so a local track no longer opens an empty Qobuz modal.
- App menu shows each entry's shortcut (muted, smaller, right-aligned, resolved
  per platform — Cmd on macOS, Ctrl elsewhere) and gains a Quit entry; the
  keyboard-shortcuts modal adds Close Window and Quit under Navigation, moves
  Immersive below Interface, and tightens row heights. i18n for Quit/Close
  Window across all eight locales.
- Persist each Library tab's filter toggles to disk, independently per tab.

cc
2026-09-10 11:21:50 -06:00
vicrodh 35c3d368b9 merge: wedged CPAL stream recovery and POLLERR rate-limit (#660)
cc
2026-09-10 01:35:48 -06:00
vicrodh 9fdf53c3ea fix(audio): recover from a wedged CPAL output stream and rate-limit POLLERR (#660)
cpal 0.17's ALSA worker reports `alsa::poll() returned POLLERR` and polls
again immediately, without snd_pcm_recover: a PCM left in XRUN/SUSPENDED/
DISCONNECTED (CPU starvation at a track change on a Pi, a suspend, a pulled
cable) becomes a tight loop that never plays again until the stream is
dropped. rodio's default callback eprintln!s every one of them, which is the
POLLERR flood in the issue. The System default and PipeWire routes installed
no error callback at all, and nothing rebuilt a wedged stream.

- New qbz-audio::stream_health: classify (Wedged vs Transient), a flood
  limiter (one log line per 5s window with a suppressed count), a wedge
  latch, and one shared error_callback installed on every CPAL route
  (System default x4, PipeWire, ALSA) and the legacy player path.
- The audio thread checks the wedge latch at the TOP of its loop, every
  iteration, not in the recv_timeout Timeout arm: under QConnect the
  renderer-state command flow keeps recv returning Ok(...) and the Timeout
  arm barely runs, which left a wedged worker spinning a core for ~22s.
  On a wedge it drops the stream (joining cpal's worker), and when playing
  rebuilds and resumes at the current position; a second wedge within a 10s
  backoff releases the device and stops instead of looping.

Bit-perfect paths (ALSA Direct, DSD, WASAPI) are untouched; they never use
cpal's worker. The low-memory profile from 2.1.0 already addressed the exit
137 OOM; this is the separate flood/wedge half.

Verified on a Pi 4B + HiFiBerry DAC+ over the System default route with a
192 kHz 835 MB track and SIGSTOP-induced wedges: rebuild+resume in ~40 ms,
auto-recovery after the backoff, release+stop on a repeat wedge, and 7
POLLERR log lines instead of a flood. qbz-audio 125 and qbz-player 139 tests
pass; new stream_health and wedge_recovery tests included.

cc
2026-09-10 01:35:38 -06:00
vicrodh 1ff6df5bac merge: DLNA service-URL tolerance and fatal-signal diagnostics (#745)
cc
2026-09-09 22:48:14 -06:00