Commit Graph
486 Commits
Author SHA1 Message Date
vicrodh d0a30c7175 fix(local-library): remove non-existent AddToPlaylistModal import
- Remove broken AddToPlaylistModal component import
- Use existing PlaylistModal infrastructure from parent component
- Pass onTrackAddToPlaylist callback from +page.svelte to LocalLibraryView
- Follow existing pattern used in AlbumDetailView and other views

cp
2026-01-15 09:43:40 -06:00
vicrodh 0b439bff14 fix(ui): use existing PlaylistModal for now playing add to playlist
- Remove duplicate AddToPlaylistModal component
- Reuse PlaylistModal component that TrackRow already uses
- Consolidate playlist management UI patterns

cp
2026-01-15 09:32:42 -06:00
vicrodh 42349f14dd fix(api): respect user locale for artist biography
- Add locale field to QobuzClient for API language preference
- Pass lang parameter to Qobuz artist detail endpoints
- Create set_api_locale command to update client locale
- Sync API locale with UI i18n settings automatically
- Render artist biography HTML tags properly using @html
- Fix syntax error in FavoritesView (missing comma)

cp
2026-01-15 08:57:13 -06:00
vicrodh 72693e184f feat: use proper quality badges in favorites view
Added maximum_bit_depth and maximum_sampling_rate fields to FavoriteAlbum interface.
Implemented getQualityLabel function to display proper quality info (e.g., 24bit/192kHz) instead of generic Hi-Res label.
Applied to both album and track views in Favorites.

cp
2026-01-15 08:50:09 -06:00
vicrodh e281932340 feat(artist): increase album and track limits
- Increase initial artist albums fetch from 500 to 1000
- Increase load more albums batch from 50 to 200
- Increase top tracks display from 5 to 20
- Prefer full biography content over summary
- Increase bio truncate threshold from 500 to 800 characters

cp
2026-01-15 08:25:03 -06:00
vicrodh bba12f2832 feat(ui): improve home settings layout and add playlist modal to now playing
- Move item limits inline with section toggles in home settings modal
- Remove separate limits section for cleaner, more compact layout
- Add add-to-playlist functionality to now playing bar Plus button
- Wire up AddToPlaylistModal to current playing track

cp
2026-01-15 08:22:16 -06:00
vicrodh c6b8ab686a Merge UX improvements
- Increased artist album limit from 100 to 500
- Added Others category for compilations/greatest hits
- Added configurable Home section limits in settings
- Added grouping toggle for LocalLibrary albums and tracks

cp
2026-01-15 08:02:43 -06:00
vicrodh b7e328d8dc feat(local-library): add grouping toggle for albums and tracks
- Add albumGroupingEnabled and trackGroupingEnabled states
- Add Off option to grouping dropdown menus
- Conditionally render group headers and alpha index based on grouping state
- Match UX behavior from Favorites view

cp
2026-01-15 08:02:29 -06:00
vicrodh bf4050a592 feat(ux): increase artist album limits and add Others section
- Increase artist detail album fetch from 100 to 500
- Increase bio truncation from 300 to 500 chars
- Add Others category for greatest hits/anthologies
- Add configurable limits for Home sections
- Update HomeSettingsModal with limits grid UI

cp
2026-01-15 08:00:16 -06:00
vicrodh dd9eb90343 fix(ui): prevent simultaneous opening of download and share menus
Ensure that opening the download menu closes the share menu and vice versa to avoid overlapping UI elements.

cc
2026-01-15 07:40:17 -06:00
vicrodh 9443708aad fix(ui): ensure album download state updates reactively in Home and Search views
Added downloadStatusTick counter to force Svelte 5 reactivity when albumDownloadStatuses Map changes.

cp
2026-01-15 07:28:20 -06:00
vicrodh a1df7095fb fix(downloads): ensure album download status is reactive in grid overlays
Add downloadStateVersion prop to AlbumCard component to make download
status reactive in all grid views. This fixes the issue where the
download menu submenu would not appear in Home, Search, and Artist
Detail views even when albums were fully downloaded.

cp
2026-01-15 01:00:55 -06:00
vicrodh f15316533f fix: album download menu not updating in grid views
- Force Map reactivity by re-assigning after .set()
- Add missing downloadStateVersion effect in SearchView
- Ensures download menu updates across all grid views

cp
2026-01-15 00:51:43 -06:00
vicrodh 6cc625c0f1 fix: reload download states in HomeView and ArtistDetailView when download state changes
cp
2026-01-15 00:45:25 -06:00
vicrodh 87f8980323 fix(ui): load album download status on grid view load
Load download status for all albums when they are first loaded
in grid views (Home, Search, Artist Detail, Favorites) so the
'Download Album' menu shows correct state immediately.

cp
2026-01-15 00:39:10 -06:00
vicrodh a1e9ced027 feat(downloads): complete album download status in grid overlays
- Update SearchView, ArtistDetailView, and FavoritesView
- Add download status tracking to all views with AlbumCards
- Display Open Folder and Re-download options when album is fully downloaded
- All grid overlays now show download status consistently

cp
2026-01-15 00:28:14 -06:00
vicrodh 7952bbb7d6 feat(downloads): add album download status to grid overlays (partial)
- Add backend command to check if album is fully downloaded
- Add frontend functions to check album download status
- Pass download handlers to HomeView
- Update HomeView AlbumCards with download status props

cp
2026-01-15 00:23:58 -06:00
vicrodh 932d13829e fix(download): resolve file_path field access error in open_album_folder
CachedTrackInfo struct does not have file_path field exposed.
Use db.get_file_path() method instead to retrieve track path.

cp
2026-01-15 00:14:18 -06:00
vicrodh c30c16145e feat(downloads): add smart download menu for fully downloaded albums
- Add submenu to album download option when album is fully downloaded
- New options: Open containing folder and Re-download album
- Backend command to open album folder in file manager
- Helper function to check if album is fully downloaded
- Works in both AlbumCard overlay and AlbumDetailView menus

cp
2026-01-15 00:07:54 -06:00
vicrodh 11d263a2bf feat: add automatic migration dialog for legacy downloads
Implement user-consent migration system for legacy numeric-named FLAC files:
- Create MigrationModal component with progress tracking
- Auto-detect legacy downloads on settings mount
- Show modal with migration details and consent dialog
- Real-time progress updates via Tauri events
- Display success/failure stats after migration
- Refresh library and stats after completion

cc
2026-01-14 23:57:20 -06:00
vicrodh 0da14a1b23 docs: add data migration section to README
Added instructions for migrating data from qbz-nix to qbz paths.
This helps existing users transition to the unified path structure.

cp
2026-01-14 23:50:10 -06:00
vicrodh 5f725195c2 fix: unify data paths to use qbz instead of qbz-nix
Changes all application data paths from qbz-nix to qbz:
- Cache directory: ~/.cache/qbz-nix -> ~/.cache/qbz
- Config directory: ~/.config/qbz-nix -> ~/.config/qbz
- Data directory: ~/.local/share/qbz-nix -> ~/.local/share/qbz

This fixes path inconsistencies between development and production builds
and resolves asset protocol permission issues with downloaded album artwork.

cp
2026-01-14 23:49:30 -06:00
vicrodh 94e26cd593 fix(library): prevent duplicate entries for re-downloaded tracks
- Remove existing qobuz_track_id entry before inserting new one
- Ensures clean database state when re-downloading same track
- Prevents artwork and metadata confusion from duplicates

cp
2026-01-14 23:32:55 -06:00
vicrodh 6ac622d69b fix(audio): use UltraHiRes quality for downloads and playback
- Changed download quality from HiRes to UltraHiRes to support 24-bit/192kHz
- Updated playback streaming to use UltraHiRes for highest quality
- Added debug logging for artwork path storage and retrieval
- Quality fallback will still work for lower subscription tiers

cp
2026-01-14 23:32:09 -06:00
vicrodh 2d82d74b7f fix(downloads): add cover art path to local library for Qobuz downloads
Downloaded albums now properly display cover art in local library by
passing artwork_path when inserting tracks to database. Cover art is
saved as cover.jpg in album directory during post-processing.

cp
2026-01-14 23:20:36 -06:00
vicrodh 481b1d18d7 feat(downloads): add album cover art file alongside embedded artwork
Save cover.jpg in album directory for local library scanning
to properly display album art in grid/list views

cp
2026-01-14 23:12:40 -06:00
vicrodh b414301df3 feat: add automatic legacy download migration system
Migration service for users with old numeric FLAC files:
- Detect legacy downloads (123456.flac in tracks/ folder)
- Fetch complete metadata from Qobuz API
- Apply FLAC tags and embed artwork
- Organize files into Artist/Album/Track structure
- Insert to library DB with proper grouping keys
- Delete legacy files after successful migration
- Progress tracking via events

Commands:
- detect_legacy_downloads: Check if migration needed
- start_legacy_migration: Start background migration task

Events:
- migration:progress: Real-time status updates
- migration:complete: Final report with success/failure counts

Architecture:
- Non-destructive (keeps originals until success)
- Async with progress callback
- Error recovery (continues on failures)
- Proper cleanup after success

Next steps:
- Add UI banner in Settings when legacy files detected
- Show migration progress dialog
- Display results after completion

cp
2026-01-14 23:10:25 -06:00
vicrodh f1dcd96e14 fix: complete database insertion for Qobuz downloads
Critical bug fix:
- insert_qobuz_download_with_grouping() was missing required NOT NULL fields
- Added file_size_bytes, last_modified, indexed_at to INSERT
- Extract bit_depth and sample_rate from FLAC file properties
- Proper type conversion for bit_depth (u8 -> u32)

Root cause:
- INSERT statement incomplete vs schema requirements
- Silent failure in post_process_track()
- Downloaded tracks organized correctly but never inserted to library DB
- Local Library view empty despite toggle ON

Now working:
- Download completes successfully
- FLAC tags and artwork embedded
- Files organized as Artist/Album/Track.flac
- Track inserted to local_tracks with source='qobuz_download'
- Albums appear in Local Library when toggle ON

cp
2026-01-14 23:07:54 -06:00
vicrodh 0b72c3fba9 fix(downloads): add album grouping keys for proper library display
Critical fix for downloads not appearing in library:

Problem: Downloads inserted without album_group_key/album_group_title
Result: Albums not grouped/displayed in Local Library UI

Solution:
1. Create insert_qobuz_download_with_grouping() method
2. Pass all metadata: album_artist, track_number, year, etc.
3. Generate album_group_key: 'album|album_artist'
4. Set album_group_title for proper display

Now downloads will:
- Group correctly by album in Local Library
- Show proper album artist (not track artist)
- Display track numbers and year
- Appear in UI when toggle is ON

cp
2026-01-14 22:51:03 -06:00
vicrodh 01be29133a feat(downloads): smart library integration with visibility toggle
Implement intelligent library insertion:
- Downloads ALWAYS inserted to library DB (persistence)
- Visibility controlled by toggle in Settings
- Downloads NOT added to scan folders (separate from local files)

Backend changes:
1. Simplified post_process_track to always insert
2. Created get_albums_with_filter() method
3. Added source filter: exclude 'qobuz_download' when toggle off
4. Wire download_settings_state to library_get_albums command
5. Read show_in_library setting and pass to DB query

Database filtering:
- When toggle ON: show all albums (local + downloads)
- When toggle OFF: filter out source='qobuz_download'
- Hidden albums filter still works independently

Design benefits:
- Downloads folder never scanned by Local Library
- Tracks always in DB for potential future features
- Clean separation: local files vs Qobuz downloads
- Toggle only affects UI visibility, not data persistence

cp
2026-01-14 22:46:21 -06:00
vicrodh 49da0832b9 feat(downloads): add library integration to post-processing
Complete the downloads-library integration:
- Add library_db parameter to post_process_track()
- Accept show_in_library flag
- Insert processed tracks into local library automatically
- Pass library_state to download_track command
- Clone library_db for async task

Post-processing pipeline now:
1. Download → mark complete
2. Fetch metadata from Qobuz
3. Write FLAC tags with all metadata
4. Download and embed artwork
5. Organize to Artist/Album/Track.flac structure
6. Update download cache DB with new path
7. **Insert into local library if show_in_library enabled**
8. Emit processed event

Files are now:
- Properly tagged with metadata
- Organized in artist/album folders
- Available in Local Library (if toggle on)
- Ready for playback with artwork

cp
2026-01-14 22:32:46 -06:00
vicrodh e12783a50e feat(downloads): implement complete post-processing pipeline
Wire up Phase 3 functionality to download completion:
- Add post_process_track() function with full pipeline
- Fetch complete metadata from Qobuz API
- Write FLAC tags with all metadata fields
- Embed artwork from Qobuz
- Organize files into Artist/Album/Track structure
- Update database with new organized path
- Emit download:processed event for UI

Post-processing now runs automatically after download:
1. Download completes → mark_complete()
2. Fetch metadata from Qobuz API
3. Write tags to FLAC file
4. Download and embed artwork
5. Move file to: <root>/<Artist>/<Album>/NN - Title.flac
6. Update database with new path
7. Emit processed event

Files now properly organized with full metadata!

cp
2026-01-14 22:31:21 -06:00
vicrodh f69a283b31 wip(downloads): identify missing post-processing pipeline
Problem identified: Downloads complete but do not trigger:
1. Metadata enhancement from Qobuz API
2. FLAC tag writing
3. File organization (artist/album structure)
4. Library insertion

Current state:
- Files saved as {track_id}.flac in tracks/ folder
- No metadata embedded
- Not added to local library
- Phase 3 code exists but not wired to download completion

Next steps:
- Wire post-processing to download completion
- Or create manual command to process existing downloads
- Ensure proper state passing (settings, library)

cp
2026-01-14 22:28:59 -06:00
vicrodh 8c458c6b03 refactor(ui): unify duplicate Downloads sections in Settings
Merge two separate Downloads sections into one unified section:
- Combine configuration (folder picker, library toggle)
- Combine statistics (track count, storage size)
- Combine actions (clear, open folder)
- Remove duplicate Downloads Section (Offline Storage)
- Use consistent labels without translations for new items
- Single cohesive Downloads section with all functionality

Now Downloads section contains:
- Download Folder configuration with Change button
- Downloaded Tracks statistics
- Show in Local Library toggle
- Clear Downloads button
- Open Folder button

cp
2026-01-14 22:20:11 -06:00
vicrodh d2f2afaf47 feat(downloads): phase 6 complete - mount status and error handling
Phase 6 implementation verified complete:
- Mount status validation in path_validator
- check_download_root_mounted command
- validate_download_path validates mount status
- move_downloads_to_path command
- PathValidationResult includes NotMounted status
- Error handling for unmounted drives

All Phase 6 functionality already implemented in Phase 2.

All 6 phases complete:
✅ Phase 1: Database Schema & Settings Store
✅ Phase 2: Download Path Management (includes mount validation)
✅ Phase 3: Metadata Enhancement & FLAC Tagging
✅ Phase 4: Local Library Integration
✅ Phase 5: Download Cache Cleanup Integration
✅ Phase 6: Mount Status & Error Handling

cp
2026-01-14 22:18:33 -06:00
vicrodh 24ea59ed28 feat(downloads): add download folder configuration UI
Add UI for configuring download folder location in Settings:
- Add downloadRoot state variable
- Add Downloads section in Settings with folder picker
- Move show_in_library toggle to Downloads section
- Add handleChangeDownloadFolder() function with dialog picker
- Validate path before applying
- Prompt to move existing downloads on path change
- Display current download folder path
- Use @tauri-apps/plugin-dialog for folder selection
- Fix property name (readyTracks vs ready_tracks)

Users can now configure where downloads are stored and
optionally move existing downloads to new location.

cp
2026-01-14 22:17:28 -06:00
vicrodh 2cc47a80c4 feat(downloads): phase 5 complete - cleanup integration
Add library cleanup integration for download cache:
- Add remove_qobuz_download() method to LibraryDatabase
- Add remove_all_qobuz_downloads() method to LibraryDatabase
- Update remove_downloaded_track command to also remove from library
- Update clear_download_cache command to remove all from library
- Properly scope database locks to avoid deadlocks
- Log removal count when clearing all downloads

When downloads are removed from cache, they are automatically
removed from the local library to maintain consistency.

Phase 5 complete.

cp
2026-01-14 21:08:11 -06:00
vicrodh 5952da661b fix(ui): move Qobuz downloads toggle to general Settings
Move download visibility toggle from LocalLibrary settings to general Settings view:
- Add showQobuzDownloadsInLibrary state in SettingsView
- Add loadDownloadSettings() function
- Add handleShowDownloadsChange() function
- Add toggle in Library section of Settings
- Remove toggle from LocalLibrary settings panel
- Remove toggleShowQobuzDownloads function from LocalLibrary
- Remove showQobuzDownloads state from LocalLibrary
- Restore settings-actions original flex layout

Qobuz downloads are now controlled from Settings > Library section,
not from LocalLibrary settings. LocalLibrary only handles hide/show
of individual albums.

cp
2026-01-14 20:59:00 -06:00
vicrodh 96a3c56388 feat(downloads): phase 4 complete - UI integration for library settings
Add UI integration for Qobuz downloads in Local Library:
- Add showQobuzDownloads state variable
- Load download settings on library data load
- Add toggleShowQobuzDownloads function
- Add toggle setting in Library Settings panel
- Add .toggle-setting styles for checkbox
- Reload library after toggling setting
- Update settings-actions layout to column flex

Phase 4 complete with backend + UI integration.
Users can now toggle Qobuz downloads visibility in library.

cp
2026-01-14 20:52:42 -06:00
vicrodh a890802d8c feat(downloads): phase 4 complete - library integration backend
Complete library integration for Qobuz downloads:
- Add conn() method to DownloadCacheDb for direct SQL access
- Implement insert_qobuz_download_direct with proper parameters
- Complete library_backfill_downloads command with Send-safe async
- Properly scope database locks to avoid Send trait issues
- Register library_backfill_downloads command in Tauri
- Add BackfillReport struct for migration tracking
- Query ready downloads directly from download_cache DB
- Insert downloads into library with source = 'qobuz_download'
- Check for existing tracks before insertion

Phase 4 backend complete. UI integration pending.

cp
2026-01-14 20:49:28 -06:00
vicrodh daa07ef9ce feat(downloads): phase 4 partial - library integration foundation
Add foundation for Qobuz downloads in local library:
- Extend get_albums to filter by source (user vs qobuz_download)
- Add include_qobuz_downloads parameter from download settings
- Create library_backfill_downloads command with report
- Add track_exists_by_qobuz_id method
- Add insert_qobuz_download method (WIP - needs file path resolution)
- BackfillReport struct for tracking migration

Phase 4 in progress - needs completion for file path handling and
UI integration. Will continue in next session.

cp
2026-01-14 20:17:44 -06:00
vicrodh b4ba435878 feat(downloads): phase 3 - metadata enhancement and FLAC tagging
Add complete metadata handling for downloaded tracks:
- Create metadata.rs module with CompleteTrackMetadata struct
- Implement fetch_complete_metadata from Qobuz API
- Add write_flac_tags using lofty crate (Vorbis comments)
- Implement embed_artwork with MIME type detection
- Add sanitize_filename for ASCII-safe names
- Create organize_download with artist/album structure
- Handle filename conflicts with counter
- Add update_file_path and update_artwork_path to DB
- Parse year from release_date_original format

Phase 3 of downloads-library integration plan.

cp
2026-01-14 20:14:07 -06:00
vicrodh 1296ee4a4b feat(downloads): phase 2 - download path management
Add path validation and file moving capabilities:
- Create path_validator module with validation logic
- Check write permissions via test file
- Detect mount status with canonicalize check
- Implement move_downloads_to_new_path with report
- Add mount status cache (30s TTL)
- Add Tauri commands: check_mount, validate_path, move_downloads
- Recursive FLAC file collection for moving

Phase 2 of downloads-library integration plan.

cp
2026-01-14 20:10:25 -06:00
vicrodh 494d3d184e feat(downloads): phase 1 - database schema and settings store
Add foundation for Qobuz downloads integration:
- Create DownloadSettings store (download_root, show_in_library)
- Add migration for local_tracks: source and qobuz_track_id columns
- Add database indices for source and qobuz_track_id
- Register Tauri commands for download settings
- Commands: get/set download_settings, validate_download_root

Phase 1 of downloads-library integration plan.

cp
2026-01-14 20:01:51 -06:00
vicrodh 7eb12b36bf docs(readme): integrate API key development instructions
- Remove separate DEV_API_KEYS.md file
- Add compile-time env var explanation in README
- Document npm run dev:tauri command usage
- Explain why .env must be sourced before build

cp
2026-01-14 19:58:32 -06:00
vicrodh 6e21b3ed1f docs(dev): add script and docs for local API key loading
- Create dev-with-env.sh script to load .env before build
- Add npm run dev:tauri command that uses the script
- Document why .env must be loaded before compilation
- Explain compile-time vs runtime environment variables

The issue: option_env!() reads vars at compile time, but .env
loads at runtime. Solution: source .env before cargo build.

cp
2026-01-14 19:43:18 -06:00
vicrodh b9c8ecb274 fix(library): improve clear library safety with double confirmation
- Add double confirmation dialog for clear library action
- Improve confirmation messages with clear warnings
- Move clear library button to separate danger zone section
- Use smaller danger button style (12px font, 6px padding)
- Add danger zone header with red warning label
- Separate dangerous action from regular settings visually
- Add error alert if clear operation fails

This prevents accidental library clearing which requires full rescan.

cp
2026-01-14 19:29:26 -06:00
vicrodh 9bee038cf2 feat(library): improve folder list with table view and multi-select
- Replace folder list with compact table view (max 150px height)
- Add checkbox selection for multiple folders
- Replace per-row delete buttons with single remove action
- Add folder actions toolbar with + and - buttons
- Implement multi-folder removal with confirmation
- Reduce row height to 36px for more compact display
- Add scroll with custom styling for overflow
- Selected rows highlight with blue background

cp
2026-01-14 19:24:54 -06:00
vicrodh 08e2c98a5b feat(library): add album edit modal with hide toggle
- Remove hide button from album row list view
- Add edit button (pencil icon) in album detail header
- Create album edit modal with hide toggle
- Add nav-row layout matching PlaylistDetailView style
- Modal styling consistent with existing PlaylistModal
- Album title editing placeholder (coming soon)

cp
2026-01-14 19:15:09 -06:00
vicrodh 3eb80c7840 feat(library): remove album limit and add album hide feature
- Remove 100 album cap from library_get_albums query
- Add album_settings table with hidden flag per album
- Add commands to hide/show albums
- Add UI toggle in settings to view hidden albums
- Add hide button to album list view
- Update LocalLibraryView to support hidden albums view

cp
2026-01-14 14:57:58 -06:00