Commit Graph
5534 Commits
Author SHA1 Message Date
vicrodh cd62853743 fix(library): tooltips on the Library header action buttons
The random-album / random-artist / random-playlist / random-label
buttons all exist (1:1 with 1.x) but rendered as bare shuffle icons —
1.x had title tooltips, so users couldn't tell them apart from a
tracks-shuffle and reported the feature as removed (#554). CircleAction
already supports the shared tooltip overlay; set it on all seven
Library header actions. 7 msgids translated in all 7 locales.

Fixes #554

cc
2026-07-06 08:05:57 -06:00
vicrodh 6293098ddb Merge feature/auto-theme-slint into pre-release
Auto Theme port (system accent / wallpaper / custom image), reviewed
adversarially: port fidelity 1:1 verified, 59 qbz-theme tests green.

cc
2026-07-05 22:44:50 -06:00
vicrodh e70d434773 fix(theme): bound auto-theme image decode, spinner via event loop
Review follow-ups: extract_palette decoded the full image before the
100x100 downsample with no limits — a decompression-bomb PNG expands
to tens of GB, and this box hard-freezes on OOM; decode is now bounded
at 12k x 12k / 512 MB (any real wallpaper fits). The generating
indicator is now set through upgrade_in_event_loop so the select_image
path (which runs on a tokio thread, where a plain upgrade() returns
None) shows it too. Startup generation stays synchronous by design:
with the decode bounded it costs milliseconds and the first paint
comes up in the generated palette instead of flashing the default.

cc
2026-07-05 22:44:50 -06:00
vicrodh 7d46aaf200 chore: lockfile entry for the vendored i-slint-renderer-skia
cc
2026-07-05 22:37:08 -06:00
vicrodh 44676a9b98 Merge bugfix/korean-skia-ttc-index into pre-release
cc
2026-07-05 22:37:05 -06:00
vicrodh e5fcb9d1af fix(text): load Korean TTC faces the macOS Skia renderer refused
Vendor i-slint-renderer-skia 1.16.1 with a second-chance typeface
workaround: skia bug 310510989 makes new_from_data fail for TTC faces
at index > 0 on macOS, and for AppleSDGothicNeo.ttc — which packs
every weight at index > 0 — the upstream read/write-fonts rebuild is
ALSO rejected by CoreText, so draw_glyph_run silently dropped every
Korean glyph run at non-regular weights (Japanese survived because
Hiragino ships one file per weight, always index 0). Resolve the same
face through CoreText by family name (typographic name preferred,
localized names resolve too) + OS/2 weight; the match points at the
same installed file so parley's glyph ids stay valid, enforced by cmap
spot checks that reject a mismatching face rather than draw wrong
glyphs. Probe-verified on the Mac Mini: matched face returns identical
glyph ids for U+C0AC across w500/600/700.

cc
2026-07-05 22:36:48 -06:00
vicrodh 1bbc98cc8e feat(ui): auto-theme settings UI + i18n
Repoint the existing auto-theme Settings scaffold from the "System" theme to
the new dynamic "Auto (dynamic)" option:

- state.slint: add theme-is-auto (distinct from theme-is-system, which stays
  the native OS-palette follow).
- AppearanceSettings.slint: gate the Source dropdown, image picker, detected-DE
  hint and Regenerate button on theme-is-auto, and drop the placeholder
  `unsupported` flag now that the rows are functional.
- translations: add "Auto theme generation failed" to all 7 catalogs and give
  the es "Wallpaper Sync" string a proper Mexican-neutral translation.

cc
2026-07-05 22:34:09 -06:00
vicrodh caabdf9327 feat(theme): auto slug, prefs and startup application + controller wiring
Integrate the dynamic "Auto (dynamic)" theme into the bin without disturbing
the static-theme path:

- ui_prefs: add auto_theme_source ("system"|"wallpaper"|"image") and
  auto_theme_image_path, with serde defaults and index<->key helpers.
- theme.rs: extract push_colors() (shared by static + auto paths), append the
  "Auto (dynamic)" dropdown entry, and add AUTO_SLUG / auto_index /
  is_auto_index / selected_index_for_slug so the "auto" slug maps to the
  appended entry (it has no static ThemeId).
- auto_theme.rs (new controller): source_from_prefs, startup apply (OLED
  fallback + toast on failure), off-thread regenerate, rfd image picker, and
  source switching — all pushing the palette back on the event loop.
- main.rs: auto-aware startup seeding/application, an "auto"/"auto-theme-source"
  arm in on_appearance_select, and a new on_appearance_action handler for the
  image picker + Regenerate button.

cc
2026-07-05 22:34:09 -06:00
vicrodh c8d8b47e49 feat(theme): port auto-theme generation core to qbz-theme
Port the legacy Tauri src-tauri/src/auto_theme/{palette,system,generator}
logic into a new frontend-agnostic qbz-theme::auto module. The palette
extraction (k-means), WCAG contrast math, HSL shifts and DE detection are
carried over 1:1; only the final assembly changes: the output is now the
registry ThemeColors contract instead of a CSS custom-property map.

The generator mirrors registry::StdSpec::build so a generated theme
composites identically to a static one — same polarity-driven alpha ramp,
success/focus_ring/favorite/border_muted derivations, and status tints.
Per-status text tokens (--btn-danger-text/--btn-warning-text) are dropped
since ThemeColors has no field for them.

Adds `image` (0.25, minimal codec features) to qbz-theme and unit tests for
the mapping (polarity, derived families, determinism, scheme path).

cc
2026-07-05 22:25:06 -06:00
vicrodh b6ec858329 Merge fix/eqbars-coarse-clock into pre-release
cc
2026-07-05 22:17:57 -06:00
vicrodh f292fc1913 fix(perf): drive the equalizer bars from the coarse clock on every tier
The current-row equalizer animated via animation-tick() on the strong
(wgpu) tier — every step is a full-window repaint, so a playlist view
with the playing row on screen sat at ~4.5% CPU on a 165 Hz monitor
for a three-bar affordance. The bars now always use the shared ~8fps
coarse clock (already the accepted look on the GL/software tiers) and
the AppShell timer additionally runs while audio plays; when the
playing row is not on screen nothing reads the property, so the tick
dirties no binding and costs nothing.

cc
2026-07-05 22:17:57 -06:00
vicrodh b277969752 Merge bugfix/543-elide-first-line-cull into pre-release
cc
2026-07-05 18:53:02 -06:00
vicrodh 7401d2c3fd fix(text): always draw the first line under overflow: elide
Vendor i-slint-core 1.16.1 with a one-rule patch in sharedparley's
line culling: with overflow: elide, every line whose bottom edge
exceeded max_height was dropped — INCLUDING the first one, eliding the
text to literally nothing. CJK fallback fonts report line metrics
taller than snug fixed-height boxes (Hiragino at 14px measures ~21px
inside TrackRow's 20px title line), so on macOS every CJK track title
rendered blank while Latin titles fit; Linux survived because Noto's
metrics fit the box. Root-caused with a headless render matrix on the
Mac Mini: the verbatim TrackRow structure reproduced the blank title,
removing elide rendered it, and the patched core renders all variants.
The first line still receives the ellipsis treatment as the last
visible line.

This is the real #543 mechanism. The earlier femtovg render_glyph
retry (3a1c367d) addressed a different, hypothesized layer and stays
as harmless defense in depth.

Fixes #543

cc
2026-07-05 18:53:02 -06:00
vicrodh f6586d9219 fix(playback): stream-error drain lives on the player's shared state
take_stream_error_message is a SharedState method, not a Player one —
the toast commit called it on the Arc<Player> and the release build
caught it (the bin crate can't be cheaply cargo-checked locally).

cc
2026-07-05 16:04:46 -06:00
vicrodh a183a41823 Merge feature/dlna-strict-renderers into pre-release
DLNA strict-renderer support (based on PR #547) + the #550 media
server memory fix.

cc
2026-07-05 15:08:34 -06:00
vicrodh 1261e98cc0 fix(cast): stop hoarding full-track buffers in the DLNA media server
register_audio inserted every cast track's complete bytes into the
entries map and NOTHING ever removed them — not stop, not disconnect;
only app shutdown dropped the server. A DLNA session therefore grew by
one full track per auto-advance (issue #550: 50 MB at launch to
4.5 GB, never released). Three changes:
- register_audio/register_file evict every other entry — only the
  track being cast is servable anyway.
- stop_if_cast and disconnect clear the entries outright, so stopping
  actually releases the buffers.
- MediaSource::Data is Arc-backed: the per-request entry clone no
  longer copies the whole track (it did, on every GET/HEAD/range
  request), and an in-flight response keeps its own Arc so eviction
  can never truncate an ongoing range request.

Fixes #550

cc
2026-07-05 15:08:34 -06:00
vicrodh 9dbf3be94d fix(cast): guard DLNA STOPPED against premature ends without wedging the queue
A bare DLNA STOPPED is ambiguous — strict renderers hiccup mid-track —
so end-of-track now requires the max observed position (RelTime resets
to 0 on STOP; the instantaneous value is useless) to reach within 5 s
of the duration. Two escape valves keep the guard from ever blocking a
genuine end, which review flagged as the regression risk: renderers
whose RelTime never moves (position signal unreliable — common, and
duration nearly always resolves via the catalog fallback, so the
`duration <= 0` hatch alone never fires) skip the guard entirely, and
a STOPPED persisting 4 consecutive polls advances anyway (~4 s late
beats a queue stuck forever). Premature stops are logged with a
counter and recover on PLAYING.

Based on the end-of-track guard contributed in PR #547, reworked per
review findings.

cc
2026-07-05 15:06:30 -06:00
vicrodh 3ee5d5d7e3 fix(cast): DLNA discovery, DIDL features and Play self-heal for strict renderers
Three device-side gaps that kept strict renderers (Signalyst HQPlayer 6)
from working:
- Services were matched by the hard-coded ":1" URN, missing renderers
  that only announce AVTransport/RenderingControl :2/:3. Match the
  service name at any UPnP version (unit-tested; recursion over
  embedded devices preserved via services_iter).
- DIDL protocolInfo advertised "*" as its 4th field; strict renderers
  cross-check it against the response headers. Advertise the same
  DLNA.ORG_OP/FLAGS the media server sends.
- HQPlayer clears its transport at natural end-of-track, so a bare Play
  (manual button or late auto-advance) faulted 702 "No contents" or
  no-op'd. play() now pre-checks an idle transport (STOPPED/
  NO_MEDIA_PRESENT — PAUSED untouched so resume keeps position) and
  re-asserts the last SetAVTransportURI first, plus a bounded retry net
  (6 attempts, linear backoff) for raw-status 701/702 settle races.

Based on the DLNA hardening contributed in PR #547; retry-net comment
corrected against rupnp 3.0's actual error mapping (non-200 becomes
HttpErrorCode before any SOAP parse — the UPnPError arm only covers
fault-inside-200).

cc
2026-07-05 15:05:16 -06:00
vicrodh 691918e267 fix(cast): serve DLNA media strict-renderer compatible
Strict DLNA renderers (e.g. Signalyst HQPlayer 6) HEAD-probe the media
URL before playing and reject chunked bodies: tiny_http auto-selected
Transfer-Encoding: chunked (dropping Content-Length) past its 32 KiB
threshold, so those renderers played the buffered seconds and went
STOPPED. Answer HEAD with 200 + Content-Type/Accept-Ranges/DLNA
headers, pin Identity encoding with an explicit Content-Length on all
media responses (200/206/HEAD), and advertise transferMode/
contentFeatures on GET too. Range handling is unchanged. Neutral for
renderers that never HEAD-probe and ignore the extra headers.

Based on the DLNA hardening contributed in PR #547.

cc
2026-07-05 15:04:30 -06:00
vicrodh 8ab7bc4b37 Merge fix/library-terminology-sweep into pre-release
cc
2026-07-05 15:03:47 -06:00
vicrodh cf9d28b9e1 fix(i18n): say "Library" wherever the copy still said favorites
The nav tab already reads Library, but the surrounding communication
kept the old Qobuz term: the Home/Discovery section "Favorite Albums",
the Add/Remove-favorites menu entries on every card/row surface, the
playlist context-menu "Favorite" verb, and the Favorites view's
empty/error states. Align all of it with the Library terminology
(9 msgids renamed, translated in all 7 locales). Routes, ids and the
genre-filter context string are untouched — this is copy only.

cc
2026-07-05 15:03:47 -06:00
vicrodh 3dc07ca9f2 Merge bugfix/clipboard-lifetime into pre-release
cc
2026-07-05 14:49:51 -06:00
vicrodh 71eab7736c fix(share): keep one clipboard instance alive for the process lifetime
arboard ties the clipboard offer to the LAST live Clipboard object:
dropping it destroys the X11 selection window (contents survive only
when a clipboard manager accepts the handoff — KDE ships one, stock
GNOME/XFCE/Cinnamon do not) and ends the Wayland offer likewise. The
create-per-copy pattern therefore worked on KDE smokes and silently
lost the text everywhere else — the HiFi wizard copy buttons and every
other copy surface (#514). Keep a single lazily created instance in a
static; on set_text failure the instance is dropped so the next copy
reconnects. Verified against arboard 3.6.1's Drop impl and with a
live repro (offer now persists with the instance held).

cc
2026-07-05 14:49:51 -06:00
vicrodh 72a9f52d06 chore: untrack prune-incremental.sh (swept in by accident)
The file was an untracked local script predating this session; a
directory-level git add pulled it into the #549 commit unintentionally.
Back to untracked, file kept on disk.

cc
2026-07-05 14:18:01 -06:00
vicrodh ace60e945b Merge fix/549-x86-baseline-runtime-aes into pre-release
cc
2026-07-05 14:17:46 -06:00
vicrodh 395e537b59 fix(build): drop compile-time x86 target-features — runtime AES dispatch
Users on CPUs without AES-NI (Nehalem i7-860, pre-2010 Intel Macs) or
without SSSE3 (AMD Phenom II) crashed at launch with SIGILL. The
global `-C target-feature=+aes,+ssse3` was kept after the #353/#343
x86-64-v3 incident on the belief that the aes crate's cpufeatures
runtime check would protect CPUs without AES-NI — but a compile-time
target feature makes cpufeatures compile its check to a constant, so
the AES-NI intrinsics ran unconditionally (credentials AES-GCM decrypt
at startup), and +ssse3 let LLVM autovectorize anywhere, breaking
Phenom II. Measured on the qbz-cmaf hot path (Ctr128BE<Aes128>
apply_keystream, 256 MB, release): 2145 MB/s compiled-in vs 2162 MB/s
runtime-dispatched, identical output — the flags bought nothing on
capable CPUs. Removed from .cargo/config.toml, all dev/build scripts
and the release/build workflows; old CPUs now get the software AES
fallback instead of a crash.

Fixes #549

cc
2026-07-05 14:17:46 -06:00
vicrodh 444b21f0c1 Merge bugfix/stream-error-toast into pre-release
cc
2026-07-05 12:12:10 -06:00
vicrodh f83eadb398 fix(playback): surface stream errors as toasts, sandbox-aware for ALSA
The player has recorded a user-readable message on stream-open failure
since the Tauri era, but the drain lived in Tauri's polling loop and
was never ported to the Slint poll loop — record_stream_error had ZERO
consumers, so ALSA Direct/exclusive failures showed as a bar frozen at
0:00 with no explanation (#508, #534, #500). Drain the message each
tick and toast it. When running inside Flatpak/Snap and the failure is
ALSA-shaped, explain that direct hw: access is blocked by the sandbox
and point at PipeWire/System Default instead of showing the raw error.
2 new msgids translated in all 7 locales.

cc
2026-07-05 12:12:10 -06:00
vicrodh ceb25cd1d1 Merge bugfix/521-release-forced-clock-on-quit into pre-release
cc
2026-07-05 12:08:15 -06:00
vicrodh fd8057fda6 fix(audio): release the forced PipeWire clock on app quit
The clock.force-rate reset only ran in the audio thread's Stop, pause
suspend and ReleaseDevice handlers — none of the quit paths (custom
titlebar close, WM close, tray Quit) go through them, so quitting mid
playback with DAC passthrough left the PipeWire graph pinned at the
last track's sample rate for every other app until PipeWire restarted.
Run the same self-gating resume_suspended_sink + reset_pipewire_clock
pair once after the event loop exits — a single choke point covering
all three quit paths. No-op when QBZ didn't force anything (and inside
Flatpak, which could never force the clock in the first place).

Fixes #521

cc
2026-07-05 12:08:15 -06:00
vicrodh 95408aba92 Merge bugfix/zbus5-accesskit-reactor-panic into pre-release
cc
2026-07-05 10:26:18 -06:00
vicrodh 6c9964481a fix(dbus): stop forcing the zbus 5 executor onto tokio
zbus features unify across the dependency graph and "tokio" wins over
"async-io": enabling it via rfd, ashpd (secret portal) and ksni's
default features flipped the shared zbus 5 executor to tokio for
accesskit_unix/atspi too — Slint's accessibility backend opens its
D-Bus connection on a plain thread and panicked at startup ("there is
no reactor running, must be called from the context of a Tokio 1.x
runtime"), killing AT-SPI support. Switch every zbus-5 consumer we
control to the async-io backend (rfd "async-std", ashpd "async-io",
ksni default-features off + "async-io"): async-io connections
self-drive from any thread and the futures still await fine inside our
tokio runtime. The zbus 4 group (keyring/secret-service/mpris-server/
qbz-audio) is a separate feature graph and stays on tokio by design.

cc
2026-07-05 10:26:18 -06:00
vicrodh c482ca0c0b Merge bugfix/deadkey-compose-text into pre-release
cc
2026-07-05 10:17:30 -06:00
vicrodh 1346f8fc77 fix(input): deliver dead-key compose commits to text fields
On layouts where the apostrophe is a dead key (us(alt-intl):
dead_acute), winit composes via xkb and delivers the committed text in
event.text, but Slint's winit backend maps logical_key first — so
' + space inserted a plain space and the apostrophe could never be
typed into any text field (search included). Detect commits whose
composed text differs from what Slint would synthesize (second key =
Character with different text, Named(Space), or Key::Dead) in the
winit event hook, dispatch the composed text as a synthetic Slint key
event and swallow the raw one. Gated on a focused text input so hotkey
behavior outside fields is unchanged; control characters excluded so
Ctrl-shortcuts keep working.

cc
2026-07-05 10:17:30 -06:00
vicrodh 63837a0412 Merge bugfix/543-cjk-bold-macos into pre-release
cc
2026-07-05 08:23:17 -06:00
vicrodh 3a1c367d1a fix(text): render CJK glyphs at non-regular weights on macOS
Vendor femtovg 0.23.2 with a targeted patch: the swash raster path can
fail to scale some variable fonts at a non-default variation instance
(the CFF2-based CJK system fonts on modern macOS), and femtovg cached
those glyphs as permanently missing — so track titles and any other
text at medium/semibold/bold weight rendered blank for CJK while
regular weight (empty coords) worked. render_glyph now retries the
glyph at the font's default instance before giving up: worst case the
glyph draws at regular weight instead of not at all. Fonts and
instances that already render are untouched.

Fixes #543

cc
2026-07-05 08:23:17 -06:00
vicrodh cf16fa263c Merge bugfix/545-genre-filter-subgenre-expand polish into pre-release
cc
2026-07-05 08:19:14 -06:00
vicrodh 279f67e580 fix(genre-filter): keep leaf rows fully clickable and steady row hover
Review follow-ups to the chevron z-order fix: disable the arrow
TouchArea on leaf rows (an enabled TouchArea consumes the click even
with a no-op handler, leaving a 20px selection dead-zone) and include
arrow hover in the row highlight so it doesn't flicker off over the
chevron.

cc
2026-07-05 08:19:14 -06:00
vicrodh 0a2bf9a73e Merge bugfix/542-multigpu-wgpu-adapter into pre-release
cc
2026-07-05 08:11:38 -06:00
vicrodh a273088205 fix(renderer): auto-revert sentinel now covers the auto-detected wgpu tier
The startup sentinel only guarded explicit Settings overrides: an
auto-detected wgpu start that crashed pre-paint re-detected wgpu on the
next launch — an unrecoverable crash loop (#542 hit exactly this). Arm
the sentinel when auto-detect picks wgpu; if it survives to the next
start, persist the GL (compatibility) renderer instead of re-detecting,
and explain with a toast. Linux-only by design (macOS has no GL tier).
Also add the .po entries for the existing revert toast, which was
missing from all catalogs, plus the new degrade toast (7 locales).

cc
2026-07-05 08:11:04 -06:00
vicrodh 3b5192acd6 fix(renderer): default to HighPerformance on hybrid desktops
PowerPreference::LowPower makes wgpu pick the integrated GPU. On a hybrid
discrete+integrated DESKTOP the monitor usually hangs off the discrete
card and the display-less iGPU cannot present the window surface, so
Surface::configure panics with "Invalid surface" at startup. Capture the
GPU topology during the adapter probe (or on demand for forced-wgpu
paths) and default hybrid machines without a system battery to
HighPerformance; laptops (system battery present) keep LowPower — their
panel is wired to the iGPU and it saves power. WGPU_POWER_PREF still
always wins. Peripheral batteries (scope=Device) are excluded from the
laptop check.

Fixes #542

cc
2026-07-05 08:09:28 -06:00
vicrodh 0a65bdfe8a Merge bugfix/544-wayland-app-id into pre-release
cc
2026-07-05 08:06:05 -06:00
vicrodh dae6e7f690 fix(window): set the Wayland app_id / X11 WM_CLASS to com.blitzfc.qbz
winit sends no xdg_toplevel.set_app_id unless the window is created with
an explicit name, and derives WM_CLASS from the binary name ("qbz") on
X11 — so compositors could not associate the window with
com.blitzfc.qbz.desktop: blank dock icon, no running indicator, and the
pinned launcher spawned a second instance. Set with_name on both the
Wayland and X11 attribute extensions in the window-attributes hook; it
runs for the main window and the miniplayer, so both group under the
same icon. StartupWMClass=com.blitzfc.qbz already matches in every
shipped .desktop file.

Fixes #544

cc
2026-07-05 08:06:05 -06:00
vicrodh 2c3636ae6e Merge bugfix/546-playlist-sort-date-added into pre-release
cc
2026-07-05 08:04:07 -06:00
vicrodh de5c50a5b3 feat(playlist): restore the "Date added" sort option
2.0 dropped the v1.x "added" sort. Restore it with the same semantics:
a positional proxy over the playlist's natural insertion order (the API
returns tracks oldest-first; no added-at timestamp is deserialized),
starting newest-first on first selection, re-click toggles direction.
New msgid translated in all 7 locales.

Fixes #546

cc
2026-07-05 08:04:07 -06:00
vicrodh bd2c1a6c21 Merge bugfix/545-genre-filter-subgenre-expand into pre-release
cc
2026-07-05 08:01:57 -06:00
vicrodh 30211f74c0 fix(genre-filter): let the expand chevron receive clicks in the advanced tree
The full-row selection TouchArea was declared after the row layout, so it
sat on top of the chevron's TouchArea and swallowed every click — sub-genres
could never be expanded. Declare the row TouchArea first (bottom of the
z-order) so the arrow's TouchArea wins inside the chevron region, matching
the stopPropagation isolation the Svelte version had.

Fixes #545

cc
2026-07-05 08:01:38 -06:00
vicrodh 54bb2c96a0 fix(gentoo): RESTRICT mirror+strip in the binary ebuild template
Without RESTRICT=mirror Portage walks every official Gentoo mirror
(guaranteed 404s — the distfiles only exist on GitHub Releases) before
falling back to SRC_URI. The source template already had it.

cc
2026-07-04 17:37:28 -06:00
vicrodh 1e521a182f fix(ci): stop snapcraft resolving the root source-build recipe
The root snapcraft.yaml (source build, kept for Snap Store remote
builders) shadowed the staged snap/snapcraft.yaml dump recipe, so the
v2.0.0 snap job recompiled the entire workspace inside LXD and the
container OOM'd. Remove the root recipes from the CI working copy
before invoking snapcraft.

cc
2026-07-04 13:07:41 -06:00
vicrodh 63a3a5aa98 chore(nix): bump flake to v2.0.0
cc
2026-07-04 12:28:38 -06:00