Commit Graph
1633 Commits
Author SHA1 Message Date
vicrodh 6db319b67a fix(keybindings): use regular variables instead of runes at module level
$state and $derived at module level cause "Cannot access uninitialized
variable" error during SSR. Changed to lazy initialization with getter
functions.
2026-02-02 23:14:46 -06:00
vicrodh fa6538df2c feat(keybindings): implement centralized keybindings system
Phase 1: Core infrastructure
- Add keyboard.ts with event-to-shortcut conversion, display formatting
- Add keybindingsStore.ts with action registry, conflict detection, persistence

Phase 2: Migration
- Migrate +page.svelte shortcuts to use keybinding manager
- Register global actions: playback, navigation, UI controls
- Integrate FocusMode with contextual seek actions
- Simplify ExpandedPlayer to use keybinding handler
- Add i18n translations for keybinding labels (en/es)
2026-02-02 23:02:33 -06:00
vicrodh cec4c32bcc chore: remove unused CSS selectors from Svelte components
Clean up dead CSS that remained after HTML refactors:
- NowPlayingBar, Sidebar, PlaylistManagerView, FavoritesView
- PlaylistModal, LocalLibraryView, PlaylistDetailView
- Dropdown, MigrationModal, AlbumCard, QualityBadge
- SearchPlaylistCard, LocalLibraryTagEditorModal
- TrackReplacementModal, ImmersiveHeader, SuggestionsPanel
- LyricsFocusPanel, ExpandedPlayer, FocusMode
- ArtistDetailView, SearchView, SettingsView
2026-02-02 22:51:42 -06:00
vicrodh 678693d0c4 fix: resolve all Rust warnings in qbz-nix crate
- Remove unused import TagExt in library/commands.rs
- Remove unnecessary unsafe block in alsa_direct.rs
- Fix value-never-read warnings in search.rs blacklist filtering
- Handle unused Result from chromecast.disconnect() in lib.rs
- Add #[allow(dead_code)] to unused but intentional API:
  - VECTOR_TTL_SECS constant (future use)
  - PipeWireBackend host field (stored for future use)
  - AlsaDirectStream is_playing field (future use)
  - CacheEntry track_id field (debug purposes)
  - CastSession app_id field (deserialized but unused)
  - ItunesAlbumResult struct (deserialized response)
  - ReleaseDetails struct (Discogs API response)
  - simple_hash function (utility for future use)
  - LrclibItem struct (lyrics API response)
  - AudioSpecs/AudioMetadata structs (future use)
  - Player visualizer_tap field (future feature)
  - Retry constants (future retry logic)
  - PlaybackEngine position/duration/is_alsa_direct methods

Remaining warnings are in vendor/rodio (external code).
2026-02-02 22:09:41 -06:00
vicrodh 1540146df6 chore: move suggestions engine logs to debug level
Keep only start/result summary at INFO for user issue reports.
Move all intermediate steps (MBID resolution, config, engine steps) to DEBUG.

Also moved to debug:
- playlist_get_settings, playlist_get_stats
- playlist_get_local_tracks_with_position
- All [SuggestionsEngine] step logs
2026-02-02 21:55:11 -06:00
vicrodh 4e80dcf731 chore: reduce log noise by changing frequent commands to debug level
Move high-frequency API read commands from log::info! to log::debug!:
- get_artist, get_artist_detail, get_artist_tracks, get_artist_albums
- get_featured_albums, get_genres
- get_user_playlists, get_playlist, search_playlists
- get_favorites, get_tracks_by_ids, get_track_info, get_current_user_id
- playlist_get_all_settings, playlist_get_all_stats
- playlist_get_all_local_track_counts, get_playlist_folders

User action commands (create, delete, add, remove) remain at info level.
2026-02-02 21:50:01 -06:00
vicrodh 9b12f761b5 feat(alsa): use stable device IDs for persistent device selection
Convert hw:X,0 to front:CARD=name,DEV=0 format when saving device selection.
This makes device IDs stable across reboots and USB reconnections since they
use the card name (e.g., C20) instead of the card number which can change.

- Add normalize_device_id_to_stable() to convert hw:X,0 to front:CARD=name,DEV=0
- Add resolve_stable_to_current_hw() for reverse lookup when needed
- Apply normalization automatically in set_audio_output_device command
- Export functions from audio module for use across codebase
2026-02-02 21:41:34 -06:00
vicrodh 67895aaa9b fix(audio): validate saved device exists in current enumeration
- Clear stale device IDs from DB when they don't exist in enumeration
- Add warning when device lookup fails in handleBackendDeviceChange
- Add logging to set_audio_output_device command for debugging

ALSA card numbers (hw:X,0) can change between boots when USB devices
are connected/disconnected. This fix prevents using invalid device IDs
that cause playback failures.

cc
2026-02-02 21:32:01 -06:00
vicrodh 1e3aa7b0df fix(i18n): add French and German to language selector
- Add Français and Deutsch to available languages in settings
- Update language mappings and Auto detection
2026-02-02 20:09:15 -06:00
vicrodh bdeb436fb8 i18n: add French and German translations
- Add fr.json with complete French translations
- Add de.json with complete German translations
- Register new locales in i18n/index.ts
- Add missing keys (playlist, metadata, genreFilter sections)
- All 869 translation keys present in both files
2026-02-02 20:07:16 -06:00
vicrodh 739c29b2c9 i18n: translate GenreFilter module to Spanish
- Add genreFilter section to en.json and es.json with all filter UI strings
- Translate GenreFilterButton: genre prefix, genre count, filter title
- Translate GenreFilterPopup: title, options, expand/collapse, clear
- Use get(t) pattern for translations inside functions
2026-02-02 18:32:01 -06:00
vicrodh 3919b59eb2 i18n: translate LocalLibraryTagEditorModal to Spanish
- Translated modal title and form labels
- Translated search buttons and results text
- Translated table headers (track, title, disc)
- Translated persistence options (sidecar vs direct)
- Translated progress states (writing tags, saving)
- Added placeholder translations for year and genre examples
2026-02-02 18:19:49 -06:00
vicrodh 059dce3114 i18n: translate PlaylistModal to Spanish
- Translated modal titles (new/edit/add to playlist)
- Translated form labels and placeholders
- Translated buttons (create, save, cancel, delete)
- Translated track count and playlist count labels
- Added missing translation keys for actions (add, create, deleteConfirm)
- Used get(t) in $derived() to avoid PostCSS extraction issues
2026-02-02 18:14:32 -06:00
vicrodh e2c3c9447d fix(i18n): avoid $t() inside $derived() to fix PostCSS error
Using $t() store subscriptions inside $derived() was causing
vite-plugin-svelte CSS extraction to fail, resulting in PostCSS
receiving the entire file content instead of just the style block.

Changed networkFsOptions to use labelKey pattern with $t() called
directly in the template instead.
2026-02-02 18:11:28 -06:00
vicrodh a489b2e875 i18n(search): translate context menus and empty states
- Update play menu items (Play now, Play next, Add to queue)
- Update navigation items (Go to artist, Go to album)
- Translate View more buttons
- Add noPlaylistsFor translation key

cc
2026-02-02 17:21:08 -06:00
vicrodh 5900e0bb83 i18n(settings): translate integrations section labels and placeholders
- Update Last.fm API key and shared secret labels
- Update Last.fm authorize button text
- Update ListenBrainz labels and token hint
- Add translations for connecting/opening states
- Add apiKey, sharedSecret, userToken translation keys

cc
2026-02-02 17:19:16 -06:00
vicrodh ef99d5f0ce i18n(components): translate dropdown placeholders and modal labels
- Update Dropdown.svelte with search placeholder translation
- Update DeviceDropdown.svelte with searchDevices placeholder
- Update GenreFilterPopup.svelte with searchGenres placeholder
- Update PlaylistModal.svelte with name and description labels
- Add playlist.name and playlist.descriptionOptional keys

cc
2026-02-02 17:17:40 -06:00
vicrodh 5b35851f41 i18n(library): translate empty states and headers
- Add translations for loading/error states
- Translate empty states for albums, artists, tracks views
- Translate header titles and subtitle
- Update button titles (Scan, Settings, Play All, Shuffle)
- Translate offline mode notice
- Translate filter panel labels
- Add editAlbumMetadataTitle key for tooltips

cc
2026-02-02 17:15:29 -06:00
vicrodh 1e2d074065 i18n(favorites): translate empty states, loading, and headers
- Add t import and use translations for all empty state messages
- Translate loading states (favorites, playlists, albums)
- Translate section headers (Discography, EPs & Singles, Live Albums)
- Translate button titles (Play All, Shuffle, More, Search, Clear)
- Add hint translations for liking items to favorites
- Update getSortLabel to use sort.* translation keys
- Update getTabLabel to use favorites.tabLabels.* keys

cc
2026-02-02 17:10:52 -06:00
vicrodh 9a053c9219 docs(i18n): add internationalization guidelines to CONTRIBUTING.md
Document i18n requirements for contributors:
- No hardcoded strings policy
- svelte-i18n interpolation format ({ values: {} })
- Translation key naming conventions
- Checklist for PRs with UI text
2026-02-02 16:51:06 -06:00
vicrodh ca11c43a4b merge: fix/general-debug-1.1.7 into pre-release (resolve i18n conflicts) 2026-02-02 16:41:38 -06:00
vicrodh 0c5c0ce1a8 i18n: add LocalLibraryView translations for empty states and UI 2026-02-02 16:38:53 -06:00
vicrodh 1d2a9f6636 i18n: add Settings, Storage, and Blacklist Manager translations
- MusicBrainz integration labels
- Storage section summary
- Complete BlacklistManagerView translations (title, description,
  search, empty states, confirm modal)
2026-02-02 16:38:02 -06:00
vicrodh a63bc1cbcd merge: integrate pre-release blacklist feature with i18n fixes 2026-02-02 16:34:52 -06:00
vicrodh 805fec1529 i18n: add Settings audio, offline library, and updates translations
Complete Spanish translations for:
- Audio settings (backend, ALSA plugin, hardware volume, streaming)
- Offline library section (repair, manage, clear)
- Updates section (check on launch, show changelog)
- Flatpak warning messages
2026-02-02 16:29:04 -06:00
vicrodh 55d383c431 fix(i18n): correct svelte-i18n interpolation format
svelte-i18n requires { values: { key: value } } format for variable
interpolation, not { key: value } directly. Fixed across all toast
and greeting calls.
2026-02-02 16:24:52 -06:00
vicrodh 764e55d1e8 fix: use $derived for networkFsOptions to support i18n reactivity 2026-02-02 16:17:18 -06:00
vicrodh aa98b4d411 i18n: Update toast messages in remaining components
- Update LocalLibraryTagEditorModal to use toast translations
- Update PlaylistImportModal to use toast translations
- Update PlaylistModal to use toast translations
- Update LocalLibraryView to use toast translations
- Update SettingsView to use toast translations for error messages
2026-02-02 15:48:05 -06:00
vicrodh 2dc9989d22 i18n: Add greeting and toast translations
- Add time-based greeting translations (goodMorning, goodAfternoon,
  goodEvening, goodNight) to homeSettings section
- Update homeSettingsStore to export getGreetingInfo for i18n support
- Update HomeView.svelte to use translated greetings
- Add comprehensive toast translations (~60 keys) for all user-facing
  notifications including queue, playback, offline, favorites, etc.
- Update +page.svelte to use $t() for all showToast calls
- Complete Spanish translations for all new keys
2026-02-02 15:45:35 -06:00
vicrodh e09c7e4a94 i18n: add missing Spanish translations for settings, audio, library and metadata 2026-02-02 15:35:04 -06:00
vicrodh 0fc5c4bb6f feat(blacklist): filter tracks in backend queue commands
Add second level of protection by filtering blacklisted artists
in Rust queue commands: set_queue, add_to_queue, add_to_queue_next,
and add_tracks_to_queue. This ensures blacklisted tracks are never
added to the queue regardless of frontend implementation.
2026-02-02 15:00:46 -06:00
vicrodh 4a1b2d6ad1 fix(blacklist): filter tracks per-artist in compilations and album queue 2026-02-02 14:42:28 -06:00
vicrodh 6ecd40b703 fix(blacklist): filter blacklisted tracks from queue operations 2026-02-02 14:32:17 -06:00
vicrodh f87e0bfe70 fix(blacklist): move @const declarations inside {#each} blocks 2026-02-02 14:22:43 -06:00
vicrodh 8480ad13da fix(blacklist): correct import path for artistBlacklistStore 2026-02-02 14:20:54 -06:00
vicrodh 6ff6269f74 feat(blacklist): add grayout styling for blacklisted artist tracks
- TrackRow: Add isBlacklisted prop with grayout styling and ban icon
- VirtualizedTrackList: Check blacklist status for each track
- PlaylistDetailView: Gray out and restrict actions for blacklisted tracks
- AlbumDetailView: Apply album-level blacklist check to all tracks
- HomeView: Gray out blacklisted tracks in Continue Listening section
- ArtistDetailView: Banner shown when viewing blacklisted artist page

Blacklisted tracks show reduced opacity, ban icon instead of track
number, and restricted menu actions (navigation only, no playback).
2026-02-02 14:17:01 -06:00
vicrodh bdffe6c709 feat(blacklist): add toast notifications for blacklist operations
- Show success/error toasts when adding/removing artists
- Show feedback when enabling/disabling blacklist
- Show confirmation toast when clearing all artists
2026-02-02 14:06:10 -06:00
vicrodh 6257f76484 fix(blacklist): use correct handleArtistClick function in BlacklistManagerView 2026-02-02 14:02:23 -06:00
vicrodh 958f0d7dca fix(blacklist): use callback prop for navigation to blacklist manager
- Replace direct navigateTo import with onBlacklistManagerClick callback
- Pass navigation callback from +page.svelte to SettingsView
- Follows same pattern as other view navigation (playlist-manager, etc)
2026-02-02 13:51:21 -06:00
vicrodh f95348bb1e feat(blacklist): add Blacklist Manager View
- Create BlacklistManagerView component with list of blocked artists
- Add enable/disable toggle, search filter, and clear all function
- Integrate navigation to blacklist manager from Settings
- Add Content Filtering section in Settings with artist count
- Add i18n translations for English and Spanish
- Wire up view routing in +page.svelte
2026-02-02 13:46:27 -06:00
vicrodh c18dfe641d fix(blacklist): filter albums and iterate most_popular for first valid item
- most_popular now iterates through all items to find first non-blacklisted
- Added album filtering to search_all by album.artist.id
- Added BlacklistState to search_albums with filtering
- Fixes edge case where most_popular was empty when first item was blacklisted
2026-02-02 13:26:23 -06:00
vicrodh e1849f0bb3 feat(blacklist): add frontend store and artist page UI
Phase 3 (minimal) - UI for testing:
- Add artistBlacklistStore.ts with O(1) local checks
- Initialize store on app startup
- Add blacklist toggle button to ArtistDetailView
- Button shows red when artist is blacklisted

cc
2026-02-02 13:18:38 -06:00
vicrodh bd4c9b7792 feat(blacklist): filter playlist suggestions by artist
Phase 2 (part 2) - Suggestions integration:
- Filter SuggestedTrack results by artist_id
- Log filtered count for debugging

cc
2026-02-02 13:10:36 -06:00
vicrodh bec6907dbe feat(blacklist): integrate filtering into search and radio commands
Phase 2 (part 1) - Read-only integration:
- Filter blacklisted artists from search_tracks, search_artists, search_all
- Filter blacklisted artists from get_similar_artists
- Filter most_popular item if blacklisted
- Add blacklist filtering to all radio commands (artist/track/infinite/refill)
- Use output-layer filtering for radio (engine internals unchanged)

cc
2026-02-02 13:09:35 -06:00
vicrodh 26c5a1b0a3 feat(blacklist): add artist blacklist module with O(1) lookups
Phase 1 of artist blacklist implementation:
- Add artist_blacklist module with HashSet-based service for O(1) lookups
- Add SQLite persistence with WAL mode
- Add global enable/disable feature flag
- Add Tauri commands for CRUD operations
- Register BlacklistState in app state

cc
2026-02-02 13:05:50 -06:00
vicrodh a742c22c8f fix(prefetch): limit concurrent prefetches to prevent memory corruption
Add semaphore to limit concurrent prefetch operations to 1 at a time.
This helps prevent potential race conditions in native audio libraries
(CPAL/PipeWire/ALSA) that can cause malloc corruption.

Also:
- Reduce QOBUZ_PREFETCH_COUNT from 3 to 2
- Reduce PREFETCH_LOOKAHEAD from 15 to 10
- Add 50ms delay before cache insertion

Addresses #38 - random crashes during prefetch
2026-02-02 12:20:10 -06:00
vicrodh aa04a26b6c fix(offline): use hybrid strategy to reduce false positives
Implement 9/10 check strategy:
- 9 out of 10 connectivity checks go to 1.1.1.1 (Cloudflare DNS)
- 1 out of 10 checks go to Qobuz to verify service availability

This prevents false offline detections when the app is making many
concurrent API calls (e.g., loading genre hierarchies), which could
trigger Qobuz rate limiting and cause timeout-based false positives.

Also reduced timeout from 15s to 10s and retry wait from 2s to 1s
since 1.1.1.1 responds much faster than Qobuz.
2026-02-02 11:29:26 -06:00
vicrodh e86ceb827c fix(genre-filter): hide carets for genres without children
Only show expand carets in the advanced view for genres that actually
have children loaded, or where children haven't been loaded yet.
Applies to all levels (parent, child, grandchild).
2026-02-02 11:14:03 -06:00
vicrodh 1dcf2ac29a feat(genre): eager load all 3 levels on first load for complete search 2026-02-02 11:10:12 -06:00
vicrodh e599a7b803 feat(genre): add 30-day localStorage cache for genres 2026-02-02 11:06:32 -06:00