Commit Graph
3650 Commits
Author SHA1 Message Date
vicrodh 33d65681c4 fix(queue): restore infinite play (V2 reimplementation)
Issue #319: Infinite Play toggle had no backend wiring after the V2
migration — toggle only wrote to localStorage and the queue-end handler
ignored it, so playback stopped at the last track.

Reimplemented in V2 (no legacy wrappers):

- New `v2_create_infinite_radio` command that takes the last few played
  track IDs, uses the most recent track's artist as the radio seed via
  `RadioPoolBuilder::create_artist_radio` (Qobuz `/radio/artist`
  endpoint), and returns 50 V2QueueTrack ready to append. Does NOT
  mutate the queue or playback context — caller decides how to use them.

- `playbackPreferencesStore`: expose `'infinite'` in `AutoplayMode`
  type and add `isInfinitePlayEnabled()` helper.

- `+page.svelte`:
  - `handleToggleInfinitePlay` now syncs to backend via
    `setAutoplayMode('infinite' | 'continue')` so the choice persists
    in `playback_preferences.db` across restarts (was localStorage only).
  - On startup load infinite play from cached preferences (was
    localStorage).
  - When `nextTrack()` returns null AND infinite play is on: collect
    the current track + last 5 history tracks, call
    `v2_create_infinite_radio`, append the result via
    `v2_bulk_add_to_queue`, then advance — playback continues without
    interruption.

i18n: add `toast.failedToSavePreference` to all 5 locales.

cc
2026-04-15 21:20:04 -06:00
vicrodh 3d0df4afba feat(a11y): add WCAG Light, WCAG Dark, High Contrast, and Colorblind themes
Four accessibility-focused themes with WCAG AAA contrast ratios:
- WCAG Light/Dark: 7:1+ contrast for all text levels
- High Contrast: pure white on pure black, yellow accent (21:1)
- Colorblind: deuteranopia-safe palette (Wong colors), no red/green

Addresses discussion #313 (user with severe vision impairment).

cc
2026-04-15 20:30:26 -06:00
vicrodh e39d9b0068 feat(carousel): add mouse drag scrolling to horizontal rows
Add pointer-based drag scrolling to HorizontalScrollRow so users can
click-and-drag to scroll album rows, matching iPad/browser behavior.
Distinguishes drag from click using a 5px threshold to avoid
intercepting album selection. Cursor changes to grab/grabbing.

Addresses user report from discussion #313 where horizontal album
rows were not explorable without arrow buttons.

cc
2026-04-15 20:27:44 -06:00
vicrodh ffe3a7b49b Merge branch 'fix/icon-sizing-shadow' into pre-release 2026-04-15 20:24:36 -06:00
vicrodh 1fe7d44311 fix(branding): resize icon to fill canvas + add blue edge rim
Tighten the viewBox so the vinyl fills ~97% of the canvas (matching
Steam/Chrome/Papirus sizing). Add a #3968be stroke rim around the
vinyl edge so the icon remains visible on pure-black backgrounds.
Include a subtle radial inner-light from top-left for depth.

Also adds 512x512.png for Flathub compatibility.

Regenerate all PNG exports: Tauri standard sizes, Windows Store
squares, ICO, Android mipmaps, and static logos.

cc
2026-04-15 20:22:00 -06:00
vicrodh 931512fed3 fix(gentoo): add inherit xdg-utils to qbz-bin ebuild template
pkg_postinst and pkg_postrm in the binary ebuild call
xdg_icon_cache_update and xdg_desktop_database_update, which
come from the xdg-utils eclass. Without `inherit xdg-utils`
those helpers are undefined and the hicolor icon cache never
refreshes on upgrade.

The source ebuild template (qbz.ebuild.template) already
inherits xdg, so this only affects users installing via
qbz-bin (the prebuilt binary path). The qbz-overlay has a
direct patch for v1.2.5; this ensures v1.2.6+ release-gentoo
runs emit correct ebuilds.

cc
2026-04-15 18:59:09 -06:00
Victor RH 76db2015c1 Merge pull request #314 from vicrodh/dependabot/cargo/crates/rustls-webpki-0.103.12
chore(deps): bump rustls-webpki from 0.103.9 to 0.103.12 in /crates
2026-04-15 16:31:51 -06:00
vicrodh 0461c36912 security: address CodeQL alerts from the v1.2.5 scan
Triaged the 8 open CodeQL alerts raised on the 1.2.5 merge commit.

Critical (1) — real, fixed:

  * .github/workflows/release-updater-manifest.yml:29 — the resolve
    step interpolated `${{ github.event.workflow_run.head_branch }}`
    directly into a shell heredoc. `head_branch` on `workflow_run` is
    attacker-controllable (any outside contributor can push a branch
    whose name embeds a payload). Route the value through an env var
    (HEAD_BRANCH) and validate the shape with a strict regex before
    letting it flow into shell or $GITHUB_OUTPUT.

Warnings (2) — real, fixed:

  * .github/workflows/build-qbzd.yml had no `permissions:` block, so
    every job inherited the repo's default GITHUB_TOKEN scope. Add a
    top-level `permissions: contents: read`; the existing `release`
    job keeps its own `contents: write` override for publishing
    artifacts.

Warnings (3) — real, low severity, mitigated:

  * crates/qbzd/src/{daemon.rs,session.rs} logged `user_id` at info
    level (CodeQL rust/cleartext-logging). Demoted the three lines to
    `log::debug!` so default-level logs stay free of the numeric user
    id, with a comment noting RUST_LOG=debug re-enables them for
    diagnostics.

Warnings (2) — false positives, dismissed in GitHub:

  * crates/qbzd/src/login.rs:103 — `println!` to stdout inside the
    interactive `qbzd login` subcommand; login confirmation UX, not a
    persistent log. (alert #63 dismissed, reason: false positive)
  * crates/qbzd/src/qconnect.rs:540 — `session_uuid` is an ephemeral
    per-connection identifier QConnect exchanges in cleartext itself;
    not a credential or token. (alert #65 dismissed, reason: false
    positive)

cc
2026-04-15 16:10:06 -06:00
dependabot[bot] 56b7b24c90 chore(deps): bump rustls-webpki from 0.103.9 to 0.103.12 in /crates
Bumps [rustls-webpki](https://github.com/rustls/webpki) from 0.103.9 to 0.103.12.
- [Release notes](https://github.com/rustls/webpki/releases)
- [Commits](https://github.com/rustls/webpki/compare/v/0.103.9...v/0.103.12)

---
updated-dependencies:
- dependency-name: rustls-webpki
  dependency-version: 0.103.12
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-04-15 21:52:32 +00:00
vicrodh a867d77528 fix(build): gate macOS-unreachable imports to cfg(target_os = "linux")
The v1.2.5 tag push flagged three macOS-only compile errors on the
release-macos workflow (Linux, aarch64 Linux, flatpak still building
successfully). All three are Linux-only symbols pulled unconditionally
into files that are compiled on every target:

  * src-tauri/src/tray.rs: imports PathBuf inside the
    `cfg(not(target_os = "linux"))` branch without `use std::path::PathBuf`.
    Add the import under the matching cfg so macOS / Windows see it.

  * src-tauri/src/commands_v2/playback.rs: `cached_audio_incompatible_with_hw`
    is defined only on Linux (ALSA). Callsites are already
    `cfg(target_os = "linux")`, but the shared `use super::{...}` block
    was not. Move that one symbol out into a Linux-only import.

  * src-tauri/src/commands_v2/legacy_compat.rs: same story with
    `v2_prepare_notification_icon_bytes` — only the Linux notification
    path calls it, but the import was unconditional.

No runtime behaviour change; this only unblocks the release-macos
(and any future Apple-target) workflow so it can build.

cc
2026-04-15 15:46:06 -06:00
vicrodh 64d51d3c85 Merge pre-release into main for v1.2.5 'Accolade Watch' 2026-04-15 15:25:16 -06:00
vicrodh aa68fa0a5b docs(release): apply user's 1.2.5 notes polish + trim
Rewrite the opening paragraph into a personal, first-person note from
the maintainer (including the Spanish sign-off), drop the sprint-
level bullets that only described iterations kept in the narrative
but don't matter to end users, and tidy a couple of typos.

cc
2026-04-15 15:22:50 -06:00
vicrodh e0a3ed6e72 chore(release): bump flake.nix qbzVersion to 1.2.5
Missed in the earlier bump pass. Confirmed every other version pin
reads 1.2.5: src-tauri/Cargo.toml, src-tauri/Cargo.lock,
src-tauri/tauri.conf.json, package.json, package-lock.json,
snapcraft.yaml, packaging/flatpak/com.blitzfc.qbz.metainfo.xml
(top <release> entry); the only remaining "1.2.4" string in the tree
is the historic release entry in metainfo.xml, which is correct.

cc
2026-04-15 15:19:14 -06:00
vicrodh 130efeb1f0 docs(release): add 1.2.5 "Accolade Watch" release notes
Follows the same pattern as docs/release-1.2.4/:

  * CHANGELOG_FULL.md — short-hash + subject for every non-merge commit
    since v1.2.4 (216 commits)
  * TAG_DETAILS.md — narrative changelog grouped by Accolades, Release
    Watch, Labels, Visual identity, Desktop integration, Streaming /
    audio / player, Updater, UI polish, Internal architecture, Packaging

qbzd work is noted but flagged as scaffolding (hidden from the release
narrative per the plan to ship it separately).

cc
2026-04-15 14:22:21 -06:00
vicrodh be63d6b3d3 chore(flatpak): point metainfo screenshots at the 1.2.5 commit
Bump the SHA in every <screenshot> URL to 5f759514d3
(the screenshot refresh commit) so Flathub picks up the new captures.

Add three new <screenshot> entries on top of the existing three —
immersive line-bed, enriched artist page, Hi-Fi DAC setup wizard — and
re-promote the Audio settings capture (default-settings.png) that was
sitting unused in the screenshots folder. New ordering for the listing:

  1. home-discover (default — first impression)
  2. immersive-cover-flow
  3. immersive-line-bed
  4. enriched-artist-page
  5. local-library
  6. hifi-wizard
  7. default-settings

cc
2026-04-15 13:42:28 -06:00
vicrodh 5f759514d3 chore(flatpak): refresh screenshots for 1.2.5
Replace the four existing Flathub screenshots with captures from the
1.2.5 build (new logo, new sidebar, refreshed login chrome) and add
three new ones that showcase features worth highlighting on the
Flathub listing:

  * enriched-artist-page.png — artist view with editorial data
  * hifi-wizard.png — DAC setup wizard
  * immersive-line-bed.png — immersive line-bed playback mode

Metainfo manifest is updated in the next commit because Flathub freezes
screenshot URLs by commit SHA, so we need this commit's SHA to land
first.

cc
2026-04-15 13:42:01 -06:00
vicrodh 824b577dc2 fix(genre-filter): popup uses CSS max-height for smart positioning
The collision check in positionPopup was reading the popup's measured
rect right after mount, but the popup grows after that runs (the
genre tree fills in asynchronously). The first measurement reported a
height much smaller than the final ~500px / ~700px max-heights from
CSS, so the "would I overflow the bottom?" branch evaluated false even
when the final popup didn't fit. Result: bottom of the popup got clipped
by the window edge (visible in the Discover -> Filter by genre flow on
short windows).

Use the CSS max-heights (530/630 already used for width) as the
collision target instead. If the down-placement still overflows, try
flipping above the trigger; if neither fits (very small window), clamp
to the bottom padding and let the popup's own internal scroll handle
the overflow.

cc
2026-04-15 13:40:58 -06:00
vicrodh 6049240640 chore(release): bump version to 1.2.5 "Accolade Watch"
* src-tauri/Cargo.toml and Cargo.lock: 1.2.4 -> 1.2.5
  * src-tauri/tauri.conf.json: 1.2.4 -> 1.2.5
  * package.json (+ package-lock.json regenerated): 1.2.4 -> 1.2.5
  * snapcraft.yaml: 1.2.4 -> 1.2.5
  * packaging/flatpak/com.blitzfc.qbz.metainfo.xml: new <release> entry
    dated 2026-04-15 covering the visual refresh (new logo + login
    branding), Plasma/Klassy auto-detect for window controls,
    opt-in match-system-chrome rounded corners, Editor's Picks
    ribbon cleanup, the two sidebar menu positioning fixes shipped
    alongside this bump, and the DAC wizard contrast fix.

Tag not applied per request — release notes are staged, ready for
the screenshots pass and manual tag afterward.

cc
2026-04-15 13:16:36 -06:00
vicrodh 372357497b fix(sidebar,about): smart positioning for playlist menus + platform label
Two bugs surfaced during 1.2.5 QA:

* The per-playlist right-click context menu opened at the cursor and
  could fall below the bottom of the window when invoked on items near
  the last of the sidebar. It now measures its own rect and flips above
  the cursor if there's no room below, or clamps to the bottom padding
  as a last resort. Same pattern already used for the main playlists
  dropdown menu.
* The Sort submenu inside the sidebar's general playlists menu was
  being clipped by its parent .dropdown-menu because the submenu lived
  inside that menu's DOM subtree. Teleport it via a local `use:portal`
  action so absolute positioning escapes any ancestor `overflow: hidden`.

Also fix a duplicated "License" label in the About dialog's Build Info
block: the second row meant to show the platform was using the license
key. Swap to about.buildInfo.platform (the key already existed in both
locales).

cc
2026-04-15 13:16:07 -06:00
vicrodh 7d1e5604da refactor(appearance): keep only the rounded corners on match-chrome
The inset dark frame + inset highlight + outer drop shadow combo
didn't produce a convincing edge on WebKitGTK — rounded corners are
the only piece of "match system chrome" that actually works today, so
drop the rest and leave the CSS minimal.

Real native shadow/border around a CSD Tauri window requires hints
like `_GTK_FRAME_EXTENTS` (X11) or `zxdg-toplevel-decoration-v1`
(Wayland) that wry doesn't expose yet. That path stays as a Phase 3
TODO — either upstream wry/tao or an FFI to gtk::Window via
raw_window_handle.

cc
2026-04-15 12:20:22 -06:00
vicrodh 4c5019dff3 fix(appearance): prioritize visible edge over drop shadow
Per user request, put explicit window edges above the ambient drop
shadow. Restore clip-path for clean corner anti-aliasing (it doesn't
clip inset shadows, only outer paints), drop the body padding
workaround, and paint two inset bands on .app:

  inset 0 0 0 1px rgba(0,0,0,0.75)    — crisp dark frame, 1px
  inset 0 0 0 2px rgba(255,255,255,0.06) — subtle inner highlight

Keep a low-weight outer drop shadow (0 8px 20px) so the window still
has a hint of lift, but the edges — not the shadow — define the
window boundary now. Works the same on any compositor because it's
all painted by the webview, not by KWin/Mutter.

cc
2026-04-15 12:12:21 -06:00
vicrodh 74d4d98e42 fix(appearance): draw the external drop shadow around rounded window
Phase 2 produced clean rounded corners but no visible shadow because
.app filled 100vw/100vh, leaving no pixels for box-shadow to paint
into — and the clip-path added for anti-alias was clipping the shadow
as well.

Reserve a 12px padding on body while match-chrome-transparent is active
and shrink .app by the matching 24px in width/height, so the outer
drop shadow has somewhere to render. Drop clip-path (it was consuming
the shadow); keep transform: translateZ(0) for GPU AA on the corners.
Two-layer shadow: a broad soft ambient (18/40 rgba(0 0 0 / 0.65)) plus
a tight 4/12 crisp shadow for edge definition without painting a hard
1px stroke that jaggies at the rounded joint.

cc
2026-04-15 12:10:57 -06:00
vicrodh 823e1c313e fix(appearance): smoother rounded corners under WebKitGTK
Remove the hard 1px outline that the "match system window chrome"
style was painting inside the radius: on WebKitGTK the outline
amplified anti-aliasing jaggies at the rounded corners because the
stroke has no blur. Replace with a softer two-layer drop shadow,
add clip-path: inset(... round ...) on top of border-radius (clip-path
gives noticeably cleaner AA than border-radius + overflow:hidden alone
in WebKitGTK), and promote the container to its own compositing layer
with translateZ(0) + backface-visibility:hidden so the GPU handles the
edge.

cc
2026-04-15 11:51:03 -06:00
vicrodh 57e63e3ef5 feat(appearance): phase 2 of match-system-window-chrome (transparent)
Rounded-corner window chrome now actually works. The toggle in
Settings > Appearance persists to the window_settings SQLite store and
gates the Tauri window transparency decision at startup, so on next
launch the main window is rebuilt with `transparent: true` and the
border-radius plus edge outline apply without painting white corners.

Flow:
  * Toggle in Settings > Appearance -> windowChromeStore saves to
    localStorage and calls v2_set_match_system_window_chrome which
    writes match_system_window_chrome to window_settings.db.
  * Toast reminds the user to restart.
  * On next launch, should_use_main_window_transparency() reads the
    setting and returns true, Tauri builds the window transparent.
  * Setup stores the decision in MAIN_WINDOW_TRANSPARENT. A new command
    v2_main_window_is_transparent reports it back to the frontend.
  * +page.svelte only applies .app.match-chrome when the window is
    actually transparent AND the custom titlebar is visible, so
    stale-state toggling never produces white wedges.
  * CSS sets html/body transparent via a global class on <html>, then
    .app.match-chrome.floating paints the rounded corners plus a
    12/28 rgba drop shadow and a 1px darkening outline.
  * Maximized state clears the radius automatically.

Env vars QBZ_FORCE_TRANSPARENT_WINDOWS / QBZ_FORCE_OPAQUE_WINDOWS still
take precedence over the DB-persisted toggle.

cc
2026-04-15 11:31:11 -06:00
vicrodh 8502c2fdb3 feat(appearance): match system window chrome (phase 1) + ribbon cleanup
Adds an opt-in "Match system window chrome" toggle in Settings >
Appearance. When enabled (and the custom title bar is active, i.e.
neither "Use system title bar" nor "Hide title bar"), QBZ rounds its
own corners to match the detected desktop's decoration radius and
paints a thin edge outline so the window reads as its own surface
against the desktop instead of a bare rectangle.

Phase 1 scope:
  * New windowChromeStore (localStorage) holding the toggle and the
    detected corner radius.
  * desktop_theme module gains a best-effort window_corner_radius_px:
    10 for Klassy, 6 for Breeze Plasma, 12 for GNOME/Adwaita, 8 fallback.
  * +page.svelte subscribes to the detector; .app.match-chrome.floating
    applies the radius via a CSS variable plus a 1px darkening outline
    and a deeper shadow. Maximized state removes the radius.
  * SettingsView: new toggle, disabled when hideTitleBar or
    useSystemTitleBar is on; i18n for en/es.

External shadow that matches each DE's compositor remains a phase 2
item — it requires `transparent: true` on the Tauri window, which has
compositor stability trade-offs and must be restart-gated.

Also cleans up redundant AlbumCard ribbons in the Editor's Picks
TAB (distinct from the home tab that was fixed earlier): removes
ribbon={album.ribbon} from the `editorPicks` and `qobuzissimes`
sections inside the editor-picks tab block. Press Accolades and
Popular Albums keep their ribbons (they vary per card).

cc
2026-04-15 11:17:05 -06:00
vicrodh 62d1674673 chore(release): hide qbzd from UI and CI until it ships
qbzd is feature-complete on disk but not ready for public release yet.
Keep all code paths in place so it can be unhidden with a one-line
flip, but remove it from the user-facing surface:

  * build-qbzd.yml: comment out the `push.tags` trigger so neither a
    regular `v*` version tag nor a `qbzd-v*` tag auto-builds artifacts.
    workflow_dispatch is preserved for manual testing.
  * CastPicker.svelte: guard the QBZ Daemon tab, the manual-connect
    section, and the three `v2_qbzd_*` Tauri invocations behind a
    `QBZD_ENABLED` flag (currently false). Default activeProtocol
    switches to 'chromecast' so the picker doesn't start on a hidden
    tab.
  * SettingsView: DAC Setup Wizard icon filter swapped — button icon
    drops the `invert(1)` so it reads on light accent colors (e.g.
    Catppuccin Lavender), and the tooltip copy of the same icon now
    has `invert(1)` so it reads on the dark surface bg. Unrelated to
    qbzd but bundled since both are pre-release polish.

cc
2026-04-15 10:28:25 -06:00
vicrodh 6a5cfc7235 feat(titlebar): auto-detect KDE Plasma/Klassy theme for window controls
Adds a runtime-detected "Klassy (auto-detect)" preset for the custom
window controls that reads the user's Plasma decoration theme and
applies matching colors and shape. When Klassy itself is not installed
but Plasma is, the option re-labels to "Plasma (auto-detect)" and
still applies the desktop color scheme. Hidden on non-KDE / non-Linux.

Backend:
  * New desktop_theme module parses kwinrc, kdeglobals, and klassyrc
    without external deps. Exposes detect_desktop_theme Tauri command
    returning DesktopThemeInfo: desktop id, isKlassy flag, WM active/
    inactive background + foreground, accent, DecorationHover, and the
    user's Klassy ButtonIconStyle / ButtonShape when present.

Frontend:
  * windowControlsStore gains applyKlassyPreset(), a cached detection
    helper, and mapKlassyShapeToQbz() that maps Klassy's button shapes
    (FullHeightRectangle, FullHeightRoundedRectangle, Tab, Circle,
    Square, IntegratedRoundedRectangle, ...) onto QBZ's shape set.
  * Adds the full-height-rounded shape to ButtonShape to cover the
    most common Klassy style that QBZ was missing; CSS matches Klassy
    FullHeightRoundedRectangle visual (full-height tab with ~7px
    radius and margin).
  * SettingsView fires detection on mount, derives the preset list
    reactively so the auto-detect option only appears when relevant,
    and adds the new shape to the Style picker.
  * i18n keys added for the new shape and both preset labels in en/es.

cc
2026-04-15 09:43:00 -06:00
vicrodh 1cb8d2c305 feat(branding): refresh app icon, tray theming, and login branding
Apply the new matte-vinyl QBZ logo (Flathub-compliant: square canvas,
74% footprint, no baked shadows/gloss) across every icon asset: Tauri
standard sizes, Windows Store squares, Android icons and mipmaps,
static/, README, and the tray.

Ship two tray variants (black and white glyphs) and pick the right
one at runtime by reading GNOME color-scheme, GTK settings, and KDE
kdeglobals. Defaults to light-theme glyph when nothing matches.

Login screen: logo 80 -> 175 px with a subtle var(--text-muted)
drop-shadow using color-mix() for alpha, plus QBZ and "Qobuz(TM)
Player" under the icon. Update app.tagline i18n accordingly.

cc
2026-04-15 03:55:28 -06:00
vicrodh b227355af7 fix(nix): export LD_LIBRARY_PATH for libappindicator in devShell
The package's `postInstall` wraps the installed `qbz` binary with
`LD_LIBRARY_PATH` so it can `dlopen(libayatana-appindicator3.so.1)` at
runtime. Inside `nix develop`, users run `target/debug/qbz` directly
without that wrapper, so the tray init panics at startup.

Add a `shellHook` that mirrors `postInstall`'s library path.

Same root cause as the previous LIBCLANG_PATH fix: `inputsFrom` makes
dependencies available at build time but does not set runtime/env vars
the way the installed wrapper does.

Refs #312.

cc
2026-04-14 23:00:35 -06:00
vicrodh c63c3ab160 chore(audio-watch): drop deprecated DeviceTrait::name fallback
rodio deprecated `DeviceTrait::name()` in favour of `description()`
(name) / `id()` (stable identifier). The legacy fallback in
`preferred_name()` was unreachable on our target platforms anyway —
the only path that matters is the `description()` one, since that is
what `get_audio_devices()` persists in settings.

Skip the device if `description()` fails instead of falling back to
the deprecated API. Silences the build warning.

cc
2026-04-14 22:59:22 -06:00
vicrodh 8871262377 chore(deps): bump rand to silence dependabot advisories
- src-tauri: rand 0.10.0 → 0.10.1 via cargo update (alert #36)
- qbz-player: rand 0.8 → 0.9, `gen_range` → `random_range` (alert #38)

The underlying RUSTSEC issue only triggers for code that calls
`rand::rng()` alongside a custom logger — we don't do that anywhere,
so actual impact is nil. Bumping closes the alerts.

cc
2026-04-14 22:47:42 -06:00
vicrodh 551c986591 fix(nix): export LIBCLANG_PATH in devShell for mupdf-sys bindgen
`inputsFrom` does not propagate the package's `env.*` attributes into
the dev shell, so running `npm run tauri dev` inside `nix develop`
failed at `mupdf-sys(build)` with "Unable to find libclang".

Re-export LIBCLANG_PATH on the shell itself.

Closes #312.

cc
2026-04-14 21:47:45 -06:00
vicrodh f7e51b980e fix(audio-watch): stop pre-flight device toast — stored name format never matched cpal enum
Level A of issue #307 was firing 'device no longer available' spuriously
because settings.output_device stores the ALSA-normalized form
(front:CARD=X,DEV=0 per normalize_device_id_to_stable) while cpal's
output_devices() enumeration returns different strings entirely —
DeviceTrait::description() (friendly) and DeviceTrait::name() both
produce values that don't match what the UI persisted. Comparing them
marked every configured device as 'missing' on normal playback.

Removes the pre-flight emit_missing_if_needed() calls from
v2_play_track and v2_resume_playback so the false-positive toast
stops firing. The init_device fallback still routes audio to default
on a truly missing device — we just no longer surface that to the UI,
which is net neutral for the user vs. wrong notifications.

Keeps audio_device_watch module, DeviceMissingThrottle state and the
frontend listener in place so Level B (emit from inside the audio
thread when the fallback actually triggers) can reuse the plumbing
without another refactor. Hardens the presence check with
empty-enumeration = inconclusive and description()-based matching for
whenever Level B actually wires up a call site that has a comparable
device name at hand.

cc
2026-04-14 21:12:03 -06:00
vicrodh 6094876aa1 fix(player): pass durationSecs on session-restore first play so seekbar advances
Root cause traced from user diagnostic: only one playback:state event
fired (position=0), then nothing. Backend's current_position() returned
0 forever because thread_state.duration was 0 — the PlayStreaming
handler at player/mod.rs:1849 stores duration verbatim from the
command parameter and current_position() at player/mod.rs:789 ends
with .min(duration), clamping to 0.

Parameter names also didn't line up. cmdPlayTrack was invoking
v2_play_track with qualityStr and lowQualityFallback, neither of
which matches Tauri's camelCase mapping of the Rust signature
(quality, forceLowestQuality, durationSecs). Quality and force-fallback
were being silently ignored; durationSecs was never sent at all.

The normal queue playback path in playbackService uses the correct
camelCase names and passes track.duration, which is why the seekbar
worked everywhere except the session-restore first play — that path
goes through togglePlayback → cmdPlayTrack.

Fix:
- Correct the parameter names in cmdPlayTrack to match the backend
  (quality, forceLowestQuality, durationSecs).
- Add durationSecs as a first-class arg and pass it from
  togglePlayback when resuming a restored track.
- Drop the temporary [Diag:*] console logs added while investigating.

cc
2026-04-14 18:57:20 -06:00
vicrodh 77d54f99d2 fix(qconnect): always persist local session to preserve track-level restore (#304)
evaluateQconnectSessionPersistence now unconditionally returns
shouldPersist: true. Previously it refused to save the local session
whenever Qobuz Connect was in remote mode, which meant closing QBZ
with QConnect active discarded the current track + position. On next
launch the app fell back to whatever QConnect held, which is
playlist/release-level only.

QConnect-vs-local priority on restore is a separate concern and
belongs at the restore path, not here.

Tests updated.

cc
2026-04-14 18:11:18 -06:00
vicrodh b62a4b01f5 feat(audio): notify user when selected output device goes missing (issue #307)
Level A of issue #307. When the configured output device has
disappeared from the host device list at the time of play/resume
(KVM switched away, USB sink unplugged, PipeWire sink removed…)
the backend emits an 'audio:device-missing' event and the frontend
shows a warning toast:

  'Output device "XYZ" is no longer available. Using system default.'

The existing init_device fallback already routes audio to the system
default, so this is purely informational — the user now understands
why audio came out of a different sink instead of staring at a silent
progress bar.

Does NOT touch the sacred audio init path (pipewire_backend.rs,
init_device, audio_settings.rs). New module audio_device_watch.rs
adds a pure presence check, a new-state throttle so we don't emit on
every resume once the user's been notified, and a v2 command
v2_check_audio_device_presence so the frontend can poll on demand.

Ready for Level B (background watchdog) — the same helpers plug into
a timer without further refactor; Level B only needs to add a tokio
task that calls emit_missing_if_needed() every N seconds while
playback is active.

cc
2026-04-14 17:58:59 -06:00
vicrodh 7425d34e27 chore(assets): add laurel wreath SVG used by AwardView placeholder
Referenced by AwardView hero / Other Awards mini-card / AlbumDetailView
sidebar award avatar in commit d719fb67 but the asset itself was never
tracked. Ships the SVG so the placeholder renders after a clean clone.

cc
2026-04-14 17:33:05 -06:00
vicrodh d8fc85a071 fix(artist): dedup releases by id in convertPageArtist initial load
appendPageReleases already skipped releases whose id already lived in
artist.albums/epsSingles/liveAlbums/others, but convertPageArtist
(the first /artist/page response) pushed everything blindly. When
Qobuz returned the same release in multiple groups (e.g. both the
main category and the 'download' distribution bucket) we ended up
with side-by-side duplicates on the discography grid — reported by
user on Holly Humberstone's 'Cruel World' entry.

Adds a seenIds Set scoped to the whole response so a release is
assigned to exactly one category on first encounter and silently
dropped on subsequent references. totalAlbums is now counted per
unique accepted item instead of raw group size, so the header count
matches the rendered grid.

cc
2026-04-14 17:27:57 -06:00
vicrodh e6ed62657a fix(artist): replace gold QualityBadge with plain text to match AlbumView
The compact QualityBadge in Popular Tracks rendered a gold-gradient
chip that clashed with the rest of the track row. Homologates to the
same look AlbumDetailView uses in its TrackRow: plain 12px grey text
('24-Bit/96 kHz' / 'CD Quality'), centered in an 80px cell, no
coloured background.

Uses formatQuality() with bit-depth > 16 as the hires signal so the
output string is identical to what AlbumDetailView shows for the
same track.

cc
2026-04-14 17:21:09 -06:00
vicrodh d719fb6794 feat(award): swap trophy icon for white laurel wreath on gold gradient
Uses /static/laurels.svg as the default award artwork everywhere a
placeholder was rendering the lucide Award (trophy) icon:
- AwardView hero circle (140px, 68%)
- AwardView 'Other awards' mini-card (120px, 56%)
- AlbumDetailView sidebar award avatar (44px, 58%)

Laurel is rendered as an <img> filtered white (brightness(0) invert(1))
over the existing gold gradient. Awards that ship with their own
image/magazine cover keep theirs — the swap only affects the default
fallback.

cc
2026-04-14 16:26:37 -06:00
vicrodh 47963c0a4f fix(award+home): reload AwardView on awardId change; drop ribbon from Essential Discography
- AwardView stayed on the same activeView when switching between
  awards via the 'Other awards' carousel, so onMount didn't re-fire
  and the old award's data persisted. Replaces the onMount trigger
  with a  keyed on awardId: resets loading flags and calls
  loadHero/loadAlbums/loadOtherAwards whenever the prop changes.
- Essential Discography albums all carry the Ideal Discography award
  by definition — the ribbon is redundant on every card. Drops the
  ribbon prop from the two AlbumCard call-sites for that rail.
  Ribbons still appear on New Releases, Press Accolades, Most
  Streamed, Qobuzissimes, Album of the Week, Editor's Picks and
  Forgotten Favorites.

cc
2026-04-14 16:21:29 -06:00
vicrodh 7c2f2941fd feat(award): gold press ribbon + Other awards carousel on AwardView
1. Press ribbon restyled to a solid gold gradient (#f5c042 → #d49511)
   with dark (#1f1407) uppercase text and a subtle white text-shadow.
   Drops the red border-left. Qobuzissime / Album of the Week keep
   their dark-background treatment with coloured left accent.

2. AwardView now loads /award/explore on mount (first 30 entries,
   current award filtered out) and renders them as a horizontal
   'Other awards' carousel below the album grid — same layout as
   LabelView's 'More labels'. Each card shows the award laurel
   (or magazine cover when present) + name + magazine name; clicking
   routes into that award's AwardView.

i18n key award.otherAwards added for all five locales.

cc
2026-04-14 16:07:22 -06:00
vicrodh c4c4bdf244 fix(album-awards): accept LegacyAwardDto's awardId/awardedAt field names
Root cause of 'Discoteca Ideal Qobuz not clickable': /album/get
returns awards as LegacyAwardDto (per a20/c.java + LegacyAlbumDto
in the Android decompilation) whose id field is named awardId, not
id. Our AlbumAward struct only looked for 'id', so every award from
/album/get deserialized with id=None and the click fell back to the
catalog resolver — which was itself incomplete.

Adds serde aliases 'awardId' / 'award_id' for the id field and
'awardedAt' for awarded_at. Applies to both qbz-models (V2) and the
src-tauri legacy mirror.

Endpoint coverage:
- /discover/index  → {id, name, awarded_at}       (primary match)
- /album/get       → {awardId, name, awardedAt, …} (alias match)
- /artist/page     → {id, name, awarded_at}       (primary match)

cc
2026-04-14 16:02:08 -06:00
vicrodh 776e7846cd fix(award-catalog): exhaustive /award/explore pagination with diagnostic logs
Previous loop short-circuited when a page returned fewer than the
requested limit, but Qobuz may return a partial page with has_more=true.
Only stop when items is empty, has_more is explicitly false, or the
page repeats ids already seen (server ignoring offset).

Also bumps the sessionStorage key (v2) so prior truncated caches are
discarded, and logs every page (offset, returned count, has_more) plus
a summary (distinct ids, names, total items, pages) for debugging.

cc
2026-04-14 15:55:23 -06:00
vicrodh d75a8505b0 debug(album): log full /album/get payload; catalog can harvest award ids from album responses
- Console-dumps album and album.awards when AlbumView loads so we can
  see exactly what Qobuz returns for a given album (user reported
  Discoteca Ideal Qobuz still not resolving even after /award/explore
  cached 15 entries).
- Adds rememberAward / rememberAwards / rememberAwardsFromAlbums to
  the catalog store plus sessionStorage persistence. Wiring these
  into the data paths comes next once we know what shape /album/get
  actually returns for awards.

cc
2026-04-14 15:52:33 -06:00
vicrodh b7f45b2d95 refactor(award-catalog): remove hardcoded editorial seed, rely on /award/explore
User pushed back on the hardcoded list of Qobuz editorial award names
across locales. Removed the seed map entirely — the catalog is now
100% what Qobuz returns from /award/explore in the user's current
session locale, so id resolution always matches whatever labels the
API is currently emitting.

Kept:
- Cache-first lookup (hit the in-memory map before touching the API).
- Diacritic-insensitive + whitespace-agnostic normalization so accent
  or case differences don't miss a real match.
- Single fetch per session, paginated.

Added a console.log summary after the initial fetch and a warn when a
name misses the catalog so future 'X award doesn't open' reports are
debuggable without guessing.

cc
2026-04-14 15:37:07 -06:00
vicrodh 2dc9c143d5 feat(award-catalog): seed editorial Qobuz awards across locales + diacritic-insensitive lookup
'Discoteca Ideal Qobuz' was not resolving because /award/explore
either doesn't list editorial Qobuz awards or returns them under a
different locale's label. Adds a hardcoded seed of the three
stable-id editorial awards (88 Qobuzissime, 151 Album of the Week,
70 Ideal Discography) with their Spanish/English/German/French/
Portuguese aliases so they resolve instantly regardless of the user's
Qobuz locale.

Name normalization now strips diacritics (NFD + combining chars) and
collapses whitespace so 'Discoteca Ideal Qobuz',
'Qobuz Ideal Discography' and 'Discothèque idéale Qobuz' all map to
the same id.

Seed runs first on every lookup (sync). /award/explore only kicks in
for press awards the seed doesn't know about, once per session.

cc
2026-04-14 15:24:45 -06:00
vicrodh 6a5f9d0901 feat(award): add See all link and dedicated AwardAlbumsView
AwardView now shows a single grid of the first 20 albums with a See
all link in the section header (visible only when there are more
albums behind it). Grid layout stays — no horizontal carousel.

Clicking See all navigates to a new 'award-albums' view
(AwardAlbumsView) with a full paginated list: header with kicker +
title, top-right search, virtualized grid with load-more. Same
structure as LabelReleasesView for visual consistency.

cc
2026-04-14 15:12:46 -06:00
vicrodh 854eaaa0a4 feat(award): resolve award id by name via /award/explore when /album/get omits it
/album/get's AwardDto has id: String? — Qobuz sometimes returns an
award entry with only a name and no id. Rather than disabling the
click or toasting, we look up the id in the Qobuz award catalog.

- Adds v2_get_award_explore (paginated /award/explore) all the way
  through qbz-qobuz → core → bridge → command → invoke_handler.
- New frontend awardCatalogStore caches the full (id, name) list
  lazily, one fetch per session, resolved on first click that needs
  it. Further clicks are instant.
- handleAwardClick goes straight to navigation when id is present,
  falls back to resolveAwardIdByName otherwise. Toast only fires if
  the name isn't in the catalog either (genuinely unknown award).

cc
2026-04-14 15:06:15 -06:00
vicrodh 9460838223 fix(album-sidebar): keep award card always clickable; toast if id missing
Previously disabled={!onAwardClick || !award.id} grayed out the award
card whenever /album/get returned an award entry without an id. User
reported the award was 'no longer clickable' on albums opened from the
artist page. Now the button always accepts clicks and the handler
shows a toast when no id is available instead of silently doing
nothing — keeps the affordance honest without sending 'null' to
/award/page.

cc
2026-04-14 14:51:54 -06:00