Commit Graph
719 Commits
Author SHA1 Message Date
vicrodh 318e3d795a feat(context): scroll to active track on context navigation
cx
2026-01-19 11:19:52 -06:00
vicrodh 78c4898edf fix(favorites): persist custom icon and sync modal state
cx
2026-01-19 11:11:17 -06:00
vicrodh 7831b07c30 feat(favorites): make tabs history-aware views and normalize order
cx
2026-01-19 11:11:03 -06:00
vicrodh b82abb145b fix: resolve Favorites tab navigation circular bug and prevent user clicks from triggering nav effect
cx
2026-01-18 16:32:13 -06:00
vicrodh 9c45a82fd8 fix(favorites): add debug logging for preferences loading
cp
2026-01-18 16:21:36 -06:00
vicrodh e752791d3a fix: correct async loading of favorites preferences and tab order
- Remove await from onMount (not async)
- Use .then() chain for proper async handling
- Initialize activeTab from preferences on mount
- Fixes tab order not persisting
- Fixes custom icon not displaying

cx
2026-01-18 16:17:30 -06:00
vicrodh 5e60de9970 fix(phase4): await favorites preferences load to preserve tab order
cp
2026-01-18 16:07:56 -06:00
vicrodh 4a6f09d5b9 fix(favorites): restore tab navigation functionality
Removed continuous  sync that was overriding user tab clicks.
Now only syncs activeTab with currentTab on initial mount to respect
configured first tab, then allows normal tab navigation.

cp
2026-01-18 16:02:10 -06:00
vicrodh ffb16656e7 feat(phase4.7): implement history-aware favorites tab navigation
- Extended navigationStore with FavoritesTab state tracking
- Added setFavoritesTab() to push tab changes to history
- Modified navigateTo() to support favorites sub-navigation
- Wired handleTabChange() to call setFavoritesTab()
- Synced activeTab with navigation store via currentTab prop
- Back button now returns to correct Favorites tab

cp
2026-01-18 15:52:31 -06:00
vicrodh 902705f47f fix(phase4): add icon_background column migration for existing databases
- Detect missing icon_background column in favorites_preferences table
- Add ALTER TABLE migration to preserve existing user data
- Apply migration in both FavoritesPreferencesStore::new() and create_table()

cx
2026-01-18 15:42:11 -06:00
vicrodh ad73b5d879 fix(phase4): adjust sticky nav top position to reach window edge
- Change top from 0 to -24px to account for container padding
- Ensures nav bar reaches top edge when scrolling
- clearCurrentSearch already collapses search correctly

cp
2026-01-18 15:31:44 -06:00
vicrodh 92486c3943 fix(phase4): sticky nav reaches top edge and search collapses on clear
- Remove negative top margin from .favorites-nav (was -24px, now 0)
- Update clearCurrentSearch() to collapse search when cleared
- Add hover state to clear button for better UX

cp
2026-01-18 15:28:07 -06:00
vicrodh a45806e4c4 fix(phase4): sticky nav now reaches top edge when scrolling
- Adjusted negative margins to cancel parent padding
- Matches Artist page sticky behavior
- Nav bar now fully sticks to window top

cp
2026-01-18 15:20:40 -06:00
vicrodh 88e0ef8e01 feat(phase4.5): implement Artist-style navigation bar
- Replaced button-style tabs with underlined navigation links
- Sticky navigation bar on scroll (top: 0, z-index: 4)
- Integrated searchbar in nav-right (icon → expandable input)
- Tab order respects user preferences (favoritesPreferences.tab_order)
- Active tab shows accent-colored bottom border (2px)
- Removed redundant search container section
- Matches Artist page and Settings page nav styles

cp
2026-01-18 15:12:58 -06:00
vicrodh 9269458d77 feat(phase4): add helper functions for tab navigation and search
- Added getCurrentSearchValue(), setCurrentSearchValue(), clearCurrentSearch()
- Added getTabIcon() and getTabLabel() helpers
- Added tabLabels constant
- Added searchExpanded state for collapsible search
- Preparation for Artist-style navigation bar (Phase 4.5)

cp
2026-01-18 15:11:42 -06:00
vicrodh 64bd4d729e feat(phase4.4): wire custom icon and background display
- Dynamic icon rendering (preset + custom upload)
- Background color/gradient applied to header icon
- Support for all preset icons (heart, star, music, folder, disc, library)
- Custom uploaded image display via asset protocol

cp
2026-01-18 15:08:44 -06:00
vicrodh 76c9a9653e feat(phase4.3): add custom gradient picker with 2-3 color support
- Expanded preset gradients (sunset, ocean, fire, mint, candy, forest)
- Added custom gradient builder (2-3 colors)
- Interactive color picker with add/remove controls
- Apply/Cancel actions for custom gradients

cp
2026-01-18 15:07:21 -06:00
vicrodh 3039cb5d37 fix(phase4.3): expand color grid to 12 columns with additional colors
- Add 3 more solid colors (cyan, rose, slate) for total of 11 solids
- Keep only sunset gradient (1 gradient)
- Change grid from 8 to 12 columns
- Ensures all colors fit in single row

cp
2026-01-18 15:02:28 -06:00
vicrodh df50eb1c8f fix(ui): reduce color grid gap to 2px
cp
2026-01-18 14:46:11 -06:00
vicrodh 2f163f36f5 fix(phase4.3): adjust modal centering and color swatch sizes
- Reduce modal width from 920px to 736px (80% of original)
- Center modal with 140px left offset (half sidebar width)
- Reduce color swatches from 40px to 30px
- Reduce color-grid gap from 8px to 4px
- Fix icon-preset button justify-content typo
- Swatches now properly fill single row

cp
2026-01-18 14:44:29 -06:00
vicrodh cdc4435306 fix(phase4.3): adjust modal width to 920px and limit color swatches to 40x40
- Reduce modal width by 20% (1150px → 920px)
- Add max-width/max-height constraints to color buttons (40px)
- Maintain aspect ratio and grid layout

cp
2026-01-18 14:37:56 -06:00
vicrodh 8607729013 fix(ui): adjust modal layout - 65/35 column split, smaller color swatches
- Changed modal columns from 50/50 to 65/35 split
- Reduced color picker grid gaps and increased density (8 columns)
- Adjusted color swatch border radius for consistency

cp
2026-01-18 14:19:51 -06:00
vicrodh 4009ae9b26 feat(phase4.3): add background color picker to favorites modal
- Add icon_background field to backend (Rust + TS types)
- Update modal to 60% wider (1150px)
- Implement two-column layout (icon left, tabs right)
- Add solid color picker (8 colors + none)
- Add gradient picker (6 gradients)
- Remove background from edit button to match PlaylistView style
- Update database migration for icon_background field

cp
2026-01-18 14:13:50 -06:00
vicrodh 5bd52cc89b feat(phase4.3): add favorites edit modal component
- Create FavoritesEditModal with preset icon grid
- Add custom image upload button
- Add tab reorder UI with up/down buttons
- Integrate edit button in Favorites page header (top-right)
- Add i18n keys for EN and ES
- Wire modal save handler to backend

cc
2026-01-18 14:02:37 -06:00
vicrodh a6aa6aa936 feat(phase4.2): add favorites preferences backend
- Create favorites_preferences.rs with FavoritesPreferences struct
- Add database table (custom_icon_path, custom_icon_preset, tab_order)
- Implement State wrapper and Tauri commands
- Register state and commands in lib.rs
- Default preset: heart, default order: tracks/albums/artists/playlists

cc
2026-01-18 13:57:17 -06:00
vicrodh d39180bd6c feat(ui): show playing status in search and artist tracks
cx
2026-01-18 05:46:57 -06:00
vicrodh c6f86a9bcc feat(ui): pause from track row playing icon
cx
2026-01-18 05:46:43 -06:00
vicrodh 407fab44db fix(ui): slow album card ticker speed
cx
2026-01-18 05:38:41 -06:00
vicrodh ed45fa4156 feat(ui): show volume value while dragging
cx
2026-01-18 05:38:32 -06:00
vicrodh 5a42df35a4 fix(ui): lock playlist import button after success
cx
2026-01-18 05:38:22 -06:00
vicrodh c67c479bac fix(ui): wire stack icon click and tooltip
cx
2026-01-18 05:33:00 -06:00
vicrodh c2628b0076 fix(config): align autoplay mode serialization
cx
2026-01-18 05:32:49 -06:00
vicrodh d96233730b fix(phase3): custom tooltip for context icon
- Replace native title with custom tooltip similar to DAC/EXC badges
- Add hover state and styled tooltip with context info
- Add debug logs to investigate onClick callback issue

cp
2026-01-18 04:58:35 -06:00
vicrodh 12067d7a61 fix(phase3): context navigation and autoplay persistence
- Fixed context navigation using correct property names (.type, .id)
- Simplified autoplay setting from radio buttons to toggle switch
- Fixed tooltip using native title attribute (like QualityBadge)
- Removed custom tooltip CSS and hover state
- Updated translations (en/es) for clearer autoplay behavior description

cp
2026-01-18 04:53:43 -06:00
vicrodh 315bdce79c fix(settings): reload playback preferences when view renders
- Added $effect to reload preferences each time SettingsView is visible
- Fixes autoplay mode not persisting when navigating away and back
- Settings view doesn't unmount, so onMount only runs once per session

cp
2026-01-18 04:38:15 -06:00
vicrodh b666722b98 debug: add detailed logging to loadPlaybackPreferences
cp
2026-01-18 04:34:54 -06:00
vicrodh 92f1644601 fix(context): add custom tooltip and pass onClick callback
- Implemented custom tooltip for StackIcon (similar to AudioOutputBadges)
- Shows 'Playing from', context name, and 'Click to navigate' hint
- Added onContextClick={handleContextNavigation} to ExpandedPlayer
- Fixed onClick prop not being passed, enabling navigation

cp
2026-01-18 04:34:42 -06:00
vicrodh 0feb1e1b4a debug: add detailed logging to StackIcon click handler
cp
2026-01-18 04:09:31 -06:00
vicrodh ae3a90d378 fix(i18n): add translations for playback preferences
Added translations for:
- Autoplay behavior setting
- Continue within source / Play only selected track options
- Show context icon setting and tooltip

Both English and Spanish translations added.

Changed StackIcon tooltip to use native browser title (matches QualityBadge style).
Removed arrow indicator from context icon (cursor change is sufficient).

cp
2026-01-18 04:09:20 -06:00
vicrodh 2a4f58cb08 fix(css): remove extra closing brace in ExpandedPlayer styles
Syntax error on line 568 - duplicate closing brace after .album rule

cp
2026-01-18 04:00:25 -06:00
vicrodh fdf288b01e fix(migration): robust database migration for show_context_icon
Problem:
- Users updating from previous versions would crash on startup
- Table created with new column caused "no column named show_context_icon" error
- Existing users had old schema without the column

Solution:
- Step 1: Create table with old schema (backwards compatible)
- Step 2: Check if show_context_icon column exists using pragma_table_info
- Step 3: Add column ONLY if it doesn't exist (safe migration)
- Step 4: Insert default row

This ensures:
✅ New installs work (table created fresh)
✅ Existing users migrate seamlessly (column added, settings preserved)
✅ No data loss
✅ Idempotent (can run multiple times safely)

Tested scenarios:
- Fresh install (no DB) → creates table, adds column, inserts defaults
  Result: id=1, autoplay_mode='continue', show_context_icon=1
- Existing DB without column → adds column, preserves user settings
  Result: id=1, autoplay_mode='track_only' (preserved), show_context_icon=1
- Existing DB with column → no changes (idempotent)

Migration logs added for debugging.

cp
2026-01-18 03:57:28 -06:00
vicrodh 584650fee1 feat(phase37): implement clickable context tooltip navigation
StackIcon Component:
- Now accepts onClick prop
- Changed from div to button element
- Added arrow (→) that appears on hover
- Tooltip text changed to "Click to go to: {source}"
- Visual feedback: hover background + active scale

Navigation Logic (+page.svelte):
- Added handleContextNavigation function
- Switch based on context_type:
  - album → handleAlbumClick
  - playlist → navigate + set selectedPlaylistId
  - artist_top → handleArtistClick
  - favorites → navigate to favorites
  - home_list → navigate to home
  - search → navigate to search
- Import getCurrentContext from playbackContextStore

UI Integration:
- ExpandedPlayer: Added onContextClick prop, passed to StackIcon
- FocusMode: Added onContextClick prop, passed to StackIcon
- Both receive handleContextNavigation callback

Phase 3.7 COMPLETE ✅

cp
2026-01-18 03:47:11 -06:00
vicrodh b070884ee8 feat(phase36): implement context icon visibility toggle (frontend + UI)
Frontend:
- Add show_context_icon to PlaybackPreferences interface
- Add setShowContextIcon function to store
- StackIcon now subscribes to preferences and checks show_context_icon
- Icon hidden when setting is false (context still tracked)

UI (Settings → Playback):
- Add toggle: "Show track playing context in player"
- Tooltip with bilingual explanation (EN/ES)
- Default: enabled (true)
- Persists across restarts

Context tracking ALWAYS active regardless of icon visibility.

Phase 3.6 COMPLETE ✅

cp
2026-01-18 03:40:19 -06:00
vicrodh dfd1eb588d feat(phase36): add show_context_icon setting (backend)
Database:
- Add show_context_icon column (INTEGER, default 1)
- Migration for existing databases

Backend:
- Add show_context_icon to PlaybackPreferences struct
- Default value: true (icon visible)
- Add set_show_context_icon method to store/state
- Add Tauri command: set_show_context_icon

Context tracking remains ALWAYS active regardless of icon visibility.

cp
2026-01-18 03:38:14 -06:00
vicrodh 640cf5db41 feat(phase35): implement context in HomeView
Context creation:
- Creates 'home_list' context for Continue Listening section
- Uses 'continue_listening' as ID and 'Continue Listening' as label
- Tracks user's listening history in a context
- Stack icon will show "Playing from: Continue Listening"

Home view now fully integrated with context system.

cp
2026-01-18 03:34:50 -06:00
vicrodh a473c969d9 feat(phase35): implement context in SearchView
Context creation:
- Creates 'search' context when playing track from results
- Uses search query as ID and 'Search: {query}' as label
- Applies to both All tab (first 6) and Tracks tab (full list)
- Stack icon will show "Playing from: Search · {query}"

Search view now fully integrated with context system.

cp
2026-01-18 03:33:23 -06:00
vicrodh e3ce6a3760 feat(phase35): implement context in FavoritesView
Context creation:
- Creates 'favorites' context when playing track
- Uses 'favorites' as ID and 'Favorites' as label
- Uses filteredTracks for context (respects search/filter)
- Stack icon will show "Playing from: Favorites"

Favorites view now fully integrated with context system.

cp
2026-01-18 03:31:25 -06:00
vicrodh 0bd60bbc8f feat(phase35): implement context in ArtistDetailView
Context creation:
- Creates 'artist_top' context when playing from Top Tracks
- Uses artist ID and name
- Passes track index from UI loop
- Stack icon will show "Playing from: Artist · {name}"

Artist view now fully integrated with context system.

cp
2026-01-18 03:30:47 -06:00
vicrodh ae478ddeb2 feat(phase35): implement context in PlaylistDetailView
Context creation:
- Creates 'playlist' context when playing track
- Uses playlist ID and name
- Filters out local tracks (Qobuz tracks only in context)
- Finds track index in Qobuz tracks list
- Stack icon will show "Playing from: Playlist · {name}"

Playlist view now fully integrated with context system.

cp
2026-01-18 03:29:33 -06:00
vicrodh fe80896fd2 feat(phase35): add helper for context creation with DisplayTrack
Added createContextAndPlayDisplayTrack helper that:
- Creates playback context with provided type/id/label/tracks
- Calls handleDisplayTrackPlay to start playback
- Will be used by Playlist, Artist, Favorites, Home views

Next: Implement context creation in each view component internally
(following AlbumDetailView pattern but keeping logic in views)

cp
2026-01-18 03:21:21 -06:00