mirror of
https://git.sr.ht/~joren/streamrip-go
synced 2026-10-16 13:57:25 +02:00
Duplicated helpers cmd/rip had its own copies of six helpers that already existed in internal/jsonutil: asString (StringFromAny), searchInt (IntFromAny), nestedSearchInt and nestedSearchString (NestedAny/NestedString), firstNonEmpty (FirstNonEmpty) and firstPositiveInt. firstPositiveInt was duplicated a third and fourth time in provider/yandex and provider/beatport, so it moves into jsonutil alongside the rest. jsonutil is back to 100% coverage. searchBool is deliberately left alone, with a comment saying why: it accepts only a real bool, and switching it to jsonutil.BoolFromAny would start coercing strings and numbers, changing how search results get labelled. config auto-upgrade is no longer destructive UpgradeOutdated re-serializes the whole config from the parsed struct, so any key this version does not know about is dropped, and it runs automatically from run() without prompting. It now copies the original to <path>.bak-<unixtime> (0600, since it holds the same credentials) and validates the result before writing. It returns the backup path so the CLI can tell the user where it went. The comment states plainly that this is a version stamp rather than a migration framework. cmd/rip tests The command bodies are testable now that they are functions returning exit codes rather than arms of a switch that called os.Exit. Covers the usage errors for every command, the quality floor on `rip id`, config path output, the --version flag, and that applyQualityOverride reaches all six sources and clamps only the two with a floor. cmd/rip coverage 17% -> 26%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
204 lines
4.6 KiB
Go
204 lines
4.6 KiB
Go
package jsonutil
|
|
|
|
import "testing"
|
|
|
|
func TestStringFromAny(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
in any
|
|
want string
|
|
}{
|
|
{"string", "hi", "hi"},
|
|
{"int", 7, "7"},
|
|
{"int64", int64(8), "8"},
|
|
{"float whole", float64(9), "9"},
|
|
{"float fractional", 44.1, "44.1"},
|
|
{"float no trailing zeroes", float64(100), "100"},
|
|
{"nil", nil, ""},
|
|
{"bool unsupported", true, ""},
|
|
{"map unsupported", map[string]any{}, ""},
|
|
}
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
if got := StringFromAny(tc.in); got != tc.want {
|
|
t.Fatalf("StringFromAny(%#v) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestIntFromAny(t *testing.T) {
|
|
tests := []struct {
|
|
in any
|
|
want int
|
|
}{
|
|
{5, 5},
|
|
{int32(6), 6},
|
|
{int64(7), 7},
|
|
{8.9, 8},
|
|
{"10", 10},
|
|
{" 11 ", 11},
|
|
{"not a number", 0},
|
|
{nil, 0},
|
|
{true, 0},
|
|
}
|
|
for _, tc := range tests {
|
|
if got := IntFromAny(tc.in); got != tc.want {
|
|
t.Errorf("IntFromAny(%#v) = %d, want %d", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestFloatFromAny(t *testing.T) {
|
|
tests := []struct {
|
|
in any
|
|
want float64
|
|
}{
|
|
{1.5, 1.5},
|
|
{2, 2},
|
|
{int64(3), 3},
|
|
{"4.5", 0}, // strings are deliberately not parsed here
|
|
{nil, 0},
|
|
}
|
|
for _, tc := range tests {
|
|
if got := FloatFromAny(tc.in); got != tc.want {
|
|
t.Errorf("FloatFromAny(%#v) = %v, want %v", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBoolFromAny(t *testing.T) {
|
|
tests := []struct {
|
|
in any
|
|
want bool
|
|
}{
|
|
{true, true},
|
|
{false, false},
|
|
{"true", true},
|
|
{"TRUE", true},
|
|
{" yes ", true},
|
|
{"1", true},
|
|
{"0", false},
|
|
{"no", false},
|
|
{1, true},
|
|
{0, false},
|
|
{int64(2), true},
|
|
{0.0, false},
|
|
{1.5, true},
|
|
{nil, false},
|
|
}
|
|
for _, tc := range tests {
|
|
if got := BoolFromAny(tc.in); got != tc.want {
|
|
t.Errorf("BoolFromAny(%#v) = %v, want %v", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestFirstNonEmpty(t *testing.T) {
|
|
if got := FirstNonEmpty("", " ", "found", "later"); got != "found" {
|
|
t.Errorf("got %q", got)
|
|
}
|
|
if got := FirstNonEmpty(" trimmed "); got != "trimmed" {
|
|
t.Errorf("got %q, want trimmed", got)
|
|
}
|
|
if got := FirstNonEmpty("", " "); got != "" {
|
|
t.Errorf("got %q, want empty", got)
|
|
}
|
|
if got := FirstNonEmpty(); got != "" {
|
|
t.Errorf("got %q, want empty", got)
|
|
}
|
|
}
|
|
|
|
func TestNestedMap(t *testing.T) {
|
|
m := map[string]any{"album": map[string]any{"title": "X"}, "n": 1}
|
|
if got := NestedMap(m, "album")["title"]; got != "X" {
|
|
t.Errorf("got %v", got)
|
|
}
|
|
if got := NestedMap(m, "missing"); len(got) != 0 {
|
|
t.Errorf("missing key should give empty map, got %v", got)
|
|
}
|
|
if got := NestedMap(m, "n"); len(got) != 0 {
|
|
t.Errorf("non-map value should give empty map, got %v", got)
|
|
}
|
|
}
|
|
|
|
func TestNestedAnyAndString(t *testing.T) {
|
|
m := map[string]any{
|
|
"album": map[string]any{
|
|
"artist": map[string]any{"name": "Nina Simone", "id": float64(42)},
|
|
},
|
|
}
|
|
if got := NestedString(m, "album", "artist", "name"); got != "Nina Simone" {
|
|
t.Errorf("got %q", got)
|
|
}
|
|
if got := NestedString(m, "album", "artist", "id"); got != "42" {
|
|
t.Errorf("numeric id = %q, want 42", got)
|
|
}
|
|
if got := NestedString(m, "album", "nope", "name"); got != "" {
|
|
t.Errorf("missing path = %q, want empty", got)
|
|
}
|
|
if got := NestedAny(m, "album", "artist", "name"); got != "Nina Simone" {
|
|
t.Errorf("got %v", got)
|
|
}
|
|
if got := NestedAny(m); got == nil {
|
|
t.Error("no keys should return the map itself")
|
|
}
|
|
// Traversing through a non-map must not panic.
|
|
if got := NestedAny(m, "album", "artist", "name", "deeper"); got != nil {
|
|
t.Errorf("over-deep path = %v, want nil", got)
|
|
}
|
|
}
|
|
|
|
func TestTitleCase(t *testing.T) {
|
|
tests := []struct{ in, want string }{
|
|
{"qobuz", "Qobuz"},
|
|
{"Tidal", "Tidal"},
|
|
{"", ""},
|
|
{"1st", "1st"},
|
|
{"ä", "ä"}, // only ASCII is uppercased
|
|
}
|
|
for _, tc := range tests {
|
|
if got := TitleCase(tc.in); got != tc.want {
|
|
t.Errorf("TitleCase(%q) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDisplayArtistNames(t *testing.T) {
|
|
tests := []struct {
|
|
in []string
|
|
want string
|
|
}{
|
|
{nil, ""},
|
|
{[]string{}, ""},
|
|
{[]string{"A"}, "A"},
|
|
{[]string{"A", "B"}, "A & B"},
|
|
{[]string{"A", "B", "C"}, "A, B & C"},
|
|
{[]string{"A", "B", "C", "D"}, "A, B, C & D"},
|
|
}
|
|
for _, tc := range tests {
|
|
if got := DisplayArtistNames(tc.in); got != tc.want {
|
|
t.Errorf("DisplayArtistNames(%v) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestFirstPositiveInt(t *testing.T) {
|
|
tests := []struct {
|
|
in []int
|
|
want int
|
|
}{
|
|
{nil, 0},
|
|
{[]int{0, 0}, 0},
|
|
{[]int{0, 5, 7}, 5},
|
|
{[]int{-3, 0, 2}, 2},
|
|
{[]int{9}, 9},
|
|
{[]int{-1}, 0},
|
|
}
|
|
for _, tc := range tests {
|
|
if got := FirstPositiveInt(tc.in...); got != tc.want {
|
|
t.Errorf("FirstPositiveInt(%v) = %d, want %d", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|