4 Commits

Author SHA1 Message Date
26c9d50fac implement native Deezer download/decrypt pipeline
Replace Deezer yt-dlp usage with native ARL session + media.get_url resolution, add BF_CBC_STRIPE decryption in downloader, and wire cipher-aware Deezer downloads through the main rip pipeline. Includes validation hardening and metadata/source-id improvements used by tagging flows.
2026-04-21 00:48:07 +02:00
0ba8faa943 improve CLI error semantics and soundcloud canonicalization
Auto-upgrade outdated configs on startup, add actionable SSL verification hints in rip error paths, and harden SoundCloud search/metadata with canonical URL handling and richer source IDs.
2026-04-20 15:16:59 +02:00
0748d5a325 improve lastfm playlist parity and fallback resolution
Queue resolved last.fm tracks as playlist media to preserve playlist semantics, and add a robust mirror-based parser fallback for last.fm temporary unavailable responses while keeping track order and duplicates.
2026-04-20 02:01:16 +02:00
47b754a216 harden deezer quality fallback and metadata handling
Improve Deezer full-quality mode behavior by returning explicit errors when yt-dlp mode fails with fallback disabled, parse structured API errors, and correctly map explicit_lyrics booleans into explicit tags.
2026-04-20 01:07:28 +02:00
16 changed files with 1296 additions and 247 deletions

View File

@@ -5,6 +5,7 @@ import (
"context" "context"
"database/sql" "database/sql"
"encoding/json" "encoding/json"
"errors"
"fmt" "fmt"
"html" "html"
"io" "io"
@@ -38,11 +39,24 @@ func main() {
} }
if gopts.command == "" { if gopts.command == "" {
fmt.Println("usage: rip <command>") fmt.Println("usage: rip <command>")
fmt.Println("commands: url, file, config, database, id, search, lastfm, soundcloud-smoke, qobuz-smoke, qobuz-rip-smoke, qobuz-convert-rip-smoke, qobuz-album-rip-smoke, qobuz-playlist-rip-smoke, qobuz-artist-rip-smoke, qobuz-label-rip-smoke, qobuz-search-smoke, tidal-search-smoke, tidal-metadata-smoke, tidal-video-smoke, tidal-rip-smoke, tidal-album-rip-smoke, tidal-playlist-rip-smoke, tidal-artist-rip-smoke") fmt.Println("commands: url, file, config, database, id, search, lastfm")
fmt.Println("tip: run `rip dev-help` to list developer smoke commands")
os.Exit(2) os.Exit(2)
} }
cfg, err := config.Load(gopts.configPath) cfg, err := config.Load(gopts.configPath)
if err != nil {
if errors.Is(err, config.ErrOutdatedConfig) {
resolvedPath, upErr := config.UpgradeOutdated(gopts.configPath)
if upErr != nil {
fmt.Fprintf(os.Stderr, "config error: %v\n", err)
fmt.Fprintf(os.Stderr, "config auto-upgrade failed: %v\n", upErr)
os.Exit(1)
}
fmt.Fprintf(os.Stderr, "config upgraded at %s\n", resolvedPath)
cfg, err = config.Load(gopts.configPath)
}
}
if err != nil { if err != nil {
fmt.Fprintf(os.Stderr, "config error: %v\n", err) fmt.Fprintf(os.Stderr, "config error: %v\n", err)
os.Exit(1) os.Exit(1)
@@ -57,6 +71,15 @@ func main() {
ctx := context.Background() ctx := context.Background()
switch os.Args[1] { switch os.Args[1] {
case "dev-help":
fmt.Println("developer smoke commands:")
fmt.Println(" soundcloud-smoke")
fmt.Println(" qobuz-smoke, qobuz-rip-smoke, qobuz-convert-rip-smoke")
fmt.Println(" qobuz-album-rip-smoke, qobuz-playlist-rip-smoke, qobuz-artist-rip-smoke, qobuz-label-rip-smoke")
fmt.Println(" qobuz-search-smoke")
fmt.Println(" tidal-search-smoke, tidal-metadata-smoke, tidal-video-smoke")
fmt.Println(" tidal-rip-smoke, tidal-album-rip-smoke, tidal-playlist-rip-smoke, tidal-artist-rip-smoke")
return
case "url": case "url":
if len(os.Args) < 3 { if len(os.Args) < 3 {
fmt.Println("usage: rip url <url...> [--force|--ignore-db]") fmt.Println("usage: rip url <url...> [--force|--ignore-db]")
@@ -94,11 +117,11 @@ func main() {
} }
if err = mainApp.Resolve(ctx); err != nil { if err = mainApp.Resolve(ctx); err != nil {
fmt.Fprintf(os.Stderr, "resolve error: %v\n", err) fmt.Fprintf(os.Stderr, "resolve error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
if err = mainApp.Rip(ctx); err != nil { if err = mainApp.Rip(ctx); err != nil {
fmt.Fprintf(os.Stderr, "rip error: %v\n", err) fmt.Fprintf(os.Stderr, "rip error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
fmt.Printf("url rip complete (%d item(s))\n", added) fmt.Printf("url rip complete (%d item(s))\n", added)
@@ -167,11 +190,11 @@ func main() {
} }
if err = mainApp.Resolve(ctx); err != nil { if err = mainApp.Resolve(ctx); err != nil {
fmt.Fprintf(os.Stderr, "resolve error: %v\n", err) fmt.Fprintf(os.Stderr, "resolve error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
if err = mainApp.Rip(ctx); err != nil { if err = mainApp.Rip(ctx); err != nil {
fmt.Fprintf(os.Stderr, "rip error: %v\n", err) fmt.Fprintf(os.Stderr, "rip error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
fmt.Printf("file rip complete (%d item(s))\n", added) fmt.Printf("file rip complete (%d item(s))\n", added)
@@ -318,11 +341,11 @@ func main() {
os.Exit(1) os.Exit(1)
} }
if err = mainApp.Resolve(ctx); err != nil { if err = mainApp.Resolve(ctx); err != nil {
fmt.Fprintf(os.Stderr, "resolve error: %v\n", err) fmt.Fprintf(os.Stderr, "resolve error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
if err = mainApp.Rip(ctx); err != nil { if err = mainApp.Rip(ctx); err != nil {
fmt.Fprintf(os.Stderr, "rip error: %v\n", err) fmt.Fprintf(os.Stderr, "rip error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
fmt.Printf("id rip complete: source=%s type=%s id=%s\n", source, mediaType, itemID) fmt.Printf("id rip complete: source=%s type=%s id=%s\n", source, mediaType, itemID)
@@ -349,6 +372,10 @@ func main() {
fmt.Fprintf(os.Stderr, "search option error: %v\n", err) fmt.Fprintf(os.Stderr, "search option error: %v\n", err)
os.Exit(2) os.Exit(2)
} }
if sopts.first && sopts.outputFile != "" {
fmt.Fprintln(os.Stderr, "cannot choose --first and --output-file together")
os.Exit(2)
}
if !isAllowedSearchSource(source) { if !isAllowedSearchSource(source) {
fmt.Fprintf(os.Stderr, "unsupported search source %q\n", source) fmt.Fprintf(os.Stderr, "unsupported search source %q\n", source)
os.Exit(2) os.Exit(2)
@@ -357,8 +384,8 @@ func main() {
fmt.Fprintf(os.Stderr, "unsupported media type %q\n", mediaType) fmt.Fprintf(os.Stderr, "unsupported media type %q\n", mediaType)
os.Exit(2) os.Exit(2)
} }
if source == "soundcloud" && mediaType != "track" { if source == "soundcloud" && mediaType != "track" && mediaType != "playlist" {
fmt.Fprintln(os.Stderr, "soundcloud search currently supports media type track only") fmt.Fprintln(os.Stderr, "soundcloud search currently supports media types track and playlist")
os.Exit(2) os.Exit(2)
} }
if sopts.query == "" { if sopts.query == "" {
@@ -448,11 +475,11 @@ func main() {
return return
} }
if err = mainApp.Resolve(ctx); err != nil { if err = mainApp.Resolve(ctx); err != nil {
fmt.Fprintf(os.Stderr, "resolve error: %v\n", err) fmt.Fprintf(os.Stderr, "resolve error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
if err = mainApp.Rip(ctx); err != nil { if err = mainApp.Rip(ctx); err != nil {
fmt.Fprintf(os.Stderr, "rip error: %v\n", err) fmt.Fprintf(os.Stderr, "rip error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
fmt.Printf("search download complete (%d item(s))\n", added) fmt.Printf("search download complete (%d item(s))\n", added)
@@ -502,11 +529,11 @@ func main() {
return return
} }
if err = mainApp.Resolve(ctx); err != nil { if err = mainApp.Resolve(ctx); err != nil {
fmt.Fprintf(os.Stderr, "resolve error: %v\n", err) fmt.Fprintf(os.Stderr, "resolve error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
if err = mainApp.Rip(ctx); err != nil { if err = mainApp.Rip(ctx); err != nil {
fmt.Fprintf(os.Stderr, "rip error: %v\n", err) fmt.Fprintf(os.Stderr, "rip error: %s\n", errorWithActionableHint(err, gopts))
os.Exit(1) os.Exit(1)
} }
fmt.Printf("search download complete (%d item(s))\n", added) fmt.Printf("search download complete (%d item(s))\n", added)
@@ -536,14 +563,31 @@ func main() {
} }
fmt.Printf("lastfm playlist: %s (%d tracks)\n", title, len(tracks)) fmt.Printf("lastfm playlist: %s (%d tracks)\n", title, len(tracks))
if err = queueLastFMTracks(ctx, mainApp, opts, tracks); err != nil { resolvedTracks, err := resolveLastFMTracks(ctx, mainApp, opts, tracks)
if err != nil {
fmt.Fprintf(os.Stderr, "lastfm resolve error: %v\n", err) fmt.Fprintf(os.Stderr, "lastfm resolve error: %v\n", err)
os.Exit(1) os.Exit(1)
} }
if len(mainApp.Pending) == 0 { if len(resolvedTracks) == 0 {
fmt.Println("no lastfm tracks resolved") fmt.Println("no lastfm tracks resolved")
return return
} }
playlistID := fmt.Sprintf("lastfm:%s", strings.ToLower(strings.ReplaceAll(title, " ", "_")))
refs := make([]app.PlaylistTrackRef, 0, len(resolvedTracks))
for _, item := range resolvedTracks {
refs = append(refs, app.PlaylistTrackRef{Source: item.Source, ID: item.ID})
}
if addErr := mainApp.AddMixedPlaylistByTrackRefs(ctx, playlistID, title, refs); addErr != nil {
fmt.Printf("playlist queue failed: err=%v\n", addErr)
fmt.Println("no lastfm playlists queued")
return
}
fmt.Printf("queued lastfm playlist: %s (%d tracks)\n", title, len(refs))
if len(refs) == 0 {
fmt.Println("no lastfm playlists queued")
return
}
if err = mainApp.Resolve(ctx); err != nil { if err = mainApp.Resolve(ctx); err != nil {
fmt.Fprintf(os.Stderr, "resolve error: %v\n", err) fmt.Fprintf(os.Stderr, "resolve error: %v\n", err)
os.Exit(1) os.Exit(1)
@@ -552,7 +596,7 @@ func main() {
fmt.Fprintf(os.Stderr, "rip error: %v\n", err) fmt.Fprintf(os.Stderr, "rip error: %v\n", err)
os.Exit(1) os.Exit(1)
} }
fmt.Printf("lastfm rip complete (%d track(s))\n", len(mainApp.Pending)) fmt.Printf("lastfm rip complete (%d track(s) across 1 playlist)\n", len(resolvedTracks))
case "soundcloud-smoke": case "soundcloud-smoke":
if len(os.Args) < 3 { if len(os.Args) < 3 {
fmt.Println("usage: rip soundcloud-smoke <soundcloud_url>") fmt.Println("usage: rip soundcloud-smoke <soundcloud_url>")
@@ -1288,6 +1332,21 @@ func applyGlobalConfigOverrides(cfg *config.Config, opts globalOptions) {
} }
} }
func errorWithActionableHint(err error, opts globalOptions) string {
if err == nil {
return ""
}
msg := err.Error()
if opts.noSSLVerify {
return msg
}
lower := strings.ToLower(msg)
if strings.Contains(lower, "x509") || strings.Contains(lower, "certificate") || strings.Contains(lower, "tls") || strings.Contains(lower, "ssl") {
return msg + " (hint: try again with --no-ssl-verify)"
}
return msg
}
func parseSmokeOptions(args []string, minQuality int, maxQuality int) (smokeOptions, error) { func parseSmokeOptions(args []string, minQuality int, maxQuality int) (smokeOptions, error) {
opts := smokeOptions{} opts := smokeOptions{}
for _, arg := range args { for _, arg := range args {
@@ -1355,10 +1414,18 @@ type lastFMTrack struct {
Artist string Artist string
} }
type resolvedLastFMTrack struct {
Source string
ID string
Query string
}
var ( var (
lastFMTitleTagsRe = regexp.MustCompile(`<a\s+href="[^"]+"\s+title="([^"]+)"`) lastFMTitleTagsRe = regexp.MustCompile(`<a\s+href="[^"]+"\s+title="([^"]+)"`)
lastFMTotalTracksRe = regexp.MustCompile(`data-playlisting-entry-count="(\d+)"`) lastFMTotalTracksRe = regexp.MustCompile(`data-playlisting-entry-count="(\d+)"`)
lastFMPlaylistTitleRe = regexp.MustCompile(`<h1 class="playlisting-playlist-header-title">([^<]+)</h1>`) lastFMPlaylistTitleRe = regexp.MustCompile(`<h1 class="playlisting-playlist-header-title">([^<]+)</h1>`)
lastFMMirrorTitleRe = regexp.MustCompile(`^Title:\s*(.+?)\s+\|`)
lastFMMirrorLinkTextRe = regexp.MustCompile(`\[([^\]]+)\]\(`)
errLastFMInvalidSource = "unsupported source" errLastFMInvalidSource = "unsupported source"
) )
@@ -1590,11 +1657,11 @@ func fetchLastFMPlaylist(ctx context.Context, verifySSL bool, playlistURL string
page1, err := fetchLastFMPlaylistPage(ctx, client, parsed, 1) page1, err := fetchLastFMPlaylistPage(ctx, client, parsed, 1)
if err != nil { if err != nil {
return "", nil, err return fetchLastFMPlaylistViaMirror(ctx, verifySSL, playlistURL)
} }
title, total, err := extractLastFMPlaylistInfo(page1) title, total, err := extractLastFMPlaylistInfo(page1)
if err != nil { if err != nil {
return "", nil, err return fetchLastFMPlaylistViaMirror(ctx, verifySSL, playlistURL)
} }
tracks := extractLastFMTitleArtistPairs(page1) tracks := extractLastFMTitleArtistPairs(page1)
if total <= len(tracks) || total <= 50 { if total <= len(tracks) || total <= 50 {
@@ -1622,6 +1689,76 @@ func fetchLastFMPlaylist(ctx context.Context, verifySSL bool, playlistURL string
return title, tracks, nil return title, tracks, nil
} }
func fetchLastFMPlaylistViaMirror(ctx context.Context, verifySSL bool, playlistURL string) (string, []lastFMTrack, error) {
client := netutil.NewHTTPClient(30*time.Second, verifySSL)
all := make([]lastFMTrack, 0, 200)
title := ""
for page := 1; page <= 50; page++ {
body, err := fetchLastFMPlaylistMirrorPage(ctx, client, playlistURL, page)
if err != nil {
if page == 1 {
return "", nil, err
}
break
}
pageTitle, tracks := extractLastFMTracksFromMirrorMarkdown(body)
if title == "" && strings.TrimSpace(pageTitle) != "" {
title = pageTitle
}
if len(tracks) == 0 {
break
}
all = append(all, tracks...)
if !strings.Contains(body, "Show more") {
break
}
}
if len(all) == 0 {
return "", nil, fmt.Errorf("could not parse playlist tracks from last.fm")
}
if strings.TrimSpace(title) == "" {
title = "Last.fm Playlist"
}
return title, all, nil
}
func fetchLastFMPlaylistMirrorPage(ctx context.Context, client *http.Client, playlistURL string, page int) (string, error) {
u, err := url.Parse(playlistURL)
if err != nil {
return "", err
}
if page > 1 {
q := u.Query()
q.Set("page", strconv.Itoa(page))
u.RawQuery = q.Encode()
}
raw := u.String()
raw = strings.TrimPrefix(raw, "https://")
raw = strings.TrimPrefix(raw, "http://")
mirrorURL := "https://r.jina.ai/http://" + raw
req, err := http.NewRequestWithContext(ctx, http.MethodGet, mirrorURL, nil)
if err != nil {
return "", err
}
req.Header.Set("User-Agent", "streamrip-go/0")
resp, err := client.Do(req)
if err != nil {
return "", err
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
return "", fmt.Errorf("lastfm mirror request failed: status %d", resp.StatusCode)
}
b, err := io.ReadAll(resp.Body)
if err != nil {
return "", err
}
return string(b), nil
}
func fetchLastFMPlaylistPage(ctx context.Context, client *http.Client, parsed *url.URL, page int) (string, error) { func fetchLastFMPlaylistPage(ctx context.Context, client *http.Client, parsed *url.URL, page int) (string, error) {
u := *parsed u := *parsed
if page > 1 { if page > 1 {
@@ -1680,21 +1817,70 @@ func extractLastFMTitleArtistPairs(page string) []lastFMTrack {
return out return out
} }
func queueLastFMTracks(ctx context.Context, mainApp *app.Main, opts lastFMOptions, tracks []lastFMTrack) error { func extractLastFMTracksFromMirrorMarkdown(md string) (string, []lastFMTrack) {
lines := strings.Split(strings.ReplaceAll(md, "\r\n", "\n"), "\n")
title := ""
tracks := make([]lastFMTrack, 0, 100)
for _, line := range lines {
line = strings.TrimSpace(line)
if title == "" {
if m := lastFMMirrorTitleRe.FindStringSubmatch(line); len(m) >= 2 {
title = strings.TrimSpace(html.UnescapeString(m[1]))
}
}
if !strings.HasPrefix(line, "|") || !strings.Contains(line, "Play track") {
continue
}
cols := splitMarkdownTableRow(line)
if len(cols) < 6 {
continue
}
trackName := markdownLinkText(cols[3])
artist := markdownLinkText(cols[4])
if strings.TrimSpace(trackName) == "" || strings.TrimSpace(artist) == "" {
continue
}
tracks = append(tracks, lastFMTrack{Title: html.UnescapeString(strings.TrimSpace(trackName)), Artist: html.UnescapeString(strings.TrimSpace(artist))})
}
return title, tracks
}
func splitMarkdownTableRow(line string) []string {
trimmed := strings.TrimSpace(line)
trimmed = strings.TrimPrefix(trimmed, "|")
trimmed = strings.TrimSuffix(trimmed, "|")
parts := strings.Split(trimmed, "|")
out := make([]string, 0, len(parts))
for _, p := range parts {
out = append(out, strings.TrimSpace(p))
}
return out
}
func markdownLinkText(cell string) string {
m := lastFMMirrorLinkTextRe.FindStringSubmatch(cell)
if len(m) >= 2 {
return m[1]
}
return strings.TrimSpace(cell)
}
func resolveLastFMTracks(ctx context.Context, mainApp *app.Main, opts lastFMOptions, tracks []lastFMTrack) ([]resolvedLastFMTrack, error) {
primary, err := mainApp.GetLoggedInProvider(ctx, opts.Source) primary, err := mainApp.GetLoggedInProvider(ctx, opts.Source)
if err != nil { if err != nil {
return fmt.Errorf("%s login error: %w", opts.Source, err) return nil, fmt.Errorf("%s login error: %w", opts.Source, err)
} }
var fallback provider.Client var fallback provider.Client
if opts.FallbackSource != "" && opts.FallbackSource != opts.Source { if opts.FallbackSource != "" && opts.FallbackSource != opts.Source {
fallback, err = mainApp.GetLoggedInProvider(ctx, opts.FallbackSource) fallback, err = mainApp.GetLoggedInProvider(ctx, opts.FallbackSource)
if err != nil { if err != nil {
return fmt.Errorf("%s login error: %w", opts.FallbackSource, err) return nil, fmt.Errorf("%s login error: %w", opts.FallbackSource, err)
} }
} }
found := 0 found := 0
failed := 0 failed := 0
resolved := make([]resolvedLastFMTrack, 0, len(tracks))
for i, tr := range tracks { for i, tr := range tracks {
query := strings.TrimSpace(tr.Title + " " + tr.Artist) query := strings.TrimSpace(tr.Title + " " + tr.Artist)
id, source, searchErr := searchLastFMTrack(ctx, opts, primary, fallback, query) id, source, searchErr := searchLastFMTrack(ctx, opts, primary, fallback, query)
@@ -1708,16 +1894,12 @@ func queueLastFMTracks(ctx context.Context, mainApp *app.Main, opts lastFMOption
fmt.Printf("[%d/%d] no result: %s\n", i+1, len(tracks), query) fmt.Printf("[%d/%d] no result: %s\n", i+1, len(tracks), query)
continue continue
} }
if err = mainApp.AddByID(ctx, source, "track", id); err != nil { resolved = append(resolved, resolvedLastFMTrack{Source: source, ID: id, Query: query})
failed++
fmt.Printf("[%d/%d] add failed: %s (%v)\n", i+1, len(tracks), query, err)
continue
}
found++ found++
fmt.Printf("[%d/%d] found: %s (%s)\n", i+1, len(tracks), query, source) fmt.Printf("[%d/%d] found: %s (%s)\n", i+1, len(tracks), query, source)
} }
fmt.Printf("lastfm resolve complete: %d found, %d failed\n", found, failed) fmt.Printf("lastfm resolve complete: %d found, %d failed\n", found, failed)
return nil return resolved, nil
} }
func fetchSoundcloudOEmbed(ctx context.Context, verifySSL bool, trackURL string) (map[string]any, error) { func fetchSoundcloudOEmbed(ctx context.Context, verifySSL bool, trackURL string) (map[string]any, error) {
@@ -2062,8 +2244,8 @@ func promptSearchInteractive(defaultLimit int) (string, string, searchOptions, e
fmt.Println("Invalid media type.") fmt.Println("Invalid media type.")
continue continue
} }
if source == "soundcloud" && mediaType != "track" { if source == "soundcloud" && mediaType != "track" && mediaType != "playlist" {
fmt.Println("SoundCloud search supports track only.") fmt.Println("SoundCloud search supports track and playlist only.")
continue continue
} }
@@ -2212,8 +2394,9 @@ func normalizeSearchResults(source, mediaType string, pages []map[string]any) []
id := asString(itm["id"]) id := asString(itm["id"])
title := asString(itm["title"]) title := asString(itm["title"])
artist := nestedSearchString(itm, "artist", "name") artist := nestedSearchString(itm, "artist", "name")
trackCount := searchInt(itm["tracks_count"])
if id != "" && title != "" { if id != "" && title != "" {
results = append(results, searchResult{ID: id, Title: title, Artist: artist}) results = append(results, searchResult{ID: id, Title: title, Artist: artist, TrackCount: trackCount})
} }
} }
} }

View File

@@ -1,6 +1,9 @@
package main package main
import "testing" import (
"errors"
"testing"
)
func TestParseFileInputJSONItems(t *testing.T) { func TestParseFileInputJSONItems(t *testing.T) {
content := []byte(`[ content := []byte(`[
@@ -166,3 +169,47 @@ func TestNormalizeCodecRejectsUnknown(t *testing.T) {
t.Fatalf("expected error for unsupported codec") t.Fatalf("expected error for unsupported codec")
} }
} }
func TestExtractLastFMTracksFromMirrorMarkdown(t *testing.T) {
md := `Title: My Playlist | user playlists | Last.fm
| Play | Image | Loved | Name | Artist name | Buy | Options | Duration |
| --- | --- | --- | --- | --- | --- | --- | --- |
| [Play track](https://x) | [img](https://i) | x | [Song A](https://a) | [Artist A](https://aa) | | | 3:00 |
| [Play track](https://x) | [img](https://i) | x | [Song B](https://b) | [Artist B](https://bb) | | | 4:00 |`
title, tracks := extractLastFMTracksFromMirrorMarkdown(md)
if title != "My Playlist" {
t.Fatalf("title = %q, want %q", title, "My Playlist")
}
if len(tracks) != 2 {
t.Fatalf("tracks len = %d, want 2", len(tracks))
}
if tracks[0].Title != "Song A" || tracks[0].Artist != "Artist A" {
t.Fatalf("unexpected first track: %+v", tracks[0])
}
}
func TestParseSearchArgsAllowsFirstAndOutputFileButCallerCanReject(t *testing.T) {
opts, err := parseSearchArgs([]string{"q", "--first", "--output-file", "/tmp/out.json"}, 20)
if err != nil {
t.Fatalf("parseSearchArgs() error = %v", err)
}
if !opts.first || opts.outputFile == "" {
t.Fatalf("expected first=true and output file set, got %+v", opts)
}
}
func TestErrorWithActionableHintForSSL(t *testing.T) {
err := errors.New("x509: certificate signed by unknown authority")
msg := errorWithActionableHint(err, globalOptions{})
if msg == err.Error() {
t.Fatalf("expected ssl hint in message")
}
}
func TestErrorWithActionableHintNoHintWhenDisabled(t *testing.T) {
err := errors.New("tls handshake failure")
msg := errorWithActionableHint(err, globalOptions{noSSLVerify: true})
if msg != err.Error() {
t.Fatalf("unexpected hint when noSSLVerify set")
}
}

1
go.mod
View File

@@ -24,6 +24,7 @@ require (
github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b // indirect github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b // indirect
github.com/ncruces/go-strftime v0.1.9 // indirect github.com/ncruces/go-strftime v0.1.9 // indirect
github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
golang.org/x/crypto v0.50.0 // indirect
golang.org/x/exp v0.0.0-20250620022241-b7579e27df2b // indirect golang.org/x/exp v0.0.0-20250620022241-b7579e27df2b // indirect
golang.org/x/sys v0.43.0 // indirect golang.org/x/sys v0.43.0 // indirect
golang.org/x/text v0.36.0 // indirect golang.org/x/text v0.36.0 // indirect

2
go.sum
View File

@@ -49,6 +49,8 @@ github.com/vbauerster/mpb/v8 v8.12.0/go.mod h1:V02YIuMVo301Y1VE9VtZlD8s84OMsk+EK
github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY= github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc= golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
golang.org/x/crypto v0.50.0 h1:zO47/JPrL6vsNkINmLoo/PH1gcxpls50DNogFvB5ZGI=
golang.org/x/crypto v0.50.0/go.mod h1:3muZ7vA7PBCE6xgPX7nkzzjiUq87kRItoJQM1Yo8S+Q=
golang.org/x/exp v0.0.0-20250620022241-b7579e27df2b h1:M2rDM6z3Fhozi9O7NWsxAkg/yqS/lQJ6PmkyIV3YP+o= golang.org/x/exp v0.0.0-20250620022241-b7579e27df2b h1:M2rDM6z3Fhozi9O7NWsxAkg/yqS/lQJ6PmkyIV3YP+o=
golang.org/x/exp v0.0.0-20250620022241-b7579e27df2b/go.mod h1:3//PLf8L/X+8b4vuAfHzxeRUl04Adcb341+IGKfnqS8= golang.org/x/exp v0.0.0-20250620022241-b7579e27df2b/go.mod h1:3//PLf8L/X+8b4vuAfHzxeRUl04Adcb341+IGKfnqS8=
golang.org/x/image v0.39.0 h1:skVYidAEVKgn8lZ602XO75asgXBgLj9G/FE3RbuPFww= golang.org/x/image v0.39.0 h1:skVYidAEVKgn8lZ602XO75asgXBgLj9G/FE3RbuPFww=

View File

@@ -36,6 +36,11 @@ type Main struct {
Media []media.Media Media []media.Media
} }
type PlaylistTrackRef struct {
Source string
ID string
}
type ripTrackOptions struct { type ripTrackOptions struct {
albumFolder string albumFolder string
albumEmbedCover string albumEmbedCover string
@@ -178,6 +183,78 @@ func (m *Main) AddByID(ctx context.Context, source, mediaType, id string) error
return nil return nil
} }
func (m *Main) AddPlaylistByTrackIDs(ctx context.Context, source, playlistID, playlistName string, trackIDs []string) error {
p, err := m.GetLoggedInProvider(ctx, source)
if err != nil {
return err
}
if strings.TrimSpace(playlistName) == "" {
playlistName = playlistID
}
ids := make([]string, 0, len(trackIDs))
for _, id := range trackIDs {
id = strings.TrimSpace(id)
if id != "" {
ids = append(ids, id)
}
}
if len(ids) == 0 {
return fmt.Errorf("playlist %q has no track ids", playlistName)
}
pending := media.PendingFunc{
ResolveFn: func(context.Context) (media.Media, error) {
metaItems := make([]any, 0, len(ids))
for _, id := range ids {
metaItems = append(metaItems, map[string]any{"id": id})
}
playlistMeta := map[string]any{
"name": playlistName,
"tracks": map[string]any{"items": metaItems},
}
return media.MediaFunc{RipFn: func(ctx context.Context) error {
if m.Config.Session.CLI.TextOutput {
m.logf("Downloading playlist: %s\n", playlistName)
}
return m.ripPlaylist(ctx, p, source, playlistID, playlistMeta)
}}, nil
},
}
m.Pending = append(m.Pending, pending)
return nil
}
func (m *Main) AddMixedPlaylistByTrackRefs(ctx context.Context, playlistID, playlistName string, refs []PlaylistTrackRef) error {
if strings.TrimSpace(playlistName) == "" {
playlistName = playlistID
}
valid := make([]PlaylistTrackRef, 0, len(refs))
for _, ref := range refs {
source := strings.TrimSpace(ref.Source)
id := strings.TrimSpace(ref.ID)
if source == "" || id == "" {
continue
}
valid = append(valid, PlaylistTrackRef{Source: source, ID: id})
}
if len(valid) == 0 {
return fmt.Errorf("playlist %q has no track refs", playlistName)
}
pending := media.PendingFunc{
ResolveFn: func(context.Context) (media.Media, error) {
return media.MediaFunc{RipFn: func(ctx context.Context) error {
if m.Config.Session.CLI.TextOutput {
m.logf("Downloading playlist: %s\n", playlistName)
}
return m.ripPlaylistMixed(ctx, playlistID, playlistName, valid)
}}, nil
},
}
m.Pending = append(m.Pending, pending)
return nil
}
func (m *Main) ripCollection(ctx context.Context, p provider.Client, source, kind, id string, meta map[string]any) error { func (m *Main) ripCollection(ctx context.Context, p provider.Client, source, kind, id string, meta map[string]any) error {
name := titleFromMetadata(meta, id) name := titleFromMetadata(meta, id)
if n := stringFromAny(meta["name"]); n != "" { if n := stringFromAny(meta["name"]); n != "" {
@@ -638,6 +715,56 @@ func (m *Main) ripPlaylist(ctx context.Context, p provider.Client, source, playl
return nil return nil
} }
func (m *Main) ripPlaylistMixed(ctx context.Context, playlistID, name string, refs []PlaylistTrackRef) error {
folder := filepath.Join(m.Config.Session.Downloads.Folder, naming.CleanName(name, naming.Config{
RestrictCharacters: m.Config.Session.Filepaths.RestrictCharacters,
TruncateTo: m.Config.Session.Filepaths.TruncateTo,
}))
total := len(refs)
m.logf("Playlist: %s (%d tracks)\n", name, total)
failures := 0
providerCache := map[string]provider.Client{}
getProvider := func(source string) (provider.Client, error) {
if p, ok := providerCache[source]; ok {
return p, nil
}
p, err := m.GetLoggedInProvider(ctx, source)
if err != nil {
return nil, err
}
providerCache[source] = p
return p, nil
}
for i, ref := range refs {
p, err := getProvider(ref.Source)
if err != nil {
failures++
m.logf("track failed: id=%s source=%s reason=%v\n", ref.ID, ref.Source, err)
continue
}
opts := ripTrackOptions{
albumFolder: folder,
index: i + 1,
total: total,
forPlaylist: true,
playlistName: name,
playlistPos: i + 1,
}
if err = m.ripTrack(ctx, p, ref.Source, ref.ID, "", opts); err != nil {
failures++
m.logf("track failed: id=%s source=%s reason=%v\n", ref.ID, ref.Source, err)
}
}
if failures > 0 {
m.logf("Playlist done with %d failed track(s)\n", failures)
}
return nil
}
func (m *Main) ripTrack(ctx context.Context, p provider.Client, source, id, fallbackTitle string, opts ripTrackOptions) error { func (m *Main) ripTrack(ctx context.Context, p provider.Client, source, id, fallbackTitle string, opts ripTrackOptions) error {
alreadyDownloaded, err := m.Store.IsDownloaded(ctx, source, id) alreadyDownloaded, err := m.Store.IsDownloaded(ctx, source, id)
if err == nil && alreadyDownloaded { if err == nil && alreadyDownloaded {
@@ -691,9 +818,19 @@ func (m *Main) ripTrack(ctx context.Context, p provider.Client, source, id, fall
if opts.total > 0 && (!m.Config.Session.CLI.ProgressBars || !m.Config.Session.CLI.TextOutput || !m.DL.ProgressEnabled()) { if opts.total > 0 && (!m.Config.Session.CLI.ProgressBars || !m.Config.Session.CLI.TextOutput || !m.DL.ProgressEnabled()) {
m.logf("[%d/%d] %s\n", opts.index, opts.total, filepath.Base(outPath)) m.logf("[%d/%d] %s\n", opts.index, opts.total, filepath.Base(outPath))
} }
if err = m.DL.File(ctx, d.URL, outPath); err != nil { downloadOnce := func() error {
if d.Source == "deezer" && strings.EqualFold(strings.TrimSpace(d.Cipher), "BF_CBC_STRIPE") {
trackID := d.TrackID
if strings.TrimSpace(trackID) == "" {
trackID = id
}
return m.DL.FileDeezerEncrypted(ctx, d.URL, outPath, trackID)
}
return m.DL.File(ctx, d.URL, outPath)
}
if err = downloadOnce(); err != nil {
m.logf("retry: %s (%v)\n", filepath.Base(outPath), err) m.logf("retry: %s (%v)\n", filepath.Base(outPath), err)
if err = m.DL.File(ctx, d.URL, outPath); err != nil { if err = downloadOnce(); err != nil {
_ = m.Store.MarkFailed(ctx, source, "track", id) _ = m.Store.MarkFailed(ctx, source, "track", id)
return fmt.Errorf("id=%s title=%q download: %w", id, title, err) return fmt.Errorf("id=%s title=%q download: %w", id, title, err)
} }
@@ -1098,10 +1235,20 @@ func buildTagMetadata(trackMeta map[string]any, title, source, trackID string, o
} }
sourceAlbumID := nestedString(trackMeta, "album", "id") sourceAlbumID := nestedString(trackMeta, "album", "id")
if sourceAlbumID == "" {
sourceAlbumID = stringFromAny(trackMeta["source_album_id"])
}
sourceArtistID := nestedString(trackMeta, "artist", "id") sourceArtistID := nestedString(trackMeta, "artist", "id")
if sourceArtistID == "" { if sourceArtistID == "" {
sourceArtistID = nestedString(trackMeta, "performer", "id") sourceArtistID = nestedString(trackMeta, "performer", "id")
} }
if sourceArtistID == "" {
sourceArtistID = stringFromAny(trackMeta["source_artist_id"])
}
sourceTrackID := trackID
if v := stringFromAny(trackMeta["source_track_id"]); v != "" {
sourceTrackID = v
}
return tag.Metadata{ return tag.Metadata{
Title: title, Title: title,
@@ -1124,7 +1271,7 @@ func buildTagMetadata(trackMeta map[string]any, title, source, trackID string, o
ReplaygainTrackPeak: trackPeak, ReplaygainTrackPeak: trackPeak,
ReplaygainAlbumPeak: albumPeak, ReplaygainAlbumPeak: albumPeak,
SourcePlatform: source, SourcePlatform: source,
SourceTrackID: trackID, SourceTrackID: sourceTrackID,
SourceAlbumID: sourceAlbumID, SourceAlbumID: sourceAlbumID,
SourceArtistID: sourceArtistID, SourceArtistID: sourceArtistID,
} }

View File

@@ -171,7 +171,7 @@ func Load(path string) (*Config, error) {
return nil, err return nil, err
} }
var data ConfigData data := DefaultConfigData()
if err = toml.Unmarshal(raw, &data); err != nil { if err = toml.Unmarshal(raw, &data); err != nil {
return nil, err return nil, err
} }
@@ -184,6 +184,27 @@ func Load(path string) (*Config, error) {
return &Config{Path: resolvedPath, File: data, Session: cloneConfigData(data)}, nil return &Config{Path: resolvedPath, File: data, Session: cloneConfigData(data)}, nil
} }
func UpgradeOutdated(path string) (string, error) {
resolvedPath, err := resolvePath(path)
if err != nil {
return "", err
}
raw, err := os.ReadFile(resolvedPath)
if err != nil {
return "", err
}
data := DefaultConfigData()
if err = toml.Unmarshal(raw, &data); err != nil {
return "", err
}
applyRuntimeDefaults(&data)
data.Misc.Version = CurrentConfigVersion
if err = saveConfigData(resolvedPath, data); err != nil {
return "", err
}
return resolvedPath, nil
}
func (c *Config) SaveFile() error { func (c *Config) SaveFile() error {
return saveConfigData(c.Path, c.File) return saveConfigData(c.Path, c.File)
} }

View File

@@ -53,6 +53,37 @@ func TestLoadOutdatedConfig(t *testing.T) {
} }
} }
func TestUpgradeOutdatedConfig(t *testing.T) {
tmpDir := t.TempDir()
path := filepath.Join(tmpDir, "config.toml")
data := DefaultConfigData()
data.Misc.Version = "1.0.0"
data.Downloads.Folder = filepath.Join(tmpDir, "Music")
if err := saveConfigData(path, data); err != nil {
t.Fatalf("saveConfigData() error = %v", err)
}
resolved, err := UpgradeOutdated(path)
if err != nil {
t.Fatalf("UpgradeOutdated() error = %v", err)
}
if resolved != path {
t.Fatalf("resolved path = %q, want %q", resolved, path)
}
cfg, err := Load(path)
if err != nil {
t.Fatalf("Load() after upgrade error = %v", err)
}
if cfg.File.Misc.Version != CurrentConfigVersion {
t.Fatalf("version = %q, want %q", cfg.File.Misc.Version, CurrentConfigVersion)
}
if cfg.File.Downloads.Folder != data.Downloads.Folder {
t.Fatalf("downloads folder changed unexpectedly")
}
}
func TestSessionCloneDoesNotAliasSlices(t *testing.T) { func TestSessionCloneDoesNotAliasSlices(t *testing.T) {
tmpDir := t.TempDir() tmpDir := t.TempDir()
path := filepath.Join(tmpDir, "config.toml") path := filepath.Join(tmpDir, "config.toml")

View File

@@ -3,12 +3,15 @@ package download
import ( import (
"bufio" "bufio"
"context" "context"
"crypto/cipher"
"crypto/md5"
"fmt" "fmt"
"io" "io"
"net/http" "net/http"
"os" "os"
"os/exec" "os/exec"
"path/filepath" "path/filepath"
"strconv"
"strings" "strings"
"sync/atomic" "sync/atomic"
@@ -17,6 +20,8 @@ import (
"golang.org/x/term" "golang.org/x/term"
"streamrip-go/internal/netutil" "streamrip-go/internal/netutil"
"golang.org/x/crypto/blowfish"
) )
type Downloader struct { type Downloader struct {
@@ -56,6 +61,33 @@ func (d *Downloader) FileVideo(ctx context.Context, sourceURL, outputPath string
return d.file(ctx, sourceURL, outputPath, true, true) return d.file(ctx, sourceURL, outputPath, true, true)
} }
func (d *Downloader) FileDeezerEncrypted(ctx context.Context, sourceURL, outputPath, trackID string) error {
if err := os.MkdirAll(filepath.Dir(outputPath), 0o755); err != nil {
return err
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, sourceURL, nil)
if err != nil {
return err
}
resp, err := d.http.Do(req)
if err != nil {
return err
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode != http.StatusOK {
return fmt.Errorf("download failed: status=%d", resp.StatusCode)
}
encrypted, err := io.ReadAll(resp.Body)
if err != nil {
return err
}
plain, err := decryptDeezerBFCBCStripe(encrypted, trackID)
if err != nil {
return err
}
return os.WriteFile(outputPath, plain, 0o644)
}
func (d *Downloader) file(ctx context.Context, sourceURL, outputPath string, allowProgress bool, includeVideo bool) error { func (d *Downloader) file(ctx context.Context, sourceURL, outputPath string, allowProgress bool, includeVideo bool) error {
if err := os.MkdirAll(filepath.Dir(outputPath), 0o755); err != nil { if err := os.MkdirAll(filepath.Dir(outputPath), 0o755); err != nil {
return err return err
@@ -204,3 +236,60 @@ func isManifestResponse(contentType string, peek []byte) bool {
} }
return false return false
} }
const deezerBFChunkSize = 2048
var deezerBFIV = []byte{0, 1, 2, 3, 4, 5, 6, 7}
func decryptDeezerBFCBCStripe(in []byte, trackID string) ([]byte, error) {
block, err := blowfish.NewCipher(deriveDeezerBlowfishKey(trackID))
if err != nil {
return nil, err
}
out := make([]byte, len(in))
for i := 0; i*deezerBFChunkSize < len(in); i++ {
start := i * deezerBFChunkSize
end := start + deezerBFChunkSize
if end > len(in) {
end = len(in)
}
chunk := in[start:end]
if i%3 == 0 && len(chunk) == deezerBFChunkSize {
dec := make([]byte, len(chunk))
mode := cipher.NewCBCDecrypter(block, deezerBFIV)
mode.CryptBlocks(dec, chunk)
copy(out[start:end], dec)
} else {
copy(out[start:end], chunk)
}
}
return out, nil
}
func deriveDeezerBlowfishKey(trackID string) []byte {
sum := md5.Sum([]byte(trackID))
md5Hex := fmt.Sprintf("%x", sum)
secret := "g4el58wc0zvf9na1"
key := make([]byte, 16)
for i := 0; i < 16; i++ {
key[i] = md5Hex[i] ^ md5Hex[i+16] ^ secret[i]
}
return key
}
func normalizeDeezerTrackID(raw string) string {
trimmed := strings.TrimSpace(raw)
if trimmed == "" {
return ""
}
if _, err := strconv.Atoi(trimmed); err == nil {
return trimmed
}
parts := strings.Split(strings.Trim(trimmed, "/"), "/")
for i := len(parts) - 1; i >= 0; i-- {
if _, err := strconv.Atoi(parts[i]); err == nil {
return parts[i]
}
}
return trimmed
}

View File

@@ -2,11 +2,14 @@ package download
import ( import (
"context" "context"
"crypto/cipher"
"net/http" "net/http"
"net/http/httptest" "net/http/httptest"
"os" "os"
"path/filepath" "path/filepath"
"testing" "testing"
"golang.org/x/crypto/blowfish"
) )
func TestDownloaderHasNoClientTimeout(t *testing.T) { func TestDownloaderHasNoClientTimeout(t *testing.T) {
@@ -51,3 +54,33 @@ func TestManifestDetection(t *testing.T) {
t.Fatalf("did not expect flac to be manifest") t.Fatalf("did not expect flac to be manifest")
} }
} }
func TestNormalizeDeezerTrackID(t *testing.T) {
if got := normalizeDeezerTrackID("https://www.deezer.com/track/3135556"); got != "3135556" {
t.Fatalf("normalize track id = %q, want 3135556", got)
}
}
func TestDecryptDeezerBFCBCStripe(t *testing.T) {
trackID := "3135556"
plain := make([]byte, deezerBFChunkSize*2)
for i := range plain {
plain[i] = byte(i % 251)
}
enc := make([]byte, len(plain))
copy(enc, plain)
block, err := blowfish.NewCipher(deriveDeezerBlowfishKey(trackID))
if err != nil {
t.Fatalf("cipher error: %v", err)
}
cbc := cipher.NewCBCEncrypter(block, deezerBFIV)
cbc.CryptBlocks(enc[:deezerBFChunkSize], enc[:deezerBFChunkSize])
dec, err := decryptDeezerBFCBCStripe(enc, trackID)
if err != nil {
t.Fatalf("decrypt error: %v", err)
}
if len(dec) != len(plain) || string(dec) != string(plain) {
t.Fatalf("decrypted data mismatch")
}
}

View File

@@ -8,7 +8,6 @@ import (
"io" "io"
"net/http" "net/http"
"net/url" "net/url"
"os/exec"
"strconv" "strconv"
"strings" "strings"
"time" "time"
@@ -19,17 +18,24 @@ import (
"streamrip-go/internal/ratelimit" "streamrip-go/internal/ratelimit"
) )
var baseURL = "https://api.deezer.com" var (
baseURL = "https://api.deezer.com"
type commandRunner func(ctx context.Context, name string, args ...string) ([]byte, error) webGWLight = "https://www.deezer.com/ajax/gw-light.php"
mediaURL = "https://media.deezer.com/v1/get_url"
deezerUA = "Deezer/9.0.11.4 (Android; 14; Mobile; us) Xiaomi Redmi Note 7"
)
type Client struct { type Client struct {
cfg *config.Config cfg *config.Config
http *http.Client http *http.Client
limiter *ratelimit.Limiter limiter *ratelimit.Limiter
loggedIn bool loggedIn bool
bin string sid string
run commandRunner arl string
jwt string
refresh string
license string
userID string
} }
func New(cfg *config.Config) *Client { func New(cfg *config.Config) *Client {
@@ -37,8 +43,7 @@ func New(cfg *config.Config) *Client {
cfg: cfg, cfg: cfg,
http: netutil.NewHTTPClient(30*time.Second, cfg.Session.Downloads.VerifySSL), http: netutil.NewHTTPClient(30*time.Second, cfg.Session.Downloads.VerifySSL),
limiter: ratelimit.New(cfg.Session.Downloads.RequestsPerMinute), limiter: ratelimit.New(cfg.Session.Downloads.RequestsPerMinute),
bin: "yt-dlp", arl: strings.TrimSpace(cfg.Session.Deezer.ARL),
run: runCommand,
} }
} }
@@ -46,7 +51,13 @@ func (c *Client) Source() string {
return "deezer" return "deezer"
} }
func (c *Client) Login(context.Context) error { func (c *Client) Login(ctx context.Context) error {
c.arl = strings.TrimSpace(c.cfg.Session.Deezer.ARL)
if c.arl != "" {
if err := c.refreshSessionFromARL(ctx); err != nil {
return err
}
}
c.loggedIn = true c.loggedIn = true
return nil return nil
} }
@@ -165,158 +176,38 @@ func (c *Client) GetMetadata(ctx context.Context, item, mediaType string) (map[s
} }
func (c *Client) GetDownloadable(ctx context.Context, item string, _ int) (*provider.Downloadable, error) { func (c *Client) GetDownloadable(ctx context.Context, item string, _ int) (*provider.Downloadable, error) {
if strings.TrimSpace(c.arl) == "" {
return nil, errors.New("deezer native download requires deezer.arl in config")
}
if strings.TrimSpace(c.license) == "" {
if err := c.refreshSessionFromARL(ctx); err != nil {
return nil, err
}
}
meta, err := c.GetMetadata(ctx, item, "track") meta, err := c.GetMetadata(ctx, item, "track")
if err != nil { if err != nil {
return nil, err return nil, err
} }
if c.shouldTryYtDlp() { trackToken := strings.TrimSpace(stringFromAny(meta["track_token"]))
d, dlErr := c.getDownloadableViaYtDlp(ctx, item, meta) if trackToken == "" {
if dlErr == nil { trackToken, err = c.getTrackToken(ctx, item)
return d, nil
}
if !c.cfg.Session.Deezer.LowerQualityIfNotAvailable {
return nil, dlErr
}
}
preview := strings.TrimSpace(stringFromAny(meta["preview"]))
if preview == "" {
return nil, errors.New("deezer track missing preview url")
}
return &provider.Downloadable{URL: preview, Extension: "mp3", Source: "deezer"}, nil
}
func (c *Client) shouldTryYtDlp() bool {
if c.cfg == nil {
return false
}
if c.cfg.Session.Deezer.UseDeezloader {
return true
}
return strings.TrimSpace(c.cfg.Session.Deezer.ARL) != ""
}
func (c *Client) getDownloadableViaYtDlp(ctx context.Context, trackID string, meta map[string]any) (*provider.Downloadable, error) {
if _, err := exec.LookPath(c.bin); err != nil {
return nil, fmt.Errorf("yt-dlp not found for deezer full-quality mode: %w", err)
}
target := strings.TrimSpace(stringFromAny(meta["link"]))
if target == "" {
target = "https://www.deezer.com/track/" + trackID
}
args := []string{"-J", "--no-playlist", "--skip-download", "--no-warnings"}
if arl := strings.TrimSpace(c.cfg.Session.Deezer.ARL); arl != "" {
args = append(args, "--add-header", "Cookie: arl="+arl)
}
args = append(args, target)
b, err := c.run(ctx, c.bin, args...)
if err != nil { if err != nil {
return nil, err return nil, err
} }
info := map[string]any{} }
if err = json.Unmarshal(b, &info); err != nil { media, err := c.getMediaURL(ctx, trackToken, c.cfg.Session.Deezer.Quality, c.cfg.Session.Deezer.LowerQualityIfNotAvailable)
if err != nil {
return nil, err return nil, err
} }
f := selectDeezerFormat(info, c.cfg.Session.Deezer.Quality) ext := extensionForFormat(media.Format)
if f.url == "" {
return nil, errors.New("yt-dlp output missing downloadable format url")
}
ext := f.ext
if ext == "" { if ext == "" {
ext = "mp3" ext = "mp3"
} }
return &provider.Downloadable{URL: f.url, Extension: ext, Source: "deezer"}, nil trackID := strings.TrimSpace(stringFromAny(meta["id"]))
} if trackID == "" {
trackID = strings.TrimSpace(item)
type deezerFormat struct {
url string
ext string
abr int
}
func selectDeezerFormat(info map[string]any, quality int) deezerFormat {
formats, _ := info["formats"].([]any)
selected := deezerFormat{}
pick := func(candidate deezerFormat, better func(cur, next deezerFormat) bool) {
if candidate.url == "" {
return
} }
if selected.url == "" || better(selected, candidate) { return &provider.Downloadable{URL: media.URL, Extension: ext, Source: "deezer", Cipher: media.Cipher, TrackID: trackID}, nil
selected = candidate
}
}
for _, raw := range formats {
m, ok := raw.(map[string]any)
if !ok {
continue
}
if strings.TrimSpace(stringFromAny(m["vcodec"])) != "none" {
continue
}
cand := deezerFormat{
url: strings.TrimSpace(stringFromAny(m["url"])),
ext: strings.TrimSpace(stringFromAny(m["ext"])),
abr: intFromAny(m["abr"]),
}
if quality >= 2 {
pick(cand, func(cur, next deezerFormat) bool {
curFlac := strings.EqualFold(cur.ext, "flac")
nextFlac := strings.EqualFold(next.ext, "flac")
if curFlac != nextFlac {
return nextFlac
}
return next.abr > cur.abr
})
continue
}
if quality == 1 {
pick(cand, func(cur, next deezerFormat) bool {
curScore := abrScore(cur.abr, 320)
nextScore := abrScore(next.abr, 320)
if curScore == nextScore {
return next.abr > cur.abr
}
return nextScore > curScore
})
continue
}
pick(cand, func(cur, next deezerFormat) bool {
curScore := abrScore(cur.abr, 128)
nextScore := abrScore(next.abr, 128)
if curScore == nextScore {
if cur.abr == 0 {
return next.abr > 0
}
if next.abr == 0 {
return false
}
return next.abr < cur.abr
}
return nextScore > curScore
})
}
if selected.url != "" {
return selected
}
rootURL := strings.TrimSpace(stringFromAny(info["url"]))
if rootURL == "" {
return deezerFormat{}
}
return deezerFormat{url: rootURL, ext: strings.TrimSpace(stringFromAny(info["ext"])), abr: intFromAny(info["abr"])}
}
func abrScore(abr int, target int) int {
if abr <= 0 {
return -1
}
if abr > target {
return target - (abr-target)*2
}
return abr
} }
func (c *Client) apiGet(ctx context.Context, path string, params url.Values) (map[string]any, error) { func (c *Client) apiGet(ctx context.Context, path string, params url.Values) (map[string]any, error) {
@@ -352,12 +243,240 @@ func (c *Client) apiGet(ctx context.Context, path string, params url.Values) (ma
if resp.StatusCode < 200 || resp.StatusCode >= 300 { if resp.StatusCode < 200 || resp.StatusCode >= 300 {
return nil, fmt.Errorf("deezer api failed: status=%d body=%s", resp.StatusCode, string(body)) return nil, fmt.Errorf("deezer api failed: status=%d body=%s", resp.StatusCode, string(body))
} }
if e := stringFromAny(out["error"]); e != "" { if errObj, ok := out["error"].(map[string]any); ok {
return nil, fmt.Errorf("deezer api error: %s", e) msg := strings.TrimSpace(stringFromAny(errObj["message"]))
if msg == "" {
msg = strings.TrimSpace(stringFromAny(errObj["type"]))
}
if msg == "" {
msg = "unknown deezer error"
}
return nil, fmt.Errorf("deezer api error: %s", msg)
} }
return out, nil return out, nil
} }
func (c *Client) refreshSessionFromARL(ctx context.Context) error {
if strings.TrimSpace(c.arl) == "" {
return errors.New("missing deezer arl")
}
if err := c.limiter.Wait(ctx); err != nil {
return err
}
params := url.Values{}
params.Set("method", "deezer.getUserData")
params.Set("input", "3")
params.Set("api_version", "1.0")
params.Set("api_token", "")
req, err := http.NewRequestWithContext(ctx, http.MethodGet, webGWLight+"?"+params.Encode(), nil)
if err != nil {
return err
}
req.Header.Set("User-Agent", deezerUA)
req.Header.Set("Accept", "application/json")
req.Header.Set("Cookie", "arl="+strings.TrimSpace(c.arl))
resp, err := c.http.Do(req)
if err != nil {
return err
}
defer func() { _ = resp.Body.Close() }()
raw, err := io.ReadAll(resp.Body)
if err != nil {
return err
}
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
return fmt.Errorf("deezer getUserData failed: status=%d body=%s", resp.StatusCode, string(raw))
}
out := map[string]any{}
if err = json.Unmarshal(raw, &out); err != nil {
return err
}
if errObj, ok := out["error"].(map[string]any); ok && len(errObj) > 0 {
return fmt.Errorf("deezer getUserData error: %s", stringFromAny(errObj["message"]))
}
results, _ := out["results"].(map[string]any)
if len(results) == 0 {
return errors.New("deezer getUserData returned empty results")
}
c.license = findStringByKey(results, "license_token")
c.userID = findStringByKey(results, "USER_ID")
if c.license == "" {
return errors.New("deezer getUserData missing license_token")
}
return nil
}
func (c *Client) getTrackToken(ctx context.Context, trackID string) (string, error) {
resp, err := c.apiGet(ctx, "/track/"+url.PathEscape(strings.TrimSpace(trackID)), nil)
if err != nil {
return "", err
}
token := strings.TrimSpace(stringFromAny(resp["track_token"]))
if token == "" {
return "", errors.New("deezer track metadata missing track_token")
}
return token, nil
}
type mediaResult struct {
URL string
Format string
Cipher string
}
func (c *Client) getMediaURL(ctx context.Context, trackToken string, quality int, allowFallback bool) (*mediaResult, error) {
requestedFormats := buildFormatPriority(quality, allowFallback)
var lastErr error
for _, format := range requestedFormats {
result, err := c.getMediaURLForFormat(ctx, trackToken, format)
if err == nil {
return result, nil
}
lastErr = err
if !allowFallback {
break
}
}
if lastErr != nil {
return nil, lastErr
}
return nil, errors.New("deezer media response contains no playable variants")
}
func (c *Client) getMediaURLForFormat(ctx context.Context, trackToken, format string) (*mediaResult, error) {
if strings.TrimSpace(c.license) == "" {
return nil, errors.New("missing deezer license token")
}
if err := c.limiter.Wait(ctx); err != nil {
return nil, err
}
reqBody := map[string]any{
"license_token": c.license,
"track_tokens": []string{trackToken},
"media": []map[string]any{{
"type": "FULL",
"formats": []map[string]string{{"cipher": "BF_CBC_STRIPE", "format": format}, {"cipher": "NONE", "format": format}},
}},
}
b, err := json.Marshal(reqBody)
if err != nil {
return nil, err
}
req, err := http.NewRequestWithContext(ctx, http.MethodPost, mediaURL, strings.NewReader(string(b)))
if err != nil {
return nil, err
}
req.Header.Set("User-Agent", deezerUA)
req.Header.Set("Accept", "*/*")
req.Header.Set("Content-Type", "text/plain; charset=UTF-8")
resp, err := c.http.Do(req)
if err != nil {
return nil, err
}
defer func() { _ = resp.Body.Close() }()
raw, err := io.ReadAll(resp.Body)
if err != nil {
return nil, err
}
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
return nil, fmt.Errorf("deezer media get_url failed: status=%d body=%s", resp.StatusCode, string(raw))
}
var parsed struct {
Data []struct {
Errors []struct {
Code int `json:"code"`
Message string `json:"message"`
} `json:"errors"`
Media []struct {
Cipher struct {
Type string `json:"type"`
} `json:"cipher"`
Format string `json:"format"`
Sources []struct {
URL string `json:"url"`
} `json:"sources"`
} `json:"media"`
} `json:"data"`
}
if err = json.Unmarshal(raw, &parsed); err != nil {
return nil, err
}
if len(parsed.Data) == 0 {
return nil, errors.New("deezer media response contains no data")
}
if len(parsed.Data[0].Errors) > 0 {
e := parsed.Data[0].Errors[0]
if strings.Contains(strings.ToLower(e.Message), "drm") {
return nil, errors.New("deezer media is DRM protected for this format/account")
}
return nil, fmt.Errorf("deezer media error %d: %s", e.Code, e.Message)
}
for _, m := range parsed.Data[0].Media {
if len(m.Sources) == 0 || strings.TrimSpace(m.Sources[0].URL) == "" {
continue
}
return &mediaResult{URL: m.Sources[0].URL, Format: m.Format, Cipher: m.Cipher.Type}, nil
}
return nil, errors.New("deezer media response contains no sources")
}
func buildFormatPriority(quality int, allowFallback bool) []string {
want := "FLAC"
if quality <= 0 {
want = "MP3_128"
} else if quality == 1 {
want = "MP3_320"
}
priority := []string{want}
if allowFallback {
for _, f := range []string{"FLAC", "MP3_320", "MP3_128"} {
if f != want {
priority = append(priority, f)
}
}
}
return priority
}
func extensionForFormat(format string) string {
switch strings.ToUpper(strings.TrimSpace(format)) {
case "FLAC":
return "flac"
case "MP3_320", "MP3_128", "MP3_64", "MP3_MISC":
return "mp3"
default:
return "mp3"
}
}
func findStringByKey(v any, wantedKey string) string {
w := strings.ToLower(strings.TrimSpace(wantedKey))
switch x := v.(type) {
case map[string]any:
for k, value := range x {
if strings.ToLower(k) == w {
if s := stringFromAny(value); strings.TrimSpace(s) != "" {
return s
}
}
if nested := findStringByKey(value, wantedKey); nested != "" {
return nested
}
}
case []any:
for _, item := range x {
if nested := findStringByKey(item, wantedKey); nested != "" {
return nested
}
}
}
return ""
}
func enrichTrack(track map[string]any) { func enrichTrack(track map[string]any) {
if artist, ok := track["artist"].(map[string]any); ok { if artist, ok := track["artist"].(map[string]any); ok {
track["performer"] = map[string]any{"name": stringFromAny(artist["name"]), "id": stringFromAny(artist["id"])} track["performer"] = map[string]any{"name": stringFromAny(artist["name"]), "id": stringFromAny(artist["id"])}
@@ -375,7 +494,7 @@ func enrichTrack(track map[string]any) {
track["media_number"] = d track["media_number"] = d
} }
} }
if v := stringFromAny(track["explicit_lyrics"]); v == "true" { if boolFromAny(track["explicit_lyrics"]) {
track["explicit"] = true track["explicit"] = true
} }
} }
@@ -441,11 +560,7 @@ func intFromAny(v any) int {
} }
} }
func runCommand(ctx context.Context, name string, args ...string) ([]byte, error) { func boolFromAny(v any) bool {
cmd := exec.CommandContext(ctx, name, args...) b, ok := v.(bool)
b, err := cmd.CombinedOutput() return ok && b
if err != nil {
return nil, fmt.Errorf("command %s failed: %w: %s", name, err, string(b))
}
return b, nil
} }

View File

@@ -5,6 +5,7 @@ import (
"encoding/json" "encoding/json"
"net/http" "net/http"
"net/http/httptest" "net/http/httptest"
"strings"
"testing" "testing"
"streamrip-go/internal/config" "streamrip-go/internal/config"
@@ -12,12 +13,11 @@ import (
func TestSearchTrack(t *testing.T) { func TestSearchTrack(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch r.URL.Path { if r.URL.Path == "/search/track" {
case "/search/track":
_ = json.NewEncoder(w).Encode(map[string]any{"data": []any{map[string]any{"id": 1, "title": "Dreams", "artist": map[string]any{"name": "Fleetwood Mac"}}}}) _ = json.NewEncoder(w).Encode(map[string]any{"data": []any{map[string]any{"id": 1, "title": "Dreams", "artist": map[string]any{"name": "Fleetwood Mac"}}}})
default: return
w.WriteHeader(http.StatusNotFound)
} }
w.WriteHeader(http.StatusNotFound)
})) }))
defer ts.Close() defer ts.Close()
@@ -25,9 +25,9 @@ func TestSearchTrack(t *testing.T) {
c := New(&config.Config{File: cfgData, Session: cfgData}) c := New(&config.Config{File: cfgData, Session: cfgData})
c.loggedIn = true c.loggedIn = true
orig := baseURL origBase := baseURL
baseURL = ts.URL baseURL = ts.URL
defer func() { baseURL = orig }() defer func() { baseURL = origBase }()
pages, err := c.Search(context.Background(), "track", "dreams", 5) pages, err := c.Search(context.Background(), "track", "dreams", 5)
if err != nil { if err != nil {
@@ -38,11 +38,13 @@ func TestSearchTrack(t *testing.T) {
} }
} }
func TestGetDownloadableUsesPreview(t *testing.T) { func TestGetDownloadableNativeCipher(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch r.URL.Path { switch r.URL.Path {
case "/track/42": case "/track/42":
_ = json.NewEncoder(w).Encode(map[string]any{"id": 42, "title": "X", "preview": "https://cdn.example/p.mp3"}) _ = json.NewEncoder(w).Encode(map[string]any{"id": 42, "title": "X", "track_token": "tt"})
case "/media":
_ = json.NewEncoder(w).Encode(map[string]any{"data": []any{map[string]any{"errors": []any{}, "media": []any{map[string]any{"cipher": map[string]any{"type": "BF_CBC_STRIPE"}, "format": "FLAC", "sources": []any{map[string]any{"url": "https://cdn.example/file"}}}}}}})
default: default:
w.WriteHeader(http.StatusNotFound) w.WriteHeader(http.StatusNotFound)
} }
@@ -50,17 +52,72 @@ func TestGetDownloadableUsesPreview(t *testing.T) {
defer ts.Close() defer ts.Close()
cfgData := config.DefaultConfigData() cfgData := config.DefaultConfigData()
cfgData.Deezer.ARL = "arl"
c := New(&config.Config{File: cfgData, Session: cfgData}) c := New(&config.Config{File: cfgData, Session: cfgData})
c.loggedIn = true c.loggedIn = true
orig := baseURL c.arl = "arl"
baseURL = ts.URL c.license = "license"
defer func() { baseURL = orig }()
d, err := c.GetDownloadable(context.Background(), "42", 0) origBase := baseURL
origMedia := mediaURL
baseURL = ts.URL
mediaURL = ts.URL + "/media"
defer func() {
baseURL = origBase
mediaURL = origMedia
}()
d, err := c.GetDownloadable(context.Background(), "42", 2)
if err != nil { if err != nil {
t.Fatalf("GetDownloadable() error = %v", err) t.Fatalf("GetDownloadable() error = %v", err)
} }
if d.URL != "https://cdn.example/p.mp3" || d.Extension != "mp3" { if d.Cipher != "BF_CBC_STRIPE" || d.Extension != "flac" || d.TrackID != "42" {
t.Fatalf("unexpected downloadable: %+v", d) t.Fatalf("unexpected downloadable: %+v", d)
} }
} }
func TestGetDownloadableRequiresARL(t *testing.T) {
cfgData := config.DefaultConfigData()
cfgData.Deezer.ARL = ""
c := New(&config.Config{File: cfgData, Session: cfgData})
c.loggedIn = true
_, err := c.GetDownloadable(context.Background(), "42", 2)
if err == nil || !strings.Contains(strings.ToLower(err.Error()), "arl") {
t.Fatalf("expected arl requirement error, got %v", err)
}
}
func TestGetDownloadableDRMError(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch r.URL.Path {
case "/track/42":
_ = json.NewEncoder(w).Encode(map[string]any{"id": 42, "title": "X", "track_token": "tt"})
case "/media":
_ = json.NewEncoder(w).Encode(map[string]any{"data": []any{map[string]any{"errors": []any{map[string]any{"code": 403, "message": "DRM required"}}, "media": []any{}}}})
default:
w.WriteHeader(http.StatusNotFound)
}
}))
defer ts.Close()
cfgData := config.DefaultConfigData()
cfgData.Deezer.ARL = "arl"
c := New(&config.Config{File: cfgData, Session: cfgData})
c.loggedIn = true
c.arl = "arl"
c.license = "license"
origBase := baseURL
origMedia := mediaURL
baseURL = ts.URL
mediaURL = ts.URL + "/media"
defer func() {
baseURL = origBase
mediaURL = origMedia
}()
_, err := c.GetDownloadable(context.Background(), "42", 2)
if err == nil || !strings.Contains(strings.ToLower(err.Error()), "drm") {
t.Fatalf("expected drm error, got %v", err)
}
}

View File

@@ -6,6 +6,8 @@ type Downloadable struct {
URL string URL string
Extension string Extension string
Source string Source string
Cipher string
TrackID string
} }
type Client interface { type Client interface {

View File

@@ -5,10 +5,15 @@ import (
"encoding/json" "encoding/json"
"errors" "errors"
"fmt" "fmt"
"io"
"net/http"
"net/url"
"os/exec" "os/exec"
"regexp"
"strconv" "strconv"
"strings" "strings"
"sync" "sync"
"time"
"streamrip-go/internal/config" "streamrip-go/internal/config"
"streamrip-go/internal/provider" "streamrip-go/internal/provider"
@@ -16,6 +21,8 @@ import (
var errUnsupportedMediaType = errors.New("unsupported soundcloud media type") var errUnsupportedMediaType = errors.New("unsupported soundcloud media type")
var soundcloudSearchBaseURL = "https://soundcloud.com"
type commandRunner func(ctx context.Context, name string, args ...string) ([]byte, error) type commandRunner func(ctx context.Context, name string, args ...string) ([]byte, error)
type Client struct { type Client struct {
@@ -23,6 +30,7 @@ type Client struct {
loggedIn bool loggedIn bool
bin string bin string
run commandRunner run commandRunner
http *http.Client
mu sync.Mutex mu sync.Mutex
cache map[string]map[string]any cache map[string]map[string]any
} }
@@ -32,6 +40,7 @@ func New(cfg *config.Config) *Client {
cfg: cfg, cfg: cfg,
bin: "yt-dlp", bin: "yt-dlp",
run: runCommand, run: runCommand,
http: &http.Client{Timeout: 20 * time.Second},
cache: map[string]map[string]any{}, cache: map[string]map[string]any{},
} }
} }
@@ -56,12 +65,19 @@ func (c *Client) Search(ctx context.Context, mediaType, query string, limit int)
if !c.loggedIn { if !c.loggedIn {
return nil, errors.New("soundcloud client not logged in") return nil, errors.New("soundcloud client not logged in")
} }
if mediaType != "track" {
return nil, fmt.Errorf("%w: %s", errUnsupportedMediaType, mediaType)
}
if limit <= 0 { if limit <= 0 {
limit = 20 limit = 20
} }
if mediaType == "track" {
return c.searchTracks(ctx, query, limit)
}
if mediaType == "playlist" {
return c.searchPlaylists(ctx, query, limit)
}
return nil, fmt.Errorf("%w: %s", errUnsupportedMediaType, mediaType)
}
func (c *Client) searchTracks(ctx context.Context, query string, limit int) ([]map[string]any, error) {
target := fmt.Sprintf("scsearch%d:%s", limit, query) target := fmt.Sprintf("scsearch%d:%s", limit, query)
b, err := c.run(ctx, c.bin, "-J", "--flat-playlist", "--skip-download", "--no-warnings", target) b, err := c.run(ctx, c.bin, "-J", "--flat-playlist", "--skip-download", "--no-warnings", target)
@@ -82,10 +98,7 @@ func (c *Client) Search(ctx context.Context, mediaType, query string, limit int)
if !ok { if !ok {
continue continue
} }
id := strings.TrimSpace(stringFromAny(m["webpage_url"])) id := canonicalSoundcloudURL(m)
if id == "" {
id = strings.TrimSpace(stringFromAny(m["url"]))
}
if id == "" { if id == "" {
continue continue
} }
@@ -93,6 +106,7 @@ func (c *Client) Search(ctx context.Context, mediaType, query string, limit int)
if artist == "" { if artist == "" {
artist = strings.TrimSpace(stringFromAny(m["channel"])) artist = strings.TrimSpace(stringFromAny(m["channel"]))
} }
artistID := strings.TrimSpace(firstNonEmpty(stringFromAny(m["uploader_id"]), stringFromAny(m["channel_id"])))
item := map[string]any{ item := map[string]any{
"id": id, "id": id,
"title": stringFromAny(m["title"]), "title": stringFromAny(m["title"]),
@@ -100,11 +114,92 @@ func (c *Client) Search(ctx context.Context, mediaType, query string, limit int)
"name": artist, "name": artist,
}, },
} }
if artistID != "" {
item["artist"] = map[string]any{"name": artist, "id": artistID}
}
if trackID := strings.TrimSpace(stringFromAny(m["id"])); trackID != "" {
item["source_track_id"] = trackID
}
items = append(items, item) items = append(items, item)
} }
return []map[string]any{{"items": items}}, nil return []map[string]any{{"items": items}}, nil
} }
func (c *Client) searchPlaylists(ctx context.Context, query string, limit int) ([]map[string]any, error) {
searchURL := strings.TrimSuffix(soundcloudSearchBaseURL, "/") + "/search/sets?q=" + url.QueryEscape(query)
req, err := http.NewRequestWithContext(ctx, http.MethodGet, searchURL, nil)
if err != nil {
return nil, err
}
req.Header.Set("User-Agent", "Mozilla/5.0")
resp, err := c.http.Do(req)
if err != nil {
return nil, err
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
return nil, fmt.Errorf("soundcloud playlist search failed: status=%d", resp.StatusCode)
}
body, err := io.ReadAll(resp.Body)
if err != nil {
return nil, err
}
re := regexp.MustCompile(`/[A-Za-z0-9_-]+/sets/[A-Za-z0-9_-]+`)
paths := re.FindAllString(string(body), -1)
if len(paths) == 0 {
return []map[string]any{}, nil
}
seen := map[string]struct{}{}
items := make([]any, 0, limit)
for _, path := range paths {
if _, ok := seen[path]; ok {
continue
}
seen[path] = struct{}{}
playlistURL := "https://soundcloud.com" + path
info, infoErr := c.playlistInfo(ctx, playlistURL)
if infoErr != nil {
continue
}
title := strings.TrimSpace(stringFromAny(info["title"]))
if title == "" {
title = strings.Trim(strings.ReplaceAll(path, "/", " "), " ")
}
artist := strings.TrimSpace(firstNonEmpty(stringFromAny(info["uploader"]), stringFromAny(info["channel"])))
artistID := strings.TrimSpace(firstNonEmpty(stringFromAny(info["uploader_id"]), stringFromAny(info["channel_id"])))
trackCount := 0
if entries := asAnySlice(info["entries"]); len(entries) > 0 {
trackCount = len(entries)
}
canonical := firstNonEmpty(canonicalSoundcloudURL(info), playlistURL)
item := map[string]any{
"id": canonical,
"title": title,
"tracks_count": trackCount,
"artist": map[string]any{"name": artist},
}
if artistID != "" {
item["artist"] = map[string]any{"name": artist, "id": artistID}
}
if pid := strings.TrimSpace(stringFromAny(info["id"])); pid != "" {
item["source_playlist_id"] = pid
}
if thumb := strings.TrimSpace(stringFromAny(info["thumbnail"])); thumb != "" {
item["image"] = soundcloudImageMap(thumb)
}
items = append(items, item)
if len(items) >= limit {
break
}
}
if len(items) == 0 {
return []map[string]any{}, nil
}
return []map[string]any{{"items": items}}, nil
}
func (c *Client) GetMetadata(ctx context.Context, item, mediaType string) (map[string]any, error) { func (c *Client) GetMetadata(ctx context.Context, item, mediaType string) (map[string]any, error) {
if !c.loggedIn { if !c.loggedIn {
return nil, errors.New("soundcloud client not logged in") return nil, errors.New("soundcloud client not logged in")
@@ -118,37 +213,60 @@ func (c *Client) GetMetadata(ctx context.Context, item, mediaType string) (map[s
} }
return trackMetadataFromInfo(item, info), nil return trackMetadataFromInfo(item, info), nil
case "playlist": case "playlist":
b, err := c.run(ctx, c.bin, "-J", "--skip-download", "--no-warnings", item) root, err := c.playlistInfo(ctx, item)
if err != nil {
return nil, err
}
root, err := parseJSONMap(b)
if err != nil { if err != nil {
return nil, err return nil, err
} }
tracks := make([]any, 0) tracks := make([]any, 0)
for _, raw := range asAnySlice(root["entries"]) { for i, raw := range asAnySlice(root["entries"]) {
entry, ok := raw.(map[string]any) entry, ok := raw.(map[string]any)
if !ok { if !ok {
continue continue
} }
id := strings.TrimSpace(stringFromAny(entry["webpage_url"])) id := canonicalSoundcloudURL(entry)
if id == "" {
id = strings.TrimSpace(stringFromAny(entry["url"]))
}
if id == "" { if id == "" {
continue continue
} }
tracks = append(tracks, map[string]any{"id": id}) track := map[string]any{"id": id}
if trackID := strings.TrimSpace(stringFromAny(entry["id"])); trackID != "" {
track["source_track_id"] = trackID
}
if title := strings.TrimSpace(stringFromAny(entry["title"])); title != "" {
track["title"] = title
}
if artist := strings.TrimSpace(firstNonEmpty(stringFromAny(entry["uploader"]), stringFromAny(entry["channel"]))); artist != "" {
artistMap := map[string]any{"name": artist}
if artistID := strings.TrimSpace(firstNonEmpty(stringFromAny(entry["uploader_id"]), stringFromAny(entry["channel_id"]))); artistID != "" {
artistMap["id"] = artistID
}
track["artist"] = artistMap
}
track["track_number"] = i + 1
tracks = append(tracks, track)
} }
name := strings.TrimSpace(stringFromAny(root["title"])) name := strings.TrimSpace(stringFromAny(root["title"]))
if name == "" { if name == "" {
name = "SoundCloud Playlist" name = "SoundCloud Playlist"
} }
return map[string]any{ meta := map[string]any{
"id": firstNonEmpty(canonicalSoundcloudURL(root), item),
"name": name, "name": name,
"description": strings.TrimSpace(stringFromAny(root["description"])),
"tracks": map[string]any{"items": tracks}, "tracks": map[string]any{"items": tracks},
}, nil }
if pid := strings.TrimSpace(stringFromAny(root["id"])); pid != "" {
meta["source_playlist_id"] = pid
}
if artist := strings.TrimSpace(firstNonEmpty(stringFromAny(root["uploader"]), stringFromAny(root["channel"]))); artist != "" {
meta["artist"] = map[string]any{"name": artist}
}
if thumb := strings.TrimSpace(stringFromAny(root["thumbnail"])); thumb != "" {
meta["image"] = soundcloudImageMap(thumb)
}
if entries := asAnySlice(root["entries"]); len(entries) > 0 {
meta["tracks_count"] = len(entries)
}
return meta, nil
default: default:
return nil, fmt.Errorf("%w: %s", errUnsupportedMediaType, mediaType) return nil, fmt.Errorf("%w: %s", errUnsupportedMediaType, mediaType)
} }
@@ -164,7 +282,7 @@ func (c *Client) GetDownloadable(ctx context.Context, item string, _ int) (*prov
} }
streamURL := strings.TrimSpace(stringFromAny(info["url"])) streamURL := strings.TrimSpace(stringFromAny(info["url"]))
if streamURL == "" { if streamURL == "" {
return nil, errors.New("yt-dlp output missing url") return nil, errors.New("yt-dlp output missing url (track may be unavailable or region-restricted)")
} }
ext := strings.TrimSpace(stringFromAny(info["ext"])) ext := strings.TrimSpace(stringFromAny(info["ext"]))
if ext == "" { if ext == "" {
@@ -198,26 +316,55 @@ func (c *Client) trackInfo(ctx context.Context, item string) (map[string]any, er
if err != nil { if err != nil {
return nil, err return nil, err
} }
canonical := canonicalSoundcloudURL(info)
c.mu.Lock() c.mu.Lock()
c.cache[item] = cloneMap(info) c.cache[item] = cloneMap(info)
if canonical != "" {
c.cache[canonical] = cloneMap(info)
}
c.mu.Unlock() c.mu.Unlock()
return info, nil return info, nil
} }
func (c *Client) playlistInfo(ctx context.Context, item string) (map[string]any, error) {
b, err := c.run(ctx, c.bin, "-J", "--flat-playlist", "--skip-download", "--no-warnings", item)
if err != nil {
return nil, err
}
return parseJSONMap(b)
}
func trackMetadataFromInfo(id string, info map[string]any) map[string]any { func trackMetadataFromInfo(id string, info map[string]any) map[string]any {
canonicalID := firstNonEmpty(canonicalSoundcloudURL(info), id)
publisher := nestedMap(info, "publisher_metadata")
title := strings.TrimSpace(stringFromAny(info["title"])) title := strings.TrimSpace(stringFromAny(info["title"]))
if title == "" { if title == "" {
title = id title = canonicalID
}
albumTitle := strings.TrimSpace(stringFromAny(publisher["album_title"]))
if albumTitle == "" {
albumTitle = strings.TrimSpace(stringFromAny(info["album"]))
}
if albumTitle == "" {
albumTitle = title
} }
artistName := strings.TrimSpace(stringFromAny(info["artist"])) artistName := strings.TrimSpace(stringFromAny(info["artist"]))
if artistName == "" {
artistName = strings.TrimSpace(stringFromAny(publisher["artist"]))
}
if artistName == "" { if artistName == "" {
artistName = strings.TrimSpace(stringFromAny(info["uploader"])) artistName = strings.TrimSpace(stringFromAny(info["uploader"]))
} }
if artistName == "" { if artistName == "" {
artistName = strings.TrimSpace(stringFromAny(info["channel"])) artistName = strings.TrimSpace(stringFromAny(info["channel"]))
} }
artistID := strings.TrimSpace(firstNonEmpty(
stringFromAny(info["uploader_id"]),
stringFromAny(info["channel_id"]),
stringFromAny(nestedMap(info, "user")["id"]),
))
trackNum := intFromAny(info["track_number"]) trackNum := intFromAny(info["track_number"])
if trackNum <= 0 { if trackNum <= 0 {
@@ -225,42 +372,48 @@ func trackMetadataFromInfo(id string, info map[string]any) map[string]any {
} }
meta := map[string]any{ meta := map[string]any{
"id": id, "id": canonicalID,
"title": title, "title": title,
"track_number": trackNum, "track_number": trackNum,
"artist": map[string]any{"name": artistName}, "artist": map[string]any{"name": artistName, "id": artistID},
"performer": map[string]any{"name": artistName}, "performer": map[string]any{"name": artistName, "id": artistID},
"album": map[string]any{ "album": map[string]any{
"id": strings.TrimSpace(stringFromAny(info["album"])), "id": firstNonEmpty(strings.TrimSpace(stringFromAny(info["album"])), canonicalID),
"title": strings.TrimSpace(stringFromAny(info["album"])), "title": albumTitle,
"artist": map[string]any{"name": artistName}, "artist": map[string]any{"name": artistName, "id": artistID},
}, },
"description": strings.TrimSpace(stringFromAny(info["description"])), "description": strings.TrimSpace(stringFromAny(info["description"])),
"genre": strings.TrimSpace(stringFromAny(info["genre"])), "genre": strings.TrimSpace(stringFromAny(info["genre"])),
"isrc": strings.TrimSpace(stringFromAny(info["isrc"])),
"label": strings.TrimSpace(firstNonEmpty(stringFromAny(info["label"]), stringFromAny(info["label_name"]))),
"copyright": strings.TrimSpace(stringFromAny(publisher["p_line"])),
"release_date": strings.TrimSpace(firstNonEmpty( "release_date": strings.TrimSpace(firstNonEmpty(
stringFromAny(info["created_at"]),
stringFromAny(info["release_date"]), stringFromAny(info["release_date"]),
stringFromAny(info["upload_date"]), stringFromAny(info["upload_date"]),
)), )),
} }
if trackID := strings.TrimSpace(stringFromAny(info["id"])); trackID != "" {
meta["source_track_id"] = trackID
}
if boolFromAny(publisher["explicit"]) || intFromAny(info["age_limit"]) >= 18 {
meta["explicit"] = true
}
if meta["release_date"] == "" { if meta["release_date"] == "" {
delete(meta, "release_date") delete(meta, "release_date")
} }
if thumb := strings.TrimSpace(stringFromAny(info["thumbnail"])); thumb != "" { if thumb := strings.TrimSpace(stringFromAny(info["thumbnail"])); thumb != "" {
meta["image"] = map[string]any{ meta["image"] = soundcloudImageMap(thumb)
"small": thumb,
"large": thumb,
"extralarge": thumb,
"original": thumb,
}
} }
if album := strings.TrimSpace(stringFromAny(info["album"])); album == "" { if strings.TrimSpace(stringFromAny(info["album"])) == "" && strings.TrimSpace(stringFromAny(publisher["album_title"])) == "" {
meta["album"] = map[string]any{ meta["album"] = map[string]any{
"id": id, "id": canonicalID,
"title": title, "title": title,
"artist": map[string]any{"name": artistName}, "artist": map[string]any{"name": artistName, "id": artistID},
} }
} }
@@ -271,6 +424,32 @@ func trackMetadataFromInfo(id string, info map[string]any) map[string]any {
return meta return meta
} }
func canonicalSoundcloudURL(info map[string]any) string {
for _, key := range []string{"webpage_url", "original_url", "url"} {
raw := strings.TrimSpace(stringFromAny(info[key]))
if raw == "" {
continue
}
u, err := url.Parse(raw)
if err != nil {
continue
}
host := strings.ToLower(strings.TrimPrefix(u.Host, "www."))
if host != "soundcloud.com" {
continue
}
u.Scheme = "https"
u.RawQuery = ""
u.Fragment = ""
u.Path = strings.TrimSuffix(u.Path, "/")
if strings.TrimSpace(u.Path) == "" {
continue
}
return u.String()
}
return ""
}
func parseJSONMap(b []byte) (map[string]any, error) { func parseJSONMap(b []byte) (map[string]any, error) {
var out map[string]any var out map[string]any
if err := json.Unmarshal(b, &out); err != nil { if err := json.Unmarshal(b, &out); err != nil {
@@ -338,6 +517,49 @@ func firstNonEmpty(items ...string) string {
return "" return ""
} }
func nestedMap(m map[string]any, key string) map[string]any {
v, ok := m[key].(map[string]any)
if !ok {
return map[string]any{}
}
return v
}
func boolFromAny(v any) bool {
switch t := v.(type) {
case bool:
return t
case string:
l := strings.ToLower(strings.TrimSpace(t))
return l == "1" || l == "true" || l == "yes"
case int:
return t != 0
case int64:
return t != 0
case float64:
return t != 0
default:
return false
}
}
func soundcloudImageMap(raw string) map[string]any {
base := strings.TrimSpace(raw)
if base == "" {
return map[string]any{}
}
large := strings.Replace(base, "-large.", "-t500x500.", 1)
if large == base {
large = strings.Replace(base, "large", "t500x500", 1)
}
return map[string]any{
"small": base,
"large": large,
"extralarge": large,
"original": large,
}
}
func runCommand(ctx context.Context, name string, args ...string) ([]byte, error) { func runCommand(ctx context.Context, name string, args ...string) ([]byte, error) {
cmd := exec.CommandContext(ctx, name, args...) cmd := exec.CommandContext(ctx, name, args...)
b, err := cmd.CombinedOutput() b, err := cmd.CombinedOutput()

View File

@@ -3,6 +3,8 @@ package soundcloud
import ( import (
"context" "context"
"fmt" "fmt"
"net/http"
"net/http/httptest"
"strings" "strings"
"testing" "testing"
@@ -28,6 +30,9 @@ func TestGetTrackMetadataAndDownloadable(t *testing.T) {
if stringFromAny(meta["title"]) != "Lean On" { if stringFromAny(meta["title"]) != "Lean On" {
t.Fatalf("title = %q, want Lean On", stringFromAny(meta["title"])) t.Fatalf("title = %q, want Lean On", stringFromAny(meta["title"]))
} }
if stringFromAny(meta["id"]) != "https://soundcloud.com/a/b" {
t.Fatalf("id = %q, want canonical soundcloud url", stringFromAny(meta["id"]))
}
d, err := c.GetDownloadable(context.Background(), "https://soundcloud.com/a/b", 0) d, err := c.GetDownloadable(context.Background(), "https://soundcloud.com/a/b", 0)
if err != nil { if err != nil {
@@ -65,6 +70,9 @@ func TestGetPlaylistMetadata(t *testing.T) {
if len(items) != 2 { if len(items) != 2 {
t.Fatalf("playlist items len = %d, want 2", len(items)) t.Fatalf("playlist items len = %d, want 2", len(items))
} }
if stringFromAny(meta["id"]) != "https://soundcloud.com/a/sets/road-trip" {
t.Fatalf("playlist id not canonical: %q", stringFromAny(meta["id"]))
}
} }
func TestSearchTrack(t *testing.T) { func TestSearchTrack(t *testing.T) {
@@ -90,6 +98,58 @@ func TestSearchTrack(t *testing.T) {
if len(items) != 1 { if len(items) != 1 {
t.Fatalf("items len = %d, want 1", len(items)) t.Fatalf("items len = %d, want 1", len(items))
} }
item0, ok := items[0].(map[string]any)
if !ok {
t.Fatalf("expected first item map")
}
if stringFromAny(item0["id"]) != "https://soundcloud.com/a/b" {
t.Fatalf("track search id not canonical: %q", stringFromAny(item0["id"]))
}
}
func TestSearchPlaylist(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.URL.Path == "/search/sets" {
_, _ = w.Write([]byte(`<html><body><a href="/a/sets/road-trip">x</a></body></html>`))
return
}
w.WriteHeader(http.StatusNotFound)
}))
defer ts.Close()
cfgData := config.DefaultConfigData()
c := New(&config.Config{File: cfgData, Session: cfgData})
c.loggedIn = true
c.http = ts.Client()
origBase := soundcloudSearchBaseURL
soundcloudSearchBaseURL = ts.URL
defer func() { soundcloudSearchBaseURL = origBase }()
c.run = func(_ context.Context, _ string, args ...string) ([]byte, error) {
joined := strings.Join(args, " ")
if strings.Contains(joined, "https://soundcloud.com/a/sets/road-trip") {
return []byte(`{"title":"Road Trip","uploader":"User","entries":[{"webpage_url":"https://soundcloud.com/a/t1"}]}`), nil
}
return nil, fmt.Errorf("unexpected args: %v", args)
}
pages, err := c.Search(context.Background(), "playlist", "road trip", 5)
if err != nil {
t.Fatalf("Search() error = %v", err)
}
if len(pages) != 1 {
t.Fatalf("pages len = %d, want 1", len(pages))
}
items := asAnySlice(pages[0]["items"])
if len(items) != 1 {
t.Fatalf("items len = %d, want 1", len(items))
}
item0, ok := items[0].(map[string]any)
if !ok {
t.Fatalf("expected first item map")
}
if stringFromAny(item0["id"]) != "https://soundcloud.com/a/sets/road-trip" {
t.Fatalf("playlist search id not canonical: %q", stringFromAny(item0["id"]))
}
} }
func TestLoginShowsYtDlpHint(t *testing.T) { func TestLoginShowsYtDlpHint(t *testing.T) {
@@ -104,3 +164,36 @@ func TestLoginShowsYtDlpHint(t *testing.T) {
t.Fatalf("expected yt-dlp hint in error, got: %v", err) t.Fatalf("expected yt-dlp hint in error, got: %v", err)
} }
} }
func TestTrackMetadataIncludesExplicitAndISRC(t *testing.T) {
meta := trackMetadataFromInfo("https://soundcloud.com/a/b", map[string]any{
"title": "T",
"uploader": "U",
"isrc": "US123",
"id": "9876",
"webpage_url": "https://soundcloud.com/a/b?si=abc",
"age_limit": float64(18),
"thumbnail": "https://img",
"upload_date": "20240101",
})
if stringFromAny(meta["isrc"]) != "US123" {
t.Fatalf("isrc = %q, want US123", stringFromAny(meta["isrc"]))
}
explicit, _ := meta["explicit"].(bool)
if !explicit {
t.Fatalf("expected explicit=true")
}
if stringFromAny(meta["source_track_id"]) != "9876" {
t.Fatalf("source_track_id = %q, want 9876", stringFromAny(meta["source_track_id"]))
}
if stringFromAny(nestedMap(meta, "album")["title"]) != "T" {
t.Fatalf("album title mismatch: %#v", nestedMap(meta, "album"))
}
}
func TestCanonicalSoundcloudURL(t *testing.T) {
got := canonicalSoundcloudURL(map[string]any{"webpage_url": "https://soundcloud.com/a/b/?si=x#frag"})
if got != "https://soundcloud.com/a/b" {
t.Fatalf("canonical url = %q, want %q", got, "https://soundcloud.com/a/b")
}
}

View File

@@ -49,7 +49,7 @@ func Parse(raw string) *ParsedURL {
return parseTidal(raw, parts) return parseTidal(raw, parts)
case isDeezerHost(host): case isDeezerHost(host):
return parseDeezer(raw, parts) return parseDeezer(raw, parts)
case host == "soundcloud.com": case isSoundcloudHost(host):
return parseSoundcloud(raw, parts) return parseSoundcloud(raw, parts)
default: default:
return nil return nil
@@ -129,7 +129,7 @@ func parseDeezer(raw string, parts []string) *ParsedURL {
} }
func parseSoundcloud(raw string, parts []string) *ParsedURL { func parseSoundcloud(raw string, parts []string) *ParsedURL {
if len(parts) < 2 { if len(parts) < 1 {
return nil return nil
} }
@@ -172,6 +172,10 @@ func isDeezerHost(host string) bool {
return host == "deezer.com" return host == "deezer.com"
} }
func isSoundcloudHost(host string) bool {
return host == "soundcloud.com" || strings.HasSuffix(host, ".soundcloud.com") || host == "on.soundcloud.com"
}
func isSupportedMedia(mediaType string) bool { func isSupportedMedia(mediaType string) bool {
switch mediaType { switch mediaType {
case "album", "track", "playlist", "artist", "label", "video": case "album", "track", "playlist", "artist", "label", "video":

View File

@@ -105,6 +105,8 @@ func TestSoundcloudURL(t *testing.T) {
inputs := []string{ inputs := []string{
"https://soundcloud.com/artist-name/track-name", "https://soundcloud.com/artist-name/track-name",
"https://soundcloud.com/artist-name/sets/playlist-name", "https://soundcloud.com/artist-name/sets/playlist-name",
"https://m.soundcloud.com/artist-name/track-name",
"https://on.soundcloud.com/abcdef",
} }
for _, input := range inputs { for _, input := range inputs {
result := Parse(input) result := Parse(input)