Duplicated helpers
cmd/rip had its own copies of six helpers that already existed in
internal/jsonutil: asString (StringFromAny), searchInt (IntFromAny),
nestedSearchInt and nestedSearchString (NestedAny/NestedString),
firstNonEmpty (FirstNonEmpty) and firstPositiveInt. firstPositiveInt was
duplicated a third and fourth time in provider/yandex and provider/beatport,
so it moves into jsonutil alongside the rest. jsonutil is back to 100%
coverage.
searchBool is deliberately left alone, with a comment saying why: it accepts
only a real bool, and switching it to jsonutil.BoolFromAny would start
coercing strings and numbers, changing how search results get labelled.
config auto-upgrade is no longer destructive
UpgradeOutdated re-serializes the whole config from the parsed struct, so any
key this version does not know about is dropped, and it runs automatically
from run() without prompting. It now copies the original to
<path>.bak-<unixtime> (0600, since it holds the same credentials) and
validates the result before writing. It returns the backup path so the CLI
can tell the user where it went. The comment states plainly that this is a
version stamp rather than a migration framework.
cmd/rip tests
The command bodies are testable now that they are functions returning exit
codes rather than arms of a switch that called os.Exit. Covers the usage
errors for every command, the quality floor on `rip id`, config path output,
the --version flag, and that applyQualityOverride reaches all six sources and
clamps only the two with a floor. cmd/rip coverage 17% -> 26%.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Dead code
Removed, each verified to have no non-test caller: promptSearchSelection
(77 lines, superseded by promptSearchSelectionMenu), AddPlaylistByTrackIDs,
download.NewWithVerifySSL, qobuz.Client.GetTrackMetadata,
tidal.Client.trackSupportsAtmos (test-only, and the comment above
GetDownloadable already documented its removal from the live path) and its
now-orphaned test, yandex.canonicalTrackRequestID (a no-op returning its
trimmed input; the call site uses strings.TrimSpace directly) and the unused
defaultEstimatedKbps constant.
Config keys that did nothing
qobuz.download_booklets and misc.check_for_updates were declared, defaulted
and documented in config.toml.example but read by no code. The whole
[youtube] block went too: there is no YouTube provider. go-toml ignores
unknown keys, verified, so existing user configs still load.
Duplicated helpers
tidal.stringify and yandex.firstNonEmpty were byte-identical copies of
jsonutil.StringFromAny and jsonutil.FirstNonEmpty. displayArtistNames
existed three times, byte-identical, in internal/app, provider/yandex and
provider/beatport; it now lives in jsonutil. The CLI's normalizeCodec
delegates to config.NormalizeCodec so the flag and the config file are
checked by the same rules.
Tests for packages that had none
internal/jsonutil (0% -> 100%) and internal/netutil (0% -> 78%), the latter
covering redactURL, which is a security control, and the zero-timeout
contract that internal/download and the qobuz body copy depend on.
internal/config rose to 82% with coverage of the new Validate(), the
0600 permissions, CloneConfigData not sharing slices, and a concurrent
UpdateTokens test that exercises the mutex under -race.
Test suite is ~85x faster
Provider tests built clients with the default 60 requests/minute, so the
rate limiter slept 1s per HTTP call: deezer took 31s, tidal 11s, qobuz 8s.
Each provider test package now builds its config through a testConfigData
helper that disables throttling. Whole suite: ~60s -> 0.7s, and 2.8s
under -race.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- Extracted common JSON parsing helpers into internal/jsonutil
- Removed duplicated helper functions from provider packages
- Removed dead code in internal/app/app.go and downloader.go
- Replaced deprecated strings.Title with jsonutil.TitleCase
- Added graceful shutdown with signal handling in main.go
- Split monolithic cmd/rip/main.go into args.go, helpers.go, lastfm.go, search.go
JorenandClaude Opus 5