From 4ba6d00748c9fc459d89170dafe7e8d3a0ba581a Mon Sep 17 00:00:00 2001 From: joren Date: Tue, 24 Mar 2026 23:55:12 +0100 Subject: [PATCH] fix: artistview nullptr connect warning + album version in header - Move updateToggleText() after m_list creation to avoid null connects - Show version (e.g. "Deluxe") in album header title Co-Authored-By: Claude Sonnet 4.6 --- src/view/artistview.cpp | 2 +- src/view/trackcontextheader.hpp | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/view/artistview.cpp b/src/view/artistview.cpp index f21446b..be823e7 100644 --- a/src/view/artistview.cpp +++ b/src/view/artistview.cpp @@ -30,7 +30,6 @@ ArtistSection::ArtistSection(const QString &title, QWidget *parent) " border: none; border-bottom: 1px solid #333; }" "QToolButton:hover { background: #1e1e1e; }" )); - updateToggleText(0); layout->addWidget(m_toggle); m_list = new AlbumListView(this); @@ -38,6 +37,7 @@ ArtistSection::ArtistSection(const QString &title, QWidget *parent) connect(m_toggle, &QToolButton::toggled, m_list, &AlbumListView::setVisible); connect(m_list, &AlbumListView::albumSelected, this, &ArtistSection::albumSelected); + updateToggleText(0); } void ArtistSection::setAlbums(const QJsonArray &albums) diff --git a/src/view/trackcontextheader.hpp b/src/view/trackcontextheader.hpp index 8e8d877..daf51e0 100644 --- a/src/view/trackcontextheader.hpp +++ b/src/view/trackcontextheader.hpp @@ -119,7 +119,9 @@ public: void setAlbum(const QJsonObject &album) { - m_title->setText(album["title"].toString()); + const QString base = album["title"].toString(); + const QString ver = album["version"].toString().trimmed(); + m_title->setText(ver.isEmpty() ? base : base + QStringLiteral(" (") + ver + QLatin1Char(')')); m_artistId = static_cast(album["artist"].toObject()["id"].toDouble()); m_subtitle->setText(album["artist"].toObject()["name"].toString()); m_subtitle->setEnabled(m_artistId > 0);