vicrodh
395e537b59
Users on CPUs without AES-NI (Nehalem i7-860, pre-2010 Intel Macs) or without SSSE3 (AMD Phenom II) crashed at launch with SIGILL. The global `-C target-feature=+aes,+ssse3` was kept after the #353/#343 x86-64-v3 incident on the belief that the aes crate's cpufeatures runtime check would protect CPUs without AES-NI — but a compile-time target feature makes cpufeatures compile its check to a constant, so the AES-NI intrinsics ran unconditionally (credentials AES-GCM decrypt at startup), and +ssse3 let LLVM autovectorize anywhere, breaking Phenom II. Measured on the qbz-cmaf hot path (Ctr128BE<Aes128> apply_keystream, 256 MB, release): 2145 MB/s compiled-in vs 2162 MB/s runtime-dispatched, identical output — the flags bought nothing on capable CPUs. Removed from .cargo/config.toml, all dev/build scripts and the release/build workflows; old CPUs now get the software AES fallback instead of a crash. Fixes #549 cc
24 lines
1.3 KiB
Bash
Executable File
24 lines
1.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# QBZ Slint — FAST dev build/run (DEBUG, *not* release).
|
|
#
|
|
# ADDITION to ./slint-dev.sh, NOT a replacement. Use this for quick, purely
|
|
# visual / layout iteration where runtime performance does NOT matter — it is
|
|
# dramatically faster to compile than the release build because:
|
|
# - debug profile (opt-level 0) → the giant Slint-generated module skips the
|
|
# heavy LLVM optimisation passes that dominate the release build,
|
|
# - the `mold` linker (much faster than the default `ld`),
|
|
# - NO debuginfo (`-C debuginfo=0`) → less to generate AND less to link,
|
|
# - the nightly PARALLEL FRONTEND (`-Z threads`) across cores.
|
|
# Debug builds live in target/debug, separate from the release target/release,
|
|
# so the two scripts don't invalidate each other's cache.
|
|
#
|
|
# DO NOT use this to judge performance — the binary is unoptimised. Always do a
|
|
# final pass with ./slint-dev.sh (release) before trusting runtime behaviour.
|
|
#
|
|
# Usage: ./scripts/slint-dev-fast.sh [extra cargo args]
|
|
# THREADS=22 ./scripts/slint-dev-fast.sh # override frontend threads
|
|
set -euo pipefail
|
|
cd "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/.."
|
|
export RUSTFLAGS="-C link-arg=-fuse-ld=mold -C debuginfo=0 -Z threads=${THREADS:-16}"
|
|
exec cargo +nightly run --manifest-path crates/Cargo.toml -p qbz "$@"
|