Implemented configurable network folder visibility when in manual offline mode.
Problem:
- Previously, ALL offline modes hid network folders
- Users in manual offline mode (privacy/metered internet) may still
have local network access and want to see network-mounted music
Solution:
- Added showNetworkFoldersInManualOffline setting (already existed in backend)
- Implemented smart filtering logic in LocalLibraryView:
- Offline real (no_network): Always hide network folders
- Offline manual: Hide ONLY if user disabled the setting
- Online: Show everything
- Added toggle in Settings > Offline Mode section
Use cases:
1. Privacy: Manual offline mode but keep local network music visible
2. Metered internet: Don't stream from Qobuz but access NAS/network shares
3. Real offline: No network at all, hide everything network-based
Settings location: Settings > Offline Mode > "Show Network Folders"
Description: "Display music from network folders when in manual
offline mode (privacy/metered connection)"
Files changed:
- src/lib/components/views/LocalLibraryView.svelte
- src/lib/components/views/SettingsView.svelte
Added UI for library_backfill_downloads command in Settings > Downloads section.
Features:
- "Repair Downloads" button with description
- Shows repair report with counts (added/repaired/skipped/failed)
- Triggers library reload after repair to reflect changes
- Disabled when no downloads exist or repair is in progress
Location: Between "Show in Local Library" toggle and "Clear Downloads" button
This allows users to easily restore source markers for Qobuz downloads
that were damaged during library scans.
Files changed:
- src/lib/components/views/SettingsView.svelte
Problem: Qobuz downloads that were already scanned lost their
source = 'qobuz_download' marker. The previous fix only prevents
future damage, but doesn't repair existing tracks.
Solution:
- Added repair_qobuz_download_source() to restore source marker
- Modified library_backfill_downloads to repair existing tracks:
- When a track exists, try to repair its source marker
- Report shows: added, repaired, and skipped counts
- This fixes downloads that lost their marker during scans
User can now run the backfill command to:
1. Restore source markers for damaged downloads
2. Make "Show in Local Library" setting work correctly
3. Separate Qobuz downloads from scanned music again
Files changed:
- src-tauri/src/library/database.rs
- src-tauri/src/library/commands.rs
Problem 1: "Show in Local Library" setting was being ignored
- Qobuz downloads appeared in library even when setting was disabled
- Root cause: Scanner was overwriting Qobuz downloads with INSERT OR REPLACE
- This lost the 'source = qobuz_download' marker needed for filtering
Problem 2: Network music visible in offline mode
- Music from network folders remained visible when offline
- User expected network content to be completely hidden offline
- Only local disk music should appear
Solution 1: Protect Qobuz downloads from scanner
- Added is_qobuz_download_by_path() to check if file is already a download
- Modified insert_track() to skip files with source = 'qobuz_download'
- Now downloads and scanned music coexist as separate "joins" in DB
Solution 2: Filter network folders when offline
- Added get_network_folder_paths() to get list of network folder paths
- Modified library_get_albums to accept excludeNetworkFolders parameter
- When offline, filter out albums whose tracks are in network folders
- Frontend passes excludeNetworkFolders: isOffline to backend
- Added reactive effect to reload library when offline state changes
This implements the "join between tables" approach - Qobuz downloads
don't interfere with scanned music, and network content is properly
hidden when offline without being deleted.
Files changed:
- src-tauri/src/library/database.rs
- src-tauri/src/library/commands.rs
- src/lib/components/views/LocalLibraryView.svelte
Problem: When app is in offline mode, LocalLibrary gets stuck in
infinite loading screen and becomes unusable.
Root cause: loadFolders() was calling checkFolderAccessibility()
for each network folder. The backend command library_check_folder_accessible
uses blocking std::fs::read_dir which can hang for 20-30 seconds per
unreachable network path.
Solution:
Frontend (LocalLibraryView.svelte):
- Skip network folder accessibility checks when offline
- Assume network folders are inaccessible in offline mode
- Only check accessibility when online
Backend (library/commands.rs):
- Add 2-second timeout to library_check_folder_accessible
- Use tokio::task::spawn_blocking to avoid blocking async runtime
- Log timeout warnings for unreachable network paths
This allows LocalLibrary to load instantly when offline, showing
only local disk content as intended.
Files changed:
- src/lib/components/views/LocalLibraryView.svelte
- src-tauri/src/library/commands.rs
Problem: When user toggled the "Show Qobuz Downloads in Local Library"
setting in Settings, LocalLibraryView didn't refresh, so downloaded
tracks continued to appear even when the setting was disabled.
Root cause: LocalLibraryView only loaded data onMount and had no
mechanism to detect when download settings changed.
Solution:
- Created downloadSettingsStore with version tracking
- SettingsView notifies store when setting changes
- LocalLibraryView subscribes via $effect() and reloads data
Backend was already correctly filtering by the setting - this was
purely a frontend reactivity issue.
Files changed:
- src/lib/stores/downloadSettingsStore.ts (new)
- src/lib/components/views/SettingsView.svelte
- src/lib/components/views/LocalLibraryView.svelte
- Added onTrackOpenFolder and onTrackReDownload to Props interface
- Pass download props to menuActions in TrackRow
- Only show Download options for Qobuz tracks (not local tracks)
- Wire up handlers in main app component
- Completes Download menu implementation across all views
- Added onDownload, isTrackDownloaded, onOpenFolder, onReDownload to TrackMenuActions interface
- Pass download props from menuActions to TrackMenu in TrackRow
- Removed debug logging
- Fixes Download menu missing in HomeView, AlbumDetailView, and FavoritesView
- Moved {@const isTrackDownloaded} to be direct child of {#each} loops
- Removed invalid placement inside <div> elements
- Fixed both track list instances (all results and dedicated tracks tab)
- Added handleTrackOpenFolder, handleTrackReDownload, and checkTrackDownloaded handlers
- Imported openTrackFolder from downloadState.ts
- Connected all handlers to HomeView, AlbumDetailView, SearchView, and FavoritesView
- Download submenu now fully functional across all Qobuz track views
- Created open_track_folder Rust command to open folder containing downloaded track
- Added frontend wrappers: openTrackFolder and reDownloadTrack in downloadState.ts
- Updated all Qobuz views to support Download submenu:
- HomeView: Added track download props and handlers
- AlbumDetailView: Added onTrackOpenFolder and onTrackReDownload
- SearchView: Added track download actions to both TrackMenu usages
- FavoritesView: Added download submenu to both track list variants
- Downloaded tracks now show submenu with 'Open containing folder' and 'Re-download' options
- Completes Phase 2 Task 2.1: Context Menu Homogenization (Download)
Added Download menu item with submenu for downloaded tracks:
- If not downloaded: Shows 'Download' button
- If downloaded: Shows 'Download' submenu with:
- 'Open containing folder' (onOpenFolder)
- 'Re-download' (onReDownload)
New props added to TrackMenu:
- onDownload: Download track
- isTrackDownloaded: Boolean to determine if track is downloaded
- onOpenFolder: Open folder containing downloaded track
- onReDownload: Re-download track
Matches pattern used in AlbumMenu.svelte for albums.
Removed special case that forced ALAC to use symphonia fallback which
decoded the entire file (~30MB) before playback, causing 6+ second delays.
Now ALAC uses rodio's Decoder first (supports ALAC via symphonia-all
feature) which streams instead of decoding everything upfront.
Fallback chain is now:
1. Rodio Decoder (streaming) - instant
2. MP4 fallback (streaming) - instant
3. Symphonia (full decode) - slow, last resort
This brings ALAC playback start time from ~6 seconds to instant,
matching FLAC and other formats.
ALAC files (and some other formats) don't include channel information in
the initial codec params, causing playback to fail with error:
'No channel info in codec params'
Changed to use .unwrap_or(2) instead of .ok_or_else() to default to
stereo (2 channels) which is the most common case and matches the
behavior in metadata extraction.
Fixes playback of ALAC (.m4a) files in Local Library.
Fixed missing type annotations in row.get() calls for sample_rate.
Without explicit type annotation, Rust was inferring the wrong type
causing 'Invalid column type Real' errors when reading from database.
Added ::<_, f64> type annotation to all three locations:
- row_to_track (line 1168)
- get_playlist_local_tracks (line 1772)
- get_playlist_local_tracks_with_qobuz (line 1821)
This is the critical fix for the database migration error.
Changed LocalAlbum.sample_rate from u32 to f64 to match database REAL type.
Fixed database queries to read sample_rate as f64 instead of u32.
Removed incorrect i64 casts when inserting sample_rate values.
This fixes the 'Invalid column type Real' error that prevented the app
from loading after the database migration.
Drop any existing local_tracks_new table before starting migration
to handle cases where a previous migration attempt failed mid-execution.
This prevents 'table already exists' errors when retrying the migration.
Use COALESCE in migration SELECT to safely handle NULL file_size_bytes
values that may exist in older database versions. This prevents the
'NOT NULL constraint failed' error when migrating from INTEGER to REAL
sample_rate type.
The migration now uses COALESCE(file_size_bytes, 0) to ensure all
rows have a valid file size value, defaulting to 0 for missing data.
Fixes critical migration failure that prevented app startup for users
with existing databases.
1. QUEUE SHUFFLE FIX (CRITICAL):
- When shuffle enabled and set_queue called, starting track was placed randomly in shuffle_order
- This caused queue UI to show only tracks AFTER that random position
- Example: 11 tracks, start at index 5, but index 5 was at position 7 in shuffle → only 3 tracks visible
- FIX: When shuffle enabled, swap starting track to position 0 in shuffle_order
- Now all tracks appear in queue UI as expected
2. LOCAL LIBRARY CONTEXT FIX:
- handleLocalTrackPlay was clearing context immediately after LocalLibraryView set it
- FIX: Removed clearPlaybackContext() call - LocalLibraryView handles context correctly
- Context icon should now display for Local Library playback
3. SAMPLE RATE CRASH FIX:
- show_track_notification expected u32 but received f64 (44.1, 88.2, etc.)
- Error: "invalid type: floating point 44.1, expected u32"
- FIX: Changed sample_rate parameter from u32 to f64 in notification command and format_quality
- Bonus: Format shows "44.1" for fractional rates, "48" for whole numbers
Files modified:
- src-tauri/src/queue/mod.rs - Fixed set_queue to move start_index to front of shuffle_order
- src/routes/+page.svelte - Removed clearPlaybackContext from handleLocalTrackPlay
- src-tauri/src/commands/notification.rs - Changed sample_rate to f64 with proper formatting
- Modified handleShuffleAlbum to pick random starting track (same fix as Local Library)
- Added comprehensive debug logs to handleAlbumTrackPlay to diagnose queue issues
- Fixed favoritesStore crash when response.tracks is undefined (defensive checks)
Fixes:
- Qobuz album shuffle no longer always starts with first track
- App no longer crashes on startup with "undefined is not an object (evaluating 'response.tracks.items')"
- Modified handleShuffleAllAlbum to pick random starting track instead of always starting with first
- Added comprehensive debug logs to track queue creation and size
- Logs will help diagnose why only 1-3 tracks appear in queue UI instead of all tracks
Multiple critical fixes for context tracking:
1. Add 'local_library' to backend context type parser
- Was rejecting 'local_library' causing "Invalid context type" error
- Now properly recognized in set_playback_context command
2. Fix shuffle to not always start with first track
- Removed logic that moved current track to front of shuffle
- Now finds current track position in shuffled order instead
- Shuffle is truly random, not biased to original order
3. Add missing await to all setPlaybackContext calls
- PlaylistDetailView: await context creation
- FavoritesView: make setFavoritesContext async + await calls
- ArtistDetailView: await context creation
- HomeView: await context creation
- SearchView: await + use home_list type (search type doesn't exist)
This fixes intermittent context tracking (race condition)
Fixes: shuffle starting with first song, Local Library context error,
intermittent playlist/favorites/artist/home/search context tracking
cc
Add proper context tracking for Local Library playback so the stack
icon shows correctly when playing from Local Library.
Changes:
- Add 'local_library' to ContextType enum (frontend and backend)
- Add 'Local Library' display label in context info
- Import setPlaybackContext in LocalLibraryView
- Call setPlaybackContext when playing tracks from Local Library
- For album view: context is the album with album title
- For tracks view: context is "Local Tracks"
- Track IDs and position are properly set for context navigation
Fixes issue where Local Library playback showed stale Qobuz context.
cc
Add shuffle functionality to Local Library album view with button
that enables shuffle mode before playing all tracks.
Changes:
- Import Shuffle icon from lucide-svelte
- Add handleShuffleAllAlbum function
- Add shuffle button next to Play All button
- Add shuffle-btn CSS styling matching secondary button pattern
cc
Previous implementation had a critical bug in the shuffle algorithm
that used the same seed value for all iterations, resulting in
weak/predictable shuffling.
Changes:
- Add rand crate dependency for proper PRNG
- Fix Fisher-Yates to use unique random value per iteration
- Use StdRng with timestamp-based seed for reproducible randomness
- Each shuffle iteration now gets a new random number from the RNG
This fixes shuffle working inconsistently across different contexts
(albums, playlists, continuous play).
cc
Add comprehensive Flatpak section with:
- Warning about PipeWire bit-perfect limitations in sandbox
- Instructions for ALSA Direct workaround
- NAS/network storage access commands (flatpak override)
- Note in Audio Backends section about Flatpak restrictions
This helps users make informed installation choices before downloading.
Display warning banner in Settings when user enables DAC Passthrough
with PipeWire backend in Flatpak environment.
The warning informs users that:
- PipeWire cannot guarantee bit-perfect in Flatpak sandbox
- ALSA Direct backend is recommended for true bit-perfect audio
This addresses the fundamental limitation where Flatpak portal does
not allow control of PipeWire daemon sample rate configuration, even
with elevated permissions.
Two critical fixes for Flatpak sandbox environment:
1. PipeWire detection now uses pactl instead of pw-cli
- pw-cli is not available in GNOME Flatpak runtime
- pactl works for both PipeWire and PulseAudio (compatibility layer)
- Fixes missing PipeWire backend in Settings
2. App ID migration now works in Flatpak sandboxes
- Detects Flatpak environment and uses absolute paths
- Accesses old sandbox (com.blitzkriegfc.qbz) via HOME directory
- Added read-only permission to old App ID in manifest
- Properly migrates config/data/cache from old to new sandbox
BREAKING CHANGE: App ID changed from com.blitzkriegfc.qbz to com.blitzfc.qbz
Changes:
- Renamed Flatpak App ID and all metadata files
- Fixed MPRIS name: qbz_nix → qbz
- Added NAS support permissions: /mnt, /media, /run/media
- Updated CI workflow for new filenames
- Updated tauri.conf.json bundle identifier
Flatpak features:
- Runtime detection (/.flatpak-info check)
- Automatic data migration from old App ID
- Migrates config, data, and cache directories
- Non-destructive (preserves old directories)
- Runs on startup before any other initialization
- New Settings section (Flatpak-only)
- Filesystem permission guidance
- Copy-paste ready commands for NAS/SSHFS
- Professional UX per Flatpak best practices
Migration is automatic and transparent for existing users.
Features:
- New Settings section that appears ONLY when running in Flatpak
- Displays clear instructions for granting filesystem permissions
- Copy-paste ready commands for common scenarios (NAS, SSHFS)
- Explains Flatseal as GUI alternative
- Professional, defensive UX per prompt requirements
The section is completely hidden when not in Flatpak.
Users see actionable guidance with examples.
Features:
- Flatpak runtime detection (/.flatpak-info check)
- Automatic migration of user data from old App ID to new ID
- Config: ~/.config/com.blitzkriegfc.qbz → ~/.config/qbz
- Data: ~/.local/share/com.blitzkriegfc.qbz → ~/.local/share/qbz
- Cache: ~/.cache/com.blitzkriegfc.qbz → ~/.cache/qbz
- Migration runs on startup before any other initialization
- Old directories are preserved (manual cleanup required)
- Tauri commands for frontend integration:
- is_running_in_flatpak()
- get_flatpak_help_text()
Migration is non-destructive and idempotent.
Changes:
- Renamed Flatpak manifest, desktop file, and AppStream metainfo
- Updated App ID in all metadata files
- Fixed MPRIS name: qbz_nix → qbz
- Added NAS support permissions: /mnt, /media, /run/media
- Updated CI workflow to use new filenames
- Updated tauri.conf.json bundle identifier
BREAKING CHANGE: Users will need to migrate data from old App ID directories
Data migration will be implemented in next commit
Implements native ALSA hw: device support for bit-perfect playback with:
- Direct PCM access bypassing PipeWire/Pulse resampling
- Automatic format detection (S16_LE, S24_LE, S32_LE, FLOAT_LE)
- Optional hardware mixer volume control via ALSA
- HW badge indicator for ALSA Direct mode
- DAC badge improvements with device name tooltip
- Lightweight hardware status polling for sample rate verification
Database migrations are safe for existing users (1.1.5+):
- alsa_hardware_volume column added with NULL-safe handling
- Defaults to disabled for backwards compatibility
UI improvements:
- Improved ticker animation on album cards and tooltips
- Badge tooltip shows actual device name with scrolling
- Fixed badge width consistency across quality types