Commit Graph
578 Commits
Author SHA1 Message Date
vicrodh f59f0e1b87 feat(qbz-nix): Phase 6.2 - CoreBridge and V2 commands
Add bridge layer connecting QbzCore to Tauri and example V2 commands.

New files:
- core_bridge.rs: CoreBridge wraps QbzCore for Tauri integration
- commands_v2.rs: Example commands using new architecture

V2 commands implemented:
- v2_is_logged_in, v2_login, v2_logout (auth)
- v2_get_queue_state, v2_set_repeat_mode, v2_toggle_shuffle, v2_clear_queue

These coexist with old commands during migration. Frontend can
gradually switch to V2 commands as they're tested.
2026-02-14 14:54:20 -06:00
vicrodh d0e46aca05 feat(qbz-nix): Phase 6.1 - integrate extracted crates
Add dependencies on extracted crates and create TauriAdapter.

Changes:
- Add qbz-models, qbz-audio, qbz-player, qbz-qobuz, qbz-core as deps
- Add async-trait dependency for FrontendAdapter impl
- Create tauri_adapter.rs implementing FrontendAdapter
- TauriAdapter emits CoreEvents to frontend via Tauri event system

This is the first step of integration. The old modules still exist
but the new crates are now available for gradual migration.
2026-02-14 14:32:24 -06:00
vicrodh 1c9bb8dfdb Merge branch 'pr-79' into pre-release 2026-02-14 12:37:54 -06:00
Joel C 1ad22000ea Add unit tests 2026-02-14 17:57:26 +01:00
Joel C f29f95f6d2 Fix clear queue, preserve playing track if needed 2026-02-14 17:57:16 +01:00
Joel C 4908421308 Fix play queue move_track, map incoming from, to index to internal state 2026-02-14 17:57:00 +01:00
vicrodh 752c236c11 fix(queue): correct index calculation when no track is playing
- When current_index is None, upcoming starts at index 0, not 1
- Add syncQueueState() after removing track to refresh UI
2026-02-13 14:23:00 -06:00
vicrodh 8dcad203c7 fix(queue): correct remove-from-queue index and add history context menu
- Add remove_upcoming_track command that correctly maps upcoming index
  to actual queue index (handles shuffle mode properly)
- Update frontend to use remove_upcoming_track instead of remove_from_queue
- Add working context menu for history tracks (Add to Playlist, Track Info)
- Remove unused .track-menu CSS class
2026-02-13 13:29:30 -06:00
vicrodh 3a8ef43227 feat(audio): add device refresh button and per-DAC sample rate limit
- Add refresh button next to device dropdown to re-enumerate devices
  without app restart (fixes #69)
- Re-enable quality limiting with per-device sample rate storage
- User can manually set max sample rate per DAC (44.1k to 384k)
- Quality limiting is opt-in (disabled by default)
- Streaming Quality dropdown always takes priority (fixes #72)

Backend: HashMap<device_id, max_rate> stored as JSON in SQLite
Frontend: Conditional UI shows rate dropdown when limit is enabled
2026-02-13 12:56:50 -06:00
vicrodh 333e6f224a feat(ui): show default device name under System Default option
Adds a help text showing which device is the current system default.
This helps users understand what "System Default" will actually use.

Backend:
- New command `get_default_device_name` that uses pactl for PipeWire/Pulse
  and CPAL for ALSA to get the current default device

Frontend:
- Shows "(System Default is: <device name>)" under the output device setting
- Styled as secondary description text (italic, muted)

Translations added for en, es, de, fr.
2026-02-13 12:35:56 -06:00
vicrodh d3fec83aa2 refactor(alsa): use /proc/asound as primary enumeration source
Previously, CPAL was the primary source and /proc/asound supplemented
missing devices. This caused inconsistent device lists because CPAL
cannot enumerate devices that are in exclusive mode.

New architecture:
- /proc/asound = PRIMARY source (always complete, stable IDs)
- CPAL = OPTIONAL enrichment (sample rates, may be unavailable)

Benefits:
- Device list is now consistent regardless of playback state
- No more devices appearing/disappearing when entering settings
- Stable device IDs using card NAMES instead of numbers (fixes #69)

Tradeoff:
- Sample rates may be unavailable when device is in exclusive mode
- This is acceptable: consistency > sample rate display
2026-02-13 11:56:08 -06:00
vicrodh 543f49ef82 fix(alsa): use consistent description format for proc devices
When adding devices from /proc/asound (because CPAL couldn't enumerate
them during exclusive mode), use the same description format as CPAL:
"{card_name}, {device_id}" instead of the longer format with
"Direct Hardware - Bit-perfect" suffix.

This ensures the device dropdown shows consistent names regardless
of whether the device was found by CPAL or added from /proc.
2026-02-13 11:50:01 -06:00
vicrodh 4af65fede5 fix(alsa): remove hw:X,Y enumeration for device ID stability
ALSA hw:X,Y device IDs use card NUMBERS which are unstable and change
between boots depending on USB enumeration order. This caused saved
devices to become unrecognized after reboot (issue #69).

Now only enumerate front:CARD=name,DEV=Y devices which use the card
NAME instead of number. Both formats are functionally equivalent for
bit-perfect playback, but front: format is stable across reboots.

Fixes #69
2026-02-13 11:38:39 -06:00
vicrodh 0e6b1fc686 refactor(alsa): replace aplay with /proc/asound reads
Remove dependency on alsa-utils package by reading device information
directly from /proc/asound filesystem:

- /proc/asound/cards for card list with names
- /proc/asound/cardX/ for detailed card info
- /proc/asound/cardX/pcmXp/ for PCM device info

This addresses Flathub reviewer feedback about not using CLI tools
when API alternatives exist. The /proc/asound interface provides
all the information we need for device enumeration and descriptions.

Changes:
- alsa_backend.rs: New enumerate_with_proc_descriptions() using /proc
- audio_backends.rs: Remove aplay calls from DAC capabilities query
- check_alsa_utils_installed() now always returns true (no longer needed)
2026-02-13 10:30:42 -06:00
vicrodh 78aa6694c7 fix(flatpak): use appid as MPRIS dbus name, remove own-name permission
Change dbus_name from "qbz" to "com.blitzfc.qbz" so the MPRIS name
matches the appid pattern. This eliminates the need for the explicit
--own-name permission as Flatpak allows apps to own names under their
appid namespace automatically.

cc
2026-02-13 07:54:36 -06:00
boxdot c207a60ba4 fix: UI lag
The lag was due to using sqlite in non-WAL mode.
2026-02-13 09:29:26 +01:00
vicrodh 1959000fd0 Expose graphics fallback status to UI with warning
Backend:
- Add static atomics to track graphics startup state
- Add set_startup_graphics_state() called from main.rs
- Add get_graphics_startup_status command for frontend

Frontend (SettingsView):
- Query graphics startup status on mount
- Show prominent red warning in Composition section when
  using fallback graphics settings
- Display recovery command (qbz --reset-graphics)

i18n: Add fallbackWarning/fallbackDesc to all 4 locales

This helps users understand when graphics settings failed to
load and may be causing performance degradation.
2026-02-12 13:11:47 -06:00
vicrodh 0d5c50a23a Add visible logging for graphics settings fallback
When graphics settings fail to load from DB:
- Logs warning to stderr (visible in terminal)
- Logs to startup log with recovery instructions
- Tracks fallback state for potential UI exposure
- Adds summary log of graphics config at startup

Helps users diagnose performance degradation caused by
silent graphics settings failures.
2026-02-12 13:05:41 -06:00
vicrodh dae8d509e5 Reduce playback state emission frequency (250ms -> 500ms)
Reduces UI reconciliation work during playback from 4Hz to 2Hz.
Seekbar updates remain smooth while cutting CPU overhead in half.
2026-02-12 13:02:16 -06:00
vicrodh e03c823bfd feat: add --reset-graphics CLI flag for full composition reset
Resets all graphics/composition settings to defaults:
- force_x11: false
- gdk_scale: auto
- gdk_dpi_scale: auto
- force_dmabuf: false

Use when QBZ crashes on startup due to bad graphics config.

cc
2026-02-12 11:40:53 -06:00
vicrodh 700183b0bb fix: prevent multiple instances when reopening from desktop icon
Cherry-picked from main (c163435b)

cc
2026-02-12 09:46:03 -06:00
vicrodh f0b7b2efb9 feat(graphics): add GPU rendering summary to startup logs
Shows effective rendering state after all env var decisions:
- FULL: compositing GPU + DMA-BUF GPU
- partial: which subsystems are on CPU vs GPU
- OFF: software rendering via llvmpipe

cc
2026-02-10 20:08:09 -06:00
vicrodh 31019d9b6a fix(graphics): revert to v1.1.9 rendering defaults, fix UI lag
Reverts the aggressive GPU disabling introduced in v1.1.10/11 that
caused severe UI lag for all users. The previous approach disabled
WEBKIT_DISABLE_DMABUF_RENDERER globally (not just NVIDIA) because
hardware_accel defaulted to false.

New behavior (matches v1.1.9 targeted mitigations):
- X11 non-NVIDIA: nothing disabled (full GPU acceleration)
- X11 + NVIDIA: only DMA-BUF disabled
- Wayland: compositing + DMA-BUF disabled (prevents EGL crashes)
- Wayland + force_x11: runs as X11 (XWayland)
- VM: software rendering via llvmpipe

Improvement over v1.1.9: DMA-BUF now disabled for ALL Wayland GPUs
(not just NVIDIA), which prevents the Intel Arc EGL crash from #59.

All settings bypassable via env vars:
- QBZ_HARDWARE_ACCEL=0 disables all GPU rendering (nuclear opt-out)
- QBZ_HARDWARE_ACCEL=1 bypasses all safety (full GPU everywhere)
- QBZ_FORCE_X11=1 forces XWayland backend
- QBZ_FORCE_DMABUF=1 / QBZ_DISABLE_DMABUF=1 fine-grained DMA-BUF
- QBZ_SOFTWARE_RENDER=1 forces Mesa llvmpipe

Also adds GDK_SCALE and GDK_DPI_SCALE DB persistence for XWayland
scaling (workaround from #67).

cc
2026-02-10 19:27:39 -06:00
vicrodh 63abf1f90c fix: graphics settings store fails on existing databases
The CREATE TABLE included force_x11 column but INSERT OR IGNORE
also referenced it, so on existing DBs (without the column) the
entire execute_batch failed before reaching the ALTER TABLE
migration. Keep original schema in CREATE/INSERT, let ALTER add
the new column.
2026-02-10 08:37:35 -06:00
vicrodh 0f31dcd310 feat: add persistent Force X11 setting for Wayland crash workaround
Add a toggle in Settings > Appearance to force X11 (XWayland) backend
on Wayland sessions. Persisted in graphics_settings.db, env var
QBZ_FORCE_X11=1|0 overrides for crash recovery. Also fixes the
display server log to report effective GDK backend instead of
session type.
2026-02-10 07:18:15 -06:00
vicrodh d3d719c609 fix: log effective display server after GDK backend selection
The "Display server" log message was checking WAYLAND_DISPLAY env var
before GDK_BACKEND selection, so GDK_BACKEND=x11 still showed
"Display server: Wayland". Now logs AFTER selection and reports
the effective backend (including "X11 (XWayland)" when forcing x11
on a Wayland session).
2026-02-10 07:10:06 -06:00
vicrodh 07f9f64a08 fix: persist volume and tray settings across restarts
Volume was saved to per-user localStorage but loaded from unscoped key
before login set the userId. Added resyncPersistedVolume() called after
login to re-read from the correct scoped key.

Close/minimize to tray read settings once at startup from the flat-path
DB, but user changes were saved to per-user DB after login. Changed
close-to-tray to read dynamically from state, and minimize-to-tray to
re-fetch before each action.
2026-02-10 06:23:05 -06:00
vicrodh c071b86ae2 feat: preserve original Qobuz playlist image when copying to library 2026-02-10 02:05:17 -06:00
vicrodh 0f8bba5f89 feat: add playlist tags endpoint and DiscoverPlaylistsBrowseView component 2026-02-10 01:48:37 -06:00
vicrodh d912bd1284 feat: add genre_ids support to discover playlists endpoint 2026-02-10 01:43:49 -06:00
vicrodh ba62057545 feat: add Qobuzissimes, Albums of the Week, Press Accolades browse pages
- Add 3 new Rust endpoint constants and command mappings for
  /discover/qobuzissims, /discover/albumOfTheWeek, /discover/pressAward
- Add 3 new navigation ViewType values and genre filter contexts
- Extend DiscoverBrowseView to handle the 3 new endpoint types
- Add See All links with chevron caret and pipe separator to all 6
  discover sections in HomeView (newReleases, mostStreamed,
  essentialDiscography, qobuzissimes, editorPicks, pressAwards)
- Wire up 3 new views in +page.svelte with full album action callbacks
- Rename Editor's Picks to Albums of the Week, Press Awards to Press
  Accolades across all 4 locale files (en, es, de, fr)
- Fix rank badge: top-right position, Impact font, 35px size
- See All styling: inline-flex with ChevronRight icon, pipe divider,
  15px gap before nav buttons, #666666 color matching nav buttons
2026-02-10 01:10:28 -06:00
vicrodh c9bdcae855 feat: add discover browse pages for New Releases, Ideal Discography, Top Albums
Add full-page browsing views for the three discover sections that were
previously only shown as limited carousels on the Home page.

Backend: add get_discover_albums Tauri command with endpoints for
newReleases, idealDiscography, and mostStreamed. Uses paginated API
calls with genre_ids filtering.

Frontend: new DiscoverBrowseView component with virtualized grid/list,
genre filter dropdown, client-side search, and infinite scroll.
VirtualizedFavoritesAlbumGrid gains ranking support (showRanking),
infinite scroll (onLoadMore), and loading indicator.

HomeView sections now show "See All" links that navigate to the
dedicated browse pages. i18n keys added to all 4 locales.
2026-02-10 00:46:39 -06:00
vicrodh ed06a397ef fix(lyrics): re-fetch when cached entry lacks synced lyrics
Cached entries with plain-only lyrics were served forever, even after
the search-first strategy can now find synced versions. Treat plain-only
cache entries as a miss so the provider chain runs again. If synced
lyrics are found, the cache is updated via upsert.
2026-02-09 23:58:46 -06:00
vicrodh 8cf84b64e8 fix(lyrics): search-first strategy to prioritise synced lyrics from LRCLIB
GET /api/get often returns results without synced lyrics even when they
exist in the database. Switch to search-first: /api/search returns
multiple candidates so pick_best_match can select one with synced lyrics.
GET is now only a fallback when search yields nothing.

Also pass track_name + artist_name as separate search filters instead
of a combined q param for more precise results.
2026-02-09 23:35:25 -06:00
vicrodh 8270de2e5e perf(api): replace Mutex with RwLock for QobuzClient
QobuzClient has no &mut self methods — all API calls are read-only.
The Mutex serialized all concurrent API requests (favorites sync,
sidebar playlists, playlist loading) causing 6+ second wait times
at startup.

RwLock allows concurrent reads. All 94 call sites across 20 files
changed from .lock() to .read(). ListenBrainz/LastFm clients keep
their own Mutex (different state, different lock).
2026-02-09 22:50:35 -06:00
vicrodh 1c7a14d789 fix(api): use POST with JSON body for track/getList endpoint
The Qobuz track/getList endpoint requires a POST request with
JSON body {"tracks_id": [...]} — not GET with query params or
form-encoded POST. This matches the Qobuz web player behavior.
2026-02-09 22:15:18 -06:00
vicrodh 042a307c41 fix(api): add POST fallback and flexible response parsing for track/getList
The Qobuz track/getList endpoint may require POST instead of GET.
Try GET first, fall back to POST with form body if response is an error.
Also handle multiple response structures and log the actual response
keys for debugging.
2026-02-09 22:03:28 -06:00
vicrodh fa784df62e feat(playlist): progressive loading via track_ids + track/getList
Replace monolithic get_playlist call with two-phase approach:
- Phase 1: playlist/get?extra=track_ids returns metadata + all track
  IDs in a single lightweight call (~50KB vs ~5MB)
- Phase 2: track/getList fetches full details in batches of 50,
  4 concurrent groups, with tracks rendering progressively

Backend changes:
- Add TRACK_GET_LIST endpoint and PlaylistWithTrackIds model
- Add get_playlist_track_ids and get_tracks_batch API client methods
- Add corresponding Tauri commands
- Update remove_tracks_from_playlist to accept either
  playlist_track_ids or regular track_ids (resolves internally)

Frontend changes:
- Rewrite loadPlaylist() for two-phase progressive loading
- Show playlist header + placeholder tracks after Phase 1 (~0.5s)
- Fill in full track details as batches arrive
- Add placeholder track row CSS (gray bars, no shimmer)
- Use Qobuz pre-made collage images from playlist metadata
- Update track removal to handle missing playlist_track_id
2026-02-09 21:56:15 -06:00
vicrodh 6a56a1492d debug: add timing logs across entire playlist load pipeline 2026-02-09 21:02:44 -06:00
vicrodh c084e64756 perf(api): fetch playlist pages concurrently after first page
First page is fetched normally to get metadata and total track count.
Remaining pages are launched concurrently via futures::join_all and
reassembled in offset order. For a 2000-track playlist this means
3 concurrent requests instead of 3 sequential ones (~3x faster).
2026-02-09 20:56:04 -06:00
vicrodh 4bbf97a131 feat(playlist-import): multipart playlists for 2000+ track imports
Qobuz limits playlists to 2000 tracks. When matched tracks exceed
this limit, the importer now automatically splits into multiple
playlists named "Playlist (Part 1)", "Playlist (Part 2)", etc.

- models.rs: qobuz_playlist_id -> qobuz_playlist_ids Vec, add parts_created
- importer.rs: chunk matched tracks by 2000, create playlist per chunk
- Frontend: show parts count in summary, move all parts to folder
- i18n: add partsCreated key in en/es/de/fr
2026-02-09 18:43:46 -06:00
vicrodh 595d6d46f5 fix(spotify): add token retry, HTTP status checking, and diagnostics
The Spotify API path was failing silently (no visible logs) and falling
back to embed which caps at ~100 tracks. Root cause: HTTP error
responses (401/429) were parsed as JSON, then failed with the
misleading "missing items" error.

Changes:
- Add error_for_status() to all HTTP calls (proxy, metadata, tracks)
  so 401/429/5xx errors surface immediately with real status codes
- Retry token + fetch once before falling back to embed (handles
  transient proxy failures and token expiry)
- Descriptive error messages include which request failed
2026-02-09 18:13:49 -06:00
vicrodh ef5a7b6c0e fix(spotify): restore embed fallback when API fetch fails
The previous commit blocked the embed fallback when the API token was
obtained but the fetch failed, causing a hard error instead of
returning partial results. Restore the original fallback behavior
with logging to diagnose API failures.
2026-02-09 18:07:57 -06:00
vicrodh e2e8766775 fix(spotify): improve pagination reliability and stop silent embed fallback
The embed scraping fallback silently caps at ~100 tracks. When the API
token was obtained successfully but the fetch failed (transient error,
rate limit), the code fell through to embed without logging, returning
incomplete results.

Changes:
- Propagate API errors instead of silently falling through to embed
  when the token was successfully obtained
- Fix next-page detection: use is_null() instead of as_str() which
  could miss non-string truthy values
- Use response.total field as backup pagination signal
- Add safety checks for empty pages to prevent infinite loops
- Validate fetched count against expected total from metadata
- Add logging at every decision point for diagnosability
2026-02-09 18:00:18 -06:00
vicrodh 9fdd1dd0df feat(playlist-import): concurrent matching with progress reporting
Replace sequential track matching with buffer_unordered(8) for 8
concurrent Qobuz API calls, reducing import time ~8x. Add real-time
progress events (import:progress, import:phase) emitted from Rust
backend and consumed by frontend via Tauri event listeners.

Frontend shows progress bar, matching status text, and current track
name during import. Individual search failures are now logged and
skipped instead of aborting the entire import.
2026-02-09 17:53:04 -06:00
vicrodh a46a422a04 fix(playlist): paginate get_playlist to fetch all tracks
The Qobuz API get_playlist call was hardcoded with limit=500, silently
dropping tracks beyond that. Now paginates in 500-track pages using
the TracksContainer.total field until all tracks are loaded.
2026-02-09 17:33:51 -06:00
vicrodh bd5725f345 feat(playlist): remove total track limit from smart playlists
Remove max_total_tracks (was 100) cap and all truncation/early-break
logic from smart playlist generation. Playlists now include all
tracks found across related artists. Increase per-artist sampling
from 10 to 25 for richer results.
2026-02-09 17:27:35 -06:00
vicrodh ae1a3533a8 Merge branch 'feature/external/warn-on-playlist-duplicates' into pre-release 2026-02-09 17:11:15 -06:00
vicrodh 7a83bfa0b9 fix(lyrics): retry LRCLIB once on network error before fallback
Distinguish not-found (Ok(None)) from network error (Err) in
fetch_lrclib. On network error, retry the full LRCLIB flow once
before falling back to lyrics.ovh. Not-found skips directly to
the fallback with no retry.
2026-02-09 15:06:09 -06:00
vicrodh d1fd6e045f fix(lyrics): fallback to lyrics.ovh when LRCLIB fails
Network errors in LRCLIB were propagated as hard Err via ? operator,
preventing the lyrics.ovh fallback from ever being reached. Changed
provider functions to return Option instead of Result so errors are
treated as soft failures. Added 10s HTTP timeout. Fixed internal
LRCLIB fallback (GET failure now falls through to search). Replaced
hardcoded UI strings with i18n keys.
2026-02-09 15:02:57 -06:00