Commit Graph
6659 Commits
Author SHA1 Message Date
vicrodh 8fd962284e fix(sync): serialize shared media cache writes
Prevent parallel Jellyfin, Subsonic, and quality hydration transactions from colliding on the shared SQLite cache during Resync all. Keep WAL reads concurrent and retain a bounded timeout for external writers.

cx
2026-08-24 23:19:55 -06:00
vicrodh 635b8b3a45 fix(metadata): restore editor mounting
Remove an unsupported shared-button property that invalidated the
workspace type lazily in both AlbumView and ephemeral surfaces.

cx
2026-08-24 22:00:22 -06:00
vicrodh 5e759fab50 refactor(metadata): split editor workspace
Give track editing a dense spreadsheet pane, move album tags to an independent sidebar, and isolate remote metadata and artwork lookup in a loading-aware popup.

cx
2026-08-24 21:37:11 -06:00
vicrodh fa649394d1 fix(metadata): scope track row selection
Bind nested editor controls to the delegate index so virtualized rows never resolve an undefined context property.

cx
2026-08-24 20:44:13 -06:00
vicrodh 284db1bfd5 chore(i18n): translate local library workflows
Cover the metadata editor, genre browsing, local tab ordering, and related validation feedback across all eight maintained locales.

cx
2026-08-24 19:47:21 -06:00
vicrodh 75a668ed12 feat(metadata): expand the local tag editor
Promote metadata editing to a routed full-page workflow with tabular per-track fields, ordered artist credits, provider identifiers, and compilation handling.

Add bounded artwork selection and retrieval through MusicBrainz, Discogs, and Last.fm. Direct and sidecar saves preflight immutable rows, verify rich tag writes, cache covers by content, and update exact database ids transactionally.

cx
2026-08-24 19:46:59 -06:00
vicrodh ed8d11e5c8 feat(library): expose catalog recovery guardrails
Add deterministic end-to-end recovery measurements for the production legacy projector at 20k and 200k rows. Validate album and artist FTS through reconciliation updates and deletions, and provide a read-only runtime integrity probe for active generations.\n\nPublish catalog generation, size, row count, integrity state, and effective surface routes in diagnostics while logging native versus legacy loads with their fallback reason.\n\ncx
2026-08-24 18:28:08 -06:00
vicrodh 5402f36992 test(library): cover every catalog track index
Extend the existing EXPLAIN plan guard to every directional TrackSort index.

cx
2026-08-24 17:44:04 -06:00
vicrodh 5a14eef258 fix(metadata): complete local editor sessions
Consume preflight data when loading clears so the modal cannot spin indefinitely.

Reuse the editor for ephemeral folders and bind sidecar or direct writes to the exact active session.

cx
2026-08-24 17:28:54 -06:00
vicrodh 0e53837582 feat(metadata): restore local tag editor in Qt
Restore the selected-version editor with sidecar-safe defaults, inspected tag layers, guarded MusicBrainz and Discogs lookup, and confirmed verified direct writes. Keep paths Rust-owned and reject stale or injected drafts.

cx
2026-08-24 16:41:06 -06:00
vicrodh d81f69113e fix(metadata): verify canonical tag writes
Inspect every tag layer before editing, target the container's canonical writable tag, and read values back before reporting progress. Preserve secondary layers by default, support explicit ID3v2.3 compatibility and synchronize compatible modern layers only when requested.\n\nMake sidecar clears persist across rescans while preserving omitted-field compatibility.\n\ncx
2026-08-24 16:33:40 -06:00
vicrodh 2c6bd510a9 fix(library): make explicit server resync authoritative
Treat Local Library resync actions as complete source reconciliations so provider IDs removed or reminted by Jellyfin are pruned only after a successful sweep.

Add regressions for a fully remapped Jellyfin identity set and for the QML resync contract.

cx
2026-08-24 15:36:32 -06:00
vicrodh d627560f4f fix(library): unify album versions across sources
Associate physical copies only when normalized album identity and strong track-title/duration overlap agree. Keep every source visible on one card and resolve each authoritative album id into the existing version cache.

Order versions by delivered quality and then track count, expose inferred edition labels and full format metadata, and keep source filters aware of every represented copy.

cx
2026-08-23 21:56:38 -06:00
vicrodh b4744b6e7f fix(playlists): open mixed playlists offline
Route numeric playlist details through persisted membership while offline. Resolve ready Qobuz downloads from the shared cache, append local and reachable Plex sidecars in stable order, and keep the page read-only without network access.\n\ncx
2026-08-23 20:59:25 -06:00
vicrodh 390a800545 fix(ui): cap now playing cards at eighty percent
Apply one shared runway fraction to the SongCard in New, Classic, Large, and Small modes while preserving each mode's alignment.

cx
2026-08-23 20:36:52 -06:00
vicrodh 63ca21abaf fix(library): paginate grouped Tracks globally
Order every source by the active grouping key before the bounded merge so later pages preserve the visible prefix. Remove the accumulated QML reorder that moved the viewport when new rows sorted ahead.

cx
2026-08-23 19:30:24 -06:00
vicrodh fcb9851736 fix(library): append Tracks pages without model reset
Keep one compatibility ListModel mounted and publish stable page prefixes through rowsInserted notifications. Preserve semantic anchor restoration only for grouped reorders so ordinary lazy pagination cannot move the viewport.

cx
2026-08-23 18:44:13 -06:00
vicrodh 1244687ab9 refactor(library): remove obsolete artist matcher wrapper
Keep the default alias-free matcher inside the test module now that production artist detail always uses corpus-derived family aliases. This removes a release-only dead-code warning without changing matching behavior.

cx
2026-08-23 18:02:58 -06:00
vicrodh f8092db81a fix(library): retain Tracks anchor through model publish
Capture the visible semantic anchor before requesting the next compatibility page and retain it across bridge signal ordering and the ListView polish pass. This prevents the loading latch from dropping early and avoids recursive page requests during viewport restoration.

cx
2026-08-23 17:50:09 -06:00
vicrodh 4a2f4bdc02 fix(library): canonicalize fallback artist families
Collapse repeated collection-and-contributor credits in the legacy Artists reader while retaining isolated collaborations. Preserve Unicode artist identities, resolve the collapsed row back to every family album, and use lexical QML timer ids so query coalescing remains live.

cx
2026-08-23 17:49:50 -06:00
vicrodh 6bbafb4f69 fix(library): collapse repeated artist credit families
Derive one canonical artist identity when an album-artist prefix repeats with multiple bullet-separated contributors, while preserving source-faithful credits and one-off collaborations. Rebuild schema-v4 catalogs side-by-side so existing installations receive the corrected artist rail without a rescan or in-place database migration.

cx
2026-08-23 17:11:53 -06:00
vicrodh 3ed48163aa fix(library): correct Tracks viewport restoration
Restore the semantic anchor in viewport coordinates and suppress lazy-page requests while the ListView is being repositioned. This avoids treating content coordinates as screen offsets and prevents recursive page loads during restoration.

cx
2026-08-23 16:58:16 -06:00
vicrodh f83e469fd9 fix(library): preserve Tracks viewport on paging
Anchor compatibility page updates to the first visible track and its partial-row offset, then restore after Qt finishes replacing the model. Invalidate deferred restores when a newer document wins.

cx
2026-08-23 16:20:18 -06:00
vicrodh 2c3dc2b29b fix(library): continue loading Tracks pages
Use origin-relative ListView scroll coordinates and terminal signals so compatibility pagination cannot stall after model replacement. Keep a manual Load more fallback and collapse duplicate page requests before Qt publishes busy state.

cx
2026-08-23 15:42:34 -06:00
vicrodh 23a4eb2912 feat(library): persist SACD image tracks
Adopt fully parsed SACD generations atomically into library.db and preserve local row IDs across image moves. Keep failed reads non-destructive, reject stale metadata writes, and project the virtual tracks through the existing local catalogue.

cx
2026-08-23 15:14:58 -06:00
vicrodh 6005510bf7 feat(library): sync Subsonic pages by generation
Project Search3 and per-album results into atomic source-generation pages, authorizing prune only after a complete enumeration.

Reject malformed authoritative responses, invalidate late writes across cancellation and profile changes, and sanitize secret-bearing transport errors.

cx
2026-08-23 14:37:45 -06:00
vicrodh 8fff37a8ef feat(library): hydrate Jellyfin quality in background
Publish bounded essential metadata pages through source generations, preserving delta sync and authorizing prune only after a complete full pass.

Hydrate MediaSources in persistent prioritized batches with cancellation epochs, startup resume, bounded retries, and coalesced catalog catch-up.

cx
2026-08-23 14:24:16 -06:00
vicrodh 6e0e0d3165 feat(library): sync Plex sections incrementally
Fetch Plex tracks in bounded container pages and commit each page with its per-section generation checkpoint. Resume interrupted sections, preserve hydrated quality, and authorize stale-row pruning only after the declared total is complete and identity-exact. Sanitize HTTP failures so authenticated request URLs never reach logs.

cx
2026-08-23 13:45:05 -06:00
vicrodh 480b4b46df feat(library): scan local roots incrementally
Stream each registered root into bounded extraction batches, persist fingerprint and checkpoint generations, and prune only after a complete reachable pass. Add local watcher hints plus separate periodic local and network reconciliation.

Preserve CUE identities, retry unreadable files, and keep cancellation, traversal errors, offline roots, and overlapping roots from authorizing destructive cleanup.

cx
2026-08-23 13:12:48 -06:00
vicrodh 6fd83c42df feat(library): page Artists from local catalog
Materialize source-scoped artist aggregates and FTS, then expose exact keyset pages and bounded A-Z metadata for the existing Artists rail.

Query the selected artist's albums through the indexed credit relationship with an independent bounded model, generation cancellation, artwork updates, and per-surface legacy fallback.

cx
2026-08-23 12:17:08 -06:00
vicrodh 299dcde5b4 feat(library): page Albums from local catalog
Materialize album browse fields and FTS in the derived catalog, then expose exact counts and stable keyset queries for the current filters, sort, grouping, and enabled sources.

Bind the existing Albums layout to a bounded native Qt model with asynchronous page misses, anchors, selection ranges, generation cancellation, artwork updates, and per-surface fallback. Resolve Plex native edition keys directly and retain the metadata-mode legacy reader.

cx
2026-08-23 10:54:31 -06:00
vicrodh 1bb3c41dcf feat(library): page Tracks from local catalog
Add an opt-in QAbstractListModel backed by keyset pages from the derived catalog, with bounded residency, global query semantics, source-aware actions, and per-session fallback to the existing reader.

Wire profile-scoped bootstrap locations and refresh the native surface only after a complete catalog is active.

cx
2026-08-23 09:37:15 -06:00
vicrodh 7689fb0df6 feat(library): reconcile catalog by source
Clone the active generation for bounded source reconciliation, advance watermarks only after complete observation, and prune only the completed source.

Coalesce catch-up after authoritative local and media-server writes while retaining the last complete generation on failure.

cx
2026-08-23 07:53:20 -06:00
vicrodh d39edf5850 feat(library): bootstrap derived catalog
Build the catalog side by side from read-only local, Plex, Jellyfin, and Subsonic cache snapshots after the first useful Qt frame.

Persist bounded batch checkpoints, preflight disk capacity, validate materializations, and activate generations atomically while preserving the existing reader as fallback.

cx
2026-08-23 07:23:23 -06:00
vicrodh a0d8a7fc94 feat(library): add derived local catalog
Introduce a frontend-agnostic generation schema with stable source identities, materialized album and artist structures, trigram FTS, matching sort indices, and descriptor-bound keyset queries.

Add deterministic SQLite coverage and an explicit one-million-track query gate.

cx
2026-08-23 06:39:00 -06:00
vicrodh 1edae11e52 fix(library): correct cross-source pagination
Bound each enabled source to an independent candidate page and merge one stable global Tracks page while advancing only consumed offsets. Include remote counts and artists, preserve Plex rows past 5,000, and reject stale search or sort generations before state and UI publication.

cx
2026-08-23 05:31:35 -06:00
vicrodh 4167f3d104 fix(home): refresh recent rails on playback
cx
2026-08-22 23:09:11 -06:00
vicrodh b03155fc2f fix(player): reduce classic song card width
cx
2026-08-22 23:09:11 -06:00
vicrodh 5160ddf6c1 fix(player): make song info responsive
cx
2026-08-22 22:26:32 -06:00
vicrodh 4e955a2b8b fix(queue): reuse resolved current cover
cx
2026-08-22 22:26:28 -06:00
vicrodh f9bc83ba8d fix(navigation): restore open media cascade
cx
2026-08-22 22:26:24 -06:00
vicrodh 04184d9d8f feat(navigation): add cascading local media menu
cx
2026-08-22 21:25:29 -06:00
vicrodh a2d0ada427 feat(queue): persist playback history across restarts
cx
2026-08-22 20:59:14 -06:00
vicrodh 5e4d7ca033 fix(queue): preserve metadata and polish extended view
cx
2026-08-22 20:58:46 -06:00
vicrodh c7038a6858 feat(queue): add extended queue view
cx
2026-08-22 20:01:47 -06:00
vicrodh eed377af1f perf(qt): optimize catalog views and gapless playback
cx
2026-08-22 18:50:21 -06:00
vicrodh e0e9566f81 perf(qt): window high-cardinality catalog views
cx
2026-08-22 16:16:36 -06:00
vicrodh 48c6f6854d fix(qt): harden remote playback transitions
cx
2026-08-22 15:42:06 -06:00
vicrodh c6d142ccb4 perf(qt): virtualize discovery and warm playback
cx
2026-08-22 14:35:36 -06:00
vicrodh 34d19211d5 perf(library): stop pulling embedded cover art just to read a track's tags
Opening a 247-file box set from a NAS took ~9.3 s. The instrumentation
added in the previous commit put the whole cost in one place:

  [ephemeral][perf] parallel tag reads: 9.268s for 247 files
  [ephemeral][perf] serial bookkeeping (artwork + ids): 29.4ms

Everything that is not a file read — artwork caching, id assignment,
grouping, sorting, serialising — is 29 ms. And parallelising the reads
across 8 threads had bought only 1.6x over the serial 14.7 s, which is
the signature of a BANDWIDTH wall, not a latency one: threads cannot help
when the bytes are the problem.

A FLAC keeps its cover art INSIDE the tag, so `Probe::read()` was pulling
multiple megabytes of picture data per file across the network in order
to recover a title, an artist and a track number. Those pictures were
then dropped on the floor: the cover shown for a block is resolved
separately, once per ALBUM, by `extract_artwork` / `find_folder_artwork`
— 13 reads out of 247 in this box.

`ParseOptions::read_cover_art(false)` on the two paths that only ever
wanted metadata (`extract_with_roots`, `extract_properties`).
`read_properties` stays ON: duration, bit depth and sample rate come from
the header and cost nothing. `extract_artwork` and `extract_artwork_bytes`
— the two functions that genuinely want the picture — are untouched.

MEASURED ON THE SAME FOLDER, SAME NAS, AFTER THE CHANGE:

  [ephemeral][perf] parallel tag reads: 922.9ms for 247 files
  [ephemeral][perf] serial bookkeeping (artwork + ids): 66.5ms

9.268 s -> 0.923 s on the reads, and ~14.8 s -> 990 ms for the whole
open. The prediction written before the run was "under 2 s", so the
mechanism is confirmed rather than merely consistent.

Worth recording plainly: the parallel-reads commit before this one was
NOT the fix. It masked a bandwidth problem with threads and made the
number look better while the app still moved the same bytes — and it left
me believing the remainder was the NAS's ceiling. What refuted that was
the owner pointing out that fooyin opens the SAME folder from the SAME
NAS almost instantly. The fix is not reading what nobody asked for.

Shared crate, so this also reaches the library scanner — which wants the
same thing for the same reason. qbz-library: 103 tests green.

cc
2026-08-22 11:32:27 -06:00