- Remove require_tos_accepted gate from all login commands
(v2_auto_login, v2_manual_login, v2_start_oauth_login, v2_login)
- Call accept_tos_best_effort after each successful session activation
so the value is persisted the moment login succeeds
- Re-initialize LegalSettingsStore in accept_tos_best_effort if torn
down (e.g. after factory reset that deletes legal_settings.db)
- Bootstrap ToS check now fails open (unwrap_or(true)) so saved
credentials still trigger auto-login after a factory reset
The frontend checkbox already gates the UI; the backend gate was
causing double-failures when the DB was unavailable post-factory-reset.
window.open() calls from social login providers are intercepted and opened
as related WebviewWindows (required on Linux/WebKitGTK). Both the main
window and all popups watch for play.qobuz.com?code_autorisation= so the
code is captured regardless of which window receives the final redirect.
Cleanup on timeout/cancel iterates all qobuz-oauth* windows.
- Save user_auth_token after successful OAuth login
- On bootstrap, restore session via saved token if no email/password creds
- If token is expired, clear it so user sees login screen normally
- Clear OAuth token on v2_clear_saved_credentials (logout)
- Add login_with_token() to api client (reuses OAuth /user/login step)
Also rename t->translateStore in NowPlayingBar.svelte (ADR-001 fix from Codex)
and improve clean-dev-runtime.sh to kill all stale processes and ports
Qobuz redirects to play.qobuz.com/discover?code_autorisation=XXX
not ?code=XXX. Both the navigation intercept and the /oauth/callback
API call were using the wrong parameter name, so the code was never
captured and the exchange request was malformed.
on_navigation returning false does not reliably block HTTP 302 redirects
on WebKitGTK (Linux). Closing the window from within the callback is
more reliable than calling close() from an async Tokio thread.
Changes:
- Always return true from on_navigation (never try to block)
- Close oauth window inside on_navigation callback after code capture
- Best-effort close via app.get_webview_window() after await (fallback)
- Add logging of every URL visited for debugging
- Idempotent: ignore duplicate code captures if callback fires twice
The subscribe handler in qobuzLegalStore persists acceptance fire-and-
forget. If the user checks the box and immediately clicks Login, the
async write can lose the race against require_tos_accepted() which reads
the DB synchronously. Force a synchronous persist in handleLogin() so the
backend gate always sees the correct value.
Previously all albums shared one scroll position key ('album'), so
opening any album would restore the scroll from the last album visited.
Now keyed as 'album:id', 'artist:id', 'playlist:id' so each item
tracks its own position independently. Back navigates to exact scroll,
fresh opens start at 0.
- Revert placement='top' to default bottom sticky across all views
- Content area already has padding-bottom: 100px in all views so no
track is ever hidden behind the bar
- AlbumDetailView/ArtistDetailView/WeeklySuggestView: bar now after tracks
- DynamicSuggestView/FavQView/TopQView: bar now after tracks (new views)
- LabelView: complete multi-select implementation with checkbox rows,
Select toggle button, and BulkActionBar after popular tracks list
AlbumDetailView:
- Select toggle button alongside AlbumMenu in action bar
- TrackRow selectable/selected/onToggleSelect props wired
- BulkActionBar with play next/later, add to playlist, add to favorites
- buildAlbumQueueTracks helper (album artwork and artist from album props)
ArtistDetailView (Popular Tracks section):
- Select button in section-header-actions alongside Play All
- Checkbox injected before track-number in custom track-row div
- click/keydown/contextmenu handlers respect multiSelectMode
- multi-selected highlight CSS
- BulkActionBar with add to favorites using toggleTrackFavorite
WeeklySuggestView:
- Select toggle button in track-controls (next to search)
- TrackRow selectable/selected/onToggleSelect props wired
- BulkActionBar with play next/later, add to playlist
- Reuses existing buildQueueTracks helper
- Add multi-select mode to PlaylistDetailView (independent of custom order mode):
Select toggle button in track-controls toolbar, multiSelectedKeys state,
checkboxes per row, multi-selected highlight, BulkActionBar with play
next/later, add to playlist, and bulk remove from playlist
- Bulk remove handles local tracks (one-by-one), Qobuz tracks with
playlistTrackId, and fallback trackId in a single invocation each
- Add onRemoveFavorites prop to BulkActionBar (HeartOff icon, danger style)
- Fix FavoritesView: replace Add to Favorites with Remove from Favorites
(tracks are already in favorites, remove makes sense there)
- Add BulkActionBar component (sticky-bottom bar with queue split button,
add to playlist, add to favorites, clear selection)
- Add selectable/selected/onToggleSelect props to TrackRow with checkbox UI
- Add .selected highlight and .track-checkbox CSS to TrackRow
- Extend VirtualizedTrackList with selectable/selectedIds/onToggleSelect props
- Wire FavoritesView tracks tab: Select toggle button in toolbar,
selectedTrackIds state, BulkActionBar with bulk queue/favorites/playlist handlers
- Add actions.select and actions.cancelSelection i18n keys to all 4 locales
- v2_bulk_add_to_queue: add multiple tracks to end of queue
- v2_bulk_add_to_queue_next: add multiple tracks as play next (reversed
to preserve selection order)
- v2_bulk_add_favorites: add multiple tracks to favorites via API then
update local cache atomically (lock not held across await points)
- v2_add_tracks_to_playlist and v2_remove_tracks_from_playlist already
accept Vec<u64> — no changes needed for playlist bulk actions
- Favorite tracks now display album art between track number and title,
matching the layout used in PlaylistDetailView (showArtwork=true)
- VirtualizedTrackList gains showArtwork and getArtworkUrl props
- AboutModal: add release codename 'La marrano de engorda' (1.1.15)
- README: remove stale KWin native title bar manual workaround section
After setting/removing custom artist images in ArtistDetailView
or LocalLibraryView, update the global store so all views
reflect the change immediately. Also fix LocalLibraryView to use
the resized thumbnail path from the backend result instead of
the original unresized file path.
Add withCustomImages() helper that overrides artist image objects
before passing to groupArtists(). All 3 call sites (alpha index,
sidepanel, virtualized grid) get custom image overrides.
Wrap getArtistImage() to check custom image store before
falling back to Qobuz default. All 3 call sites (most popular,
search results, virtual grid) get the override automatically.
Centralized store for resolving custom artist image overrides
globally. Loaded on login, exposes resolveArtistImage() with
normalized name matching (handles diacritics, case differences).
Add get_all_custom_artist_images() database method and
v2_library_get_all_custom_artist_images command to support
loading all custom artist image overrides at once for the
global resolution store.
vicrodh