Commit Graph
6101 Commits
Author SHA1 Message Date
Afonso Jorge Ramos 61df66c529 fix(offline): purge only allowlisted cache layout directories
Stop recursive-deleting arbitrary siblings of the offline root so a
mis-set cache path cannot wipe unrelated folders on a shared mount.
2026-07-13 13:49:55 +02:00
Afonso Jorge Ramos 542ee8050f fix(player): clear streaming loaded state on streaming setup failures
Buffer timeout, engine creation failure, and incremental source failure
no longer leave has_loaded_audio true with no engine; each records a
user-visible stream error.
2026-07-13 13:49:34 +02:00
Afonso Jorge Ramos e153673acf fix(cmaf): fail init parse when raw_data length exceeds payload
Do not advance the cursor by an unclamped raw_len after a truncated slice.
2026-07-13 13:48:40 +02:00
Afonso Jorge Ramos 39dccd8b01 fix(credentials): tighten permissions of existing secret files on load 2026-07-13 13:48:30 +02:00
Afonso Jorge Ramos c1bb5b3dc2 fix(audio): fail closed when ALSA exclusive rate is not exact
Read back the hardware rate after hw_params for PCM, DoP, and native DSD
and refuse silent nearest-rate mismatches.
2026-07-13 13:47:43 +02:00
Afonso Jorge Ramos e1c34005e0 fix(credentials): write secret files with mode 0o600 on Unix
Salt, machine-id fallback, encrypted credentials, and OAuth token files
must not inherit a permissive umask.
2026-07-13 13:47:18 +02:00
vicrodh d0a7ded531 fix(audio): superseded plays skip the 60s initial-buffer wait; non-streaming path falls back to legacy
Follow-ups to #591/#592. The streaming initial-buffer wait blocked the audio thread up to 60s even when the play had been superseded by a newer track, which fed the stop/restart-loop feel; play_generation moved onto SharedState and threaded through PlayStreaming so a superseded wait exits in ~50ms (the 60s timeout stays for genuine slow networks). And the non-streaming Play path gained the same legacy-CPAL fallback the streaming path got, instead of dead-ending on backend-init failure (macOS keeps surfacing the error). Control flow only; sample path untouched.

cc
2026-07-13 05:01:22 -06:00
vicrodh c3523722f4 feat(local-library): add a Plex sync button to refresh media without restarting
Fetching new Plex music required restarting QBZ. Add a sync button in the Local Library header (gated on plex-available, with a busy spinner) that triggers the existing Plex re-sync (new plex_auth::sync_now over the persisted selected libraries) and refreshes the view. Strings in all 8 locales. Resolves #573.

cc
2026-07-13 04:44:08 -06:00
vicrodh 99cf738a4c fix(scroll): boost Wayland trackpad scroll speed in the vendored Flickable
Trackpad PixelDelta events arrive divided by the HiDPI scale factor, making trackpad scrolling far slower than other apps on scaled Wayland desktops. In FlickableData::scroll_delta, distinguish line-based wheel deltas (always exact multiples of 60) from pixel-precise trackpad deltas and apply a 2.75x factor to the latter only; wheel and fling scrolling are unchanged. Resolves #588.

cc
2026-07-13 04:44:08 -06:00
vicrodh f8a256c62d fix(audio): don't require pactl for PipeWire, and fall back to legacy on streaming init failure
Two stacked defects broke playback under sandboxes (Snap/Flatpak/minimal .deb) in 2.0.1: PipeWireBackend::is_available() probed only `pactl info`, which those images don't ship, so PipeWire reported unavailable even though it was running (native pw-dump enumeration succeeded in the same log). And the streaming stream-init path had no legacy fallback (unlike init_device), so a failure dead-ended into a stuck spinner until the 45s watchdog. is_available() now checks the pipewire-0 socket + pw-dump (both time-bounded, fail-fast) with pactl kept as a last fallback; the StartStreaming path falls back to legacy CPAL on non-macOS. Sample path untouched (no gain/resample/rate change). Addresses #591/#592.

cc
2026-07-13 04:44:08 -06:00
vicrodh 0f88361427 fix(album): readable header text on light themes + gradient reaches the divider
The header sits on the always-dark art atmosphere, but its text used Theme.text-* which is dark on a light theme = unreadable. Route the header title/artist/meta/description through hdr-strong/hdr-body colors that go white over the gradient and fall back to the theme colors when the gradient is off; below-divider text is untouched. The atmosphere also faded out above the divider on description-bearing headers — raise its height to 440px and push the fade start to 74% so it reaches the header/track-list divider. Addresses #491/#519.

cc
2026-07-13 04:28:26 -06:00
vicrodh f5a8afc0f2 fix(playlist): reorder via the existing row drag gesture, not a bespoke grip
The prior reorder reused only the DragGhost but re-implemented the drag gesture with its own grip + absolute-position math, which placed the ghost several px off the cursor. Remove the grip entirely and drive reorder off the SAME row-body drag that already adds a track to a sidebar playlist: it captures the source index on start, the shared DragGhost (positioned by the Rust DragActions path) follows the cursor exactly, the drop slot is read from DragState.pointer-y against the ListView's absolute-position (no row double-count), and releasing WITHIN the list reorders while releasing on a sidebar playlist still adds. Reverted the sidebar drop suppression + removed DragState.reorder.

cc
2026-07-13 02:45:10 -06:00
vicrodh 85e11d284a feat(quality): downgrade arrow + true-quality tooltip on the Now Playing badge
Follow-up to #590: playback now downgrades to the streaming-quality setting but the badge still showed the catalog max with no indicator. The poll loop already received the delivered stream's sample-rate/bit-depth in PlaybackEvent but dropped them; publish them plus a quality-downgraded flag (effective < catalog max, DSD-exempt on depth) and the true effective detail string. AudioStamp shows an amber down-arrow glyph when downgraded and a Source/Output hover tooltip; mirrored to the miniplayer. Strings translated in all 8 locales.

cc
2026-07-13 01:49:18 -06:00
vicrodh 6e58682aa6 fix(playlist): reuse the shared drag ghost for custom-order reorder
The bespoke reorder ghost read a row's absolute-position inside a ListView, which double-counts the row's own offset, so it only sat at the cursor for row 0 and flew off for the rest. Drive the app-wide DragState directly from the reorder gesture so the shared DragGhost (positioned in AppShell at the proven window coords) renders the reorder ghost; a new DragState.reorder flag keeps the sidebar from claiming it as an add-to-playlist drop and keeps the Rust DragActions path out of it. Removed the buggy local ghost. Reorder logic + persistence unchanged. (state.slint also carries the quality-badge fields for the next commit.)

cc
2026-07-13 01:29:09 -06:00
Ronjar 9696c93a3d Changed apt format to deb822 (#530) 2026-07-13 00:40:16 -06:00
dependabot[bot] 144428ed89 chore(deps): bump softprops/action-gh-release from 2 to 3 (#577)
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2 to 3.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](https://github.com/softprops/action-gh-release/compare/v2...v3)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-version: '3'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-13 00:39:52 -06:00
dependabot[bot] caa9a682ef chore(deps): bump peter-evans/repository-dispatch from 3 to 4 (#576)
Bumps [peter-evans/repository-dispatch](https://github.com/peter-evans/repository-dispatch) from 3 to 4.
- [Release notes](https://github.com/peter-evans/repository-dispatch/releases)
- [Commits](https://github.com/peter-evans/repository-dispatch/compare/v3...v4)

---
updated-dependencies:
- dependency-name: peter-evans/repository-dispatch
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-13 00:39:49 -06:00
vicrodh 4210ec088a fix(playback): honor the streaming-quality setting
The Settings streaming-quality dropdown persisted the pref but playback used a hardcoded UltraHiRes const, so the setting did nothing. Resolve the pref (via a new streaming_quality_for_key mapping to the Quality format ids) at playback time for the normal, prefetch and gapless paths. Resolves #590.

cc
2026-07-13 00:19:51 -06:00
vicrodh c85686c473 feat(media-controls): inhibit system sleep/idle while playing (Linux)
QBZ let the machine suspend mid-playback. Take an org.freedesktop.login1 Inhibit (sleep:idle, block) fd while the MPRIS status is Playing and drop it on pause/stop, hooked to the same play-state channel MPRIS already uses. Linux-only, all failures log-and-continue. Resolves #522.

cc
2026-07-13 00:19:51 -06:00
vicrodh b3f866d933 fix(audio): treat D-Bus device-reservation name failure as non-fatal
Under Snap's mediated session bus, requesting the org.freedesktop.ReserveDevice name is denied and the error aborted ALSA Direct stream creation, so there was no audio. Fall back to the existing Degraded state (proceed without the reservation) on acquire failure, reusing the same non-fatal path the card-index / no-bus cases already take. Audio sample path untouched. Resolves #534.

cc
2026-07-13 00:19:51 -06:00
vicrodh 3174488d8e fix(renderer): classify Intel UHD 600 (Gemini Lake) as weak -> GL tier
It flickers on the wgpu tier; the reporter confirmed QBZ_RENDERER=gl fixes it. Added the uhd-600 markers to WEAK_GPU_MARKERS so it auto-selects the stable GL renderer. Resolves #578.

cc
2026-07-13 00:19:51 -06:00
vicrodh 256b0d36a0 fix(volume): kill the slider rubberband on release
The live-drag thumb reverted to the round-tripped bound value on release; because that value echoes back asynchronously the thumb snapped to the stale position then to the fresh one (a rubberband bounce). The thumb now tracks drag-fraction, which stays put on release and re-syncs to the external value only when it changes on its own (MPRIS / keyboard) while not dragging.

cc
2026-07-13 00:19:51 -06:00
vicrodh a0cca35810 fix(volume): live drag state on the slider primitives so the thumb follows the pointer
The de-quantization (0.1% scale + f32-bits atomic) removed the stepping in the VALUE, but the thumb still derived from the round-tripped bound value, so it felt snappy/laggy during a drag. Give QbzSlider/QbzVerticalSlider a live drag fraction: while held, the thumb tracks the pointer position directly (continuous, no round-trip); on release it reverts to the bound value. The emitted value is still the nearest step to the pointer (round), now imperceptible at the 0.1% scale.

cc
2026-07-12 23:38:34 -06:00
vicrodh e369f4bb3a chore(issue-template): require a logs checklist on bug reports
Adds a prominent 'bug reports need logs' banner and a required pre-flight checklist (attach logs or explain why not, searched duplicates, included repro steps). Without logs most reports stall on needs-info.

cc
2026-07-12 20:17:12 -06:00
vicrodh 42105eaf46 fix(volume): make the volume control fully fluid (de-quantize)
Volume snapped between 1% steps from two integer quantizers. UI: the volume sliders now use a 0..1000 scale so the shared int slider's round() lands on 0.1% (imperceptible). Runtime: the player volume atomic widened from integer-percent AtomicU64 to f32-bits AtomicU32 (same idiom as normalization_gain) so a continuous value no longer re-snaps on track restart / device switch / gapless. Bit-perfect untouched: 1.0f32 round-trips its bits, no gain multiply or ramp added to the protected ALSA-direct / DoP / JACK paths.

cc
2026-07-12 20:17:12 -06:00
vicrodh 2103bbd3eb feat(playlist): drag-and-drop reorder for custom-order tracks
Adds a dedicated drag HANDLE (grip) in the reorder gutter with the queue's drag gesture (6px threshold, absolute-position - root.y correction, three end paths incl. the changed-pressed safety net), so the row-body drag-to-sidebar stays intact. PlaylistView keeps component-local reorder state (slot math folds in the ListView viewport-y), a drop indicator and a floating ghost; commit fires PlaylistActions.reorder-track(from,to). Rust reuses the arbitrary-index persist path (repo::reorder for local, persist_custom for Qobuz) the arrows already back. Edge auto-scroll during drag is a follow-up TODO. Resolves #589.

cc
2026-07-12 20:17:12 -06:00
Victor RH 02cf9ad011 Merge pull request #586 from afonsojramos/bugfix/internal/cast-csprng-tokens
fix(cast): use CSPRNG media path tokens and redact URIs in logs
2026-07-12 19:40:03 -06:00
Victor RH 22a69a1db8 Merge pull request #585 from afonsojramos/bugfix/internal/dop-write-errors
fix(player): stop DoP writer on ALSA write failure
2026-07-12 19:40:00 -06:00
Victor RH db2f21289c Merge pull request #584 from afonsojramos/bugfix/internal/seek-engine-restore
fix(player): clear playing state when seek rebuild fails
2026-07-12 19:39:57 -06:00
Victor RH 287c3e93b5 Merge pull request #583 from afonsojramos/bugfix/internal/cancel-superseded-play
fix(player): cancel superseded play_track completions
2026-07-12 19:39:54 -06:00
Victor RH b99598e122 Merge pull request #582 from afonsojramos/bugfix/internal/log-redaction-all-sinks
fix(log): redact secrets on stderr and stop Last.fm body dumps
2026-07-12 19:39:51 -06:00
Victor RH 7fcbe1255a Merge pull request #581 from afonsojramos/bugfix/internal/queue-clear-keep-current
fix(queue): keep current_index track on clear(true)
2026-07-12 19:39:47 -06:00
Victor RH 9352a498a7 Merge pull request #574 from afonsojramos/ci/test-crates
ci: add test-crates workflow for workspace unit tests
2026-07-12 19:39:44 -06:00
vicrodh f4a6858f6b merge: kiosk profile (2.0.2 frente #3) into pre-release
Lightweight kiosk shell — profile boot (windowed default, fullscreen opt-in),
immersive mount, Now Playing redesign, Search All dashboard, lyrics lite-fill,
plus the owned-playlists Library fix.

cc
2026-07-12 19:39:17 -06:00
vicrodh d61b59223e fix(favorites): show owned playlists in the Library playlists tab
load_favorites built the Playlists Library sub-tab only from locally-hearted ids and the Following list excludes owner.id == uid, so the user's own playlists appeared nowhere. Seed the Library list with owned playlists first, then hearted-but-not-owned (dedup). Fixes desktop and kiosk.

cc
2026-07-12 19:38:43 -06:00
vicrodh ec8c487564 feat(lyrics): lite-fill display pref — static active-line highlight to cut CPU
The per-word karaoke sweep animates a clip rect ~60x/s, driving continuous full-window repaints (~4% CPU). Lite fill highlights the active line whole (no per-frame animation) so the surface only repaints on line changes. New toggle in the lyrics controls flyout, persisted via lyrics_prefs; default off (smooth karaoke). Kiosk / weak-GPU tiers force it on via ShellState.reduce-motion.

cc
2026-07-12 19:38:43 -06:00
vicrodh 5fa4e8bdd5 feat(kiosk): redesign Now Playing panel — dominant contain cover, compact meta, floating quality stamp
The cover is image-fit:contain filling the flex art area (no fragile parent-geometry math), so it is large and scales with the window. Toggle and meta rows get vertical-stretch:0 so only the art area takes the slack (nested layouts stretch greedily) — kills the dead space and the ~55px cover. Title toned to 20px, quality stamp floats on the transport row instead of owning a line. Cover<->Lyrics toggle; lyrics fill the panel width.

cc
2026-07-12 19:38:43 -06:00
Afonso Jorge Ramos 0ff3fc7f40 fix(scrobble): host delay gate in qbz-app for unit testing
Extract scrobble_delay_secs so cargo test -p qbz-app covers unknown
duration without compiling the Slint binary.
2026-07-13 00:08:18 +02:00
Afonso Jorge Ramos 41daffdf71 fix(scrobble): do not scrobble when track duration is unknown
duration_secs == 0 used to arm an immediate scrobble; skip delayed
scrobble instead while still allowing now-playing when online.
2026-07-13 00:01:11 +02:00
Afonso Jorge Ramos 7e824bd65a fix(offline): place download size validator at module scope 2026-07-12 23:57:18 +02:00
Afonso Jorge Ramos f507b5c214 fix(offline): reject truncated downloads when Content-Length is known
Fail closed on short bodies and empty payloads so partial files never
become complete cache entries.
2026-07-12 23:56:59 +02:00
Afonso Jorge Ramos 19b1c2bead fix(cmaf): fail closed on invalid session-key seed hex
Reject odd length and non-hex digits instead of zero-filling bad nibbles.
2026-07-12 23:33:14 +02:00
vicrodh 5be0e2233a feat(kiosk): hide NPB layout/lyrics/queue controls; layout button toggles Desktop mode
In kiosk the layout-flyout would carry a single Desktop mode row that the fixed-height popup floats high above the button, so the layout button toggles straight to Desktop mode instead. Lyrics/Queue toggles are hidden (their panels aren't mounted in the kiosk shell; the queue lives in Now Playing).

cc
2026-07-12 13:07:40 -06:00
vicrodh 772fe42df2 feat(kiosk): Search "All" dashboard — most-popular hero + per-type previews
All is no longer a flat album grid: a polymorphic most-popular hero (artist/album/track) plus Artists/Albums/Tracks(6)/Playlists previews, each with a View all that jumps to that tab. Reads SearchState verbatim, mirroring the desktop hierarchy.

cc
2026-07-12 12:43:56 -06:00
vicrodh dabf4a88c8 feat(kiosk): Now Playing — queue/history tabs, cover<->lyrics toggle with synced follow
Left panel toggles cover/synced lyrics (reuses LyricsLinesView, gated on status==2 to dodge the geometry recursion footgun); right panel is a Queue/History list (Flickable+VerticalLayout so rows top-anchor). The lyrics-sync engine bailed unless a desktop/immersive surface was open, so a kiosk-lyrics-follow flag on ShellState widens lyrics_surface_open().

cc
2026-07-12 12:43:56 -06:00
vicrodh 8cdf26cd34 perf(kiosk): window the album grid so only visible cards mount
cc
2026-07-12 12:43:56 -06:00
vicrodh 26f9e3e1a2 feat(kiosk): shell — mount immersive overlay, hide transport on Now Playing, fixed footer, drop Search tile
The immersive overlay hangs inside AppShell, so the kiosk shell mounts its own copy. The transport bar is hidden on Now Playing (redundant there) and the content height no longer subtracts it then, so the NavRail stays pinned. Footer Search tile removed — the back-bar carries a persistent search field.

cc
2026-07-12 12:43:56 -06:00
vicrodh 67d81ea415 feat(kiosk): boot windowed by default, fullscreen opt-in via QBZ_KIOSK_FULLSCREEN
Forcing fullscreen at kiosk boot trapped the user with no way out (Esc/F11 don't leave it, the kiosk shell has no titlebar control). Fullscreen is now opt-in for a real appliance image; the persisted-kiosk-profile case opens in a normal window.

cc
2026-07-12 12:43:56 -06:00
Afonso Jorge Ramos a0bf1328d6 fix(cast): use CSPRNG media path tokens and redact URIs in logs
Replace RandomState-based tokens with getrandom, avoid logging full
media base URLs, and redact /audio/<token>/… in DLNA info logs.
2026-07-11 23:01:05 +02:00
Afonso Jorge Ramos 3dc54a751d fix(player): stop DoP writer on ALSA write failure
Match the PCM ALSA path: on write_dop_i32 Err, stop the writer thread
instead of logging and advancing position (which desyncs DoP markers).
2026-07-11 23:01:05 +02:00