Commit Graph
1152 Commits
Author SHA1 Message Date
vicrodh 2f163f36f5 fix(phase4.3): adjust modal centering and color swatch sizes
- Reduce modal width from 920px to 736px (80% of original)
- Center modal with 140px left offset (half sidebar width)
- Reduce color swatches from 40px to 30px
- Reduce color-grid gap from 8px to 4px
- Fix icon-preset button justify-content typo
- Swatches now properly fill single row

cp
2026-01-18 14:44:29 -06:00
vicrodh cdc4435306 fix(phase4.3): adjust modal width to 920px and limit color swatches to 40x40
- Reduce modal width by 20% (1150px → 920px)
- Add max-width/max-height constraints to color buttons (40px)
- Maintain aspect ratio and grid layout

cp
2026-01-18 14:37:56 -06:00
vicrodh 8607729013 fix(ui): adjust modal layout - 65/35 column split, smaller color swatches
- Changed modal columns from 50/50 to 65/35 split
- Reduced color picker grid gaps and increased density (8 columns)
- Adjusted color swatch border radius for consistency

cp
2026-01-18 14:19:51 -06:00
vicrodh 4009ae9b26 feat(phase4.3): add background color picker to favorites modal
- Add icon_background field to backend (Rust + TS types)
- Update modal to 60% wider (1150px)
- Implement two-column layout (icon left, tabs right)
- Add solid color picker (8 colors + none)
- Add gradient picker (6 gradients)
- Remove background from edit button to match PlaylistView style
- Update database migration for icon_background field

cp
2026-01-18 14:13:50 -06:00
vicrodh dddae17d63 Re-enable ALSA Direct backend for testing
- Remove filter from backend selector dropdown
- Remove auto-switch logic from ALSA Direct to Auto
- Allow user to test if CPAL can actually open hw: devices
- If this works, we can skip alsa-rs implementation
- If it fails, we'll need to implement direct alsa-rs approach
2026-01-18 14:06:32 -06:00
vicrodh 9c76792741 Add alsa crate for direct ALSA hardware access
- Add alsa 0.9 as Linux-only dependency
- Will replace CPAL-based ALSA backend with direct alsa-rs implementation
- Required to properly access hw:X,Y devices for bit-perfect playback
2026-01-18 14:02:43 -06:00
vicrodh 5bd52cc89b feat(phase4.3): add favorites edit modal component
- Create FavoritesEditModal with preset icon grid
- Add custom image upload button
- Add tab reorder UI with up/down buttons
- Integrate edit button in Favorites page header (top-right)
- Add i18n keys for EN and ES
- Wire modal save handler to backend

cc
2026-01-18 14:02:37 -06:00
vicrodh a6aa6aa936 feat(phase4.2): add favorites preferences backend
- Create favorites_preferences.rs with FavoritesPreferences struct
- Add database table (custom_icon_path, custom_icon_preset, tab_order)
- Implement State wrapper and Tauri commands
- Register state and commands in lib.rs
- Default preset: heart, default order: tracks/albums/artists/playlists

cc
2026-01-18 13:57:17 -06:00
vicrodh d39180bd6c feat(ui): show playing status in search and artist tracks
cx
2026-01-18 05:46:57 -06:00
vicrodh c6f86a9bcc feat(ui): pause from track row playing icon
cx
2026-01-18 05:46:43 -06:00
vicrodh 407fab44db fix(ui): slow album card ticker speed
cx
2026-01-18 05:38:41 -06:00
vicrodh ed45fa4156 feat(ui): show volume value while dragging
cx
2026-01-18 05:38:32 -06:00
vicrodh 5a42df35a4 fix(ui): lock playlist import button after success
cx
2026-01-18 05:38:22 -06:00
vicrodh c67c479bac fix(ui): wire stack icon click and tooltip
cx
2026-01-18 05:33:00 -06:00
vicrodh c2628b0076 fix(config): align autoplay mode serialization
cx
2026-01-18 05:32:49 -06:00
vicrodh d96233730b fix(phase3): custom tooltip for context icon
- Replace native title with custom tooltip similar to DAC/EXC badges
- Add hover state and styled tooltip with context info
- Add debug logs to investigate onClick callback issue

cp
2026-01-18 04:58:35 -06:00
vicrodh 12067d7a61 fix(phase3): context navigation and autoplay persistence
- Fixed context navigation using correct property names (.type, .id)
- Simplified autoplay setting from radio buttons to toggle switch
- Fixed tooltip using native title attribute (like QualityBadge)
- Removed custom tooltip CSS and hover state
- Updated translations (en/es) for clearer autoplay behavior description

cp
2026-01-18 04:53:43 -06:00
vicrodh 315bdce79c fix(settings): reload playback preferences when view renders
- Added $effect to reload preferences each time SettingsView is visible
- Fixes autoplay mode not persisting when navigating away and back
- Settings view doesn't unmount, so onMount only runs once per session

cp
2026-01-18 04:38:15 -06:00
vicrodh b666722b98 debug: add detailed logging to loadPlaybackPreferences
cp
2026-01-18 04:34:54 -06:00
vicrodh 92f1644601 fix(context): add custom tooltip and pass onClick callback
- Implemented custom tooltip for StackIcon (similar to AudioOutputBadges)
- Shows 'Playing from', context name, and 'Click to navigate' hint
- Added onContextClick={handleContextNavigation} to ExpandedPlayer
- Fixed onClick prop not being passed, enabling navigation

cp
2026-01-18 04:34:42 -06:00
vicrodh 0feb1e1b4a debug: add detailed logging to StackIcon click handler
cp
2026-01-18 04:09:31 -06:00
vicrodh ae3a90d378 fix(i18n): add translations for playback preferences
Added translations for:
- Autoplay behavior setting
- Continue within source / Play only selected track options
- Show context icon setting and tooltip

Both English and Spanish translations added.

Changed StackIcon tooltip to use native browser title (matches QualityBadge style).
Removed arrow indicator from context icon (cursor change is sufficient).

cp
2026-01-18 04:09:20 -06:00
vicrodh 2a4f58cb08 fix(css): remove extra closing brace in ExpandedPlayer styles
Syntax error on line 568 - duplicate closing brace after .album rule

cp
2026-01-18 04:00:25 -06:00
vicrodh fdf288b01e fix(migration): robust database migration for show_context_icon
Problem:
- Users updating from previous versions would crash on startup
- Table created with new column caused "no column named show_context_icon" error
- Existing users had old schema without the column

Solution:
- Step 1: Create table with old schema (backwards compatible)
- Step 2: Check if show_context_icon column exists using pragma_table_info
- Step 3: Add column ONLY if it doesn't exist (safe migration)
- Step 4: Insert default row

This ensures:
✅ New installs work (table created fresh)
✅ Existing users migrate seamlessly (column added, settings preserved)
✅ No data loss
✅ Idempotent (can run multiple times safely)

Tested scenarios:
- Fresh install (no DB) → creates table, adds column, inserts defaults
  Result: id=1, autoplay_mode='continue', show_context_icon=1
- Existing DB without column → adds column, preserves user settings
  Result: id=1, autoplay_mode='track_only' (preserved), show_context_icon=1
- Existing DB with column → no changes (idempotent)

Migration logs added for debugging.

cp
2026-01-18 03:57:28 -06:00
vicrodh 584650fee1 feat(phase37): implement clickable context tooltip navigation
StackIcon Component:
- Now accepts onClick prop
- Changed from div to button element
- Added arrow (→) that appears on hover
- Tooltip text changed to "Click to go to: {source}"
- Visual feedback: hover background + active scale

Navigation Logic (+page.svelte):
- Added handleContextNavigation function
- Switch based on context_type:
  - album → handleAlbumClick
  - playlist → navigate + set selectedPlaylistId
  - artist_top → handleArtistClick
  - favorites → navigate to favorites
  - home_list → navigate to home
  - search → navigate to search
- Import getCurrentContext from playbackContextStore

UI Integration:
- ExpandedPlayer: Added onContextClick prop, passed to StackIcon
- FocusMode: Added onContextClick prop, passed to StackIcon
- Both receive handleContextNavigation callback

Phase 3.7 COMPLETE ✅

cp
2026-01-18 03:47:11 -06:00
vicrodh b070884ee8 feat(phase36): implement context icon visibility toggle (frontend + UI)
Frontend:
- Add show_context_icon to PlaybackPreferences interface
- Add setShowContextIcon function to store
- StackIcon now subscribes to preferences and checks show_context_icon
- Icon hidden when setting is false (context still tracked)

UI (Settings → Playback):
- Add toggle: "Show track playing context in player"
- Tooltip with bilingual explanation (EN/ES)
- Default: enabled (true)
- Persists across restarts

Context tracking ALWAYS active regardless of icon visibility.

Phase 3.6 COMPLETE ✅

cp
2026-01-18 03:40:19 -06:00
vicrodh dfd1eb588d feat(phase36): add show_context_icon setting (backend)
Database:
- Add show_context_icon column (INTEGER, default 1)
- Migration for existing databases

Backend:
- Add show_context_icon to PlaybackPreferences struct
- Default value: true (icon visible)
- Add set_show_context_icon method to store/state
- Add Tauri command: set_show_context_icon

Context tracking remains ALWAYS active regardless of icon visibility.

cp
2026-01-18 03:38:14 -06:00
vicrodh 640cf5db41 feat(phase35): implement context in HomeView
Context creation:
- Creates 'home_list' context for Continue Listening section
- Uses 'continue_listening' as ID and 'Continue Listening' as label
- Tracks user's listening history in a context
- Stack icon will show "Playing from: Continue Listening"

Home view now fully integrated with context system.

cp
2026-01-18 03:34:50 -06:00
vicrodh a473c969d9 feat(phase35): implement context in SearchView
Context creation:
- Creates 'search' context when playing track from results
- Uses search query as ID and 'Search: {query}' as label
- Applies to both All tab (first 6) and Tracks tab (full list)
- Stack icon will show "Playing from: Search · {query}"

Search view now fully integrated with context system.

cp
2026-01-18 03:33:23 -06:00
vicrodh e3ce6a3760 feat(phase35): implement context in FavoritesView
Context creation:
- Creates 'favorites' context when playing track
- Uses 'favorites' as ID and 'Favorites' as label
- Uses filteredTracks for context (respects search/filter)
- Stack icon will show "Playing from: Favorites"

Favorites view now fully integrated with context system.

cp
2026-01-18 03:31:25 -06:00
vicrodh 0bd60bbc8f feat(phase35): implement context in ArtistDetailView
Context creation:
- Creates 'artist_top' context when playing from Top Tracks
- Uses artist ID and name
- Passes track index from UI loop
- Stack icon will show "Playing from: Artist · {name}"

Artist view now fully integrated with context system.

cp
2026-01-18 03:30:47 -06:00
vicrodh ae478ddeb2 feat(phase35): implement context in PlaylistDetailView
Context creation:
- Creates 'playlist' context when playing track
- Uses playlist ID and name
- Filters out local tracks (Qobuz tracks only in context)
- Finds track index in Qobuz tracks list
- Stack icon will show "Playing from: Playlist · {name}"

Playlist view now fully integrated with context system.

cp
2026-01-18 03:29:33 -06:00
vicrodh fe80896fd2 feat(phase35): add helper for context creation with DisplayTrack
Added createContextAndPlayDisplayTrack helper that:
- Creates playback context with provided type/id/label/tracks
- Calls handleDisplayTrackPlay to start playback
- Will be used by Playlist, Artist, Favorites, Home views

Next: Implement context creation in each view component internally
(following AlbumDetailView pattern but keeping logic in views)

cp
2026-01-18 03:21:21 -06:00
vicrodh 7907b695f8 feat(ui): complete stack icon repositioning (all 4 players)
Stack icon now appears in artist/album area across all players:

- FocusMode: icon before artist (size 12px)
- MiniPlayer: icon at start of artist-album row (size 12px)
- Consistent sizing: 12px (compact players), 16px (expanded player)
- Visual hierarchy: Title → [icon] Artist · Album

All 4 players updated and consistent.

cp
2026-01-18 03:16:38 -06:00
vicrodh 2071149747 feat(ui): move stack icon to artist/album area
Icon now appears before artist/album metadata instead of title.

Changes:
- NowPlayingBar: icon in song-meta row (size 12px)
- ExpandedPlayer: icon in new artist-album-row with separator (size 16px)
- Removed song-title-row wrapper (not needed)
- Icon placement: [icon] Artist · Album

Remaining: FocusMode and MiniPlayer (next commit)

cp
2026-01-18 03:15:49 -06:00
vicrodh 17cd6f0ae2 fix(logic): context creation should NOT depend on autoplay setting
CRITICAL LOGIC FIX:

The autoplay setting was misunderstood. Corrected behavior:

BEFORE (wrong):
- Setting controls whether context is created
- 'continue' = create context
- 'track_only' = clear context

AFTER (correct):
- Context is ALWAYS created when playing from a source (album/playlist)
- Stack icon ALWAYS appears
- Setting only affects what happens at END of track:
  - 'continue' = play next track in context
  - 'track_only' = stop after current track

Why this makes sense:
- You're playing from an album = that's the context
- Stack icon shows the origin (informative)
- Setting controls continuation behavior (not context existence)

Also:
- Added logging to handleAutoplayModeChange
- Will investigate why setting doesn't persist

cp
2026-01-18 03:09:57 -06:00
vicrodh f69a7ab461 fix(ui): fix settings layout and add detailed logging
UI Fix:
- Add :has(.radio-group) rule to allow flexible height
- Set align-items: flex-start for radio group rows
- Prevents radio buttons from being squashed

Logging Enhancement:
- Log autoplay_mode preference value
- Log track index and total tracks
- Log when no album tracks found
- Will help diagnose why context isn't being created

cp
2026-01-18 01:53:21 -06:00
vicrodh f2891c2071 fix(wiring): move context logic to parent (+page.svelte)
CRITICAL FIX: Context was being cleared instead of created.

Root cause:
- AlbumDetailView had internal handlers but used parent's onTrackPlay
- Parent's handleAlbumTrackPlay had no context logic
- Result: context always cleared (default behavior)

Solution:
- Moved context creation logic to handleAlbumTrackPlay in +page.svelte
- Checks autoplay_mode preference
- Creates context if 'continue', clears if 'track_only'
- Removed duplicate logic from AlbumDetailView (was never executed)

Now when clicking a track:
1. handleAlbumTrackPlay checks preference
2. Creates/clears context accordingly
3. Stack icon should appear/disappear correctly

Test with default setting ('continue'):
- Click any track → should see context creation logs
- Stack icon should appear immediately

cp
2026-01-18 01:39:01 -06:00
vicrodh 3851fecd92 fix(ui): improve StackIcon reactivity and add debugging
- Replace onMount/onDestroy with $effect rune for better reactivity
- Add console logging to trace context changes
- Log when setPlaybackContext/clearPlaybackContext are called
- Log when StackIcon receives context updates

This will help debug why stack icon might not appear immediately.

To test:
1. Open browser console
2. Click a track in an album
3. Check logs for '[PlaybackContext]' and '[StackIcon]'
4. Verify context is being set and icon is receiving updates

cp
2026-01-18 01:26:18 -06:00
vicrodh b6001b0203 feat(wiring): complete playback context integration in AlbumDetailView
EXAMPLE IMPLEMENTATION showing how to wire context system:

Context Creation:
- createAlbumContext(startIndex) helper creates context with track list
- handlePlayAll() creates context from first track
- handlePlayFromHere() creates context from selected track (explicit)

Autoplay Logic:
- handleTrackPlay() checks user preference (implicit action)
  - If 'continue': creates context (play within album)
  - If 'track_only': clears context (isolated playback)

Menu Actions (Explicit - Override Setting):
- onPlayTrackOnly: always clears context
- onPlayFromHere: always creates context from track
- onPlayNow: respects autoplay setting

Precedence Rule Enforced:
- Menu actions (explicit) override global autoplay setting
- Simple clicks (implicit) respect autoplay setting

Stack Icon Integration:
- Context automatically tracked by backend
- Stack icon appears when context active
- Tooltip shows 'Playing from: Album · {album.title}'

This pattern should be replicated in:
- PlaylistDetailView
- ArtistDetailView (Top Tracks)
- FavoritesView
- HomeView (curated lists)

cp
2026-01-18 01:01:32 -06:00
vicrodh 9d4a269d36 feat(init): initialize playback context and preferences stores
- Call initPlaybackContextStore() on app mount
- Call initPlaybackPreferences() on app mount
- Load backend state into frontend stores
- Phase 3 backend + UI complete
- Wiring for track actions pending (will be done per-page)

cp
2026-01-18 00:58:26 -06:00
vicrodh 1ed541c4ac feat(ui): add autoplay mode setting in Playback section
- Add radio buttons: Continue within source / Play only selected track
- Load preference on settings mount
- Save changes immediately via handleAutoplayModeChange
- Styled with hover states and proper spacing

cp
2026-01-18 00:57:42 -06:00
vicrodh dbdd664415 feat(settings): add global autoplay mode preference (backend)
- Create PlaybackPreferences config module with SQLite persistence
- Add AutoplayMode enum (ContinueWithinSource | PlayTrackOnly)
- Register Tauri commands: get_playback_preferences, set_autoplay_mode
- Create playbackPreferencesStore for frontend state management
- Add loadPlaybackPreferences to SettingsView
- Default: Continue within source (creates context on track click)
- Settings UI pending (next commit)

cp
2026-01-18 00:49:45 -06:00
vicrodh 515632913d feat(ui): add context menu actions for playback context
- Add 'Play track only' option (clears context, single track)
- Add 'Play from here' option (sets context from current position)
- Update TrackMenu component with new actions
- Update TrackRow to pass new menu actions
- Backend integration ready for Phase 3 (settings + wiring)

cp
2026-01-18 00:41:17 -06:00
vicrodh cf5be434e3 feat(ui): add stack icon to all 4 players
- Create StackIcon component with reactive context subscription
- Display Layers icon before track title when context exists
- Show tooltip with origin info on hover
- Add to: NowPlayingBar, ExpandedPlayer, FocusMode, MiniPlayer
- Icon hidden when no playback context (single track)
- Responsive sizing per player (14px-18px)

cp
2026-01-18 00:39:25 -06:00
vicrodh 49fe9e6b11 feat(player): implement playback context system
- Add PlaybackContext module with ContextManager
- Context tracks semantic origin (album, playlist, artist top, etc.)
- Separate from queue - defines what 'next' means
- Backend: Rust struct with track IDs and position tracking
- Frontend: Svelte store with reactive subscriptions
- Tauri commands for context CRUD operations
- Context is nullable (single track playback has no context)

cp
2026-01-18 00:26:54 -06:00
vicrodh 02469aa7b2 Temporarily disable ALSA Direct backend from UI
ALSA Direct is currently non-functional due to CPAL limitations:
- CPAL cannot enumerate or open hw:X,Y devices required for bit-perfect playback
- Only named devices (front:, iec958:, sysdefault:) work, but they all use ALSA plugins with resampling
- User's DAC cannot achieve bit-perfect playback (stuck at 44.1kHz regardless of track sample rate)

Changes:
- Filter out ALSA Direct from backend selector dropdown
- Auto-switch users from ALSA Direct to Auto on settings load
- Add comments indicating this is temporary until alsa-rs rewrite

This prevents user frustration with a broken backend while we evaluate implementing
direct ALSA support via alsa-rs (bypassing CPAL entirely).
2026-01-17 23:41:04 -06:00
vicrodh b224538088 Manually create hw: and plughw: devices - CPAL doesn't enumerate them
Critical Fix:
- CPAL only enumerates named ALSA devices (front:, sysdefault:, etc.)
- CPAL does NOT enumerate hw:X,Y or plughw:X,Y devices
- These must be created manually from aplay -l card list

Solution:
- Parse aplay -l to get card numbers and descriptions
- Manually create hw:X,0 and plughw:X,0 for each card
- Assume max_sample_rate: 384000 (devices are capable)
- Description: "Cambridge Audio USB Audio 2.0 (Direct Hardware - Bit-perfect)"

For user's system (based on aplay -l):
- hw:0,0 → CS201 (Direct Hardware - Bit-perfect)
- hw:2,0 → HDA NVidia (Direct Hardware - Bit-perfect)
- hw:3,0 → sof-hda-dsp (Direct Hardware - Bit-perfect)
- hw:4,0 → Cambridge Audio USB Audio 2.0 (Direct Hardware - Bit-perfect) ← USER NEEDS THIS
- Plus plughw: variants for each

These devices will now appear in the dropdown and can be selected for
true bit-perfect playback without resampling.
2026-01-17 21:29:17 -06:00
vicrodh c93226718f Fix duplicate device names in dropdown - append device ID
UX Problem:
- 4 devices all showed "Cambridge Audio USB Audio 2.0"
- Selecting one would select all (Map key collision)
- User couldn't distinguish between hw:4,0, front:CARD=C20, iec958:CARD=C20

Solution:
- Detect duplicate display names in deviceOptions
- Append [device_id] to duplicates for uniqueness
- Example: "Cambridge Audio USB Audio 2.0 (Direct Hardware - Bit-perfect) [hw:4,0]"

Now User Sees:
- Cambridge Audio USB Audio 2.0 (Direct Hardware - Bit-perfect) [hw:4,0] ← TRUE bit-perfect
- Cambridge Audio USB Audio 2.0 [front:CARD=C20,DEV=0] ← Front output with plugins
- Cambridge Audio USB Audio 2.0 [iec958:CARD=C20,DEV=0] ← S/PDIF with plugins
- Cambridge Audio USB Audio 2.0 [sysdefault:CARD=C20] ← System default with dmix

Each option is now unique and selectable. The hw:4,0 option is clearly
marked as "Direct Hardware - Bit-perfect" for audiophiles.
2026-01-17 21:23:25 -06:00
vicrodh 39a661417d Add hw: and plughw: devices for true bit-perfect playback
ALSA Backend Changes:
- Include hw:X,Y and plughw:X,Y devices from CPAL enumeration
- These devices bypass ALL ALSA plugins (dmix, resampling, etc.)
- Parse aplay -l to build card number → description map
- hw: devices get friendly names: "Cambridge Audio USB Audio 2.0 (Direct Hardware - Bit-perfect)"

Why This Matters:
- front:CARD=C20,DEV=0 → Has dmix plugin → resamples to 44.1kHz
- iec958:CARD=C20,DEV=0 → Has plugins → resamples to 44.1kHz
- hw:4,0 → Direct hardware access → TRUE bit-perfect → 96kHz playback

Device Description Examples:
- hw:4,0 → "Cambridge Audio USB Audio 2.0 (Direct Hardware - Bit-perfect)"
- plughw:4,0 → "Cambridge Audio USB Audio 2.0 (Plugin Hardware)"

Blacklist Updates:
- Filter surround*, usbstream, pipewire, pulse, bare sysdefault
- Keep hw:, plughw:, default, sysdefault:CARD=, front:CARD=, hdmi:CARD=, iec958:CARD=

User should now select hw:4,0 device for true bit-perfect playback that
changes sample rate to match the track (96kHz, 192kHz, etc.)
2026-01-17 21:21:01 -06:00