Commit Graph
5644 Commits
Author SHA1 Message Date
vicrodh 9099123091 Refactor Spotify and Tidal playlist import to use proxy
- Update Spotify to use Cloudflare Workers proxy endpoint
- Update Tidal to use Cloudflare Workers proxy endpoint
- Remove embedded CLIENT_ID and CLIENT_SECRET constants
- Remove Base64 encoding and client credentials flow (proxy handles it)
- Add User-Agent 'QBZ/1.0.0' for proxy validation
- Maintain backward compatibility with user_creds parameter (ignored)
2026-01-16 21:19:51 -06:00
vicrodh c810663c6f feat: implement 3-state DAC badge and hardware sample rate detection
Backend changes:
- Add audio_diagnostics module to read actual hardware sample rate from /proc/asound
- New command get_hardware_audio_status() parses hw_params for real-time monitoring
- Add glob dependency for file pattern matching

Frontend (AudioOutputBadges):
- Implement 3-state DAC badge system:
  - Green: DAC passthrough working correctly (rates match)
  - Yellow: DAC passthrough ON but resampling detected (warning)
  - Gray: DAC passthrough OFF (intentionally disabled)
- Dynamic tooltips showing actual hardware sample rate
- Compare file sample rate vs hardware sample rate
- Increase tooltip z-index to 9999 to prevent occlusion issues
- Add pointer-events: none to tooltip to prevent interaction issues

Frontend (SettingsView):
- Replace hardcoded "192 kHz" with dynamic hardware sample rate
- Load and display actual hardware audio status
- Show format details (e.g., S32_LE) when available
- Display "No active playback" when no audio is playing
- Add muted styling for inactive state

Frontend (QualityBadge):
- Add native tooltip showing tier and format
- Add cursor: help to indicate interactivity

i18n:
- Add "noActivePlayback" translations (EN/ES)

This allows users to verify bit-perfect playback is working and detect
resampling issues that would compromise audio quality.
2026-01-16 21:14:22 -06:00
vicrodh 179a6b7c54 Refactor Last.fm integration to use Cloudflare Workers proxy
- Update LASTFM_API_URL to point to proxy endpoint
- Remove MD5 signature generation (proxy handles it)
- Remove api_key and api_secret from LastFmClient (proxy manages credentials)
- Simplify client to only handle session_key
- Update get_token() to return (token, authUrl) tuple from proxy
- Update all methods (get_session, scrobble, update_now_playing) to use proxy
- Add User-Agent header 'QBZ/1.0.0' for proxy validation
- Update bootstrap.ts to skip credential restoration (proxy handles it)
- Maintain backward compatibility with set_credentials as no-op
2026-01-16 21:09:18 -06:00
vicrodh 09881856d0 fix: DAC badge now activates based on setting alone
Remove isExternal requirement for DAC Passthrough badge activation.
The badge now lights up when DAC Passthrough setting is enabled,
regardless of whether the device is detected as external or internal.

This fixes the issue where the badge would remain off even when
DAC passthrough was working (confirmed by 192kHz reaching hardware).
2026-01-16 20:56:02 -06:00
vicrodh 3a49e3f6dd Remove embedded Last.fm API secret for Flathub compliance
- Remove DEFAULT_API_SECRET constant and get_api_secret() function
- Update Default impl to require user-provided secret
- Update has_embedded_credentials() to only check API key
- API secret will be handled by Cloudflare Workers proxy
2026-01-16 20:46:01 -06:00
vicrodh 791ff7a73b feat: implement mutual exclusion for incompatible audio settings
Add auto-disable logic to prevent incompatible settings from being enabled simultaneously:

Frontend (SettingsView.svelte):
- DAC Passthrough ON → auto-disables Gapless Playback and Crossfade
- Gapless Playback ON → auto-disables DAC Passthrough
- Crossfade > 0 → auto-disables DAC Passthrough
- Added handleGaplessPlaybackChange() and handleCrossfadeChange() handlers
- Modified handleDacPassthroughChange() to disable incompatible settings

Backend (player/mod.rs):
- Only recreate OutputStream on format change when DAC passthrough is enabled
- When DAC passthrough is OFF: reuse existing stream for gapless transitions
- When DAC passthrough is ON: recreate stream for bit-perfect playback
- Added detailed logging for stream recreation decisions

This fixes the issue where Gapless Playback was enabled but gaps still occurred
due to DAC passthrough forcing stream recreation on sample rate changes.
2026-01-16 20:41:53 -06:00
vicrodh 20fc254769 Merge branch 'bugfix/pretty-device-names' 2026-01-16 19:53:11 -06:00
vicrodh 33c5e00da0 Fix audio device selection to show friendly PipeWire names
The previous implementation tried to map ALSA device names (from cpal)
to PipeWire descriptions, but the naming schemes are completely different:
- cpal returns names like "plughw:1,0"
- pactl returns sink names like "alsa_output.usb-Cambridge_Audio_..."

This fix changes the approach:
1. Use PipeWire sinks directly for the device dropdown (already filtered
   to real outputs and have friendly descriptions like "DacMagic Plus")
2. Store the PipeWire sink name when user selects a device
3. Set the PipeWire default sink using pactl when device is selected
4. Use rodio's default device (which follows PipeWire's default)

This ensures users see 4-5 meaningful devices with friendly names
instead of 30+ raw ALSA device names.

Backend changes:
- Add set_pipewire_default_sink command (pactl set-default-sink)
- Register new command in lib.rs

Frontend changes:
- Use pipewireSinks directly for device dropdown
- Display sink description (friendly name)
- Store sink name (for pactl)
- Call set_pipewire_default_sink when device changes
- Remove unused AudioDevice interface and getDevicePrettyName import
2026-01-16 19:52:51 -06:00
vicrodh 6e36b56486 fix: make offline detection less aggressive
- Increase network check timeout from 5s to 15s
- Add retry (2 attempts with 2s delay) before declaring offline
- Add logging for failed network check attempts

This prevents false offline mode triggers from temporary latency spikes.
2026-01-16 19:24:35 -06:00
vicrodh c5a1d14822 fix: use fast header-only metadata extraction instead of full decode
The play_data function was calling decode_with_symphonia which decoded
the entire audio file (271MB+) just to extract sample_rate and channels.
This caused 30-35 second delays between download complete and playback.

New extract_audio_metadata function:
- For FLAC: uses rodio decoder (reads headers only)
- For isomp4: uses symphonia probe to read codec_params without decoding

This restores the fast playback we had before.
2026-01-16 18:32:16 -06:00
vicrodh eebf440f84 Merge remote-tracking branch 'origin/main' into feature/favorite-playlists 2026-01-16 17:12:34 -06:00
vicrodh 573d818cf5 Merge branch 'research/dac-passthrough' 2026-01-16 17:12:19 -06:00
vicrodh b7048fae74 feat: register qbz:// URI scheme for OAuth callbacks
Add URI scheme handler registration for OAuth flow implementation:
- Register x-scheme-handler/qbz in .desktop files
- Add %u parameter to Exec for URL handling
- Add OpenURI portal permission in Flatpak manifest

This enables OAuth PKCE flows for Spotify and other providers
to redirect back to the application after browser authentication.

Files modified:
- packaging/arch/qbz.desktop
- packaging/aur/qbz.desktop
- packaging/flatpak/com.blitzkriegfc.qbz.desktop
- packaging/flatpak/com.blitzkriegfc.qbz.yml
2026-01-16 17:11:11 -06:00
vicrodh 287ac59e7f feat: register qbz:// URI scheme for OAuth callbacks
Add URI scheme handler registration for OAuth flow implementation:
- Register x-scheme-handler/qbz in .desktop files
- Add %u parameter to Exec for URL handling
- Add OpenURI portal permission in Flatpak manifest

This enables OAuth PKCE flows for Spotify and other providers
to redirect back to the application after browser authentication.

Files modified:
- packaging/arch/qbz.desktop
- packaging/aur/qbz.desktop
- packaging/flatpak/com.blitzkriegfc.qbz.desktop
- packaging/flatpak/com.blitzkriegfc.qbz.yml
2026-01-16 17:10:42 -06:00
vicrodh 8f32eec782 refactor(wayland): harden NVIDIA fix with detection and user overrides
Improvements to the Wayland compatibility fix:

Detection:
- Add NVIDIA GPU detection via /proc and kernel modules
- Apply DMA-BUF workaround only on NVIDIA systems
- Preserve full acceleration on Intel/AMD GPUs

User Overrides:
- QBZ_FORCE_DMABUF=1: Force-enable DMA-BUF (bypass workaround)
- QBZ_DISABLE_DMABUF=1: Force-disable DMA-BUF
- QBZ_FORCE_X11=1: Force X11 backend on Wayland

Diagnostics:
- Clear logging of display server type
- NVIDIA detection status
- Applied workarounds and reasons
- User override notifications

This makes the fix selective and transparent while protecting
NVIDIA + Wayland users from fatal protocol errors.

Related: #6

cc
2026-01-16 14:57:19 -06:00
vicrodh 837fe0bb7a fix(wayland): add environment variables for Wayland and WebKit compatibility
Resolves protocol errors and GBM buffer issues on Wayland by:
- Detecting Wayland display and forcing GDK backend
- Disabling WebKit compositing mode for transparent windows
- Disabling DMA-BUF renderer to fix GPU driver compatibility
- Setting client-side decorations preference

This addresses issue #6 where users on Wayland experienced crashes
with "Error 71 (Protocol error)" and GBM buffer creation failures.

cc
2026-01-16 14:57:14 -06:00
vicrodh 27431d2ea9 Add backend support for playlist favorites
- Add is_favorite column migration to playlist_settings table
- Update PlaylistSettings struct with is_favorite field
- Add set_playlist_favorite() and get_favorite_playlist_ids() methods
- Add playlist_set_favorite and playlist_get_favorites Tauri commands
2026-01-16 14:40:47 -06:00
vicrodh 26116d0670 Wire up onPlaylistSelect prop in FavoritesView 2026-01-16 14:40:07 -06:00
vicrodh e92ca494d4 Add Playlists tab to FavoritesView for favorite playlists 2026-01-16 14:39:41 -06:00
vicrodh 432b4e5f97 Add favorite heart indicator to PlaylistManagerView items 2026-01-16 14:35:26 -06:00
vicrodh 1537b2de7f Add favorite heart button to PlaylistDetailView header 2026-01-16 14:33:25 -06:00
vicrodh 88b1f959ae Implement DAC passthrough and sample rate switching
This commit implements proper sample rate passthrough for high-quality
audio playback, addressing issue #10 where DAC sample rates were locked
at 44.1kHz regardless of file quality.

Core Changes:
- Modified Player to accept and store AudioSettings (exclusive mode, DAC passthrough)
- Updated AudioCommand::Play to include sample_rate and channels metadata
- Created create_output_stream_with_config() to build custom StreamConfig
- Added sample rate tracking to detect changes between tracks
- Modified Play handler to recreate OutputStream when sample rate changes
- Updated play_data() to extract audio metadata before playback
- Modified lib.rs to read AudioSettings on startup and pass to Player

Device Detection Improvements (Issue #4):
- Added display_name and device_type fields to AudioDevice struct
- Implemented get_pipewire_device_descriptions() to extract friendly names
- Updated get_audio_devices() to map technical names to user-friendly names
- Added device type detection (USB, HDMI, PCI, Bluetooth)

Technical Details:
- Audio files are decoded twice: once for metadata, once for playback
- Stream is recreated only when sample rate or channel count changes
- Falls back to default device config if custom config fails
- Supports both PipeWire and PulseAudio device naming via pactl
- Logs sample rate transitions and OutputStream configuration

Files Modified:
- src-tauri/src/player/mod.rs: Core playback engine changes
- src-tauri/src/lib.rs: Initialize Player with AudioSettings
- src-tauri/src/commands/playback.rs: Device enumeration improvements

Tested: Compiles successfully on Linux with Rust 1.92
2026-01-16 14:16:18 -06:00
vicrodh 8565696d41 security: override cookie to 0.7.x
Fixes CVE for out of bounds characters (LOW)
All 7 dependabot alerts now resolved
2026-01-16 13:43:09 -06:00
vicrodh 3025c918f1 security: override esbuild to 0.25.x
Fixes CVE for dev server request vulnerability (MEDIUM)
svelte-i18n requires ^0.19.2, override forces ^0.25.0
2026-01-16 13:09:20 -06:00
vicrodh deeb26dc3f security: update svelte to 5.46.4
Fixes CVE for Cross-site Scripting vulnerability (MEDIUM)
2026-01-16 12:37:33 -06:00
vicrodh c81d03b5b0 security: update @sveltejs/kit to 2.49.5
Fixes:
- CVE for DoS/SSRF in prerendering (HIGH)
- CVE for memory amplification DoS (HIGH)
- Also updates devalue to 5.6.2 (2 HIGH CVEs)
2026-01-16 10:27:01 -06:00
vicrodh a68230fadc Make scrobbling options mutually exclusive in offline settings
Immediate and Accumulated scrobbling cannot be enabled at the same
time, but both can be disabled. When one is turned on, the other
is automatically turned off.
2026-01-16 10:07:05 -06:00
vicrodh 8a5d3e8971 Fix column alignment for unavailable tracks in playlist view
Show favorite and download indicators for unavailable Qobuz tracks
to maintain column alignment. The elements are already non-interactive
due to pointer-events: none on the wrapper.
2026-01-16 10:02:49 -06:00
vicrodh 3984f5b9a0 Fix track row alignment for unavailable tracks in playlist view 2026-01-16 09:56:25 -06:00
vicrodh 9499203c69 Refine offline mode UX for unavailable tracks and playlist filters
- Remove wifi-off icon from unavailable tracks in playlist detail view,
  keeping only the disabled styling for a cleaner look
- Rename "Available Offline" filter to "Fully Available Offline" to
  clarify it shows only playlists where all tracks are available
- Update filter logic to only show all_local playlists in the fully
  available filter, not partially available ones
- Fix visible filter in offline mode to respect showPartialPlaylists
  setting by using isPlaylistAvailableOffline function
2026-01-16 09:35:40 -06:00
vicrodh 93d886e1dd Fix partial playlist detection for offline mode
The hasLocalContent field was never being calculated - it was just
read from settings (always undefined). Now calculate it dynamically
from actual data:

- localTrackCounts.get(playlistId) - number of local tracks
- playlist.tracks_count - number of Qobuz tracks

Status calculation:
- 'no': localCount === 0 (not available offline)
- 'all_local': localCount > 0 && qobuzCount === 0 (fully available)
- 'some_local': localCount > 0 && qobuzCount > 0 (partially available)

This fixes Show partial playlists toggle and Partially available
filter in playlist manager.
2026-01-16 09:13:55 -06:00
vicrodh 73d022ae20 Add two-level audio cache system (L1: memory, L2: disk)
L1 (Memory): 300MB for ~3-4 Hi-Res tracks, instant access
L2 (Disk): 500MB playback cache at ~/.cache/qbz/playback/

Flow:
- When track evicted from memory, saved to disk cache
- When loading: check memory → disk → download cache → network
- Tracks promoted back to memory when accessed from disk

This reduces re-downloads when navigating back to recently played
tracks in mixed playlists.
2026-01-16 08:49:56 -06:00
vicrodh 2bdde3d592 Improve prefetch for mixed playlists
- Look ahead 15 tracks instead of 3 to find Qobuz tracks past local ones
- Prefetch up to 3 Qobuz tracks regardless of local track positions
- Count cached/fetching tracks toward limit to avoid over-prefetching

Example: [Local, Local, Qobuz, Qobuz, Local x4, Qobuz]
Before: Only prefetched tracks 3,4 (next 3 total)
After:  Prefetches tracks 3,4,9 (next 3 Qobuz)
2026-01-16 08:42:17 -06:00
vicrodh 94d7d78a22 Fix buffering UX when transitioning from local to Qobuz tracks
- Stop playback immediately when starting a Qobuz track to prevent
  previous track from continuing during download
- Show buffering toast while downloading Qobuz audio
- Skip buffering UI for local tracks since they load instantly
- Add is_local field to QueueTrack for prefetch optimization
- Update prefetch to skip local tracks (no network needed)
- Update all queue track builders to include is_local flag
2026-01-16 07:58:13 -06:00
vicrodh 3e3f89b6a8 Fix effect_update_depth_exceeded infinite loop in playlist loading
Remove reactive effect that was causing infinite re-renders due to
inline callback function recreation. Replace with imperative calls
to notifyParentOfCounts() after data loading completes.

The effect was reading onPlaylistCountUpdate which got recreated
on every parent re-render, triggering the effect again in a loop.
2026-01-16 07:48:34 -06:00
vicrodh aeb13b9ffc Connect playlist count callback for single source of truth
Wire onPlaylistCountUpdate from PlaylistDetailView to Sidebar's
updatePlaylistCounts method in +page.svelte. This ensures the
sidebar displays accurate track counts from the database instead
of calculated values that could drift out of sync.
2026-01-16 07:19:34 -06:00
vicrodh 7292635210 Fix displayTracks to handle local track positions beyond simple sum
Calculate totalCount as max of (qobuz+local count) or (highest local
position + 1) to ensure all local tracks are included regardless of
their position value
2026-01-16 07:13:09 -06:00
vicrodh 16486e4591 Fix playlist track ordering to respect insertion order
- Add PlaylistLocalTrack struct with playlist_position field
- Add playlist_get_local_tracks_with_position command
- Update PlaylistDetailView to merge tracks by position instead of
  appending local tracks at the end
- Update PlaylistModal to calculate correct position when adding local
  tracks (total count = qobuz + existing local)
- Local tracks now appear in the order they were added, interleaved
  with Qobuz tracks
2026-01-16 07:04:21 -06:00
vicrodh 24c9df3bce Fix TrackMenu z-index and edge clipping issues
- Use portal pattern to render menu in body (escapes stacking context)
- Increase z-index to 99999/100000 for menu/submenu
- Update click outside handler to work with portal
- Menu now properly appears above all track rows
2026-01-16 06:56:36 -06:00
vicrodh 9366388041 Fix local tracks not being added to queue from playlists
- Update handlePlayAll to include both Qobuz and local tracks
- Update handlePlayAllNext and handlePlayAllLater similarly
- Add onSetLocalQueue prop to mark local tracks in queue store
- Connect prop to handleSetLocalQueue in +page.svelte
2026-01-16 06:51:59 -06:00
vicrodh 825534621a Add login timeout mechanism and fix premature API calls
- Add 60-second timeout to login initialization in LoginView
- Show retry/offline options when login times out
- Move loadFavorites() to handleLoginSuccess to prevent API calls
  before authentication is complete
- Prevents errors when auto-login is slow or stuck
2026-01-16 06:49:03 -06:00
vicrodh 688d798b9d Fix local track quality badge showing Hz instead of kHz
Convert sample_rate to kHz in localTrackToDisplay function so local
tracks display correctly as 16bit/44.1kHz instead of 16bit/44100kHz
2026-01-16 06:40:23 -06:00
vicrodh 3297257a24 Fix tooltip updates and change Song to Track terminology
- Update onPlaylistUpdated callback to also refresh local track counts
- Change all Song/Songs references to Track/Tracks in Sidebar tooltips
- Ensure tooltip cache is properly invalidated when tracks are modified
2026-01-16 06:39:08 -06:00
vicrodh 5f4cfa5888 feat(playlists): include local tracks in counts everywhere
- Add playlist_get_all_local_track_counts command to get local track
  counts for all playlists efficiently
- PlaylistDetailView: show combined track count and duration in header,
  style local count with muted color, remove redundant count below
- Sidebar: load and display local track counts in tooltips
- PlaylistModal: show combined counts when selecting playlist to add to
- PlaylistManagerView: show combined counts in both grid and list views
- TrackRow: move local indicator to download column position, add
  placeholder for favorite column to maintain alignment, update tooltip
- Remove local tracks notice banner (info now in tooltip)

cc
2026-01-16 06:32:13 -06:00
vicrodh d731805eca refactor(playlists): unify track row appearance and add remove option
- Move local track indicator from quality column to favorite button position
  for consistent row alignment with Qobuz tracks
- Remove explicit delete button from playlist track rows (was easy to
  accidentally click)
- Add "Remove from playlist" option to TrackMenu for all tracks (local and
  Qobuz)
- Qobuz track removal uses playlist_track_id from API response
- Clean up unused CSS and imports from PlaylistDetailView

cc
2026-01-16 06:18:32 -06:00
vicrodh 3915abd3bb fix(playlists): add local tracks to playlists correctly
- PlaylistModal now uses playlist_add_local_track command for local tracks
  instead of the Qobuz-only add_tracks_to_playlist command
- Added isLocalTracks prop to PlaylistModal and wired it through uiStore
- Updated LocalLibraryView to pass isLocal=true when adding tracks to playlists
- Added HardDrive icon indicator next to quality badge for local tracks in TrackRow

cc
2026-01-16 06:03:09 -06:00
vicrodh 81d2bdcf33 CRITICAL: Fix library clear to preserve Qobuz downloads
- clear_all_tracks now only deletes local library tracks
- Qobuz downloads (source = 'qobuz_download') are preserved
- Local library management is now completely separate from Qobuz downloads
2026-01-16 05:15:18 -06:00
vicrodh cd1319cea9 Fix critical bug in Clear Library Database function
- Prevent double execution with clearingLibrary flag
- Stop event propagation to prevent multiple triggers
- Convert to non-async function with explicit promise chain
- Disable button during operation
- Show "Clearing..." state while in progress
2026-01-16 05:11:16 -06:00
vicrodh 6b224ce0da Polish folder settings modal
- Increase width to 720px
- Reduce folder name font size to 13px
- Fix button labels (use actions.cancel/save instead of common)
- Add 'saving' i18n key (en/es)
- Wrap long hint texts in <small> tags
2026-01-16 05:09:18 -06:00
vicrodh ae7b32d70a Increase folder settings modal width to 660px 2026-01-16 05:05:22 -06:00