Commit Graph
5206 Commits
Author SHA1 Message Date
vicrodh 8391ef46df refactor(qconnect): extract QconnectEventSink impl to event_sink.rs
Move the Tauri-side event sink (struct TauriQconnectEventSink + the
QconnectEventSink trait impl + the apply_session_management_event
dispatcher) into a dedicated event_sink submodule.

This is the seam between the qconnect-app crate's event stream and
qbz's local state — every WS-driven event (renderer updated, queue
updated, command applied, session-management messages) flows through
on_event. Splitting it out makes the dispatch graph navigable
without scrolling through 4000+ unrelated lines.

apply_session_management_event handles 9 message types:
SESSION_STATE, ADD_RENDERER, UPDATE_RENDERER, REMOVE_RENDERER,
ACTIVE_RENDERER_CHANGED, RENDERER_STATE_UPDATED, VOLUME_CHANGED,
VOLUME_MUTED, MAX_AUDIO_QUALITY_CHANGED, LOOP_MODE_SET — plus three
post-dispatch hooks (apply_remote_loop_mode_to_corebridge,
sync_local_playback_for_renderer_ownership, sync_active_renderer_
projection).

mod.rs:
- TauriQconnectEventSink moved to event_sink module
- qconnect_now_ms marked pub(super) for cross-module access
- async_trait, qconnect_app::{QconnectAppEvent, QconnectEventSink}
  imports removed (now confined to event_sink.rs)
- The session/queue_resolution imports trimmed to only what mod.rs
  itself still references

Pure relocation. mod.rs: 4460 → 4022 lines. event_sink.rs: 425 lines.
Total qconnect/ submodules now: 7 (types, session, queue_resolution,
corebridge, track_loading, event_sink, plus the residual mod.rs).

cc
2026-04-27 15:42:05 -06:00
vicrodh 579aafbe2c refactor(qconnect): extract remote track streaming and load dedup to track_loading.rs
Move 7 items that own remote track loading (HTTP streaming, FLAC probe,
fallback download, and the load-attempt dedup window) into a dedicated
track_loading submodule:

- LOAD_ATTEMPT_DEDUP_WINDOW (5s constant)
- should_reload_remote_track (track-id-only reload predicate)
- load_remote_track_into_player (top-level load with streaming-then-
  download fallback)
- is_recent_load_attempt (dedup check against sync_state)
- ensure_remote_track_loaded (pub(super) — orchestrator called by
  corebridge::apply_renderer_command_to_corebridge and the V2
  play_track_handoff path)
- QconnectRemoteStreamInfo (FLAC probe result)
- stream_remote_track_into_player, probe_remote_stream_info,
  download_and_stream_remote_track, download_remote_audio

corebridge.rs now imports ensure_remote_track_loaded directly from
super::track_loading instead of going through mod.rs.

Pure relocation. mod.rs: 4777 → 4460 lines. track_loading.rs: 337 lines.
Total qconnect/ submodules now: 6 (types, session, queue_resolution,
corebridge, track_loading, plus the residual mod.rs).

cc
2026-04-27 15:05:19 -06:00
vicrodh 69ef5de5a0 refactor(qconnect): extract CoreBridge bridging logic to corebridge.rs
Move 6 functions that bridge cloud-emitted QConnect events to the
local CoreBridge audio engine into a dedicated corebridge submodule:

- queue_state_needs_materialization (dedup comparator)
- apply_remote_loop_mode_to_corebridge
- apply_renderer_command_to_corebridge (SetState/SetVolume/MuteVolume/
  SetLoopMode/SetActive handler — ~180 lines, the busiest function)
- sync_corebridge_remote_shuffle_projection (shuffle projection with
  identity-shuffle deferral; remains private to corebridge)
- materialize_remote_queue_to_corebridge (queue replication, ~210 lines)
- align_corebridge_queue_cursor

mod.rs deps that corebridge.rs reaches via super:: are now pub(super):
- PLAYING_STATE_PLAYING/PAUSED/STOPPED/UNKNOWN constants
- normalize_volume_to_fraction, qconnect_repeat_mode_from_loop_mode,
  model_track_to_core_queue_track
- ensure_remote_track_loaded (still in mod.rs, will move to
  track_loading.rs in a follow-up step)

corebridge.rs imports queue_resolution::* directly for the cursor and
order helpers, and session::is_peer_renderer_active for the echo-reset
gate.

Pure relocation. mod.rs: 5304 → 4777 lines. corebridge.rs: 565 lines.

cc
2026-04-27 15:02:14 -06:00
vicrodh 7ea9511c26 refactor(qconnect): extract queue cursor and order resolution to queue_resolution.rs
Move 18 items that own the protocol-side queue/cursor/order math from
mod.rs into a dedicated queue_resolution submodule:

Types (pub(super)):
- QconnectOrderedQueueCursor — Queue/Autoplay cursor abstraction
- QconnectRemoteSkipDirection — controller next/previous direction
- QconnectControllerQueueItemResolution — skip resolution outcome

Helpers (pub(super) when used by other submodules, fn otherwise):
- is_valid_ordered_queue_shuffle_order
- ordered_queue_cursors, queue_item_track_id_for_cursor,
  normalized_queue_item_id_for_cursor
- find_cursor_index_by_queue_item_id, find_cursor_index_by_track_id,
  find_cursor_index_by_track_id_before
- resolve_current_cursor_index_from_snapshots,
  resolve_controller_queue_item_from_snapshots,
  resolve_queue_item_ids_from_queue_state
- dedupe_track_ids
- resolve_remote_start_index, resolve_core_shuffle_order
- is_cloud_placeholder_current_queue_item,
  normalize_current_queue_item_id_from_queue_state

session.rs now imports cursor helpers directly from
super::queue_resolution::* instead of going through mod.rs.

Pure relocation. mod.rs: 5766 → 5297 lines. queue_resolution.rs: 460 lines.

cc
2026-04-27 14:57:54 -06:00
vicrodh a608ba2e06 refactor(qconnect): extract session topology and renderer snapshots to session.rs
Move 16 items from mod.rs to a dedicated session submodule:

Types:
- QconnectSessionState (pub) — session topology surfaced to frontend
- QconnectRendererInfo (pub) — renderer device descriptor
- QconnectSessionRendererState (pub(crate)) — per-renderer cached state
- QconnectFileAudioQualitySnapshot (pub(crate)) — audio quality dedup
- QconnectRendererReportDebugEvent (pub(crate)) — renderer report telemetry

Helpers (all pub(super)):
- refresh_local_renderer_id, find_unique_renderer_id
- normalize_active_renderer_id, is_peer_renderer_active, is_local_renderer_active
- sync_session_renderer_active_flags, ensure_session_renderer_state
- build_session_renderer_snapshot, build_effective_renderer_snapshot
- build_visible_queue_projection, queue_item_snapshot_for_cursor
- cache_renderer_snapshot

mod.rs deps that session.rs reaches via super:: are now pub(super):
- QconnectRemoteSyncState and all its fields
- QconnectOrderedQueueCursor
- ordered_queue_cursors, find_cursor_index_by_queue_item_id,
  find_cursor_index_by_track_id, normalize_current_queue_item_id_from_queue_state
- default_qconnect_device_info, resolve_qconnect_device_uuid

Pure relocation. mod.rs: 6109 → 5766 lines. session.rs: 372 lines.

cc
2026-04-27 14:51:33 -06:00
vicrodh e5c0261158 refactor(qconnect): extract wire types and request payloads to types.rs
Move 22 public types (QconnectConnectOptions, QconnectLifecycleState,
QconnectConnectionStatus, QconnectVisibleQueueProjection, the 20-variant
QconnectOutboundCommandType + 5 request payload structs, the 4 admission/
handoff types, the 8 device/session/queue payloads) into a dedicated
types.rs submodule. mod.rs re-exports via `pub use types::*` so external
callers (lib.rs invoke handlers, commands_v2/queue.rs) keep their import
paths.

Pure data and enum-mapping impls only. Two helper methods on
QconnectOutboundCommandType (to_queue_command_type,
requires_remote_queue_admission) become pub(super) since they are only
used from within the qconnect module tree.

mod.rs: 6371 → 6109 lines. types.rs: 273 lines.

cc
2026-04-27 14:17:19 -06:00
vicrodh fc5cd6efc7 refactor(qconnect): move qconnect_service.rs to qconnect/mod.rs
Pure rename to enable subsequent splits into focused submodules. No
behavior change: 34 invoke handler refs in lib.rs and 2 use statements
in commands_v2/queue.rs updated from qconnect_service:: to qconnect::.

Foundation for the qconnect_service.rs → qconnect/ module split: the
file is 6371 lines and mixes 12 distinct responsibilities (types,
session topology, event sink, queue resolution, corebridge bridging,
track loading, transport, Tauri commands, etc). Splitting into focused
submodules makes the area navigable for both authors and reviewers,
enables independent reasoning per concern, and creates a clean target
for the eventual qbz-qconnect-proto crate extraction.

cc
2026-04-27 14:14:12 -06:00
vicrodh 147bcbd715 fix(qconnect): eliminate first-track hiccup, prev/next bouncing, and shuffle drift
Bundle of related fixes addressing QConnect echo handling and shuffle
authority. All four converge on the same architectural principle:
qbz must not invent state when the cloud is the source of truth.

1. Remove should_force_remote_track_restart and its echo-driven reload

   The function fired whenever the cloud echoed SetState with
   target_position_ms=0 for the same track currently playing. The cloud
   re-emits this routinely on secondary field changes (next_track
   corrections, queue_item_id refresh) — every echo triggered a
   load_remote_track_into_player that interrupted in-progress audio.

   Track-change cases continue to load via align_corebridge_queue_cursor
   plus ensure_remote_track_loaded.

2. Reject echo seeks in apply_renderer_command_to_corebridge

   Authoritative seek-to-zero is only honored when the command targets
   a different track, or when local position is already near zero. If
   command.current_track matches playback_state.track_id and target<=1s
   while local_pos>2s, the seek is treated as echo and skipped. The
   prior 2s threshold was insufficient to absorb cloud round-trip during
   queue changes.

3. Drop has_loaded_audio gate from should_reload_remote_track

   playback_state.track_id is updated by the audio thread only after
   engine.append(source) succeeds. During the 1-3s buffer/decode window
   of an initial load, has_loaded_audio is false even though loading is
   in flight — the prior gate caused ensure_remote_track_loaded to
   redundantly re-trigger load on every echo SetState arriving in that
   window. This was the residual first-track hiccup.

4. Add load-attempt dedup across V2 play and ensure_remote_track_loaded

   New sync_state.last_load_attempt: Option<(track_id, Instant)> with a
   5s window. Two write sites:
     - play_remote_renderer_track_if_active when active_renderer_is_local
       (V2 frontend just dispatched a local play)
     - ensure_remote_track_loaded when it triggers its own load
   Read site: ensure_remote_track_loaded skips if last attempt for the
   same track was within the window. Eliminates redundant loads when an
   echo SetState arrives while a local play is still buffering.

5. Defer engine shuffle activation until cloud sends a valid order

   The cloud broadcasts shuffle toggles in two stages: first a
   QueueUpdated with shuffle_mode=true and shuffle_order=null, then
   ~400ms later a QueueUpdated with the computed shuffle_order. The
   prior code applied set_queue_with_order with shuffle_enabled=true on
   the first event, falling through to set_identity_shuffle_order_internal
   — qbz inventing a sequence (0,1,2,...) that diverges from the order
   the cloud is about to authorize. If the second event was delayed,
   dropped, or raced against the first, qbz drifted from peer clients
   (the long-standing "doble shuffle" symptom).

   Now: effective_shuffle_enabled = shuffle_mode && core_shuffle_order.
   is_some(). When the order is absent, the engine stays unshuffled and
   waits for the second QueueUpdated. sync_corebridge_remote_shuffle_
   projection short-circuits identically. Updated diagnostic log
   surfaces remote_shuffle_mode, shuffle_order_present, and engine_
   shuffle_enabled separately for future triage.

Tests: removed should_force_remote_track_restart test, simplified
should_reload_remote_track test to reflect the track-id-only contract.

cc
2026-04-27 14:02:58 -06:00
vicrodh dee987c1aa fix(player): gate gapless transition on prefetch attempted for current track
The isGaplessTransition predicate fired on every external track change
(QConnect renderer command, MPRIS, etc.) when qbz was the local
renderer, mis-classifying remote-driven track changes as gapless
transitions. The handler then ran onGaplessTransition every backend
tick (~1Hz) without updating currentTrack, leaving the UI stale and
spamming v2_next_track.

Added gaplessAttemptedForCurrent gate captured before the existing
null-out: only treat the event as a gapless transition when
gaplessAttemptTrackId matches the track currentTrack actually believes
is playing. External track changes fall through to the
"track changed externally" block which updates currentTrack properly.

cc
2026-04-27 14:02:32 -06:00
vicrodh 89651cae60 Merge chore/internal/orphan-files-deletion into pre-release 2026-04-26 23:15:34 -06:00
vicrodh 6cecb22cb1 chore(network): delete dead pub mod commands block in network/mod.rs
The inner `pub mod commands` block in network/mod.rs hosted three
unregistered Tauri commands (get_network_mounts_cmd,
check_mount_accessible, check_network_paths_batch) and was uncalled.
The non-command helpers in the parent module (get_network_mounts,
check_mount_accessibility, find_mount_for_path, parse_mount_info)
are also no longer referenced now that the commands are gone, but
they remain pub for potential future use without warnings.

- Remove the inner `pub mod commands { ... }` block.
- Drop the now-unused std::collections::HashMap import.

cc
2026-04-26 22:50:38 -06:00
vicrodh 2345bf7849 chore(commands): delete legacy commands module and inline helpers
src-tauri/src/commands/user_session.rs hosted three unregistered
#[tauri::command] entries (activate_user_session, deactivate_user_session,
get_last_user_id) plus two non-command helpers (init_type_alias_state,
teardown_type_alias_state) consumed only by session_lifecycle.rs.

- Move init_type_alias_state and teardown_type_alias_state into
  session_lifecycle.rs (their only caller) as plain pub helpers.
- Delete src-tauri/src/commands/user_session.rs and
  src-tauri/src/commands/mod.rs.
- Remove pub mod commands; from lib.rs — the legacy commands
  namespace is now empty.
- Refresh the activate_session doc comment to match the new layout.

cc
2026-04-26 22:47:11 -06:00
vicrodh 3b6cb3c51f chore(library): delete dead library/commands.rs
The 1,375-line library/commands.rs hosted only unregistered Tauri
commands (54 of them) plus a path-compat pub use of state types.
Every #[tauri::command] in the file is V2-replaced and uncalled.
The state-types pub use was the only external surface and is
already exported canonically from library/mod.rs.

- Delete src-tauri/src/library/commands.rs entirely
- Drop pub mod commands; from library/mod.rs
- Update session_lifecycle.rs to use crate::library::LibraryState
  (the canonical path) instead of crate::library::commands::LibraryState
- Refresh the doc comment in library/state.rs to reflect the
  post-cleanup layout

cc
2026-04-26 22:44:34 -06:00
vicrodh df1583a727 chore(offline_cache): extract purge helper and delete dead commands.rs
All 17 #[tauri::command] entries in offline_cache/commands.rs are
unregistered (V2 owns the live cache commands) and uncalled. The only
surviving consumer was session_lifecycle.rs reaching for
purge_all_cached_files (a non-command helper).

- Move purge_all_cached_files to a new offline_cache/purge.rs module
  (drops the LibraryState path through library::commands; uses the
  canonical crate::library::LibraryState directly)
- Delete offline_cache/commands.rs along with its dead siblings:
  cache_track_for_offline + post_process_cached_track,
  is_track_cached, get_cached_track_path, get_cached_track,
  get_cached_tracks, get_offline_cache_stats, remove_cached_track,
  clear_offline_cache + cleanup_empty_folder, set_offline_cache_limit
  + evict_if_needed, open_offline_cache_folder, open_album_folder,
  open_track_folder, check_offline_root_mounted, validate_offline_path,
  move_offline_cache_to_path, detect_legacy_cached_files (the command
  shim — the helper of the same name lives in migration.rs and is
  still consumed by V2), start_legacy_migration,
  sync_offline_cache_to_library + SyncResult.
- Update session_lifecycle.rs to import from offline_cache::purge.

cc
2026-04-26 22:42:28 -06:00
vicrodh 1a138d8e2f chore(reco_store): rename commands.rs to helpers.rs and drop dead commands
The reco_store/commands.rs module no longer hosts any registered Tauri
commands. Its surviving content is purely helper logic consumed by V2
home recommendations in commands_v2/library.rs.

- Rename reco_store/commands.rs -> reco_store/helpers.rs
- Drop the unregistered/uncalled #[tauri::command] entries
  (reco_log_event, reco_train_scores, get_playlist_suggestions,
  reco_backfill_genres, reco_needs_genre_backfill) and their dead
  scoring helpers (build_scores, build_track_entries, decay_factor,
  current_timestamp, etc.) along with RecoTrainStats / RecoScoreCounts
  / BackfillStats structs that only those commands referenced.
- Update commands_v2/library.rs to import from
  crate::reco_store::helpers::* (still uses get_home_seeds_internal,
  resolve_albums, resolve_tracks, resolve_artists, album_to_card_meta).

cc
2026-04-26 22:39:05 -06:00
vicrodh 3f819d71df chore(cast): delete dead cast and dlna commands modules
The Tauri commands in cast/commands.rs and cast/dlna/commands.rs are
unregistered (handler list is V2-only) and uncalled. The CastState /
DlnaState path-compat re-exports are also unused (canonical paths are
crate::cast::CastState and crate::cast::dlna::DlnaState). Remove the
files entirely and drop pub mod declarations.

cc
2026-04-26 22:35:14 -06:00
vicrodh c57acbda4c Merge refactor/internal/api-server-v2-migration into pre-release 2026-04-26 22:26:02 -06:00
vicrodh dc16e71617 chore(legacy): delete src-tauri/src/commands/playback.rs
The last consumer (api_server REST handlers) was migrated to
commands_v2::v2_play_track / v2_seek / v2_set_volume in the previous
commit, so the file's three remaining #[tauri::command] functions
(play_track, seek, set_volume) plus the unregistered prefetch_track,
get_playback_state, and all helper symbols (parse_quality,
limit_quality_for_device, PlayTrackResult, StreamInfo, download_audio,
get_stream_info, extract_audio_format_from_header, download_and_stream,
spawn_prefetch, prefetch constants, PREFETCH_SEMAPHORE) had zero
remaining callers.

Drops the `pub mod playback;` and `pub use playback::*;` lines from
commands/mod.rs. Only user_session.rs remains in the legacy commands
module.

cc
2026-04-26 22:00:06 -06:00
vicrodh 2d60f50140 refactor(api): migrate api_server playback to V2 commands
Switches the REST endpoints serving the PWA remote control from the
legacy commands::playback::* helpers to their V2 equivalents:

- play_queue_track / play_queue_index / play_album:
    commands::playback::play_track -> commands_v2::v2_play_track
- seek: commands::playback::seek -> commands_v2::v2_seek
- set_volume: commands::playback::set_volume -> commands_v2::v2_set_volume

The HTTP contract (paths, methods, payload shapes, response codes,
emit_playback_update side-effects) is unchanged. Behaviour gains the
V2 features that legacy lacked (CMAF cache hits, ALSA hardware
sample-rate guard, manual-offline-mode awareness) because the PWA
remote now flows through the same playback path as the desktop UI.

Drops the `commands` import from this module (now only `commands_v2`
is used) and adds the State acquisitions needed by v2_play_track:
CoreBridgeState, OfflineState, RuntimeManagerState.

cc
2026-04-26 21:58:16 -06:00
vicrodh 05db9dee67 Merge refactor/internal/inline-library-delegates into pre-release 2026-04-26 21:46:06 -06:00
vicrodh 6ebb234a50 chore(commandRouter): delete dead cmdUpdateAudioSettings function
The function had zero callers across src/. Today's H2 audio rewiring
work updated the invoke names inside cmdUpdateAudioSettings but the
function itself was already unreachable. Remove it.

The remaining commandRouter exports (cmdGetAudioSettings,
cmdGetAvailableBackends, cmdGetDevicesForBackend,
cmdGetHardwareAudioStatus, plus all Playback/Queue helpers) still
have callers, so the file stays.

cc
2026-04-26 21:32:24 -06:00
vicrodh e277862f9d fix(settings): align fetchQobuzArtistImages default convention with consumer
SettingsView read qbz-fetch-artist-images with === 'true' (OFF when key
absent or unrecognised) while LocalLibraryView read with !== 'false'
(ON when key absent or unrecognised). The two files disagreed on
first-run behaviour and on any stored value other than 'true'/'false'.

Switch SettingsView to the !== 'false' convention so the toggle UI
matches what the consumer actually does at fetch time.

cc
2026-04-26 21:31:27 -06:00
vicrodh 078bc98a02 chore(settings): delete orphaned handleShowPartialPlaylistsChange and store import
The Show-Partial-Playlists toggle was intentionally hidden in commit
2579c1990 ("Remove offline playlist integration") because offline
playlists are not yet functional. The handler and its
setShowPartialPlaylists store import were left behind as dead code.
The store function and OfflineSettings.showPartialPlaylists field
remain because Sidebar.svelte and PlaylistManagerView.svelte still
read the setting (defaulting to true).

When offline playlist integration ships, the toggle and handler can
be re-added.

cc
2026-04-26 21:30:27 -06:00
vicrodh f56f146eb8 fix(settings): persist plexManualTokenMode via getUserItem/setUserItem like sibling Plex flags
Toggling Manual Token Mode only updated local $state, so on every
remount of the Settings view the toggle reverted to OFF and hid the
manual-token field. Hydrate from getUserItem and persist via
setUserItem on change, matching the pattern used by plexEnabled,
plexUiCollapsed, and plexMetadataWriteEnabled.

Storage key: qbz-plex-poc-manual-token-mode (string 'true'/'false').

cc
2026-04-26 21:29:30 -06:00
vicrodh fb36aa1bc2 fix(settings): wire RemoteControlSetupGuide to a Show-setup-guide button
The RemoteControlSetupGuide modal was rendered but unreachable: nothing
ever set showRemoteControlGuide to true. Add a Setup-Guide button next
to the existing Regenerate / QR controls in the Remote Control developer
subsection so the onboarding wizard can actually be opened.

The button intentionally is not gated by remoteControlEnabled because
the guide is intended for users who have not yet enabled remote control.

Reuses the pre-existing settings.integrations.remoteControlSetupGuide
i18n key (already present in en/es/de/fr/pt).

cc
2026-04-26 21:28:15 -06:00
vicrodh c647cd0373 refactor(v2): inline offline status, settings, and pending playlist delegates
Inlines bodies of get_offline_status, get_offline_settings,
set_manual_offline, check_network, and get_pending_playlists from
offline::commands directly into the v2 wrappers in commands_v2/library.rs.

Deletes the entire offline::commands submodule (the inlined commands and
the additional dead Tauri command shims that lived alongside them — none
were registered with Tauri or referenced outside the submodule). Prunes
the now-unused tauri AppHandle/Emitter imports from offline/mod.rs.

Step 8 of legacy cleanup, group H.

cc
2026-04-26 20:30:38 -06:00
vicrodh d98d35796e refactor(v2): inline reco_get_home, reco_get_home_ml, reco_get_home_resolved
Inlines bodies of reco_get_home, reco_get_home_ml, and reco_get_home_resolved
from reco_store/commands.rs directly into the v2 wrappers in
commands_v2/library.rs. Promotes their shared helpers
(get_home_seeds_internal, resolve_tracks, resolve_artists,
album_to_card_meta) from private to pub(crate) so the v2 wrappers can
call them without crossing back into a legacy command module.

Deletes the corresponding legacy #[tauri::command] definitions and
prunes now-unused imports from reco_store/commands.rs.

Step 8 of legacy cleanup, group G.

cc
2026-04-26 20:26:19 -06:00
vicrodh 7d18e6d3a8 refactor(v2): inline playlist custom order and local copies delegates
Inlines bodies of playlist_get_custom_order, playlist_has_custom_order,
and playlist_get_tracks_with_local_copies from library/commands.rs
directly into the v2 wrappers in commands_v2/playlists.rs, mapping
LibraryError to RuntimeError::Internal as needed.

Deletes the corresponding legacy #[tauri::command] definitions and
removes their re-exports from library/mod.rs.

Step 8 of legacy cleanup, group F.

cc
2026-04-26 20:21:22 -06:00
vicrodh 7858c16b64 refactor(v2): inline library album, track, and playlist folder delegates
Inlines bodies of library_get_album_tracks, library_get_tracks_by_ids,
and update_playlist_folder from library/commands.rs directly into the
v2 wrappers in commands_v2/library.rs.

Deletes the corresponding legacy #[tauri::command] definitions and
removes their re-exports from library/mod.rs.

Step 8 of legacy cleanup, group E.

cc
2026-04-26 20:18:14 -06:00
vicrodh 44ad3392ef refactor(v2): inline library artwork and thumbnails delegates
Inlines bodies of library_fetch_missing_artwork, library_get_thumbnail,
and library_get_thumbnails_cache_size from library/commands.rs directly
into the v2 wrappers in commands_v2/library.rs.

Deletes the corresponding legacy #[tauri::command] definitions and the
unused legacy library_clear_thumbnails command. Removes their re-exports
from library/mod.rs.

Step 8 of legacy cleanup, group D.

cc
2026-04-26 20:15:52 -06:00
vicrodh 056480a0be refactor(v2): inline library scan progress, stats, and search delegates
Inlines bodies of library_get_scan_progress, library_get_artists,
library_search, and library_get_stats from library/commands.rs directly
into the v2 wrappers in commands_v2/library.rs.

Deletes the corresponding legacy #[tauri::command] definitions and
removes their re-exports from library/mod.rs.

Step 8 of legacy cleanup, group C.

cc
2026-04-26 20:12:24 -06:00
vicrodh 2af3e2059f refactor(v2): inline library folder management delegates
Inlines bodies of library_add_folder, library_cleanup_missing_files,
library_get_folders, and library_get_folders_with_metadata from
library/commands.rs directly into the v2 wrappers in commands_v2/library.rs.

Deletes the corresponding legacy #[tauri::command] definitions and
removes their re-exports from library/mod.rs.

Step 8 of legacy cleanup, group B.

cc
2026-04-26 20:09:09 -06:00
vicrodh 25fffb7fd0 refactor(v2): inline library scan and metadata _impl delegates
Inlines bodies of library_scan_impl, library_stop_scan_impl,
library_scan_folder_impl, library_clear_impl, library_update_album_metadata_impl,
library_write_album_metadata_to_files_impl, and library_refresh_album_metadata_from_files_impl
from library/commands.rs directly into the v2 wrappers in commands_v2/legacy_compat.rs.
Moves their helpers (process_cue_file, apply_sidecar_override_if_present,
compute_track_artist_match, normalize_library_path) alongside the inlined bodies.

Deletes the corresponding legacy #[tauri::command] _impl definitions and
the dead public command siblings (library_scan, library_stop_scan,
library_scan_folder, library_clear, library_update_album_metadata,
library_write_album_metadata_to_files, library_refresh_album_metadata_from_files)
that were only ever called from the deleted _impl variants.
Updates library/mod.rs to drop the corresponding re-exports.

Step 8 of legacy cleanup, group A.

cc
2026-04-26 20:05:16 -06:00
vicrodh 3224a5219b Merge refactor/internal/inline-legacy-compat into pre-release 2026-04-26 19:29:02 -06:00
vicrodh 81461bec32 refactor(v2): inline network check_network_path delegate
Inlines `check_network_path` from crate::network::commands into
commands_v2/legacy_compat.rs. The legacy command was a one-line wrapper
over crate::network::is_network_path; the inlined v2 form calls
is_network_path directly with no behavior change.

Deletes the legacy #[tauri::command] definition in network/mod.rs.
Other tauri commands inside crate::network::commands remain (they have
no v2 delegates and keep being exported as their own legacy commands;
they will be addressed in a separate cleanup step if needed).

No frontend invoke changes required.

Step 6 of the legacy cleanup plan, group G (network path).

cc
2026-04-26 18:21:26 -06:00
vicrodh 145b589c2a refactor(v2): inline folder settings and track-by-path delegates
Inlines the bodies of `library_update_folder_settings` and
`get_track_by_path` from crate::library::commands::* directly into
commands_v2/legacy_compat.rs. Maps the legacy String error type to
RuntimeError::Internal at every return path.

Deletes the legacy #[tauri::command] definitions in
library/commands.rs. The data-layer methods on LibraryDatabase
(update_folder_settings, get_folder_by_id, get_track_by_path) are
unchanged.

No frontend invoke changes required.

Step 6 of the legacy cleanup plan, group F (folder settings + track
lookup).

cc
2026-04-26 18:19:59 -06:00
vicrodh 99729d3888 refactor(v2): inline library_backfill_downloads delegate
Inlines the body of `library_backfill_downloads` from
crate::library::commands::* directly into commands_v2/legacy_compat.rs,
mapping the legacy String error type to RuntimeError::Internal at every
return path. Adjusts the v2 return type to refer to
crate::library::BackfillReport (the canonical re-export from
qbz-library) instead of the deleted crate::library::commands path.

Deletes the legacy #[tauri::command] definition in
library/commands.rs. MetadataExtractor and BackfillReport are reused
unchanged from their crate::library re-exports.

No frontend invoke changes required.

Step 6 of the legacy cleanup plan, group E (backfill downloads).

cc
2026-04-26 18:18:15 -06:00
vicrodh afa8298745 refactor(v2): inline offline cache fully-cached delegates
Inlines the bodies of `check_album_fully_cached` and
`check_albums_fully_cached_batch` from
crate::offline_cache::commands::* directly into
commands_v2/legacy_compat.rs, mapping the legacy String error type to
RuntimeError::Internal at the v2 boundary.

Note: v2_cache_notification_artwork is NOT a delegate — it lives in
commands_v2/helpers.rs and is a true helper used by other v2 commands.
The investigation list flagged it as a possible delegate, but
verification showed it owns its implementation.

Deletes the legacy #[tauri::command] definitions in
offline_cache/commands.rs. Other functions in the offline_cache::commands
module remain (still called from commands_v2/library.rs delegates,
which are step 8 scope).

No frontend invoke changes required.

Step 6 of the legacy cleanup plan, group D (offline cache).

cc
2026-04-26 18:16:02 -06:00
vicrodh 515f73b259 refactor(v2): inline offline scrobble/playlist delegates
Inlines the bodies of `create_pending_playlist`,
`get_pending_playlist_count`, `queue_scrobble`, `get_queued_scrobbles`,
`get_queued_scrobble_count`, and `cleanup_sent_scrobbles` from
crate::offline::commands::* directly into commands_v2/legacy_compat.rs.

The legacy bodies were uniform: lock state.store, unwrap optional store,
delegate to a method on the store struct. Inlined verbatim with the
String error type mapped to RuntimeError::Internal at each return path.
The store-side OfflineStore methods (data layer) are untouched.

Deletes the legacy #[tauri::command] definitions in offline/mod.rs.
Other functions in the offline::commands module remain (still called
from commands_v2/library.rs delegates, which are step 8 scope).

No frontend invoke changes required.

Step 6 of the legacy cleanup plan, group C (offline scrobble/playlist).

cc
2026-04-26 18:14:14 -06:00
vicrodh 40b8ec90a0 refactor(v2): inline discogs delegates and delete legacy discogs commands
Inlines the bodies of `discogs_has_credentials`,
`discogs_search_artwork`, and `discogs_download_artwork` from
crate::library::commands::* directly into commands_v2/legacy_compat.rs.
The discogs delegates were single-line bodies (or trivial proxy logic);
DiscogsClient and library::get_artwork_cache_dir are reused as-is.

The String error type from the underlying DiscogsClient methods is
mapped to RuntimeError::Internal at the v2 boundary, matching the
existing v2 contracts.

Deletes the legacy #[tauri::command] definitions from
library/commands.rs. No frontend invoke changes required.

Step 6 of the legacy cleanup plan, group B (discogs).

cc
2026-04-26 18:11:58 -06:00
vicrodh ba878b8419 refactor(v2): inline lyrics delegates and delete legacy lyrics commands
Inlines the bodies of `lyrics_get` and `lyrics_get_cache_stats` from
crate::lyrics::commands::* directly into commands_v2/legacy_compat.rs,
mapping the legacy String error type to RuntimeError::Internal at the
return boundary for v2_lyrics_get. Renames LyricsCacheStats to
V2LyricsCacheStats, hosted next to the inlined v2_lyrics_get_cache_stats.

Deletes lyrics/commands.rs entirely (also drops the dead
lyrics_clear_cache helper which had no callers; v2_lyrics_clear_cache in
commands_v2/library.rs already inlines its own logic).

The v2 functions retain their existing names, parameter shapes, and
Tauri::State signatures; only the body changes. No frontend invoke
changes required.

Step 6 of the legacy cleanup plan, group A (lyrics).

cc
2026-04-26 18:09:59 -06:00
vicrodh 42f872fd86 Merge chore/internal/legacy-dead-code-sweep into pre-release 2026-04-26 17:53:25 -06:00
vicrodh ac44b8a713 refactor(cast): move CastState and DlnaState to dedicated state modules
Relocates CastState (struct + impl) from cast/commands.rs to
cast/state.rs, and DlnaState (struct + impl) from
cast/dlna/commands.rs to cast/dlna/state.rs.

Both types are consumed by commands_v2/library.rs (and the legacy
Tauri commands themselves) via the existing re-exports in
cast/mod.rs and cast/dlna/mod.rs. The re-exports are updated to
source from the new state modules, and each commands.rs re-exports
its state type so historical
crate::cast::commands::CastState / crate::cast::dlna::commands::DlnaState
paths continue to compile.

This unblocks future deletion of cast/commands.rs and
cast/dlna/commands.rs in a later cleanup step (the
#[tauri::command] functions in those files are already
unregistered and have zero Rust call sites).

cc
2026-04-26 17:19:21 -06:00
vicrodh e0dc464a65 refactor(library): move state types out of commands.rs
Relocates LibraryState (struct + impl), CleanupResult, BackfillReport,
LibraryAlbumMetadataUpdateRequest, and LibraryAlbumTrackMetadataUpdate
from library/commands.rs to a new library/state.rs module.

These types are consumed by commands_v2/library.rs,
commands_v2/legacy_compat.rs, commands_v2/mixtapes.rs,
commands_v2/link_resolver.rs, cast/commands.rs, and
session_lifecycle.rs. The existing pub use re-exports in
library/mod.rs are updated to source from state, and commands.rs
re-exports them in turn so historical
crate::library::commands::* paths (still used by
commands_v2/legacy_compat.rs, which is out of scope for this task)
continue to compile.

This unblocks future deletion of library/commands.rs once the
remaining #[tauri::command] definitions there are inlined into
their commands_v2 callers (separate task).

No serde shape changes; struct fields, derives and serde
attributes are preserved verbatim, so the JSON the frontend
receives is identical.

cc
2026-04-26 17:12:47 -06:00
vicrodh aecdd4f5c8 chore(legacy): delete dead Tauri commands in commands/playback.rs
Removes 11 #[tauri::command] functions that are unregistered and have
zero Rust call sites:
- pause_playback, resume_playback, stop_playback
- play_next_gapless, set_media_metadata
- get_audio_devices, reinit_audio_device
- get_audio_output_status, get_pipewire_sinks
- set_pipewire_default_sink, debug_get_cpal_devices

play_track, seek, and set_volume are preserved - they are still
consumed by src-tauri/src/api_server/mod.rs (REST endpoints for
the PWA remote). They will be migrated to call commands_v2/playback
or core_bridge in a later step.

Helper functions used solely by the deleted commands are also
removed: AudioDevice, AudioOutputStatus, PipewireSink structs,
get_pipewire_device_descriptions (linux + non-linux), and
cpal_device_name. Helpers reachable from play_track / seek /
set_volume / prefetch_track / get_playback_state (parse_quality,
limit_quality_for_device, download_audio, get_stream_info,
extract_audio_format_from_header, download_and_stream,
spawn_prefetch, prefetch constants and PREFETCH_SEMAPHORE) are
preserved.

cc
2026-04-26 17:07:56 -06:00
vicrodh 92ceb025a1 chore(legacy): delete src-tauri/src/commands/search.rs
All 20 #[tauri::command] functions in this file are unregistered
(no longer in invoke_handler) and have zero Rust call sites. V2
equivalents in commands_v2/search.rs and commands_v2/catalog.rs
cover all use cases.

Removed:
- search_albums, search_tracks, search_artists, search_all
- get_album, get_featured_albums, get_track, get_artist
- get_similar_artists, get_genres
- get_discover_index, get_discover_playlists, get_playlist_tags, get_discover_albums
- get_artist_page, get_artist_basic, get_artist_detail
- get_artist_tracks, get_artist_albums, get_releases_grid

The corresponding pub mod search; declaration in commands/mod.rs is
also removed.

The SearchAllResults / MostPopularItem types (used by api_server's
REST /search/all endpoint, the PWA remote control surface) are
relocated into api_server/mod.rs since that is the only remaining
consumer; this avoids leaving a near-empty file just to host two
serde DTOs.

cc
2026-04-26 17:04:10 -06:00
vicrodh 49df57675a chore(legacy): drop 15 unused legacy command registrations from invoke_handler
These commands had v2_* equivalents registered alongside them; the
frontend has been migrated and no longer invokes them. The legacy
function definitions remain in their respective modules - they will
be removed in subsequent steps once we verify nothing internally
calls them.

cc
2026-04-26 17:00:51 -06:00
vicrodh fd545eccaa Merge refactor/internal/v2-cleanroom-final into pre-release 2026-04-26 13:07:17 -06:00
vicrodh c70db4157a refactor(v2): migrate get_pipewire_sinks to v2
Path C: legacy CPAL output-sink enumeration was inlined directly in
commands/playback.rs (cfg-gated Linux + non-Linux variants), with
no equivalent in any domain crate. Extract a domain function
`qbz_audio::output_sinks::list_output_sinks` that returns the same
{name, description, volume, is_default} shape (mirrored as the new
public `OutputSinkInfo` struct) for both Linux and non-Linux
platforms, preserving the original logging cadence and the rule
that name == CPAL device name (so saved IDs reopen correctly).

Add v2_get_pipewire_sinks in commands_v2/audio.rs that calls into
qbz_audio directly — no `crate::commands::*` delegation. Updates the
two frontend call sites (AudioOutputBadges.loadStatus and
SettingsView.loadAudioDevices). Legacy command in
commands/playback.rs is preserved untouched; the audio-protected
files (pipewire_backend.rs, audio_settings.rs, player init_device)
are not modified.

cc
2026-04-26 12:03:28 -06:00
vicrodh 1abb57bd7f refactor(v2): migrate get_audio_output_status to v2
Path B: legacy command read state.player.state.current_device() and
state.player.state.is_playing() — both methods already exist on the
qbz-player Player.state in the V2 architecture. No domain extraction
needed; the v2 command reads them via CoreBridge.player() like the
existing v2_get_hardware_audio_status does.

Adds v2_get_audio_output_status returning V2AudioOutputStatus
(serialized to the same {device_name, is_playing} shape so the
AudioOutputBadges frontend type is unchanged). Updates both
AudioOutputBadges call sites (initial loadStatus + the 1s polling
interval). The legacy command in commands/playback.rs is preserved
untouched.

cc
2026-04-26 12:00:15 -06:00