Commit Graph
1415 Commits
Author SHA1 Message Date
vicrodh 6cea4149c0 Migrate all queue operations to V2 commands
- Add V2 queue commands: v2_set_shuffle, v2_move_queue_track,
  v2_add_tracks_to_queue, v2_add_tracks_to_queue_next,
  v2_remove_upcoming_track
- Migrate queueStore.ts to use all V2 queue commands
- Update all view components to use V2 queue commands:
  - HomeView, SearchView, ArtistDetailView, FavoritesView
  - LocalLibraryView, PlaylistDetailView
- Update +page.svelte to use V2 shuffle, repeat, and remove commands

No legacy queue commands are called from frontend anymore.
2026-02-14 23:21:19 -06:00
vicrodh c4b28e37ea fix(session): prevent false login state with userId=0
Addresses race condition and invalid state issues identified by Codex diagnostic:

1. CoreBridge: Add try_get() and is_initialized() methods to gracefully
   handle uninitialized state instead of panicking

2. auth.rs: Use try_get() for V2 auth in login/auto_login/logout to
   avoid panic if CoreBridge init is still in progress

3. LoginView.svelte: Reject userId=0 as fallback - if userInfo or userId
   is missing/invalid, don't call onLoginSuccess (require re-login)

4. +page.svelte:
   - Move get_audio_settings call to after sessionReady is set
   - Add explicit userId > 0 check before activate_user_session
   - Return early if activation fails to prevent sessionReady from
     being set in broken state

These are tactical fixes aligned with ADR_RUNTIME_SESSION_CONTRACT.md
invariants. Full runtime state machine implementation to follow.
2026-02-14 22:59:20 -06:00
vicrodh c3a14c1c87 feat(v2): add v2_reinit_audio_device command
- Added v2_reinit_audio_device for V2 player device reinitialization
- SettingsView now calls both legacy and V2 reinit commands
- Converts legacy AudioSettings to qbz_audio::AudioSettings for reload
2026-02-14 22:48:03 -06:00
vicrodh 82a81e1ded feat(v2): add MPRIS, gapless, and prefetch V2 commands
V2 Playback Features:
- v2_set_media_metadata: Update MPRIS metadata
- v2_play_next_gapless: Queue next track for gapless playback
- v2_prefetch_track: Pre-download track into memory cache

V2 Command Updates:
- v2_pause/resume/stop: Now update MPRIS state
- v2_seek: Updates MPRIS progress
- v2_get_playback_state: Updates MPRIS progress on poll

Frontend Migration:
- playbackService: Use v2_set_media_metadata
- playerStore: Use v2_play_next_gapless
2026-02-14 22:42:03 -06:00
vicrodh 6778ef4ba6 fix(auth): sync V2 CoreBridge authentication with legacy login
- Modified login/auto_login commands to also authenticate CoreBridge
- Modified logout command to also logout from CoreBridge
- Removed redundant v2_login call from LoginView.svelte frontend

This ensures both legacy AppState.client and V2 CoreBridge.QbzCore.client
are authenticated in sync, allowing V2 commands to work after login.
2026-02-14 22:38:26 -06:00
vicrodh 6b432586a7 feat(frontend): migrate playback commands to V2
Migrate all frontend playback invocations to V2 commands:
- play_track -> v2_play_track
- pause_playback -> v2_pause_playback
- resume_playback -> v2_resume_playback
- stop_playback -> v2_stop_playback
- seek -> v2_seek
- set_volume -> v2_set_volume

Updated files:
- playbackService.ts
- playerStore.ts
- playerStore.test.ts
- castStore.ts
- SettingsView.svelte

Frontend now uses V2 architecture for all Qobuz playback operations.
2026-02-14 22:17:36 -06:00
vicrodh b12a06fff3 feat(v2): expand V2 commands with playback and dual event emission
V2 Commands expanded:
- Add searchType parameter to search commands
- Add blacklist filtering to V2 search commands
- Add V2 playback commands (pause, resume, stop, seek, volume, state)

TauriAdapter dual emission:
- Emit both "core-event" (new) and legacy events during migration
- Legacy events: queue:updated, queue:shuffle-changed, queue:repeat-changed
- Legacy events: auth:logged-in, auth:logged-out, error

Frontend migration (partial soft-delete test):
- SearchView, ArtistDetailView, LocalLibraryView use v2_search_*
- HomeView, +page.svelte use v2_get_album, v2_get_track
- TrackReplacementModal uses v2_search_tracks

Old commands remain registered but are no longer called by migrated
frontend code. This enables testing V2 architecture while keeping
fallback available.
2026-02-14 20:10:58 -06:00
vicrodh 6c509225a4 fix(playlist): ensure progressive loading completes for large playlists
- Track failed batches and retry them once after initial load
- Detect playlist change and abort background loading if user navigates
- Log final status (COMPLETE vs INCOMPLETE with missing count)
- Prevents silent failures that left playlists partially loaded
2026-02-13 18:54:19 -06:00
vicrodh 8dcad203c7 fix(queue): correct remove-from-queue index and add history context menu
- Add remove_upcoming_track command that correctly maps upcoming index
  to actual queue index (handles shuffle mode properly)
- Update frontend to use remove_upcoming_track instead of remove_from_queue
- Add working context menu for history tracks (Add to Playlist, Track Info)
- Remove unused .track-menu CSS class
2026-02-13 13:29:30 -06:00
vicrodh 3a8ef43227 feat(audio): add device refresh button and per-DAC sample rate limit
- Add refresh button next to device dropdown to re-enumerate devices
  without app restart (fixes #69)
- Re-enable quality limiting with per-device sample rate storage
- User can manually set max sample rate per DAC (44.1k to 384k)
- Quality limiting is opt-in (disabled by default)
- Streaming Quality dropdown always takes priority (fixes #72)

Backend: HashMap<device_id, max_rate> stored as JSON in SQLite
Frontend: Conditional UI shows rate dropdown when limit is enabled
2026-02-13 12:56:50 -06:00
vicrodh 333e6f224a feat(ui): show default device name under System Default option
Adds a help text showing which device is the current system default.
This helps users understand what "System Default" will actually use.

Backend:
- New command `get_default_device_name` that uses pactl for PipeWire/Pulse
  and CPAL for ALSA to get the current default device

Frontend:
- Shows "(System Default is: <device name>)" under the output device setting
- Styled as secondary description text (italic, muted)

Translations added for en, es, de, fr.
2026-02-13 12:35:56 -06:00
vicrodh abb2a30e6e fix(ui): prevent duplicate System Default in device list
Skip the 'default' device from backend enumeration since we already
add an explicit "System Default" entry. This prevents showing
"System Default" twice in the dropdown.
2026-02-13 11:49:56 -06:00
vicrodh c07325d26f fix(ui): use device.id as each block key to prevent duplicates
Changed the keyed each block in DeviceDropdown.svelte from device.value
to device.id. This fixes the each_key_duplicate error when multiple
devices have the same display name (e.g., "System Default").
2026-02-13 11:38:33 -06:00
vicrodh e977ca8b34 feat(ui): new playlist collage layout with 3+1 grid
- Change 4-cover layout from 2x2 to 3 small left + 1 large right
- Always use track artwork collage instead of low-res API image
- Upscale images to 600px for better quality

cc
2026-02-13 07:54:36 -06:00
vicrodh e8929cb2a4 fix(ui): volume buttons and playlist search refinements
- Remove border from volume step buttons (no circles in player)
- Remove separator between volume and queue button
- Make playlist search input taller using negative margins
- Auto-expand folders with matching results during search
- Hide folders without matches during search

cc
2026-02-13 07:54:36 -06:00
vicrodh ebae1aa83a feat(ui): add volume step buttons and playlist search
- Add +/- buttons to volume control for 5% increments
- Reduce SongCard min-width from 508px to 436px
- Add playlist search in sidebar header with expandable input
- Add translations for new features in all 4 locales

cc
2026-02-13 07:54:36 -06:00
vicrodh 3f8914e8cb Move graphics settings to Composition section
- Add Hardware Acceleration toggle to Composition section
- Move Force DMA-BUF toggle from Developer Mode to Composition
- Add i18n keys for new composition toggles (en, es, de, fr)

These settings logically belong together since they both control
GPU rendering behavior. Hardware Acceleration is the broad switch
that enables GPU; Force DMA-BUF controls the specific buffer-sharing
mechanism with the compositor.
2026-02-12 14:16:52 -06:00
vicrodh 901b0edab8 Fix system title bar sync only propagating true values
The localStorage->backend sync only ran when useSystemTitleBar was true,
so toggling it OFF never persisted to the database. On restart, the
backend read the old 'true' value and created the window with system
decorations, while the UI showed 'false' from localStorage.

Now syncs the value unconditionally on init.
2026-02-12 13:56:33 -06:00
vicrodh 348e615d41 Fix infinite loop in AudioOutputBadges causing log spam
The $effect watching outputStatus.is_playing would call loadStatus(),
which updates outputStatus, triggering the effect again. This caused
~30 calls per second when hovering over the audio badges.

Removed the problematic $effect - mouseenter handler and 1s polling
for hardware status are sufficient.
2026-02-12 13:45:58 -06:00
vicrodh 14e657e8af Optimize console log capture in production
Only capture log/info levels in dev builds or when verbose mode is
explicitly enabled in Developer Mode. Always capture error/warn for
bug tracking. Reduces GC/CPU overhead in production builds.

Adds toggle in Settings > Developer Mode to enable verbose capture
when debugging production issues.
2026-02-12 13:34:02 -06:00
vicrodh 51a24de9cb Fix async listener leak on fast unmount/HMR
Apply disposed flag pattern to prevent listener leaks when component
unmounts before async listen() calls complete.

+page.svelte:
- Add disposed flag for tray/media control listeners
- Check disposed after each await listen(), cleanup immediately if true
- Set disposed=true at start of cleanup function

offlineCacheState.ts:
- Add listenersDisposed flag
- Check flag after each listener registration
- Cleanup any registered listeners if disposed during async sequence
- Set flag in stopOfflineCacheEventListeners()

This prevents memory leaks during HMR and fast navigation.
2026-02-12 13:27:00 -06:00
vicrodh 9c5245f2ce Add context menu for queue tracks
QueuePanel:
- Add vertical ... icon to the right of track duration
- Context menu with 3 options:
  - Remove from Queue (calls backend remove_from_queue)
  - Add to Playlist (reuses existing playlist modal)
  - Show Track Info (reuses existing track info modal)
- Menu shows on button click, closes on click outside

+page.svelte:
- Add handlers: handleRemoveFromQueue, handleQueueTrackAddToPlaylist,
  handleQueueTrackInfo
- Wire up new QueuePanel props

i18n: Add toast messages for remove from queue (all 4 locales)
2026-02-12 13:20:08 -06:00
vicrodh 1959000fd0 Expose graphics fallback status to UI with warning
Backend:
- Add static atomics to track graphics startup state
- Add set_startup_graphics_state() called from main.rs
- Add get_graphics_startup_status command for frontend

Frontend (SettingsView):
- Query graphics startup status on mount
- Show prominent red warning in Composition section when
  using fallback graphics settings
- Display recovery command (qbz --reset-graphics)

i18n: Add fallbackWarning/fallbackDesc to all 4 locales

This helps users understand when graphics settings failed to
load and may be causing performance degradation.
2026-02-12 13:11:47 -06:00
vicrodh 36632548fe Add idempotency guard to offline cache listeners
Prevents duplicate event listeners if startOfflineCacheEventListeners
is called multiple times (e.g., during HMR or accidental remount).
2026-02-12 13:02:41 -06:00
vicrodh 42034623be Disable MiniPlayer feature (incomplete)
- Hide MiniPlayer button in NowPlayingBar when not provided
- Comment out miniplayer IPC emissions in player state subscriber
- Removes unnecessary IPC overhead during playback

MiniPlayer needs significant work before re-enabling.
2026-02-12 12:59:16 -06:00
vicrodh 2514c53e7b Remove Vinyl panel from Immersive focus mode tabs
Removes vinyl from the focus mode tab options while keeping the
VinylPanel component intact for potential future use. Users can
now choose from coverflow, static, visualizer, lyrics, and queue.
2026-02-12 12:44:45 -06:00
vicrodh 5d48e15e76 merge: integrate bugfixes/pre-release-1.1.12
Includes:
- fix(graphics): revert to v1.1.9 rendering defaults
- feat(graphics): GPU rendering summary in startup logs
- feat(settings): collapsible Composition section
- fix: disable gapless when DAC Passthrough active
- fix: prevent multiple instances
- feat: playlist offline option

cc
2026-02-12 09:47:53 -06:00
vicrodh a69009d23d feat: add "Make available offline" option for playlists
Cherry-picked from main (126a5714)

cc
2026-02-12 09:46:13 -06:00
vicrodh 968a9d7116 fix: disable gapless when DAC Passthrough is active
Cherry-picked from main (ab3dac32)

cc
2026-02-12 09:45:55 -06:00
vicrodh 0170519a6b feat(updates): add snap welcome modal with plug setup commands
cx
2026-02-11 09:07:38 -06:00
vicrodh aed7e43c0f feat(settings): add collapsible Composition section in Appearance
Replace the misleading Hardware Acceleration toggle (which was a no-op
since v1.1.12 reverted to env-var-only control) and the standalone
Force X11 toggle with a collapsible "Composition" subsection that:

- Groups all GPU/rendering settings in one place
- Shows help text explaining what the section controls
- Includes a crash recovery warning with terminal command
- Keeps Force X11 toggle (functional, writes to DB)
- Adds GDK_SCALE and GDK_DPI_SCALE inputs (shown when Force X11 on)
- Lists all env var overrides with descriptions
- Translated in all 4 locales (en, es, de, fr)
2026-02-10 20:32:40 -06:00
vicrodh 0f31dcd310 feat: add persistent Force X11 setting for Wayland crash workaround
Add a toggle in Settings > Appearance to force X11 (XWayland) backend
on Wayland sessions. Persisted in graphics_settings.db, env var
QBZ_FORCE_X11=1|0 overrides for crash recovery. Also fixes the
display server log to report effective GDK backend instead of
session type.
2026-02-10 07:18:15 -06:00
vicrodh 07f9f64a08 fix: persist volume and tray settings across restarts
Volume was saved to per-user localStorage but loaded from unscoped key
before login set the userId. Added resyncPersistedVolume() called after
login to re-read from the correct scoped key.

Close/minimize to tray read settings once at startup from the flat-path
DB, but user changes were saved to per-user DB after login. Changed
close-to-tray to read dynamically from state, and minimize-to-tray to
re-fetch before each action.
2026-02-10 06:23:05 -06:00
vicrodh 051c9a3197 fix: remove z-index from artist page sticky nav to prevent sidebar dropdown overlap 2026-02-10 02:08:11 -06:00
vicrodh c071b86ae2 feat: preserve original Qobuz playlist image when copying to library 2026-02-10 02:05:17 -06:00
vicrodh bbc3b4a32e fix: use localized playlist tags and align tag selector below section title 2026-02-10 01:52:56 -06:00
vicrodh b76b369d9b feat: wire up discover playlists browse page with navigation and i18n 2026-02-10 01:51:31 -06:00
vicrodh 0f8bba5f89 feat: add playlist tags endpoint and DiscoverPlaylistsBrowseView component 2026-02-10 01:48:37 -06:00
vicrodh d453bcd559 fix: remove z-index from favorites-nav and dropdown-container
Both were creating stacking contexts that trapped the sidebar playlist
dropdown behind them. Removing z-index entirely avoids creating stacking
contexts — sticky positioning handles scroll overlap natively, and the
dropdown-menu child manages its own z-index.
2026-02-10 01:25:17 -06:00
vicrodh 8857ef0597 fix: lower favorites-nav z-index to prevent sidebar dropdown overlap
The sticky .favorites-nav header had z-index: 4 which created a stacking
context that trapped the sidebar playlist dropdown menu behind it. Lower
to z-index: 1, matching the pattern used in ArtistDetailView and
LocalLibraryView.
2026-02-10 01:22:04 -06:00
vicrodh 0fe1174a0b fix: move See All link below section title instead of beside it
Wrap title + See All in a flex column group so the link sits directly
under the section heading, left-aligned. Remove margin-left: auto that
was pushing it to the right edge.
2026-02-10 01:13:30 -06:00
vicrodh 3e4f95d297 fix: replace pipe separator with arrow icon for See All links
Remove the pipe divider that looked bad. Replace ChevronRight with
ArrowRight for a cleaner See All > appearance. Revert HorizontalScrollRow
gap change that was only needed for the pipe.
2026-02-10 01:11:21 -06:00
vicrodh ba62057545 feat: add Qobuzissimes, Albums of the Week, Press Accolades browse pages
- Add 3 new Rust endpoint constants and command mappings for
  /discover/qobuzissims, /discover/albumOfTheWeek, /discover/pressAward
- Add 3 new navigation ViewType values and genre filter contexts
- Extend DiscoverBrowseView to handle the 3 new endpoint types
- Add See All links with chevron caret and pipe separator to all 6
  discover sections in HomeView (newReleases, mostStreamed,
  essentialDiscography, qobuzissimes, editorPicks, pressAwards)
- Wire up 3 new views in +page.svelte with full album action callbacks
- Rename Editor's Picks to Albums of the Week, Press Awards to Press
  Accolades across all 4 locale files (en, es, de, fr)
- Fix rank badge: top-right position, Impact font, 35px size
- See All styling: inline-flex with ChevronRight icon, pipe divider,
  15px gap before nav buttons, #666666 color matching nav buttons
2026-02-10 01:10:28 -06:00
vicrodh a575c0c805 fix: use existing genre filter, fix ranking display and See All positioning
- Replace custom genre <select> with GenreFilterButton component, each
  discover page gets independent persistence via separate contexts
- Rank badge in grid mode: 3x bigger (33px), positioned on right side
  of album card, no # symbol
- See All link: pushed to right edge (margin-left: auto), color matches
  nav buttons (#666666), hover transitions to text-primary
- Add proper page padding to DiscoverBrowseView (18px left, 8px right)
2026-02-10 00:57:57 -06:00
vicrodh c9bdcae855 feat: add discover browse pages for New Releases, Ideal Discography, Top Albums
Add full-page browsing views for the three discover sections that were
previously only shown as limited carousels on the Home page.

Backend: add get_discover_albums Tauri command with endpoints for
newReleases, idealDiscography, and mostStreamed. Uses paginated API
calls with genre_ids filtering.

Frontend: new DiscoverBrowseView component with virtualized grid/list,
genre filter dropdown, client-side search, and infinite scroll.
VirtualizedFavoritesAlbumGrid gains ranking support (showRanking),
infinite scroll (onLoadMore), and loading indicator.

HomeView sections now show "See All" links that navigate to the
dedicated browse pages. i18n keys added to all 4 locales.
2026-02-10 00:46:39 -06:00
vicrodh dcdddf384c fix: remove inner scroll from Search tabs, use parent scroll container
Search tabs (albums, tracks, artists) had their own overflow-y scroll
containers, causing double scrollbars and preventing the global
back-to-top button and sticky search bar from working.

- Remove height, min-height, overflow from .virtual-scroll-container
- Remove scrollbar pseudo-element CSS for virtual containers
- Feed virtual scroll calculations from parent .search-view scroll
- Remove per-container onscroll handlers (unused)
- ResizeObservers now only track width for grid column calculations
- Container height comes from parent scroll viewport
2026-02-09 23:15:56 -06:00
vicrodh 7b5a7d963d feat: move back-to-top to global layout level
Replaced the per-view back-to-top in PlaylistDetailView with a
global one in +page.svelte. Uses capture-phase scroll listener
on .main-content to track scroll from any child view. Appears
after 800px scroll on any view. Resets on view change.
2026-02-09 23:08:40 -06:00
vicrodh 170b6408f7 fix(artist,library): bump jump-nav z-index above scrolling content
Content elements (track artwork z:1, play overlay z:2) were rendering
on top of the sticky jump-nav (also z:1). Bumped to z:10, still below
dropdown menus (z:50+) and context menus (z:100).
2026-02-09 23:05:21 -06:00
vicrodh cb3b518eb2 fix(playlist): add bottom spacer when suggestions section is absent
Prevents the back-to-top button from covering the last track's
action buttons on playlists without a suggestions section.
2026-02-09 23:01:01 -06:00
vicrodh cdc051d476 fix(playlist): position back-to-top 10px above the player bar 2026-02-09 22:58:50 -06:00