Commit Graph
7018 Commits
Author SHA1 Message Date
vicrodh cab68c9209 fix(queue): play-next/play-later ordering + Q-mix multiselect/queue/create-playlist (#442)
Split the manual insertion block into two tiers so "Play later" no longer
behaves identically to "Play next":
- add a `manual_later_count` to InternalState tracking the trailing
  "Play later" sub-block: [now][play-next block][play-later block][source].
- play-next inserts at the FRONT of the manual block; play-later appends at
  its END (after any earlier play-later tracks), in order.
- fix the idle + shuffle case: with no current track, both actions anchor at
  base 0 instead of the end of shuffle_order, so an idle-built queue plays
  play-next first and play-later right after, and does not collapse the rest
  of the queue on the first transport play.
- next()/remove_at()/jump decrement drain the play-next tier before the
  play-later tier; set_queue/clear/shuffle-enable dissolve both.
- the public QueueState.manual_next_count exposes mnc+mlc so both tiers render
  inside the single "Next in queue" visual container.

NorinB's shuffle-randomization report keeps a debug log in next() to capture
a repro if it recurs; the temporary INFO instrumentation is lowered to debug.

MixView Q-mixes reach transport parity with playlists: functional multiselect
(SelectionModel + multi-select bar), header queue menu (play next / later /
add to queue via bulkTracksAction), and create-playlist-from-selection.

Queue engine covered by 86 passing tests (play-later ordering non-shuffle,
under shuffle, and idle-shuffle cases added).

cc
2026-09-11 08:51:38 -06:00
vicrodh ef74cde3d8 test(myqbz): align tracks_text test with the #766 empty-column contract
The stale test still asserted the pre-#766 behavior (em-dash for an unknown
album count, "1" for a track). #766 made the tracks column empty for a track
and empty for an unknown album count (filled only once resolve_items backfills)
— the shipped, smoke-validated behavior. Update the test to match; the CI qt
gate was red on this alone.

cc
2026-09-10 23:20:38 -06:00
vicrodh 6047a9ee0d fix(artwork): show custom album cover / artist portrait on cards app-wide
A user-set custom cover (add_custom_cover) or artist portrait (add_custom_image)
showed only on the album/artist page, never on the grid cards. The card
builders emitted the source artwork URL and skipped the override map.

Library album and artist cards now prefer the override; Home (all tabs) and
recommendations pick it up at the shared attach_cached choke point — one store
read per pass, skipped entirely when a profile has no overrides — keying albums
by id and artist rails by display name; and Search artist rows prefer the
portrait too. Albums already routed through prefer_album_cover on the album,
artist, playlist and search-album surfaces.

cc
2026-09-10 20:55:08 -06:00
vicrodh c82e624188 release: bump workspace version to 2.1.1
The About modal reads CARGO_PKG_VERSION, so it showed 2.1.0. Bump the workspace
version (and the Cargo.lock members) to 2.1.1 and add the 2.1.1 metainfo release
entry.

cc
2026-09-10 20:33:15 -06:00
vicrodh dbb4d849d3 fix(flake): install the prebuilt release tarball instead of building from source (#744)
The source build failed under Nix at cxx-qt / qt-build-utils with "Could not
find qmltyperegistrar": the Qt host tools live across several outputs and the
sandbox PATH did not carry qtdeclarative's. Rather than chase that, the flake
now repacks the published bare-binary tarball (the same asset AUR-bin / Gentoo
/ Flathub consume) — matching the project's binary-repack packaging doctrine and
dropping the whole Rust/Qt toolchain from the closure.

autoPatchelfHook rewrites the binary against nixpkgs and wrapQtAppsHook wires
the Qt plugin/QML paths; qt6-base/declarative/svg/wayland mirror the qbz-bin
depends. Per-arch tarball hashes for x86_64 and aarch64, computed from the
published v2.1.0 assets. Verified: nix build succeeds and the wrapped binary
launches against nixpkgs Qt 6.10.2. Bump version + hashes post-tag.

cc
2026-09-10 20:33:15 -06:00
vicrodh 9e6992c066 merge: collapsible My QBZ sidebar (tree, per-element hide, header toolbar)
cc
2026-09-10 20:22:38 -06:00
vicrodh ae9f1c2679 docs(release-2.1.1): tag details and changelog
First 2.1 maintenance release: scroll response/perf in heavily populated
sections plus a broad round of bug fixes (#764, #766, #748, #745, #660).

cc
2026-09-10 20:20:26 -06:00
vicrodh d025e92160 chore(about): add Ko-fi supporter Olivier
Cumulative thank-you list update from the maintainer's Ko-fi records; no
GitHub changes this round.

cc
2026-09-10 20:20:26 -06:00
vicrodh e402fa250a feat(myqbz): collapsible My QBZ sidebar with per-element hide and toolbar
Opt-in collapsible My QBZ tree in the sidebar (Settings > Navigation): a
branding-titled parent over Mixtapes and Collections sections, each header a
link to its grid with a chevron that only collapses. Header text and icon on
the left, a Playlists-parity toolbar floating right (search, new, sort A-Z/Z-A,
refresh, collapse) with the chevron aligned to the playlist carets. The tree
feed rides QbzShell (QbzMyQbz is not reliably registered in the shell context)
and is published through publish_sidebar, so it lands reliably at startup.

Per-element visibility reuses the mixtape hidden flag (repo::set_hidden): a
row's right-click hides it from the sidebar, and the detail hero menu toggles
"Hide from sidebar" / "Show in sidebar". Collapse state for the playlist tree
and all three My QBZ sections is persisted. The collapsible tree and the flat
My QBZ entry are mutually exclusive — the classic row is suppressed whenever the
tree is on. Settings gains a Navigation section (Navigation + Search moved out
of Appearance). Detail view also gains a discreet, column-aligned sub-header
over the inline track list. Eight locales updated.

cc
2026-09-10 20:19:48 -06:00
vicrodh 66cd5fb1da merge: mixtape/collection detail fixes and importer reduction (#766)
Song-to-album routing, source-aware "Remove from Mixtape", per-source glyphs,
tracks count, "Add to mixtape" from the playlist header with live update, and
stop importing mixtapes/collections until their ids remap. Validated by owner
smoke.

cc
2026-09-10 16:11:57 -06:00
vicrodh ee66a21457 fix(migration): stop importing mixtapes and collections until ids remap
Mixtape/collection items reference playlist and album ids that change during an
account import, so copying mixtape_collections / mixtape_collection_items
verbatim left garbage rows pointing at ids that no longer exist. Drop them from
both copy paths (fast and remapped) and drop the collection view-state JSON,
with a note on how to re-enable once the importer remaps ids (import elements
first, note the new ids, then import + update the collections). Elements
(playlists, local albums) still import.

cc
2026-09-10 16:11:44 -06:00
vicrodh 0297dfcee9 feat(myqbz): add a playlist to a mixtape from its header, update live
- PlaylistView's header menu gains "Add to mixtape" (source-aware: local vs
  qobuz), matching the cards and the sidebar which already had it.
- Adding an item to a mixtape now re-derives and republishes the OPEN detail
  (reload_if_open), so a just-added playlist appears without reopening. (#766)

cc
2026-09-10 16:11:44 -06:00
vicrodh cc50b01dca fix(myqbz): mixtape/collection detail row corrections (#766)
- A song row opens the album it is on (its resolved, source-aware albumId)
  instead of a blank page; the album id is plumbed from the first resolved track
  through the resolve pass, and an unresolved click is ignored like the artist
  link. (#766 problem 1)
- The row menu says "Remove from Mixtape" on a mixtape, "Remove from collection"
  elsewhere. (#766 problem 2)
- A playlist inside a mixtape hides its quality cell (per-track quality is
  varied); collections keep it.
- The source column shows one glyph per DISTINCT source across the item's
  tracks, so a mixed-source playlist shows them all.
- The tracks column is empty only for a track; an album or playlist shows its
  resolved track count instead of a dash.

cc
2026-09-10 16:11:44 -06:00
vicrodh 95d5d532f3 chore(packaging): jack makedepends and Flathub runtime 6.11
- AUR qbz and qbzd: makedepends jack2 -> jack, so pipewire-jack can satisfy the
  build-time JACK dependency (both provide `jack`; only jack2 provides `jack2`).
- Flathub: bump runtime/SDK from the EOL org.kde.Platform 6.9 to 6.11 (verified
  available in the KDE flatpak-kde-runtime branches). The binary is built
  against Qt 6.8 and loads on 6.11 by forward ABI compatibility. (#755)

cc
2026-09-10 13:24:24 -06:00
vicrodh 435098b981 merge: MusicBrainz 503/transport resilience + scene loading UX
Retry 503s and transient transport hangs behind a shared per-process rate
limiter, cache resolved artists, drop the redundant scene backoff, and add a
scene loading heads-up + 5-minute retry timeout. Client tuning and scene
verified by owner smoke.

cc
2026-09-10 13:24:24 -06:00
vicrodh 89da9bbd13 feat(scene): loading heads-up and a 5-minute retry timeout
The ArtistScene discovery fans out many MusicBrainz requests, so a throttled MB
can keep it loading a while. After ~10s the loading screen shows a "this can
take a few minutes" note; after 5 minutes it swaps the spinner for a Retry (a
late success still swaps in the grid on its own). Both derive from the existing
pulse-driven clock, so no new Timer and the repaint law holds. Two new strings
across all eight locales.

cc
2026-09-10 13:23:53 -06:00
vicrodh 8e8efb00fa feat(mb): cache resolved artists in the core, drop the redundant scene backoff
- musicbrainz_resolve_artist is now cache-first + write-after via
  MusicBrainzCache::get_artist/put_artist (resolved_artists), the same shape as
  the metadata path, so reopening an ArtistPage no longer re-runs a live
  artist?query= search. Negatives are never cached; the existing cleanup(ttl)
  governs expiry.
- Remove the scene's one-shot Retry-After backoff: the client already retries
  503s, so stacking another wait could push the total past ~10s.

cc
2026-09-10 13:23:53 -06:00
vicrodh 857cb16e87 fix(mb): retry MusicBrainz 503s and transport failures behind a shared limiter
- Route every endpoint through a new send_with_retry: it waits on the rate
  limiter, GETs, logs the x-ratelimit budget, and on a 503/429 backs off the
  server's Retry-After (capped 8s) and retries, up to 3 attempts. get_artist_tags
  and get_recording_isrcs, which skipped status handling entirely, now go
  through it too.
- Also retry transient TRANSPORT failures (a hung connection to the request
  timeout, a drop or refusal). MusicBrainz under load hangs instead of returning
  503, which surfaced as "error sending request for url". Capped at 2 attempts
  with a 6s request timeout so a total failure is ~13s, not ~33s, while a hang
  that clears still recovers on the second try.
- Share ONE process-wide direct rate limiter across every client (core, the tag
  editor, remote metadata) so several clients on one public IP pace as one 1.1s
  stream instead of each pacing itself.
- Log MusicBrainz's x-ratelimit-limit/remaining/reset headers (debug on 2xx,
  warn on 429/503) as the only signal of whether the bucket was ours or MB's.

Tests: 503-then-200, a dropped connection, and shared-limiter serialization,
each red-to-green. Dev-only deps (tokio test features + rustls/aws-lc-rs to
install the crypto provider); no runtime dependency added.

cc
2026-09-10 13:23:53 -06:00
vicrodh 4216bdb6cc merge: 2.1.x UI polish, playlist row fixes (#764) and sponsor update
Bundles the header-select homologation, seekbar fluidity, per-platform app-menu
and keyboard shortcuts, per-tab Library filter persistence, the local track-info
routing, the playlist removal and remote-cover-art fixes, and a Ko-fi credit.
All verified by smoke test.

cc
2026-09-10 11:22:36 -06:00
vicrodh 4a52c66385 chore(about): add Ko-fi supporter Miguel
New named one-time Ko-fi supporter. Anonymous entries are not recorded.

cc
2026-09-10 11:22:08 -06:00
vicrodh d9d5cd0771 fix(qt): playlist row removal and remote-source cover art
- Remove from playlist did nothing for a Qobuz row. The membership-id split
  made a row's display id (the catalog id QML sends) differ from its
  playlist_track_id (the membership id), but remove_track still matched the
  open document and called playlist/deleteTracks by the catalog id, so the
  lookup found nothing and the endpoint got a non-membership id. Resolve the
  catalog id to the row's membership id, remove exactly that row, and delete by
  membership; same-catalog duplicates keep their other copy. The local and
  mixed-sidecar arms were already correct. Verified by smoke test. (#764)
- Media-server rows (Jellyfin, Subsonic/Navidrome and Plex) showed no cover in
  the playlist TrackRow while the queue and NowPlayingBar did. The row fed
  cached_path the raw artwork token, which classify cannot resolve, whereas the
  queue namespaces it through portable_artwork_ref. Build the row cover from
  that same ref, and warm uncached covers on the local-playlist load (the Qobuz
  loader already did) so the cover appears without playing the track.

cc
2026-09-10 11:22:08 -06:00
vicrodh 04f6ef44e4 feat(qt): 2.1.x UI polish round — header selects, seekbar, shortcuts, per-tab filters
- Homologate the three Library header selects to the ambient Group style; Sort
  gains an arrow-down-up glyph, a "Sort" placeholder and an explicit Default,
  and every select's border clears when it returns to its default value.
- Seekbar fluidity: a drag scrubs locally and commits a single seek on release;
  the time readout is a floating opaque tooltip reparented to the overlay so the
  content-frame shadow no longer bleeds noise over it.
- Route the NowPlayingBar info button and title to the LOCAL track-info modal
  for a local row, so a local track no longer opens an empty Qobuz modal.
- App menu shows each entry's shortcut (muted, smaller, right-aligned, resolved
  per platform — Cmd on macOS, Ctrl elsewhere) and gains a Quit entry; the
  keyboard-shortcuts modal adds Close Window and Quit under Navigation, moves
  Immersive below Interface, and tightens row heights. i18n for Quit/Close
  Window across all eight locales.
- Persist each Library tab's filter toggles to disk, independently per tab.

cc
2026-09-10 11:21:50 -06:00
vicrodh 35c3d368b9 merge: wedged CPAL stream recovery and POLLERR rate-limit (#660)
cc
2026-09-10 01:35:48 -06:00
vicrodh 9fdf53c3ea fix(audio): recover from a wedged CPAL output stream and rate-limit POLLERR (#660)
cpal 0.17's ALSA worker reports `alsa::poll() returned POLLERR` and polls
again immediately, without snd_pcm_recover: a PCM left in XRUN/SUSPENDED/
DISCONNECTED (CPU starvation at a track change on a Pi, a suspend, a pulled
cable) becomes a tight loop that never plays again until the stream is
dropped. rodio's default callback eprintln!s every one of them, which is the
POLLERR flood in the issue. The System default and PipeWire routes installed
no error callback at all, and nothing rebuilt a wedged stream.

- New qbz-audio::stream_health: classify (Wedged vs Transient), a flood
  limiter (one log line per 5s window with a suppressed count), a wedge
  latch, and one shared error_callback installed on every CPAL route
  (System default x4, PipeWire, ALSA) and the legacy player path.
- The audio thread checks the wedge latch at the TOP of its loop, every
  iteration, not in the recv_timeout Timeout arm: under QConnect the
  renderer-state command flow keeps recv returning Ok(...) and the Timeout
  arm barely runs, which left a wedged worker spinning a core for ~22s.
  On a wedge it drops the stream (joining cpal's worker), and when playing
  rebuilds and resumes at the current position; a second wedge within a 10s
  backoff releases the device and stops instead of looping.

Bit-perfect paths (ALSA Direct, DSD, WASAPI) are untouched; they never use
cpal's worker. The low-memory profile from 2.1.0 already addressed the exit
137 OOM; this is the separate flood/wedge half.

Verified on a Pi 4B + HiFiBerry DAC+ over the System default route with a
192 kHz 835 MB track and SIGSTOP-induced wedges: rebuild+resume in ~40 ms,
auto-recovery after the backoff, release+stop on a repeat wedge, and 7
POLLERR log lines instead of a flood. qbz-audio 125 and qbz-player 139 tests
pass; new stream_health and wedge_recovery tests included.

cc
2026-09-10 01:35:38 -06:00
vicrodh 1ff6df5bac merge: DLNA service-URL tolerance and fatal-signal diagnostics (#745)
cc
2026-09-09 22:48:14 -06:00
vicrodh 2181b379bb merge: restore macOS Exclusive mode row and cascade (#748)
cc
2026-09-09 22:44:16 -06:00
vicrodh 7f10782e79 fix(qbzd): keep exclusive_mode across a backend change on macOS
The TUI cascade cleared `exclusive_mode` on any non-ALSA backend. On macOS
System default honours it through CoreAudio Hog Mode, so mirror the Qt
shell's cascade (#748): the flag survives onto ALSA and, on macOS, System
default; every other backend still resets it. The platform is a parameter so
the macOS arm runs on the Linux gate.

cc
2026-09-09 22:44:16 -06:00
vicrodh e58ec85eb2 fix(qt): restore the Exclusive mode row on macOS (#748)
System default on macOS is the CoreAudio exclusive backend: with
`exclusive_mode` set, qbz-audio takes Hog Mode, pins the device and switches
its nominal rate to the track (PR #391, shipped in 1.2.11 and never removed).
The Tauri settings gated the toggle on `ALSA || (macos && SystemDefault)`;
the Slint port copied only the ALSA half, and fc0d35e29 then hid the row on
macOS on the premise that no backend there could honour it. So 2.0.x showed
a grey row and 2.1.0 none, while the DB flag still engaged Hog Mode.

- SettingsDoc publishes `backendIsCoreAudio` (macOS && System default); the
  row is visible and enabled on it. Linux and Windows are unchanged.
- The backend-switch cascade goes through one predicate
  (`output_labels::backend_honours_exclusive`), so re-selecting Auto or
  System default on macOS no longer clears the flag.
- The output LED reads EXCL on macOS System default + exclusive_mode instead
  of DEFAULT while the device is hogged.
- Node test `scripts/test_qt_exclusive_gate.mjs` evaluates the row's real
  gate expressions across platforms; added to qt-runtime-gate.sh. Rust tests
  cover the predicate, the LED and the serde name QML reads.

Verified by smoke on the Mac mini with a USB DAC: the row appears, Hog Mode
is acquired, and browser audio moves to the built-in speakers while QBZ
plays. qbz-qt suite 782/782 on Linux; 13/13 with cfg(macos) on the Mac.

cc
2026-09-09 22:44:16 -06:00
vicrodh 7c4310d8fb merge: integrate Qt window lifecycle and grid artwork improvements
cx
2026-09-09 21:58:39 -06:00
vicrodh 2fc03d325d fix(qt): restore window lifecycle and improve grid artwork
Restore tray-aware close and quit confirmation, circular label covers, and missing label artist portraits. Publish artwork progressively, preload two grid rows, and skip redundant motion reports while preserving data refreshes.

Include regression tests and isolated artwork benchmarks. Verified Linux build, QML checks, and scrolling smoke tests.

cx
2026-09-09 21:58:25 -06:00
vicrodh 5fab503eb7 feat(media): integrate validated Quick Connect and connection guards
cx
2026-09-09 17:12:46 -06:00
vicrodh 75b8eee1c6 feat(media): add Jellyfin Quick Connect and harden remote connections
Add cancellable Quick Connect pairing and shared connection guards for Jellyfin and Subsonic. Bound connection attempts, validate library access before saving credentials, and report per-provider connection and synchronization status.

cx
2026-09-09 17:12:45 -06:00
vicrodh a097b7bf76 fix(library): integrate validated library visibility and toolbar updates
cx
2026-09-09 17:08:42 -06:00
vicrodh 17e08e93de fix(library): restore offline visibility and unify filters and sorting
Recover missing offline library entries, recognize cached-only libraries, and refresh availability after cache changes. Unify per-tab filters, compact the toolbar, and add reversible sort criteria with complete available purchase metadata.

cx
2026-09-09 17:08:33 -06:00
vicrodh 9504139dec fix(qconnect): integrate validated playback and queue hardening
cx
2026-09-09 13:08:52 -06:00
vicrodh d82602e2c7 fix(qconnect): preserve playback state and queue occurrence identity
Keep queue edits from resetting the playback clock, preserve Play next and Play later batches, and report observed renderer state and owned output telemetry. Guard duplicate-track gapless transitions by queue occurrence.

cx
2026-09-09 13:08:39 -06:00
vicrodh 45b745a6d1 fix(qt): integrate validated natural wheel scrolling
cx
2026-09-08 22:19:32 -06:00
vicrodh 55ddc2c768 fix(qt): make mouse wheel scrolling predictable
Accumulate wheel distance with short easing instead of kinetic acceleration. Preserve rapid and fractional wheel input, immediate direction changes, nested scroll chaining and scroll-memory takeover.

Validated with 38 Qt Quick tests and desktop smoke testing.

cx
2026-09-08 22:19:32 -06:00
vicrodh 49247f2ee7 fix(qt): integrate validated input focus and shortcut fixes
cx
2026-09-08 21:40:28 -06:00
vicrodh 0e76c1f486 fix(qt): preserve navigation shortcuts and release text input focus
Keep search, settings and link shortcuts usable while editing, dismiss focus on outside clicks and navigation, and guard deferred focus against hidden inputs. Add Qt Quick regression coverage.

Refs #753

cx
2026-09-08 21:40:28 -06:00
vicrodh bc6a795980 Merge ALAC format and ALSA buffering fixes into pre-release
cx
2026-09-08 20:54:37 -06:00
vicrodh e0755fe2d6 fix(audio): apply rate-scaled ALSA callback buffering
Apply the period after Rodio resets stream configuration, respect device bounds, and timestamp stream errors.

cx
2026-09-08 20:54:37 -06:00
vicrodh b2ca4d7be6 fix(player): derive ALAC signal format from codec configuration
Keep device setup and streaming sources consistent with the decoded ALAC rate and bit depth. Verify real hi-res files and exact synthetic samples.

cx
2026-09-08 20:54:30 -06:00
vicrodh 5c0d62f108 fix(qt): integrate validated playback and library fixes
cx
2026-09-08 18:28:03 -06:00
vicrodh 0b6b111c74 fix(qt): correct playback commands and library browsing
Handle explicit MPRIS Play/Pause without toggling paused playback, remove the 10,000-favorite cutoff, and sort albums by original release dates. Isolate Library filters by tab, include purchased release dates, and support server-ranked artist popularity with safe pagination.

Validated with 766 Qt tests, QML checks, release-sort regressions, and a release build. Refs #750, #751.

cx
2026-09-08 18:27:51 -06:00
vicrodh 09d640138c fix(library): integrate remote album and SACD artwork fixes
Integrate the combined build containing the remote album ID correction and SACD artwork sidecars. The KEF DLNA fix remains on its separate branch pending reporter feedback.

cx
2026-09-08 15:26:15 -06:00
vicrodh 0ebcab6d3e fix(library): support SACD artwork fallback and image sidecars
Refresh missing artwork for unchanged SACD images when a folder cover is added after scanning. Enable image-specific metadata and cover sidecars in the Qt editor while preserving physical track numbers and never writing the ISO.

Validated with SACD regressions, the real Heathen image, 13 Qt editor tests, QML audits and the combined release build.

cx
2026-09-08 15:26:03 -06:00
vicrodh 357f2373fa fix(library): omit remote albums without a server album ID
Keep orphan Jellyfin and Subsonic tracks indexed without exposing internal grouping keys as server album IDs. Align album cards, artist counts and track navigation, and rebuild derived catalogs with schema 8.

Regression fails on the previous projection (three cards for one real album) and passes with the fix for both providers. Catalog suite: 45 passed, 2 ignored scale benchmarks.

cx
2026-09-08 14:38:36 -06:00
vicrodh 6b0561c5cd fix(library): merge validated remote album artwork fallback
cx
2026-09-08 13:39:51 -06:00
vicrodh ff49cbd2ab fix(library): retain album artwork fallback for remote catalogs
Use collection artwork when Jellyfin or Subsonic tracks have no image, preserving existing track artwork. Rebuild derived catalogs so existing libraries receive the correction.

cx
2026-09-08 13:39:50 -06:00