This commit implements proper sample rate passthrough for high-quality
audio playback, addressing issue #10 where DAC sample rates were locked
at 44.1kHz regardless of file quality.
Core Changes:
- Modified Player to accept and store AudioSettings (exclusive mode, DAC passthrough)
- Updated AudioCommand::Play to include sample_rate and channels metadata
- Created create_output_stream_with_config() to build custom StreamConfig
- Added sample rate tracking to detect changes between tracks
- Modified Play handler to recreate OutputStream when sample rate changes
- Updated play_data() to extract audio metadata before playback
- Modified lib.rs to read AudioSettings on startup and pass to Player
Device Detection Improvements (Issue #4):
- Added display_name and device_type fields to AudioDevice struct
- Implemented get_pipewire_device_descriptions() to extract friendly names
- Updated get_audio_devices() to map technical names to user-friendly names
- Added device type detection (USB, HDMI, PCI, Bluetooth)
Technical Details:
- Audio files are decoded twice: once for metadata, once for playback
- Stream is recreated only when sample rate or channel count changes
- Falls back to default device config if custom config fails
- Supports both PipeWire and PulseAudio device naming via pactl
- Logs sample rate transitions and OutputStream configuration
Files Modified:
- src-tauri/src/player/mod.rs: Core playback engine changes
- src-tauri/src/lib.rs: Initialize Player with AudioSettings
- src-tauri/src/commands/playback.rs: Device enumeration improvements
Tested: Compiles successfully on Linux with Rust 1.92
Immediate and Accumulated scrobbling cannot be enabled at the same
time, but both can be disabled. When one is turned on, the other
is automatically turned off.
Show favorite and download indicators for unavailable Qobuz tracks
to maintain column alignment. The elements are already non-interactive
due to pointer-events: none on the wrapper.
- Remove wifi-off icon from unavailable tracks in playlist detail view,
keeping only the disabled styling for a cleaner look
- Rename "Available Offline" filter to "Fully Available Offline" to
clarify it shows only playlists where all tracks are available
- Update filter logic to only show all_local playlists in the fully
available filter, not partially available ones
- Fix visible filter in offline mode to respect showPartialPlaylists
setting by using isPlaylistAvailableOffline function
The hasLocalContent field was never being calculated - it was just
read from settings (always undefined). Now calculate it dynamically
from actual data:
- localTrackCounts.get(playlistId) - number of local tracks
- playlist.tracks_count - number of Qobuz tracks
Status calculation:
- 'no': localCount === 0 (not available offline)
- 'all_local': localCount > 0 && qobuzCount === 0 (fully available)
- 'some_local': localCount > 0 && qobuzCount > 0 (partially available)
This fixes Show partial playlists toggle and Partially available
filter in playlist manager.
L1 (Memory): 300MB for ~3-4 Hi-Res tracks, instant access
L2 (Disk): 500MB playback cache at ~/.cache/qbz/playback/
Flow:
- When track evicted from memory, saved to disk cache
- When loading: check memory → disk → download cache → network
- Tracks promoted back to memory when accessed from disk
This reduces re-downloads when navigating back to recently played
tracks in mixed playlists.
- Stop playback immediately when starting a Qobuz track to prevent
previous track from continuing during download
- Show buffering toast while downloading Qobuz audio
- Skip buffering UI for local tracks since they load instantly
- Add is_local field to QueueTrack for prefetch optimization
- Update prefetch to skip local tracks (no network needed)
- Update all queue track builders to include is_local flag
Remove reactive effect that was causing infinite re-renders due to
inline callback function recreation. Replace with imperative calls
to notifyParentOfCounts() after data loading completes.
The effect was reading onPlaylistCountUpdate which got recreated
on every parent re-render, triggering the effect again in a loop.
Wire onPlaylistCountUpdate from PlaylistDetailView to Sidebar's
updatePlaylistCounts method in +page.svelte. This ensures the
sidebar displays accurate track counts from the database instead
of calculated values that could drift out of sync.
Calculate totalCount as max of (qobuz+local count) or (highest local
position + 1) to ensure all local tracks are included regardless of
their position value
- Add PlaylistLocalTrack struct with playlist_position field
- Add playlist_get_local_tracks_with_position command
- Update PlaylistDetailView to merge tracks by position instead of
appending local tracks at the end
- Update PlaylistModal to calculate correct position when adding local
tracks (total count = qobuz + existing local)
- Local tracks now appear in the order they were added, interleaved
with Qobuz tracks
- Use portal pattern to render menu in body (escapes stacking context)
- Increase z-index to 99999/100000 for menu/submenu
- Update click outside handler to work with portal
- Menu now properly appears above all track rows
- Update handlePlayAll to include both Qobuz and local tracks
- Update handlePlayAllNext and handlePlayAllLater similarly
- Add onSetLocalQueue prop to mark local tracks in queue store
- Connect prop to handleSetLocalQueue in +page.svelte
- Add 60-second timeout to login initialization in LoginView
- Show retry/offline options when login times out
- Move loadFavorites() to handleLoginSuccess to prevent API calls
before authentication is complete
- Prevents errors when auto-login is slow or stuck
- Update onPlaylistUpdated callback to also refresh local track counts
- Change all Song/Songs references to Track/Tracks in Sidebar tooltips
- Ensure tooltip cache is properly invalidated when tracks are modified
- Add playlist_get_all_local_track_counts command to get local track
counts for all playlists efficiently
- PlaylistDetailView: show combined track count and duration in header,
style local count with muted color, remove redundant count below
- Sidebar: load and display local track counts in tooltips
- PlaylistModal: show combined counts when selecting playlist to add to
- PlaylistManagerView: show combined counts in both grid and list views
- TrackRow: move local indicator to download column position, add
placeholder for favorite column to maintain alignment, update tooltip
- Remove local tracks notice banner (info now in tooltip)
cc
- Move local track indicator from quality column to favorite button position
for consistent row alignment with Qobuz tracks
- Remove explicit delete button from playlist track rows (was easy to
accidentally click)
- Add "Remove from playlist" option to TrackMenu for all tracks (local and
Qobuz)
- Qobuz track removal uses playlist_track_id from API response
- Clean up unused CSS and imports from PlaylistDetailView
cc
- PlaylistModal now uses playlist_add_local_track command for local tracks
instead of the Qobuz-only add_tracks_to_playlist command
- Added isLocalTracks prop to PlaylistModal and wired it through uiStore
- Updated LocalLibraryView to pass isLocal=true when adding tracks to playlists
- Added HardDrive icon indicator next to quality badge for local tracks in TrackRow
cc
- clear_all_tracks now only deletes local library tracks
- Qobuz downloads (source = 'qobuz_download') are preserved
- Local library management is now completely separate from Qobuz downloads
- Prevent double execution with clearingLibrary flag
- Stop event propagation to prevent multiple triggers
- Convert to non-async function with explicit promise chain
- Disable button during operation
- Show "Clearing..." state while in progress
- Increase width to 720px
- Reduce folder name font size to 13px
- Fix button labels (use actions.cancel/save instead of common)
- Add 'saving' i18n key (en/es)
- Wrap long hint texts in <small> tags
- Make modal larger (560px width, more padding)
- Add specific warnings when user override differs from detection:
- Warning when marked as network but not detected
- Danger when marked as local but detected as network
- Detect network status when modal opens for comparison
- Add i18n strings for override warnings (en/es)
- Fix offline settings database migrations to run individually
- Add network detection refresh when loading folder list
- Add network detection during folder scan
- Show folder alias with path tooltip in folder list
- Add folder path change capability in FolderSettingsModal
- Add network content visibility toggle in offline settings
- Add i18n strings for new features (en/es)
- Disable import playlists button when offline (shows disabled state)
- Add Cast, immediate scrobbling, and accumulated scrobbling toggles
- These settings only appear when manual offline mode is enabled
- Add time limit note for accumulated scrobbling (Last.fm 2 week limit)
- Persist new settings in SQLite with proper migrations
- Add i18n strings for all new settings (en/es)
- Add batch check command for track local status in Rust
- Show unavailable tracks with grayed-out visual state in PlaylistDetailView
- Disable interactions for unavailable tracks (click, menu, play)
- Add WifiOff indicator for unavailable tracks
- Update QueuePanel to show unavailable track styling
- Implement auto-skip for unavailable tracks during playback
- Add offline mode sync to queue store
- Add offline-specific filter states to PlaylistManager:
- Available Offline
- Partially Available
- Not Available Offline (view-only)
- Disable edit/drag for unavailable playlists in PlaylistManager
- Add i18n strings for offline states (en/es)
Add offline mode filtering to sidebar playlist list to match behavior
in PlaylistManagerView. Playlists without local content are hidden
when in offline mode, respecting the showPartialPlaylists setting.
The section refs were not reactive, so the derived array captured undefined
values at definition time. Changed to resolve refs at call time using a
getSectionEl() function instead of capturing them in a derived array.
The login state check was causing race conditions on app startup because
offline status was being checked before auto_login completed. Since the
frontend already handles showing LoginView when not logged in, the
NotLoggedIn check in offline detection was redundant and problematic.
Now offline detection only checks:
1. Manual offline mode (from settings)
2. Network connectivity (via HTTP HEAD to qobuz.com)
Refresh offline status after successful login to prevent false offline
detection. Previously, the offline status was checked during bootstrap
before auto_login completed, causing 'NotLoggedIn' reason even though
the user would be logged in moments later.
- Add navigation bar below Account section with links to all sections
- Navigation becomes fixed at top when scrolling (sticky position)
- Active section highlighted with accent underline
- Hover state shows lighter underline for contrast
- Scroll tracking updates active section automatically
- Small text labels to fit all sections horizontally
- Change OfflinePlaceholder icon to use offline.svg instead of Power icon
- Add flex-shrink protection to Toggle component to prevent collapsing
- Add network verification when disabling offline mode:
- Check network connectivity before switching to online
- Show semi-transparent overlay during check
- Revert to offline and show toast if no internet available
- Add check_network Tauri command to verify connectivity
- Add i18n strings for noNetworkToast and checkingNetwork (en/es)
Toast notifications:
- "Offline mode activated" when going offline
- "Back online" when connectivity restored
Accessibility (ARIA):
- role="status" and aria-label on offline indicator in NowPlayingBar
- role="alert" and aria-live="polite" on OfflinePlaceholder
- role="alert" on PlaylistImportModal offline warning
- aria-label on DownloadButton
- aria-hidden="true" on decorative icons
Research findings:
- Last.fm API supports batch scrobbling (up to 50 tracks)
- Timestamps can be backdated up to 14 days
Implementation:
- Add scrobble_queue table to offline database
- Add queue_scrobble, get_queued_scrobbles, mark_scrobbles_sent commands
- Queue scrobbles when offline instead of skipping
- Flush queue automatically when transitioning to online
- Skip scrobbles older than 14 days (Last.fm limit)
- Cleanup sent scrobbles after 7 days
- Add offline indicator icon in right section when offline
- Disable lyrics button with tooltip when offline
- Skip Last.fm scrobbling when in offline mode
- Use offline-small.svg for compact indicator
- DownloadButton: show CloudOff icon and disable when offline
- LyricsStore: skip fetching and show "unavailable offline" message
- LocalLibraryView: skip artist image fetching from Qobuz/Discogs
- PlaylistImportModal: disable import with warning when offline
- Add "Start in offline mode" link below login form
- Enable offline mode without authentication
- Navigate directly to local library when starting offline
- Add i18n strings for offline start link (en/es)