Commit Graph
3026 Commits
Author SHA1 Message Date
vicrodh c2e9a4f0ba fix: replace broken screen resolution clamping with sane fallback
xdpyinfo returns combined multi-monitor resolution (e.g. 6000x1600 for
dual monitors), causing false positives like clamping 1926x1590 to
5700x1520. The 95% multiplier made things worse — the fallback size was
larger than any single monitor.

Replace with simple corruption guard: only clamp values above 8K
(obviously corrupt DB entries), fallback to 1920x1080. The window
manager already handles fitting windows to the actual display.

cc
2026-03-19 08:44:29 -06:00
vicrodh 2439b5f4d8 fix: remove KDE KWin SSD hack entirely (#170)
The KWin window rule approach (kwinrulesrc + qdbus reconfigure) was
never actually active because GDK_BACKEND is unset on most KDE Wayland
sessions. In v1.1.18 this meant decorations(use_system_titlebar) was
used directly — GTK CSD appeared (ugly but functional, no CPU issues).

The hack itself, when triggered, caused double titlebar and a CPU busy
loop that blocked networking. Remove all KDE-specific detection and
KWin rule setup. Window now simply uses decorations(use_system_titlebar)
on all platforms, matching the effective behavior of v1.1.18.

The one-time cleanup of stale kwinrulesrc entries is preserved so users
who had the rule from v1.1.14-v1.1.19 get it cleaned up automatically.

cc
2026-03-19 08:29:49 -06:00
vicrodh 6722e6f59a fix: add offline mode button to network error screen (#173)
When BundleExtractionFailed (no network), the error box only showed
"Retry" with no way to enter offline mode. The timeout case and login
form both had the offline button, but the error state was missing it.

Added "Start Offline" button using existing offline-btn CSS and
i18n keys. Also replaced hardcoded strings with $t() calls.

cc
2026-03-19 03:32:29 -06:00
vicrodh 8a8c709c1b feat: lock volume at 100% when ALSA Direct hw: is active
With ALSA Direct hw: there is no software mixer — volume must be
controlled at the DAC/hardware level. Software volume attenuation
would reduce bit depth and defeat the purpose of bit-perfect playback.

Backend: v2_set_volume forces volume to 1.0 when backend=Alsa+plugin=Hw
Frontend: volume slider disabled (grayed out at 100%), mute/step buttons
hidden, handleVolumeChange and handleToggleMute return early.
Settings callbacks notify +page.svelte when backend/plugin changes to
update the lock state in real-time.

i18n: volumeLockedHw tooltip added to all 5 locales.

cc
2026-03-19 00:10:59 -06:00
vicrodh 9bcafe26fb fix: alsa_hardware_volume was hardcoded false + v2_reset_audio_settings sync
Two additional gaps found during audio settings sync audit:

1. convert_to_qbz_audio_settings() hardcoded alsa_hardware_volume to
   false instead of reading settings.alsa_hardware_volume. This meant
   the player never received the user's ALSA hardware volume preference.

2. v2_reset_audio_settings saved defaults to DB but never synced them
   to the CoreBridge player, leaving stale settings in memory.

cc
2026-03-18 22:20:04 -06:00
vicrodh e490010e58 fix: sync audio settings to CoreBridge player on change and session activation
Two bugs caused the exclusive mode to not work when QConnect was active:

1. Critical audio setters (backend_type, exclusive_mode, dac_passthrough,
   output_device, alsa_plugin, pw_force_bitperfect, sample_rate,
   alsa_hardware_volume) saved to the per-user store but never called
   reload_settings() on the CoreBridge player. The Player kept using
   stale settings (often defaults with backend_type=None), falling back
   to CPAL/PipeWire instead of ALSA Direct.

2. After login, per-user audio settings were loaded into AudioSettingsState
   but never pushed into the CoreBridge player, which was created at
   startup with flat-path defaults.

Fix: Add sync_audio_settings_to_player() helper and call it from all
critical audio setters. Also sync settings in activate_session() and
activate_offline_session() right after audio_settings.init_at().

cc
2026-03-18 22:03:23 -06:00
vicrodh bf91822b4d feat: add QConnect dev toggle and device name settings
Developer Mode: toggle to show/hide QConnect dev panel button in
the player bar (hidden by default, persisted in localStorage).

Integrations: editable device name input for Qobuz Connect with
default "Qbz - {hostname}". Backend commands v2_qconnect_get/set
_device_name and v2_get_hostname. Custom name is used during the
WS bootstrap handshake.

cc
2026-03-18 21:31:11 -06:00
vicrodh 2953b86062 feat: add QconnectBadge as full-height badge in song card
Place QConnect badge as direct child of badges-group with 3px gap
matching DAC/EXC spacing. Two-row vertical layout: icon on top,
Qobuz/Connect text below. Wire props from +page.svelte to both
NowPlayingBar instances. Add qconnect i18n keys to de/fr/pt locales.

cc
2026-03-18 21:03:56 -06:00
vicrodh d4fa6f4210 feat(qconnect): add debug-level diagnostics for shuffle order tracking
Logs QueueUpdated shuffle_order validity and resolve_core_shuffle_order
results at debug level for verbose troubleshooting.

cc
2026-03-16 19:16:10 -06:00
vicrodh 8330dd08ed Revert "Reapply "fix(qconnect): pass server shuffle order through to CoreBridge""
This reverts commit 2bb72455d1.
2026-03-16 11:05:12 -06:00
vicrodh 2bb72455d1 Reapply "fix(qconnect): pass server shuffle order through to CoreBridge"
This reverts commit d9f112390f.
2026-03-16 11:01:53 -06:00
vicrodh d9f112390f Revert "fix(qconnect): pass server shuffle order through to CoreBridge"
This reverts commit 065cf734d2.
2026-03-16 10:54:02 -06:00
vicrodh 065cf734d2 fix(qconnect): pass server shuffle order through to CoreBridge
resolve_core_shuffle_order was reordering the server's shuffle_order
to put the current track first. This destroyed the server's concept
of "already played" vs "upcoming" — CoreBridge showed all tracks as
upcoming while the web player correctly split them.

Now the server's raw shuffle_order is passed through unchanged.
CoreBridge's set_queue_with_order finds shuffle_position from
current_index, preserving the played/upcoming split.

cc
2026-03-16 10:52:41 -06:00
vicrodh b4ebad20c5 Revert "fix(qconnect): suppress local playback automation when connected"
This reverts commit b5ab4cd148.
2026-03-15 23:23:57 -06:00
vicrodh 9c14a76975 fix: make mupdf optional to unblock build on Arch Linux
mupdf-sys 0.5.0 bindings are incompatible with the current system
MuPDF library (struct size assertions overflow). Gate mupdf behind
a booklet feature flag (disabled by default). When disabled, booklet
commands return an error instead of crashing the build.

cc
2026-03-15 13:48:35 -06:00
vicrodh a3cde0449d feat: wire autoplay mode sync to QConnect
- setAutoplayMode now sends autoplay preference to QConnect server
- queue_load_tracks syncs local autoplay mode after loading
- QConnect panel shows autoplay_mode status
2026-03-15 10:32:59 -06:00
vicrodh 87be5fbf16 feat: add set_autoplay_mode and autoplay_load_tracks remote commands
Backend _if_remote methods for QConnect autoplay protocol:
- set_autoplay_mode_if_remote: toggles autoplay on the QConnect server
- autoplay_load_tracks_if_remote: loads track IDs into the autoplay pool
Both follow the established _if_remote pattern with diagnostics.
2026-03-15 09:46:01 -06:00
vicrodh 8e2bb021c2 fix: guard re-bootstrap with has_disconnected flag
Prevents double-bootstrap on initial connect. The Subscribed
handler now only calls bootstrap_remote_presence when the
connection was previously lost (has_disconnected=true), not
on the first connect where connect() already bootstraps.
Also sets has_disconnected=true in the Disconnected handler.
2026-03-15 09:21:41 -06:00
vicrodh 8e87b414db feat(qconnect): route volume/mute to peer renderer when remote is active
New _if_remote backend commands for set_volume and mute_volume.
handleVolumeChange and handleToggleMute in both main view and miniplayer
now check for peer renderer before setting volume locally.  Media
control set_volume also routed through the guard.  When no peer is
active, volume is set locally and reported to QConnect server.
2026-03-15 09:14:07 -06:00
vicrodh 1fc2e79391 feat(qconnect): add stop_if_remote guard for media control stop action
When a peer renderer is active, the MPRIS/media-key stop command now
sends SetPlayerState(STOPPED) to the QConnect server instead of stopping
local playback.  Falls back to local stop on error or when no peer is
active.
2026-03-15 07:27:32 -06:00
vicrodh e5155f2baa refactor: homologate seek to preview+commit in ImmersivePlayer and Miniplayer
Replace immediate seek-on-drag with the NowPlayingBar pattern:
preview the position visually during drag, commit the seek only on
mouseup.  Both PlayerControlsCompact and MiniPlayerFooter now use
dragPreviewTime/effectiveTime, matching NowPlayingBar behavior.
2026-03-14 23:22:09 -06:00
vicrodh 6bb416f854 refactor: centralize mute in ImmersivePlayer and Miniplayer via playerStore.toggleMute
Replace local isMuted/previousVolume state in PlayerControlsCompact and
MiniPlayerFooter with the global toggleMute from playerStore.  Muted
state is now derived from volume === 0, matching NowPlayingBar behavior.
Pre-mute volume is persisted in localStorage by the store.
2026-03-14 22:53:43 -06:00
vicrodh d21f2253bc feat(qconnect): add QConnect guards to shuffle, repeat, queue play, and history play handlers
When a peer renderer is active, shuffle/repeat/queue-play/history-play
commands are now routed to the QConnect server instead of being applied
locally.  Two new backend commands (toggle_shuffle_if_remote,
cycle_repeat_if_remote) follow the existing _if_remote pattern.
Guards added to both +page.svelte (main + immersive) and miniplayer.
2026-03-14 22:44:31 -06:00
vicrodh b5ab4cd148 fix(qconnect): suppress local playback automation when connected
When QBZ is the local renderer in a QConnect session and the web player
presses next, the server sends SET_STATE with the new track. The backend
correctly starts playback, but the frontend's gapless transition handler
saw the track_id change, treated it as a local gapless event, and called
nextTrack() — which advanced the CoreBridge queue every 1s polling cycle,
flooding the queue and destroying the shuffle order.

Root cause: shouldQconnectSuppressLocalPlaybackAutomation only suppressed
when a peer renderer was active (activeRendererId !== localRendererId).
When QBZ IS the renderer, remoteControlMode stayed false, so all local
automation (gapless, auto-advance, resume-from-stop) remained active and
fought the server.

Fix: suppress local playback automation whenever QConnect is connected,
regardless of which renderer is active. The server is the authority for
track transitions in all QConnect scenarios.

cc
2026-03-14 22:09:50 -06:00
vicrodh 3b3dbc7ce1 fix(qconnect): trigger resync on reorder and remove server events
SrvrCtrlQueueTracksReordered and SrvrCtrlQueueTracksRemoved were not
triggering AskForQueueState, so the local queue never reflected
reorder/remove actions performed via QConnect. Same pattern as the
existing shuffle resync.

cc
2026-03-14 21:34:03 -06:00
Victor RH ee1459a0f1 Update funding information in FUNDING.yml 2026-03-14 21:07:43 -06:00
vicrodh 66b5288150 fix(qconnect): use authoritative queue mutations
cx
2026-03-14 19:29:11 -06:00
vicrodh 311b7269ee fix(qconnect): keep gapless enabled for local renderer
cx
2026-03-14 17:57:46 -06:00
vicrodh 52e3653dc3 fix(qconnect): complete repeat pending on loop ack
cx
2026-03-14 13:25:22 -06:00
vicrodh 8a468ed725 fix(qconnect): restore local repeat renderer flow
cx
2026-03-14 13:09:23 -06:00
vicrodh f47f691063 fix(qconnect): allow rapid repeat toggles
cx
2026-03-14 12:07:11 -06:00
vicrodh e6a20b02e8 fix(qconnect): align repeat loop mode mapping
cx
2026-03-14 11:43:31 -06:00
vicrodh 0529f355e8 fix(qconnect): reanchor repeat state before toggles
cx
2026-03-14 07:55:42 -06:00
vicrodh 7a11b6548c fix(qconnect): anchor remote shuffle projection
cx
2026-03-14 07:32:46 -06:00
vicrodh 8b950da5c9 fix(qconnect): honor remote shuffle order for next
cx
2026-03-14 00:59:51 -06:00
vicrodh f693d1c61a fix(qconnect): wait for authoritative repeat mode
cx
2026-03-14 00:12:47 -06:00
vicrodh 6805b4f61a fix(qconnect): reapply authoritative queue snapshots
cx
2026-03-13 23:22:25 -06:00
vicrodh a59daf43dc fix(qconnect): resync queue after shuffle mode changes
cx
2026-03-13 23:13:16 -06:00
vicrodh cf2447f4b2 fix(qconnect): stop deriving remote shuffle locally
cx
2026-03-13 23:07:22 -06:00
vicrodh af7652c86b fix(qconnect): wait for authoritative shuffle queue
cx
2026-03-13 22:54:27 -06:00
vicrodh 19b4182dd6 fix(qconnect): render connect queue in remote shuffle order
cx
2026-03-13 22:45:56 -06:00
vicrodh 4312bf0524 fix(qconnect): refresh queue store from backend events
cx
2026-03-13 20:51:44 -06:00
vicrodh 1fc7a0a1a3 fix(qconnect): materialize remote shuffle atomically
cx
2026-03-13 20:43:56 -06:00
vicrodh b28fd39737 fix(qconnect): trust remote shuffle order
cx
2026-03-13 20:35:56 -06:00
vicrodh 09c6d8f1f8 fix(qconnect): route shuffle and repeat through runtime
cx
2026-03-13 20:28:11 -06:00
vicrodh 2efa1b0809 fix(qconnect): route clear queue through runtime
cx
2026-03-13 20:00:57 -06:00
vicrodh f72a4db7be chore(qconnect): checkpoint stable handoff state
cx
2026-03-13 19:52:12 -06:00
vicrodh d3d0fe491a fix(qconnect): stream local handoff playback
cx
2026-03-13 18:52:30 -06:00
vicrodh f18bd10aa4 fix(qconnect): complete active-renderer pending on session ack
cx
2026-03-13 18:50:04 -06:00
vicrodh 0a9064aa24 fix(qconnect): keep local renderer queue ids in interval reports
cx
2026-03-13 17:38:52 -06:00