Two related bugs surfacing after the AlbumCardLite migration in
Search > Albums:
1. `albumGridCols` over-computed the column count because the
constant `ALBUM_CARD_WIDTH = 210` was stale — AlbumCardLite is
actually 220px wide post-migration. The math thought N+1 cards
fit per row when only N did, the last card per row wrap-around
to a visual second line inside the same virtual-scroll-item,
and visually piled on top of the next virtual row's cards.
Bumped the constant to 220.
2. `AlbumQuickMenu` (the kebab popover) used `position: fixed` but
was rendered inline inside the card, which lives inside the
virtual scroller's `transform: translateY(...)` wrapper. Per the
CSS spec, `position: fixed` resolves relative to the nearest
ancestor with a transform, not the viewport — so the menu
opened way off where the user clicked. Added a small `portal`
action that appends the menu to `document.body` on mount,
keeping it in viewport coordinates regardless of where the
trigger lives in the tree.
Bonus: reverted the speculative `contain: paint` on `cover-wrap`
from 5045096e — that was attacking the wrong symptom (the user
reported the issue was rooted in #1 above, not in cover-image
clipping). `contain: paint` would add a per-card layer cost under
SW compositing without buying anything now that the real cause is
fixed.
cc
Third pass at the SearchView > Albums overlap bug. `overflow: hidden`
+ `position: absolute; inset: 0` on the img weren't enough to keep
some artwork inside the 220x220 box — the `cachedSrc` action applies
`transform: translateZ(0)` to the img under HW acceleration (the
WebKit 2.50+ texture-eviction workaround) and the composited layer
that creates can escape the parent's clip rect in certain layouts.
`contain: paint` on the parent forces it to be a paint containment
boundary at the rendering-layer level — anything painted by
descendants, composited or not, gets clipped to this box.
cc
Two cleanups in one:
1. Cover img positioning. User reported some portrait-aspect album
artwork in Search > Albums was visually escaping cover-wrap's
`overflow: hidden` and bleeding upward into the row above. The
img was `width: 100%; height: 100%; object-fit: cover` but in
normal flow, while `cachedSrc` applies `transform: translateZ(0)`
to it under HW acceleration (the WebKit 2.50+ texture-eviction
workaround). Combined, the transform was lifting the img into
its own composited layer in a way that escaped the parent's
clip box for some configurations.
Fix: `.cover` (and `.cover-placeholder`) are now
`position: absolute; inset: 0`. Same containment pattern
AlbumCardLibraryLite already uses; strictly bounds the painted
image to the 220x220 cover-wrap box regardless of any transform
the image carries.
2. HomeView.svelte and ForYouTab.svelte are deleted. They were
legacy /home renderings that DiscoveryView (Discovery V2)
replaced — `+page.svelte` only mounts DiscoveryView under
`activeView === 'home'`, and the only remaining `HomeView` and
`ForYouTab` references were the two files referencing each
other. The legacy `AlbumCard.svelte` (used only by those two)
goes with them. `AlbumMenu.svelte` stays for now — `AlbumDetailView`
and `PlaylistDetailView` still use it for page-header menus.
cc
User-reported visual bug after the AlbumCardLite migration: some
album covers in Search > Albums appeared to overlap into the row
above. The `.albums-grid-row` flex container used the default
`align-items: stretch`, which stretched each wrapper to the tallest
card in the row. With AlbumCardLite's optional Hi-Res pill the
rows had heterogeneous heights, and stretched wrappers let the
absolutely-positioned cover from neighbouring cards visually
encroach on previous rows.
Two clamps:
- `align-items: flex-start` on `.albums-grid-row` — every card's
cover top-aligns to the row baseline.
- `width: 220px` on `.album-card-wrapper` (replaces the old
`min-width: 160px`) — matches AlbumCardLite's intrinsic width
exactly, no flex stretch room left.
cc
Profile C path (purchased albums grid). Reused
`AlbumCardLibraryLite` rather than the full AlbumCardLite because
Purchases never needs favorites, the genre overlay, the menu, or
the artist link — it's a read-only grid of bought albums that
either click through (downloadable) or render as unavailable.
The legacy passed a formatted purchase date through the
`releaseDate` slot. AlbumCardLibraryLite doesn't surface a date
field; the purchase date is recoverable from the album detail
page, so the surface loses one secondary cue but stays
functional.
The remaining legacy `AlbumCard.svelte` callers are now only
`HomeView.svelte` and `ForYouTab.svelte`, both Discovery V2
replacement candidates that are slated for deletion once parity
is signed off.
cc
FavoritesView (3 inline grid callsites, one per Discography / EPs &
Singles / Live Albums section per the in-favorites artist-detail
layout) and VirtualizedFavoritesAlbumGrid (one callsite inside the
virtualizer's grid-row branch) both swap to AlbumCardLite. Same
`makeArtistClickHandler` pattern as the other Profile B views.
Same prop drops + renames as before.
cc
Three more Profile B views swap to Discovery V2's AlbumCardLite:
- AwardView: single discography grid; `makeArtistClickHandler`
pattern for the per-album artist link.
- AlbumDetailView: the Related Albums section renders cards for
other albums by the same artist. `onArtistClick` closes over
the page's main `album.artistId` (all related albums share
it). All the relatedAlbum-prefixed handlers route through the
Lite props with the same per-album closures.
- ArtistsByLocationView: three identical-shape grids (Discography
/ EPs & Singles / Live Albums) — slim invocation, no menu
actions, just `onClick` + `onPlay`.
Same prop drops + renames as the earlier migrations.
cc
LabelView (2 callsites: New Releases + Critics' Picks horizontal
rows) and LabelReleasesView (2 callsites: grouped + flat grids)
swap to Discovery V2's AlbumCardLite. Same `makeArtistClickHandler`
pattern as SearchView so the per-album artist id closes correctly
into the zero-arg `onArtistClick`.
Critics' Picks block in LabelView didn't pass the download/
isAlbumFullyDownloaded set originally — kept that gap (it's a
read-only editorial section, no offline-cache UX expected).
Same prop drops as the other Profile B migrations: `size`,
`releaseDate` → parsed `releaseYear`, `onOpenContainingFolder`,
`downloadStateVersion`. Renames: `onAddAlbumToPlaylist` →
`onAddToPlaylist`, `onclick` → `onClick`.
cc
Two callsites in SearchView (Albums tab + Best Match) swap to
Discovery V2's `AlbumCardLite`. Profile B differs from Artist
Detail in that albums DO have a clickable artist label — the Lite
component's `onArtistClick: () => void` takes no args, so a small
`makeArtistClickHandler(artistId)` factory closes over the album's
artist id at iteration time and produces the right zero-arg
handler (or `undefined` when the album lacks an artist id).
Same prop drops as ArtistDetailView: `size`, `searchId`,
`releaseDate` (replaced by parsed `releaseYear`),
`onOpenContainingFolder` (never rendered by legacy menu anyway),
`downloadStateVersion` (Svelte reactivity replaces it). Renames:
`onAddAlbumToPlaylist` → `onAddToPlaylist`, `onclick` → `onClick`.
cc
Six callsites in ArtistDetailView (one per release-type section)
swap from legacy `../AlbumCard.svelte` to
`$lib/discovery-v2/AlbumCardLite.svelte`. AlbumCardLite gained the
`isAlbumFullyDownloaded` flag + `onReDownloadAlbum` callback this
session so the chunked path keeps the offline-cache UX legacy
provided.
Props dropped during migration (legacy artefacts AlbumCardLite
doesn't model and the legacy view didn't really need either):
- `size="large"` — Lite is fixed 220x220, matches the legacy
"large" size already.
- `searchId` — data attribute used by search-result navigation;
not applicable to discography views.
- `releaseDate` — Lite shows `releaseYear` (number) instead of a
formatted date string. Year flows through the artist subtitle
slot the same way the legacy view did (`album.year || ''`),
so the visible info is unchanged.
- `onOpenContainingFolder` — the legacy AlbumMenu declared but
never rendered an item for it; Lite mirrors that.
- `downloadStateVersion` — Lite re-evaluates props natively
through Svelte reactivity; the manual version bump isn't needed.
Renames: `onAddAlbumToPlaylist` → `onAddToPlaylist`,
`onclick` → `onClick` (Svelte 5 convention used across Discovery V2).
cc
Two bugs from the same session:
- The plex_aggregated CTE prefixed `group_key` with `'plex:'`, but
`plex/mod.rs::plex_album_key()` already returns `"plex:<hash>"`.
Result: album.id was `"plex:plex:<hash>"` from the chunked path,
which `handleAlbumClick` couldn't resolve, so opening an album
showed NO TRACKS. Fixed: use `COALESCE(album_key, 'plex:' ||
rating_key)` so populated rows pass through untouched and only
the rating_key fallback gets the prefix added. GROUP BY mirrors
the same expression for consistency.
- On AlbumCardLibraryLite the scrim (`.cover-wrap::after`) and the
overlay container (`.overlay`) were both at `z-index: 2`. Pseudo-
elements paint after all DOM children at the same z-index, so
the scrim ended up ON TOP of the buttons, hiding them on hover.
Re-laid the layering so it's monotonic top-to-bottom:
1 cover img
2 scrim
3 overlay (action buttons)
4 select-checkbox + source-badge-slot
Plus: restored the dark `rgba(0,0,0,0.85)` hover scrim itself,
removed the `::after` accent-border ring + title-colour cue. Per the
2026-05-12 user call ("Hasta quisiera el overlay de regreso") — the
Plex thumbnail downscale (9f417999) made the scrim's opacity
transition cheap again since the underlying paint is now 220x220
not 1000x1000. Buttons go back to opacity 0 → 1 on hover with a
single transition on `.action-buttons`. White-outline circles
(transparent fill) since the scrim provides contrast.
cc
Plex artwork URLs were going directly to `/library/metadata/<id>/thumb/<ts>`
which serves the **full resolution** image — typically 1000x1000 or
larger for album covers. The browser then had to decode the full JPEG
and downscale to the displayed 220x220, blowing through both decode
budget (full-res JPEG decode per visible card) and memory budget
(~4MB raw raster per card × N visible = hundreds of MB of image cache).
For a Plex-dominant library (the user's case), this was a hidden
cost factor on every thumbnail grid surface.
Fix: `buildPlexArtworkUrl` now takes an optional `size` parameter.
When provided, the path is wrapped in `/photo/:/transcode` so the
Plex server downscales server-side and the browser receives ~30KB
JPEGs at the right size instead of 1MB+ originals. When `size` is
omitted, the original full-res URL is returned — preserved for
`getFullArtworkUrl` (AlbumDetailView's big artwork display).
Updated callsites pass `220`:
- LocalLibraryView `getArtworkUrl` (grid + list thumbs)
- MixtapeCollectionDetailView resolve path
- PlaylistDetailView track artwork
Per the 2026-05-12 user call: 220 over 440 — fluidity wins over
HiDPI sharpness on this surface.
cc
Three follow-ups from the 2026-05-12 user call:
- Hover ring on AlbumCardLibraryLite was set up as a
`.cover-wrap::after` pseudo with a transparent → accent border,
but the cover `<img>` lives at `z-index: 1` while the pseudo
inherited `auto` z-index — so the img painted on top of the
ring. `z-index: 2` on the pseudo lifts it above the artwork.
- Scrollbar in `.grid-pool` and `.virtual-container` was styled at
10px wide with a non-standard track / thumb / hover palette,
which read as a one-off vs the global `::-webkit-scrollbar`
rule in app.css. Aligned to the app convention: 8px, transparent
track, `var(--bg-tertiary)` thumb with `border-radius: 9999px`,
`var(--text-muted)` on hover. `scrollbar-width: thin` for the
standard property path.
- `.album-sections.virtualized { height: calc(100vh - 280px) }`
over-extended past the NowPlayingBar (104px) once the scrollbar
was forced always visible — the gutter ran to viewport bottom
instead of ending at the player. Bumped to `100vh - 360px` so
the scroll area ends where the player starts.
cc
User reports neither the grid path nor the legacy virtualizer
(albums list, tracks, folders) show a vertical scrollbar in
LocalLibrary. The global `::-webkit-scrollbar` rule in app.css is
defined but doesn't appear to win against the overlay-scrollbar
behaviour some WebKitGTK builds default to.
Belt-and-suspenders on both scrollers (`.grid-pool` in AlbumGridPool
and `.virtual-container` in VirtualizedAlbumList):
- `overflow-y: scroll` instead of `auto` reserves a permanent
gutter and forces the bar to render even when the content
barely overflows.
- Standard `scrollbar-width` + `scrollbar-color` set, plus the
`::-webkit-scrollbar*` pseudo-element rules with explicit
thumb / track colours pulled from the theme. Different
WebKitGTK configurations honour different sets, so we set
both. 10px width so the bar is clearly visible (vs the 8px
global default).
- Hover state on the thumb shifts to `--text-primary` for
affordance.
Bonus: `albumViewMode` now defaults to `'list'`. Per the same
user call, list mode runs acceptably under SW compositing while
grid still has the perf-cliff problem we're chasing. The toggle
is still in the toolbar so power users can flip it; persistence
is in-session only so the default reasserts on next launch.
Hover indicator on AlbumCardLibraryLite reworked: the previous
inset box-shadow was being painted under the absolutely-positioned
`<img>` so it never showed. Switched to a `.cover-wrap::after`
pseudo-element with a transparent border by default that flips to
`var(--accent-primary)` on `.card:hover`. The pseudo paints after
the image in DOM order, so it stays visible. Title still shifts
to the accent colour as a secondary cue.
cc
Plex cache lives in a separate SQLite database
(`<data_dir>/qbz/plex_cache.db`), which is why `v2_library_get_albums_page`
previously only saw local_tracks and the LocalLibraryView chunked
path had to fall back to the legacy virtualizer when Plex was on.
That fallback meant Plex-dominant users (which is the common case)
got none of the chunked-store / recycling-pool perf work.
Now consolidated server-side via SQL `ATTACH DATABASE` + `UNION ALL`:
Backend (qbz-library):
- `get_albums_metadata_page` accepts `plex_cache_path: Option<&Path>`.
When the file exists it `ATTACH`es the plex DB to the connection,
runs a CTE that aggregates `plex_cache.plex_cache_tracks` by
`album_key` into the same column shape as local_aggregated, and
UNIONs both before the filter/sort/pagination step. DETACHes at
the end so subsequent queries don't see stale attachment.
Plex group_key prefixed with `'plex:'` so it doesn't collide with
local group keys; `'plex'` literal in the `source` column drives
the frontend's SourceBadge mapping.
- Schema differences smoothed via `CAST` in the plex arm:
`duration_ms / 1000 → total_duration` (matches local seconds),
`sampling_rate_hz → sample_rate` (INTEGER → REAL).
- `count_albums_metadata_for_page` mirrors the same UNION so total
is consistent across empty-page edge cases.
Backend (Tauri command):
- `v2_library_get_albums_page` accepts an `include_plex` bool.
When true, resolves the plex cache path the same way
`plex/mod.rs::open_plex_cache_db` does and passes it through.
Frontend:
- Chunked store's `LocalAlbumsQueryParams` carries an `includePlex`
flag, included in the `paramsEqual` check so toggling Plex
visibility invalidates the chunk cache.
- LocalLibraryView drops the `!isPlexLibraryEnabled()` guard from
both the `$effect` that calls `setParams` and the render
condition that picks chunked vs legacy. The new path serves
Plex-only, local-only, and mixed libraries the same way.
cc
Previous attempt used `outline` with positive `outline-offset` so the
ring sat in the gap outside the cover. The leftmost column has no
horizontal slack between the cover edge and the scroll container's
inner edge, so the outline was eaten on the left side of every card
in column 0.
`box-shadow: inset 0 0 0 3px var(--accent-primary)` paints the ring
INSIDE the cover-wrap's box. No layout reflow, no clipping concerns,
no transition — single instant paint on hover entry/exit. Title text
still flips to accent colour for a second cue.
cc
GRID_GAP was 22px and album-grid-row CSS was 22px gap. Discovery V2
uses 32px. Library users with Plex enabled stay on the legacy grid
(per the temporary fallback in 7508c3cd) and saw the smaller gap as
the user-reported "20px separación entre columnas". Aligning to
32px matches Discovery and matches the AlbumGridPool default.
cc
User wanted a hover indicator without bringing back the per-frame
opacity transition that was the scroll-perf bottleneck. CSS `outline`
fits: paints outside the element's box (no layout reflow), no
transition, single paint event on hover entry/exit. Uses
`var(--accent-primary)` solid, no transparency, no animation per
user's "sin animación ni transparencia" follow-up.
Bumped the card cover from 210x210 to 220x220 so Library matches
Discovery V2 `AlbumCardLite` width — with the same 32px gap on both
sides, the column step is now identical and the two views share
one visual rhythm. Updated `VirtualizedAlbumList`'s
`GRID_MIN_CARD_WIDTH` and `GRID_ROW_HEIGHT` so the legacy grid path
(used when grouping or quality filters are on) stays consistent
with the chunked path.
cc
Library was rendering at 22px horizontal / 24px vertical between
cards while Home (DiscoverySection) used 32px in both axes. Reading
the same artist library across the two views felt like two different
densities. Aligning to 32/32.
cc
User feedback: the solid theme-coloured buttons looked "horrible"
against the artwork. Replaced with the same white-outline circles
that Home AlbumCardLite uses, plus a static `box-shadow` under each
button and a small `drop-shadow` on the icon for legibility on light
covers. Cost is a one-time paint per slot rebind, not the per-frame
re-paint the transitioning overlay caused — so the visual contrast
guarantee comes back without restoring the perf regression.
Also bumped buttons further toward the bottom edge (padding-bottom
44px → 12px).
cc
Buttons used to sit center-vertically of the 210x210 cover; user
asked for the Home AlbumCardLite Y position (44px clearance above
the bottom edge). Done with flex `align-items: flex-end` +
`padding-bottom: 44px` rather than `position: absolute; bottom: 44px;
transform: translateX(-50%)` — avoids any transform on the child,
which under SW compositing is one fewer hint for WebKit to maybe
allocate a separate framebuffer over.
cc
Direct attack on the residual scroll-time cost under software
compositing. The user-reported pain ("el mouse over tarda en
reaccionar") is hit-testing: every pointermove during a mouse-wheel
scroll forces WebKit to walk every visible hit target, and with
~50 cards × multiple nested elements per card (cover-wrap, image,
placeholder, overlay, source-badge, buttons) the cascade was visible
as hover delay and scroll lag. Per the 2026-05-12 user call, this is
a palliative — the underlying SW-comp hit-testing cost stays — but
removes the bulk of the hot path.
Two changes:
- `.cover-wrap { pointer-events: none }` opts the decorative
children out of hit-testing. Mouse moves over the cover fall
through to `.card` (which carries `role="button"` and the click
handler) without WebKit needing to consider each of the 5+
nested elements as hit candidates. `.action-buttons` re-enables
pointer-events on itself so the buttons still receive clicks.
- Action buttons are now permanently visible (no `opacity: 0 → 1`
on hover, no transition). Buttons use theme variables —
`var(--bg-primary)` background + `var(--text-primary)` icon —
so contrast holds on any cover artwork without needing the
artwork-palette sampling the legacy AlbumCard did. The primary
play button keeps `var(--accent-primary)` for visual hierarchy.
cc
CPU-mode CSV from the 2026-05-12 measurement window showed mean CPU%
regressing run-over-run since the chunked-store landing:
8f2cd965 (chunked + top/left, no contain) mean 62
a3f1426c (transform on slot) mean 172
9003d93a (+ contain layout paint) mean 176
Theory for the regression: under software compositing every "layer
hint" (`transform`, `contain: paint`, `will-change`) forces WebKit
to allocate a per-slot CPU framebuffer. ~50 framebuffers composited
per frame in CPU dwarfs the layout work the hints were supposed to
skip. Under HW comp those would be GPU layers (cheap); the SW path
isn't symmetric.
Reverts:
- `transform: translate(...)` → inline `top: Npx; left: Mpx`.
- drops `contain: layout paint` from `.grid-slot`.
Keeps:
- drop scrim (f494b1e6) — user explicitly accepted; cheap visual
- skeleton placeholder (9003d93a) — visual-only, no perf cost
- chunked store (8f2cd965) — the actually-confirmed win
Also drops `bufferRows` from 2 to 1, taking pool size from ~63 to
~49 cards. Chunk pre-fetch lead time is still ample (100 albums per
chunk ≈ 14 rows).
cc
Two complementary changes to the chunked LocalLibrary grid:
- `bufferRows = 2` in AlbumGridPool. With ~7 cols + ~5 visible
rows, pool size drops from 77 to 63 cards (-18%). Under software
compositing each rendered card carries per-frame paint and hit-
testing cost, so trimming buffer is a direct win. Chunk pre-
fetch lead time is unchanged in practice — chunks are 100 albums
= ~14 rows, so even bufferRows=1 would give ample lead.
- `renderPlaceholder` snippet wired up in LocalLibraryView. When a
slot maps to an index whose chunk hasn't arrived, the pool now
renders a static skeleton (cover block + 3 text bars) instead
of leaving the slot blank. No shimmer, no animation — shape
alone signals "loading". Matches the loaded card dimensions
so binding the real data later doesn't shift layout.
cc
Per the 2026-05-12 user call ("para localLibrary podría aceptar
quitarle el overlay y solo dejar los botones, que al final son
funcionalidad"), the dark `rgba(0,0,0,0.85)` overlay that filled the
entire 210x210 cover on hover is gone. Each card's hover state now
fades only the 3 action buttons (play + kebab) in over 120ms; the
artwork stays fully visible underneath.
Why this matters under CPU compositing: every pointer-traversal of a
card during a mouse-wheel scroll triggered a paint of the full
overlay area (44K pixels per card alpha-blended over the cover).
Multiplied by ~80 cards in the pool and a continuous pointermove
stream, the paint cost dominated frame time. With the scrim gone,
the per-card hover paint is bounded to ~44x44 px per button
backdrop — a 30x reduction.
Buttons now carry their own `rgba(0,0,0,0.55)` backdrop so they stay
readable on light cover art. Hover boosts that to 0.8. Same visual
hierarchy as before (play primary in white, kebab outlined), just
without the curtain over the artwork.
cc
The transform-only positioning eliminated scroll-tick layout for slot
position updates, but the perf trace still showed 1s+ layout spikes
triggered by pointermove during scroll. Root cause: WebKit's hit-
testing on each pointer event re-evaluates layout across the whole
grid because slot boundaries aren't isolated. `contain: layout paint`
on each slot tells WebKit the slot's layout and paint are independent
of the rest, so a hover-state change (or any internal mutation) in
one slot can no longer cascade to its 79 neighbours.
cc
The Web Inspector perf trace showed scroll-time was dominated by
layout, not script or paint. Single layout records ran 750ms-1.5s
each, triggered by scroll → animation-frame → slot position update.
Each slot's `style="top: Npx; left: Mpx"` mutation invalidates its
own layout box, and with 80 slots repositioned per scroll tick the
cascade became the frame.
`transform: translate(x, y)` on the same absolutely-positioned slot
goes straight to paint/composite and skips layout entirely.
Reported even under software compositing the GPU-layer cost is
negligible compared to the layout work it eliminates.
cc
The chunked grid silently hid every Plex album because
`v2_library_get_albums_page` only queries `local_tracks`. Plex cache
lives in a separate SQLite database (`plex_cache.db`) and the
proper consolidation needs `ATTACH DATABASE` + `UNION ALL` from the
same aggregation, which is the next delta.
Until that lands, gate the chunked path on `!isPlexLibraryEnabled()`
so Plex users keep seeing their full library through the legacy
`VirtualizedAlbumList` (slower under CPU compositing but
functionally complete). Pure-local users still get the chunked
benefit.
cc
Phase A of the Plex-style port: the Albums grid no longer keeps the
full collection (1200+ rows on the user's library) in reactive Svelte
state. Instead, it pulls a single chunk at a time from a new Tauri
command, with the recycling-grid pool firing `requestIndex` for
indices whose data hasn't arrived yet.
Why this matters: Phase B (recycling pool against an in-memory array)
removed mount/unmount churn during scroll but left two costs in
place — every reactive tick still ran the `$derived` filter/sort
pipeline over all 1200 records, and the records themselves still
sat in Svelte's reactivity graph. Under software compositing the
combined cost was still the dominant scroll-time spike.
Server-side pagination eliminates both: sort + filter run in SQL,
only the visible chunk's records are in memory, and the per-tick
$derived work disappears.
Backend:
- `qbz-library/src/models.rs` — new `AlbumsMetadataPage` struct
(`{ albums, total }`) returned by the paginated query.
- `qbz-library/src/database.rs` — `get_albums_metadata_page`:
reuses the existing track-aggregation CTE from
`get_albums_metadata_grouped`, adds a HAVING-style search filter
over the aggregated title/artist (mirroring the legacy
`matchesAlbumSearchFast` semantics), validated allowlist-based
`ORDER BY` for artist/title/year × asc/desc, and
`LIMIT ?/OFFSET ?` on the filtered set. Total comes from
`COUNT(*) OVER ()` in the same query for one round-trip; a
fallback `count_albums_metadata_for_page` covers the empty-page
case where the window function has no row to attach to.
- `src-tauri/src/commands_v2/library.rs` — new
`v2_library_get_albums_page` Tauri command, registered in
`lib.rs`. `include_qobuz_downloads` is read from
`DownloadSettingsStore` to match the legacy
`v2_library_get_albums_metadata` behavior.
Frontend:
- `src/lib/discovery-v2/localAlbumsChunkedStore.svelte.ts` — new
class-backed store with `version` + `total` as `$state`, sparse
`Map<chunkIdx, LocalAlbumLite[]>`, in-flight `Set<chunkIdx>`
dedup, and a generation counter that drops stale responses if
the user switches filters mid-flight. `getAlbum(globalIdx)` is
sync (null for missing chunks); `requestIndex(globalIdx)` fires
the fetch.
- `src/lib/components/views/LocalLibraryView.svelte` — when the
Albums tab is in grid mode AND grouping is off AND no quality
filters are active (the common case), render through
`AlbumGridPool` bound to the chunked store. Other paths
(grouped, filtered, list mode) keep the legacy
`VirtualizedAlbumList` so we don't lose features we haven't
server-side yet. A `$effect` mirrors search/sort/source state
into `setParams` whenever they change; the store no-ops on
unchanged params.
Plex consolidation (other source listed in the audit) deferred to a
follow-up: `plex_cache.db` is a separate SQLite file, so unifying
needs `ATTACH DATABASE` + `UNION ALL` from the same aggregation,
which is a clean delta once the local-only path is verified.
cc
Replaces the keyed `{#each visibleItems as item (album.id)}` pattern
in the Albums grid (Local Library tab, ungrouped) with a Plex-style
recycling pool. Same DOM stays mounted across the entire scroll;
slot bindings update in place.
Why: the legacy keyed-each pattern destroys and remounts card
components every scroll tick. Each remount runs the favorites store
subscription, the cached-image action lifecycle, the quick-menu
floatingMenuStore subscription, and the cover-resolve closure. Under
software compositing (CPU-only WebKitGTK) the mount/unmount churn
dominates scroll cost — confirmed in a 60s CPU window measure with
a library of 1200 albums.
Three changes:
- New `AlbumGridPool.svelte` (Discovery V2): a constant-size pool
of absolutely-positioned slots inside a pre-sized spacer. The
spacer's height is `totalRows * rowStep + bottomPadding` so the
native scrollbar reflects the full collection even when only a
chunk is materialized — same trick Plex uses. Slot count is
derived from `(visibleRows + 2*bufferRows) * cols` and is stable
until container resize, so `{#each Array(maxPool) as _, slotIdx
(slotIdx)}` never destroys a slot during scroll. Data flows via
an abstract `getItem(index)` getter, leaving the door open for
Phase A (backend pagination + chunked store) without refactoring
the pool itself.
- `AlbumCardLibraryLite.svelte`: added an `$effect` that watches
`albumId` and resets the per-slot transient state (`menuOpen`,
`menuAnchor`, `imageError`) when the slot recycles to a new
album. Without this, a menu opened on one album would stay open
after the slot scrolls onto a different album. Also cleared two
earlier issues uncovered while preparing this migration: the
img tag's `src=` was set in parallel with `use:cachedSrc`,
causing the WebView to start a raw-URL fetch in the same tick
the cache action checked locally — duplicate loads on every
scroll. And `content-visibility: auto` on each card was layered
on top of the virtualizer's own slicing, which gave WebKit an
extra intersection check per card per frame with no real
benefit since cards inside a visible row are always in viewport.
- `LocalLibraryView.svelte`: Albums tab grid mode (ungrouped) now
renders through `AlbumGridPool` with a snippet that wires the
same callbacks the old virtualizer used. Grouped grid + list
mode fall back to `VirtualizedAlbumList` for now — grouping
needs header support in the pool, which is a follow-up.
Phase A (backend pagination): unchanged interface. The pool already
takes `totalCount` and `getItem`; swapping in a chunked store with
`getItem` returning `null` for unloaded chunks + `onNeedIndex`
triggering chunk fetches is plumbing only, not a pool rewrite.
cc
First slice of the AlbumCard → Lite migration. Profile A (Local
Library) is the heaviest paint surface in CPU mode because users
routinely scroll thousands of cards. Swapping it onto the Lite paint
strategy is the biggest single CPU-mode win available before Slint.
New component: `src/lib/discovery-v2/AlbumCardLibraryLite.svelte`.
Designed for the LocalLibrary / Purchases / VirtualizedAlbumList
profile, which never surfaces favorites or the genre/date hover.
What it has vs the legacy AlbumCard at `size="large"`:
- 210px fixed width (matches `GRID_MIN_CARD_WIDTH` in
VirtualizedAlbumList so the virtualizer math is unchanged).
- Cero efectos: opacity-only hover overlay, no marquee, no per-
card ResizeObserver, no will-change, no backdrop-filter.
- `content-visibility: auto` so offscreen cards skip paint —
essential for libraries with thousands of albums.
- Disc3 placeholder + imageError fallback + resolveAlbumCover
lookup for user custom covers.
- SourceBadge (bottom-right) and selectable checkbox (top-left).
- Full quality pill (not gated on Hi-Res like the Discovery V2
base AlbumCardLite).
- Right-click context menu mirrors the kebab menu.
AlbumQuickMenu gains the three actions the Library + Search profiles
need but didn't have: `onAddToMixtape` (CassetteTape icon),
`onReDownloadAlbum` (RefreshCw icon), and the
`isAlbumFullyDownloaded` flag that toggles between "Make available
offline" (when false) and "Refresh offline copy" (when true). The
legacy `onOpenContainingFolder` prop is intentionally left
unwired — the original `AlbumMenu` declared it but never rendered
an item, and we mirror that until someone actually wants the
feature.
Migrated callsites:
- `VirtualizedAlbumList.svelte` (grid mode rendering)
- `LocalLibraryView.svelte` (selected-artist albums grid)
Next: AlbumCardSearchLite for Profile B (Search / Awards / Favorites /
VirtualizedFavoritesAlbumGrid), then Purchases as a small follow-up.
cc
User feedback: a long explanatory note plus an interactive toggle
that the runtime silently overrides is confusing. The right shape is
"you literally cannot turn this on without a GPU" — hard-disable the
toggle when HW accel is off, and let the note be a one-liner.
Changes:
- Toggle's `disabled` prop now also depends on `!isHardwareAccelEnabled()`.
Combined with the existing `hideTitleBar || useSystemTitleBar`
guards, the user simply can't flip the toggle in CPU mode. The
visual reads as "available only when conditions are met."
- Toggle's `enabled` prop is also gated so the visual state matches
the effective state, not the stored preference, when HW accel is
off. The stored preference is still preserved on disk and
reactivates the next time HW accel is on.
- i18n note shortened to a single line across all five locales:
"Available only with GPU acceleration." (and equivalents).
cc
User finding (2026-05-12): under SW compositing, toggling the
"Match system window chrome" setting OFF turned an unusable modal
experience into instant popups. The transparent main window forces
GTK to repaint the client-side decoration chrome (rounded corners +
subtle edge + window shadow) on every frame. Under GPU compositing
the cost is imperceptible; under SW compositing it becomes the
dominant frame-budget cost — modals, the splash spinner, and any
other animation visibly drop frames because each tick the WebKit
surface has to be recomposited against the CSD chrome.
Auto-gate the transparent window on hardware acceleration so users
in CPU rendering mode (whether by setting or by env var) don't have
to discover this themselves. While we work toward Slint, this is the
single biggest win available for the SW path.
Implementation:
- `should_use_main_window_transparency()` in src-tauri/src/lib.rs
now reads QBZ_HARDWARE_ACCEL env var (mirroring main.rs) and
falls back to graphics_settings.db.hardware_acceleration. When
HW accel is off, returns false regardless of the user's
match_system_window_chrome preference. The window is built
opaque; the frontend's `windowTransparent` reads false from the
Rust side; the `.match-chrome-transparent` CSS class never
activates. Round corners disappear, opaque rectangle remains.
- The user's chrome preference is preserved in the DB. When HW
accel is re-enabled (next restart with QBZ_HARDWARE_ACCEL unset
or set to 1), the preference reactivates automatically.
- SettingsView shows a `<small class="setting-note">` under the
chrome toggle when `isHardwareAccelEnabled()` is false,
explaining the override. Toggle itself stays interactive so the
user can still set their preference for the next HW-accel-on
session.
- New i18n key `settings.appearance.matchSystemChromeCpuOverride`
in all 5 locales.
cc
Sister script of dev-ultra-restore.sh. Runs `npm run tauri dev` with
the full degraded-rendering env applied so the SW path can be
exercised even when the persisted graphics_settings DB has HW accel
enabled. Useful for testing the modal mount cost, splash spinner
smoothness, and Discovery V2 paint cost under WebKitGTK without GPU.
Sets five env vars:
QBZ_HARDWARE_ACCEL=0 (QBZ's own nuclear opt-out)
WEBKIT_DISABLE_COMPOSITING_MODE=1
WEBKIT_DISABLE_DMABUF_RENDERER=1
GSK_RENDERER=cairo (GTK4 SW renderer)
LIBGL_ALWAYS_SOFTWARE=1 (Mesa llvmpipe)
Flags:
--no-kill skip stale-process cleanup
--print print the env vars and exit (for sourcing)
cc
Mechanical sweep. Each modal swaps the `Modal` import path from
`./Modal.svelte` / `../Modal.svelte` to `$lib/discovery-v2/ModalLite.svelte`.
No other changes — `ModalLite` already exposes the same Props
(`isOpen`, `onClose`, `title?`, `showCloseButton?`, `maxWidth?`,
`children`, `footer?`) with backwards-compatible defaults
(`withScrim={true}`, `footerAlign='start'`), so every call site
renders the same as before.
Modals migrated:
FavoritesEditModal, FolderEditModal, HomeSettingsModal,
LibraryEditModal, LinkResolverModal, LocalLibraryTagEditorModal,
LogsModal, MigrationModal, PlaylistDuplicateConfirmModal,
QconnectPanel, ReportIssueModal, TrackMixModal,
ImmersivePlayer (immersive settings), OfflineCacheManagerView,
FlatpakWelcomeModal, SnapWelcomeModal, UpdateAvailableModal,
UpdateCheckResultModal, UpdateProgressModal, UpdateReminderModal,
WhatsNewModal — and DiscoverySettingsModal moves to the `$lib`
alias for consistency.
Wins from the swap:
- No `backdrop-filter: blur(...)` — the scrim is plain rgba which
paints in one pass even under software compositing.
- No fade-in / slide-up mount animations.
- Dropdown.svelte instances portaled from inside a modal no longer
close the modal when clicked (the previous ModalLite document-
level outside-click listener was the bug; the new overlay-based
backdrop click matches the legacy Modal behavior).
Legacy `src/lib/components/Modal.svelte` is now unreferenced but
kept in tree for one release cycle as a rollback safety net.
cc
Prep for the modal sweep: bring ModalLite to feature parity with
`Modal.svelte` so the migration is a one-line import swap per modal.
Three changes:
1. New `withScrim` prop (default true) that brings back the dim
`rgba(0,0,0,0.7)` background under the modal. The earlier
overlay-less variant existed because the *blur* on the scrim was
the perf killer on software compositing — but the dim itself is
just a single rect paint. Now that HW accel is on by default
(ADR-004) the rect is cheap. Pass `withScrim={false}` to keep the
overlay-less floating variant.
2. New `footerAlign` prop (`'start'` | `'end'`, default `'start'`).
Legacy `Modal.svelte` left-aligns footer content; the original
ModalLite right-aligned it. Defaulting to `'start'` so existing
modals migrate without visual shift; opt into `'end'` for the
modern Cancel | Save right-aligned convention.
3. Backdrop click handled via the overlay div (`e.target ===
e.currentTarget`) instead of a `document.mousedown` listener. The
document listener closed the modal when clicking any portaled
descendant — including `Dropdown.svelte` instances opened from
inside the modal, which is a known interaction pattern (see
memory: feedback_use_shared_modal_component). The overlay
approach restores legacy behavior without re-introducing the
blur perf cost.
Cero animations on mount kept (no fade-in, no slide-up) — that part
of the perf philosophy stays.
cc
Three visual fixes from the latest review:
1. SpotlightLite rewritten faithfully to the legacy ForYouTab structure:
a hero (portrait + ARTIST label + name + play-top-tracks + go-to-artist
circle buttons) plus a single paginated row mixing a TOP TRACKS radio
card, a RADIO card, the artist's Qobuz playlists (as PLAYLIST-labelled
radio cards) and the artist's albums (AlbumCardLite). Dropped the
earlier invented sub-blocks (separate Top Tracks list, separate
Albums grid, separate Playlists row). Internal `handleSpotlightTopTracks`
and `handleSpotlightRadio` ported from the legacy ForYouTab so the
play + radio buttons work out of the box from DiscoveryView.
RadioCardLite gains an optional `label` prop (default "RADIO") so the
same stereo-component visual can render the TOP TRACKS and PLAYLIST
variants the spotlight needs.
2. ArtistTileLite gains a subtle hover (background tint, 120ms ease) so
the cursor reads as interactive on Your Top Artists. With an `onFollow`
callback it also renders an "Artist" sublabel and a Follow chip with a
UserPlus icon (or LoaderCircle while pending). DiscoveryView passes
`onFollow` only for the Artists-to-Follow section via a new
`artistTileFollowable` snippet; Top Artists keep the bare tile. Follow
uses `toggleArtistFavorite` and strips the artist from the suggestion
list on success, matching legacy behavior.
3. Replaced the "Discovery V2 — under construction" placeholder with a
loading skeleton: three placeholder sections (title bar + a row of
220x220 card silhouettes) shown until the three main fetches
(release-watch, discover-index, home-resolved) resolve. Cero efectos
(no shimmer, no animation) — the shape alone signals "loading".
Removed `discovery.comingSoon` from all 5 locale files; the truly
empty case now falls through to `empty.noContent`.
cc
Three issues from the latest visual review:
1. Spotlight was missing the RADIO card that anchors the Qobuz layout.
Added `RadioCardLite.svelte` — a 220×220 stereo-component-styled
card with vertical speaker-bar pseudo-elements, the seed's artwork
centered as the "display", a RADIO wordmark, and a background color
pulled from the artwork's dominant palette (artworkPalette). Used
in SpotlightLite as the first item of the albums row alongside the
six release tiles, and as the renderItem for the new "Radio
Stations" section in DiscoveryView (seeded from the union of
recentlyPlayedAlbums + favoriteAlbums, deduped, sliced to 12).
2. Three untranslated keys in SpotlightLite. The keys lived in
different namespaces than I'd guessed:
- `home.popularTracks` → `artist.popularTracks`
- `home.albums` → `artist.albums`
- `home.radio.startArtistRadio` → `actions.radio.startArtistRadio`
Added one new key `discovery.qobuzRadioStation` for the radio card
subtitle, across all 5 locales.
3. QobuzMixesRow tiles were stretched by `grid auto-fit minmax(200px,
1fr)` so on wide windows they ran 280-320px each — visually outsizing
every other card and making the section feel cartoonish. Switched
to `display: flex; flex-wrap: wrap; gap: 32px` with fixed 220px
tiles. Same scale as AlbumCardLite now.
cc
Closes parity with the legacy ForYouTab by adding the 7 sections it
had that aren't shared with Home / Editor's Picks:
- qobuzMixes (Home + For You) — 4-tile entry point to DailyQ /
WeeklyQ / FavQ / TopQ via existing onNavigate* callbacks.
Implemented as `QobuzMixesRow.svelte` (CSS grid + gradient
artwork tiles, no fetch).
- rediscoverLibrary (For You only) — albums favorited but unplayed
recently. Wraps `v2_reco_get_forgotten_favorites`.
- artistsToFollow (For You only) — similar artists derived from
user's top-3 seeds, deduped against already-followed. Wraps
`v2_get_cached_favorite_artists` + `v2_get_similar_artists` × 3.
- similarAlbums (For You only) — Qobuz suggestions seeded by a
random recent album. Dynamic title "Similar to {seed}".
- essentialsByGenre (For You only) — `ideal-discography` featured
albums for the user's top genre. Dynamic title "Essentials in
{genre}". Wraps `v2_reco_get_top_genres` + `v2_get_featured_albums`.
- artistSpotlight (For You only) — featured-artist hero with
portrait + top 5 tracks + 6 albums + playlists. Wraps
`v2_get_artist_page`. Implemented as `SpotlightLite.svelte`,
minimal but representative: no radio-card extraction, no
spotlight color theming (deferred — both were cosmetic in legacy).
Type system: 7 new IDs added to `DiscoverySectionId`. `DEFAULT_PREFS`
now reflects per-tab availability (the customize modal naturally hides
sections not present in the active tab's prefs list):
- home: 12 universal + qobuzMixes
- editorPicks: 7 editorial-only (no personalized ever)
- forYou: 12 universal + qobuzMixes + 6 exclusives + spotlight
Data layer: 5 new fetch functions in `data.ts` (`fetchRediscoverLibrary`,
`fetchArtistsToFollow`, `fetchSimilarAlbums`, `fetchEssentialsByGenre`,
`fetchArtistSpotlight`) and 3 new typed shapes (`SimilarAlbumsSection`,
`EssentialsSection`, `SpotlightSection`). All fired in parallel after
home-resolved completes (the seeds — top artists, recent albums — are
needed first). All errors caught and degraded to empty results so a
broken backend response doesn't break the whole view.
i18n: adds `discovery.{similarAlbums, similarTo, rediscoverLibrary,
essentialsByGenre, essentialsIn, artistsToFollow, artistSpotlight}`
across the five locales.
radioStations is registered as an ID but not yet rendered — the legacy
implementation derived radio cards from recent + favorite albums, will
land in a follow-up commit.
cc
vicrodh