Joren/qbz - qbz

6,354 Commits 1 Branch 0 Tags

3 Commits

Include renames

Author	SHA1	Message	Date
vicrodh	8bd02e35d3	feat(qt): custom-theme editor, artist portrait, playlist rail, About/What's New and diagnostics Five surfaces the Qt frontend was missing, landed together because they share five wiring files (build.rs, main.rs, shell_bridge.rs, AppShell.qml, HeaderBar.qml) and splitting them would produce commits that do not build. ARTIST PAGE - The Playlists section used a hand-rolled Rectangle delegate: a MouseArea with no onClicked, and a RoundedImage with no fit:, so the default crop blew an 800x380 playlist banner up inside a 200x200 box and showed the middle 47% at 2.1x. Replaced by the real cards/PlaylistCard.qml — already live on five other surfaces — mounted in a new views/PlaylistRail.qml modelled on SectionRail. ArtistPlaylist publishes the five roles the card reads. - The portrait gains what the album cover has: the right-click menu the Slint reference already has (Add/Change/Remove image, Open in browser, Save as…) and the lightbox this port invented for albums and playlists. Custom images are keyed by artist NAME into the same custom_artwork.json the Slint build writes, so they round-trip between the two. - CoverLightbox is now aspect-aware. It forced a square box on the premise that covers are square; artist portraits are not (1080x720 measured in the cache). - Removing an override invalidates the pipeline's resolved path for that url: artwork_qt::cached_path consults the override FIRST, so coverMap held the custom file and the header kept showing the picture the user had just deleted. - artwork_qt::local_path is the inverse of file_url. trim_start_matches("file://") is not: it leaves the percent-escapes in place, so any path holding % # or ? came back as a name that does not exist on disk. - One new msgid, "View image", in the seven non-en locales — matching its sibling "View cover", since en carries none of that family and falls back to the msgid. CUSTOM THEME - The editor, the colour picker and the swatch grid, ported 1:1 from AppearanceSettings.slint and ColorPicker.slint. The 11 editable base tokens, their expansion into the full 55-value palette and the on-disk format all stay in the shared qbz-theme crate, so a theme authored in the shipping Slint build already rendered here and now round-trips both ways. - Hue is normalised 0..1 at every Qt.hsva boundary; the reference stores 0..360, and porting the number instead of the domain would render every swatch red. - The first-selection seed is captured BEFORE set_theme persists the slug, because current_slug() re-reads it from disk — a seed taken afterwards would resolve "custom", find no file and snapshot the default it was meant to replace. - The in-memory base is dropped when the theme row enters "custom": it is memoized for the life of the process and filled at bridge construction, so a process that booted without the file would keep serving the OLED default even after the shipping Slint build wrote the user's theme. - The disk write is debounced to drag-end and atomic; the reference persists on every drag frame with a truncating write, on a file the other build has open. ABOUT + WHAT'S NEW - Both modals, with their producers. render_markdown is transcribed line for line from the reference: h1 and h2 collapse to one level, an indent-0 bullet becomes a section plus a TOC entry, bold and backticks are stripped rather than styled. Text.MarkdownText is a different subset and would have rendered a different document from the same source. Pinned by tests, including the real 2.0.2 body. - The codename is a single const, so the release checklist has one Qt-side place to bump. DIAGNOSTICS - The panel in Settings > Developer, the Report an Issue modal and its menu row. - The log bundle carried eight hand-built header fields where the reference carries about seventy, so every issue filed from a Qt build arrived with no kernel, no distro, no install method, no GPU, no exclusive-mode / DAC / sample-rate state and no playback context. The report is injected INTO qbz_log::bundle rather than replacing it, keeping the <details> wrapper that makes a pasted bundle readable. - The GTK / WebKit / GSK / GDK rows are CUT. In a Qt process those libraries are not mapped, so their runtime column can only read "—", and their saved column would come from a graphics.json this binary never reads or writes — foreign state presented as this app's configuration. SHELL - The four always-on-top overlays (toast, tooltip, art preview, immersive) relied on declaration order and carried no z, so any z-bearing modal buried them: a toast raised by a background event behind an opaque panel is never seen. They now sit in a band above the modals, keeping their relative order. - build.rs asked cargo to watch ../../.git/HEAD, which does not exist in a git worktree (.git is a file). Cargo treats a missing rerun-if-changed target as always-dirty, so the whole build script — per-shader qsb, the recursive asset sweep, cxx-qt/moc codegen — re-ran on every cargo invocation. Verified: cargo test -p qbz-qt 343 passed, cargo test -p qbz-library 83 passed, qml_singleton_xref and qml_resolution_audit clean over 35 bridges and 265 QML files, and qmlcachegen compiles every one of them. Smoke-tested by hand. Contracts, recon and adversarial reviews: qbz-nix-docs/qt-frontend/2026-08-14-six-item-round/ cc	2026-08-15 00:52:25 -06:00
vicrodh	a53e8a7af7	feat(qt): custom covers for playlists + the app-wide custom-art sweep Two halves of one feature: - Playlist custom covers (Qt-first; no Slint counterpart yet): the playlist header cover gets the cover menu (Add/Change/Remove) and the lightbox on left-click. The store is a NEW file, custom_playlist_covers.json — a `playlists` key inside the shared custom_artwork.json would be silently dropped the next time the Slint app wrote an override (its store round-trips only known keys). The override beats the playlist's own Qobuz graphic AND the member-cover mosaic on the header, the sidebar rows, the cards and the library grid. - Album custom covers now apply everywhere, not just the album header: doc builders route an album's art URL through cover_artwork_qt::prefer_album_cover (the override's path flows through the ordinary artwork pipeline — artwork_qt::classify's LocalFile arm resolves it synchronously, no QML change). Swept: album page carousels (more-from-artist / suggestions / Last.fm similar), artist page releases, search result cards, and the playlist mosaics (a member album with a custom cover contributes THAT art to the collage tiles). km	2026-08-11 01:38:18 -06:00
vicrodh	d9b1c26ff3	feat(qt): album page parity — cover menu + lightbox, header actions, album info modal Four wired surfaces on AlbumView, all previously inert stubs: - Cover menu (right-click, AlbumPageView.slint:300-370): Add/Change/Remove custom cover over the SAME custom_artwork.json store the Slint app uses (a cover set in one app shows in both), Open in browser, Save as…. Plus the NEW lightbox (menu entry + left-click): the art at its best available quality fitted to the window, custom override preferred. - Header action row: radio (the existing foryou_qt album-radio seam), booklet (visible when a PDF goody exists; downloads via save-as — no in-app reader, like the reference), and add-to-mixtape/collection — the MyQBZ picker's Accepts engine already lets albums target Collections (the Tauri rule), so the button just feeds it. - Album Info modal (the extensive one): fresh /album/get → credits grouped through the shared qbz_qobuz::performers parser, per-track copyright, review tab when the album has editorial text, label link, musician navigation, per-track play in album context. Tauri layout (left fixed meta column, right scrollable tabs) per the project ruling for this feature; the header's label link is wired along the way (LabelView has existed for a while — the POC-NOTE was stale). - … menu: Add to playlist (the loaded view's track ids into the picker), Add to mixtape, Share Qobuz link, Share Album.link (UPC -> Deezer -> album.link, #514 path — the resolver half of share.rs is now ported for the album arm). The offline rows stay out: no Qt album-cache seam. i18n: "View cover" + "Could not load the image" catalogued in all seven locales. Gate: both QML audits + 305 tests + debug/release builds green. km	2026-08-10 20:24:25 -06:00

Author

SHA1

Message

Date

vicrodh

8bd02e35d3

feat(qt): custom-theme editor, artist portrait, playlist rail, About/What's New and diagnostics

Five surfaces the Qt frontend was missing, landed together because they share
five wiring files (build.rs, main.rs, shell_bridge.rs, AppShell.qml,
HeaderBar.qml) and splitting them would produce commits that do not build.

ARTIST PAGE
- The Playlists section used a hand-rolled Rectangle delegate: a MouseArea with
  no onClicked, and a RoundedImage with no fit:, so the default crop blew an
  800x380 playlist banner up inside a 200x200 box and showed the middle 47% at
  2.1x. Replaced by the real cards/PlaylistCard.qml — already live on five other
  surfaces — mounted in a new views/PlaylistRail.qml modelled on SectionRail.
  ArtistPlaylist publishes the five roles the card reads.
- The portrait gains what the album cover has: the right-click menu the Slint
  reference already has (Add/Change/Remove image, Open in browser, Save as…) and
  the lightbox this port invented for albums and playlists. Custom images are
  keyed by artist NAME into the same custom_artwork.json the Slint build writes,
  so they round-trip between the two.
- CoverLightbox is now aspect-aware. It forced a square box on the premise that
  covers are square; artist portraits are not (1080x720 measured in the cache).
- Removing an override invalidates the pipeline's resolved path for that url:
  artwork_qt::cached_path consults the override FIRST, so coverMap held the
  custom file and the header kept showing the picture the user had just deleted.
- artwork_qt::local_path is the inverse of file_url. trim_start_matches("file://")
  is not: it leaves the percent-escapes in place, so any path holding % # or ?
  came back as a name that does not exist on disk.
- One new msgid, "View image", in the seven non-en locales — matching its sibling
  "View cover", since en carries none of that family and falls back to the msgid.

CUSTOM THEME
- The editor, the colour picker and the swatch grid, ported 1:1 from
  AppearanceSettings.slint and ColorPicker.slint. The 11 editable base tokens,
  their expansion into the full 55-value palette and the on-disk format all stay
  in the shared qbz-theme crate, so a theme authored in the shipping Slint build
  already rendered here and now round-trips both ways.
- Hue is normalised 0..1 at every Qt.hsva boundary; the reference stores 0..360,
  and porting the number instead of the domain would render every swatch red.
- The first-selection seed is captured BEFORE set_theme persists the slug,
  because current_slug() re-reads it from disk — a seed taken afterwards would
  resolve "custom", find no file and snapshot the default it was meant to replace.
- The in-memory base is dropped when the theme row enters "custom": it is
  memoized for the life of the process and filled at bridge construction, so a
  process that booted without the file would keep serving the OLED default even
  after the shipping Slint build wrote the user's theme.
- The disk write is debounced to drag-end and atomic; the reference persists on
  every drag frame with a truncating write, on a file the other build has open.

ABOUT + WHAT'S NEW
- Both modals, with their producers. render_markdown is transcribed line for line
  from the reference: h1 and h2 collapse to one level, an indent-0 bullet becomes
  a section plus a TOC entry, bold and backticks are stripped rather than styled.
  Text.MarkdownText is a different subset and would have rendered a different
  document from the same source. Pinned by tests, including the real 2.0.2 body.
- The codename is a single const, so the release checklist has one Qt-side place
  to bump.

DIAGNOSTICS
- The panel in Settings > Developer, the Report an Issue modal and its menu row.
- The log bundle carried eight hand-built header fields where the reference
  carries about seventy, so every issue filed from a Qt build arrived with no
  kernel, no distro, no install method, no GPU, no exclusive-mode / DAC /
  sample-rate state and no playback context. The report is injected INTO
  qbz_log::bundle rather than replacing it, keeping the <details> wrapper that
  makes a pasted bundle readable.
- The GTK / WebKit / GSK / GDK rows are CUT. In a Qt process those libraries are
  not mapped, so their runtime column can only read "—", and their saved column
  would come from a graphics.json this binary never reads or writes — foreign
  state presented as this app's configuration.

SHELL
- The four always-on-top overlays (toast, tooltip, art preview, immersive) relied
  on declaration order and carried no z, so any z-bearing modal buried them: a
  toast raised by a background event behind an opaque panel is never seen. They
  now sit in a band above the modals, keeping their relative order.
- build.rs asked cargo to watch ../../.git/HEAD, which does not exist in a git
  worktree (.git is a file). Cargo treats a missing rerun-if-changed target as
  always-dirty, so the whole build script — per-shader qsb, the recursive asset
  sweep, cxx-qt/moc codegen — re-ran on every cargo invocation.

Verified: cargo test -p qbz-qt 343 passed, cargo test -p qbz-library 83 passed,
qml_singleton_xref and qml_resolution_audit clean over 35 bridges and 265 QML
files, and qmlcachegen compiles every one of them. Smoke-tested by hand.

Contracts, recon and adversarial reviews:
qbz-nix-docs/qt-frontend/2026-08-14-six-item-round/

cc

2026-08-15 00:52:25 -06:00

vicrodh

a53e8a7af7

feat(qt): custom covers for playlists + the app-wide custom-art sweep

Two halves of one feature:

- Playlist custom covers (Qt-first; no Slint counterpart yet): the
  playlist header cover gets the cover menu (Add/Change/Remove) and the
  lightbox on left-click. The store is a NEW file,
  custom_playlist_covers.json — a `playlists` key inside the shared
  custom_artwork.json would be silently dropped the next time the Slint
  app wrote an override (its store round-trips only known keys). The
  override beats the playlist's own Qobuz graphic AND the member-cover
  mosaic on the header, the sidebar rows, the cards and the library
  grid.
- Album custom covers now apply everywhere, not just the album header:
  doc builders route an album's art URL through
  cover_artwork_qt::prefer_album_cover (the override's path flows
  through the ordinary artwork pipeline — artwork_qt::classify's
  LocalFile arm resolves it synchronously, no QML change). Swept: album
  page carousels (more-from-artist / suggestions / Last.fm similar),
  artist page releases, search result cards, and the playlist mosaics
  (a member album with a custom cover contributes THAT art to the
  collage tiles).

km

2026-08-11 01:38:18 -06:00

vicrodh

d9b1c26ff3

feat(qt): album page parity — cover menu + lightbox, header actions, album info modal

Four wired surfaces on AlbumView, all previously inert stubs:

- Cover menu (right-click, AlbumPageView.slint:300-370): Add/Change/Remove
  custom cover over the SAME custom_artwork.json store the Slint app uses
  (a cover set in one app shows in both), Open in browser, Save as…. Plus
  the NEW lightbox (menu entry + left-click): the art at its best available
  quality fitted to the window, custom override preferred.
- Header action row: radio (the existing foryou_qt album-radio seam),
  booklet (visible when a PDF goody exists; downloads via save-as — no
  in-app reader, like the reference), and add-to-mixtape/collection — the
  MyQBZ picker's Accepts engine already lets albums target Collections
  (the Tauri rule), so the button just feeds it.
- Album Info modal (the extensive one): fresh /album/get → credits grouped
  through the shared qbz_qobuz::performers parser, per-track copyright,
  review tab when the album has editorial text, label link, musician
  navigation, per-track play in album context. Tauri layout (left fixed
  meta column, right scrollable tabs) per the project ruling for this
  feature; the header's label link is wired along the way (LabelView has
  existed for a while — the POC-NOTE was stale).
- … menu: Add to playlist (the loaded view's track ids into the picker),
  Add to mixtape, Share Qobuz link, Share Album.link (UPC -> Deezer ->
  album.link, #514 path — the resolver half of share.rs is now ported for
  the album arm). The offline rows stay out: no Qt album-cache seam.

i18n: "View cover" + "Could not load the image" catalogued in all seven
locales. Gate: both QML audits + 305 tests + debug/release builds green.

km

2026-08-10 20:24:25 -06:00