Apply getDevicePrettyName translator to all audio devices in settings.
This provides user-friendly names for ALSA devices (e.g., 'USB: Topping D50s'
instead of 'hw:0,0') while preserving PipeWire's native descriptions.
Changes:
- Import getDevicePrettyName from audioDeviceNames utils
- Apply translator in deviceOptions derived state
- Create deviceByPrettyName map for reverse lookup
- Update handleBackendDeviceChange to use pretty name mapping
- Update loadAudioSettings to display pretty names
This solves the issue where Auto and ALSA Direct backends showed
cryptic device names while PipeWire showed friendly descriptions.
ALSA Direct Backend Implementation:
- Fully functional ALSA backend using CPAL's ALSA host
- Enumerates ALSA devices with hardware names
- Supports custom sample rates for bit-perfect playback
- Supports exclusive mode (device blocking)
- Smaller buffer size (512 samples) for lower latency in exclusive mode
- Clear error messages when device is in use
Smart Toggles in UI:
- Exclusive Mode auto-disabled with PipeWire/Auto backends
(PipeWire is multiplexed and cannot provide true exclusive access)
- Gapless Playback auto-disabled with DAC Passthrough
(bit-perfect requires recreating streams for sample rate changes)
- Toggle component now supports 'disabled' prop with visual feedback
- Tooltips updated to explain why features are disabled
- Auto-disable exclusive mode when switching to PipeWire backend
User Benefits:
- ALSA Direct now appears in backend dropdown
- True exclusive mode available with ALSA Direct
- Prevents confusing feature combinations
- Clear explanations via tooltips
- No more wondering why exclusive mode doesn't work with PipeWire
Technical Notes:
- ALSA backend uses CPAL host selection (not alsa-rs directly)
- Disabled toggles shown as grayed out with cursor: not-allowed
- Backend switching auto-adjusts incompatible settings
All API requests now go through Cloudflare Workers proxy.
User-provided credentials were collected but never used.
Removed:
- src-tauri/src/api_keys.rs (entire module)
- API Keys section from Settings UI
- ApiKeysState and related commands
- User credential parameters from providers
- Simplified DiscogsClient (removed with_user_credentials)
- Cleaned up imports and translations
Moved documentation:
- CHANGELOG-api-keys-refactor.md
- HANDOFF-MERGE.md
- MERGE-PREP.md
- POST-MERGE-CLEANUP.md
Moved to: qbz-nix-docs/feature-api-keys-refactor/
This cleanup reduces codebase by ~715 lines and removes
confusing UI that promised functionality that didn't work.
PREVIOUS WRONG APPROACH (commit 212aae5):
- Used pactl to enumerate devices (PipeWire sink names)
- Tried to open those sink names with CPAL
- CPAL couldn't find PipeWire sink names → fell back to default
- Attempted workaround: change system default with set_pipewire_default_sink
- UNACCEPTABLE: Changed system-wide default, affecting all apps
ROOT CAUSE (identified by ChatGPT research):
- CPAL can open specific devices by name (research was correct)
- BUT: Name mismatch between pactl sinks and CPAL device names
- pactl returns: "alsa_output.usb-Cambridge_Audio..." (PipeWire sink)
- CPAL sees: "DacMagic Plus Analog Stereo" (user-friendly name)
CORRECT SOLUTION:
- Use CPAL for BOTH enumeration AND opening devices
- CPAL device names are consistent: enumerate → save → find → open
- No need to change system default
- Device selection only affects QBZ
CHANGES:
1. Rewrote get_pipewire_sinks() on Linux to use CPAL instead of pactl
2. Removed all calls to set_pipewire_default_sink()
3. Pass CPAL device names directly to reinit_audio_device()
4. CPAL can now find and open devices because names match
BENEFITS:
- ✅ Device selection only affects QBZ (not system-wide)
- ✅ No regresions
- ✅ No features lost
- ✅ Works exactly like librespot (Spotify client in Rust)
- ✅ Consistent with rodio/CPAL architecture
TESTING REQUIRED:
1. Select Cambridge DAC in QBZ → audio plays through Cambridge
2. Open Firefox/other app → uses its own device (unaffected)
3. Toggle devices in QBZ → changes correctly
4. Restart QBZ → restores saved device
5. DAC passthrough bit-perfect → works
ROOT CAUSE:
CPAL/Rodio (the audio library) cannot open PipeWire sinks by name directly.
CPAL only sees ALSA device names like "default", "hw:0,0", etc., not
PipeWire sink names like "alsa_output.usb-Cambridge_Audio...".
When we tried to pass the PipeWire sink name to reinit_audio_device(), CPAL
couldn't find it and fell back to system default, ignoring user selection.
SOLUTION:
1. When user selects a device, set it as PipeWire default using pactl
2. Pass device: null to reinit_audio_device() (uses PipeWire default)
3. On app startup, restore saved device as PipeWire default
This works because:
- PipeWire's "default" sink can be changed programmatically
- CPAL can successfully open "default" device
- The default sink points to the user's selected device
TRADE-OFFS:
- QBZ changes the system-wide PipeWire default sink
- Other apps will also use this sink (unless they specify their own)
- This is unavoidable with CPAL - it's the only way to select a specific
PipeWire sink from Rust without using PipeWire/ALSA APIs directly
AFFECTED FUNCTIONS:
- handleOutputDeviceChange() - Sets sink as default when user selects device
- handleExclusiveModeChange() - Restores saved sink as default before reinit
- handleDacPassthroughChange() - Restores saved sink as default before reinit
- handleGaplessPlaybackChange() - Restores saved sink as default before reinit
- handleCrossfadeChange() - Restores saved sink as default before reinit
- loadAudioSettings() - Restores saved sink as default on app startup
PROBLEM:
When selecting an audio device in QBZ settings, the app was changing
the system-wide PipeWire default sink, affecting all applications.
ROOT CAUSE:
handleOutputDeviceChange() was calling set_pipewire_default_sink(),
which changes the PipeWire default for the entire system.
FIX:
Removed set_pipewire_default_sink() call. The backend reinit_audio_device()
already handles opening a specific device for QBZ without changing the
system default.
Now QBZ uses the selected device independently from the system default.
PROBLEM:
When user selected a specific audio device (e.g., Cambridge Audio DAC),
audio would always play through system default device (laptop speakers)
instead of the selected device.
ROOT CAUSE:
All calls to reinit_audio_device() were passing device: null instead of
the actual selected device name. When device: null is passed, the Player
falls back to system default regardless of user selection.
Affected functions:
- handleOutputDeviceChange() - Primary bug, selected device ignored
- handleExclusiveModeChange() - Reset to default when toggling
- handleDacPassthroughChange() - Reset to default when toggling
- handleGaplessPlaybackChange() - Reset to default when auto-disabling DAC
- handleCrossfadeChange() - Reset to default when auto-disabling DAC
FIX:
Created getCurrentDeviceSinkName() helper that:
- Returns the internal sink name for selected device
- Returns null only for "System Default" selection
- Used consistently across all audio setting changes
SECONDARY CHANGES:
Improved DAC Passthrough warning messages in AudioOutputBadges:
- "ERROR: PipeWire is resampling" instead of generic warning
- Clearer tooltip guidance for fixing resampling issues
- Better distinction between active/warning/disabled states
This ensures device selection persists across all audio setting changes
and provides clearer feedback when bit-perfect playback is compromised.
Tooltip improvements:
- Consolidate duplicate tooltips into single unified tooltip
- Show device info + DAC status + sample rate in one place
- Remove native 'title' attributes that were causing conflicts
- Add visual indicators (colored dots) for setting states
- Display resampling warning with actual rates when detected
- Better structured tooltip with sections
Mutual exclusion enforcement:
- Validate settings on load in loadAudioSettings()
- Auto-disable Gapless and Crossfade if DAC Passthrough is enabled
- Prevents invalid state from persisted settings
This fixes the issue where users could have incompatible settings
active simultaneously after app restart.
Backend changes:
- Add audio_diagnostics module to read actual hardware sample rate from /proc/asound
- New command get_hardware_audio_status() parses hw_params for real-time monitoring
- Add glob dependency for file pattern matching
Frontend (AudioOutputBadges):
- Implement 3-state DAC badge system:
- Green: DAC passthrough working correctly (rates match)
- Yellow: DAC passthrough ON but resampling detected (warning)
- Gray: DAC passthrough OFF (intentionally disabled)
- Dynamic tooltips showing actual hardware sample rate
- Compare file sample rate vs hardware sample rate
- Increase tooltip z-index to 9999 to prevent occlusion issues
- Add pointer-events: none to tooltip to prevent interaction issues
Frontend (SettingsView):
- Replace hardcoded "192 kHz" with dynamic hardware sample rate
- Load and display actual hardware audio status
- Show format details (e.g., S32_LE) when available
- Display "No active playback" when no audio is playing
- Add muted styling for inactive state
Frontend (QualityBadge):
- Add native tooltip showing tier and format
- Add cursor: help to indicate interactivity
i18n:
- Add "noActivePlayback" translations (EN/ES)
This allows users to verify bit-perfect playback is working and detect
resampling issues that would compromise audio quality.
Add auto-disable logic to prevent incompatible settings from being enabled simultaneously:
Frontend (SettingsView.svelte):
- DAC Passthrough ON → auto-disables Gapless Playback and Crossfade
- Gapless Playback ON → auto-disables DAC Passthrough
- Crossfade > 0 → auto-disables DAC Passthrough
- Added handleGaplessPlaybackChange() and handleCrossfadeChange() handlers
- Modified handleDacPassthroughChange() to disable incompatible settings
Backend (player/mod.rs):
- Only recreate OutputStream on format change when DAC passthrough is enabled
- When DAC passthrough is OFF: reuse existing stream for gapless transitions
- When DAC passthrough is ON: recreate stream for bit-perfect playback
- Added detailed logging for stream recreation decisions
This fixes the issue where Gapless Playback was enabled but gaps still occurred
due to DAC passthrough forcing stream recreation on sample rate changes.
The previous implementation tried to map ALSA device names (from cpal)
to PipeWire descriptions, but the naming schemes are completely different:
- cpal returns names like "plughw:1,0"
- pactl returns sink names like "alsa_output.usb-Cambridge_Audio_..."
This fix changes the approach:
1. Use PipeWire sinks directly for the device dropdown (already filtered
to real outputs and have friendly descriptions like "DacMagic Plus")
2. Store the PipeWire sink name when user selects a device
3. Set the PipeWire default sink using pactl when device is selected
4. Use rodio's default device (which follows PipeWire's default)
This ensures users see 4-5 meaningful devices with friendly names
instead of 30+ raw ALSA device names.
Backend changes:
- Add set_pipewire_default_sink command (pactl set-default-sink)
- Register new command in lib.rs
Frontend changes:
- Use pipewireSinks directly for device dropdown
- Display sink description (friendly name)
- Store sink name (for pactl)
- Call set_pipewire_default_sink when device changes
- Remove unused AudioDevice interface and getDevicePrettyName import
Immediate and Accumulated scrobbling cannot be enabled at the same
time, but both can be disabled. When one is turned on, the other
is automatically turned off.
- Fix offline settings database migrations to run individually
- Add network detection refresh when loading folder list
- Add network detection during folder scan
- Show folder alias with path tooltip in folder list
- Add folder path change capability in FolderSettingsModal
- Add network content visibility toggle in offline settings
- Add i18n strings for new features (en/es)
- Disable import playlists button when offline (shows disabled state)
- Add Cast, immediate scrobbling, and accumulated scrobbling toggles
- These settings only appear when manual offline mode is enabled
- Add time limit note for accumulated scrobbling (Last.fm 2 week limit)
- Persist new settings in SQLite with proper migrations
- Add i18n strings for all new settings (en/es)
The section refs were not reactive, so the derived array captured undefined
values at definition time. Changed to resolve refs at call time using a
getSectionEl() function instead of capturing them in a derived array.
- Add navigation bar below Account section with links to all sections
- Navigation becomes fixed at top when scrolling (sticky position)
- Active section highlighted with accent underline
- Hover state shows lighter underline for contrast
- Scroll tracking updates active section automatically
- Small text labels to fit all sections horizontally
- Change OfflinePlaceholder icon to use offline.svg instead of Power icon
- Add flex-shrink protection to Toggle component to prevent collapsing
- Add network verification when disabling offline mode:
- Check network connectivity before switching to online
- Show semi-transparent overlay during check
- Revert to offline and show toast if no internet available
- Add check_network Tauri command to verify connectivity
- Add i18n strings for noNetworkToast and checkingNetwork (en/es)
- Add Offline Mode section to SettingsView
- Display current offline status with reason
- Toggle for manual offline mode (Enable Offline Mode)
- Toggle for showing partial playlists in offline mode
- Subscribe to offlineStore for real-time status updates
- Add status indicator styling (green=online, yellow=offline)
cc
Artist biographies were being cached per locale but not refreshed
when user changed language settings. Now automatically clears artist
cache when language is changed to force refetch in new language.
cp
Implement user-consent migration system for legacy numeric-named FLAC files:
- Create MigrationModal component with progress tracking
- Auto-detect legacy downloads on settings mount
- Show modal with migration details and consent dialog
- Real-time progress updates via Tauri events
- Display success/failure stats after migration
- Refresh library and stats after completion
cc
Merge two separate Downloads sections into one unified section:
- Combine configuration (folder picker, library toggle)
- Combine statistics (track count, storage size)
- Combine actions (clear, open folder)
- Remove duplicate Downloads Section (Offline Storage)
- Use consistent labels without translations for new items
- Single cohesive Downloads section with all functionality
Now Downloads section contains:
- Download Folder configuration with Change button
- Downloaded Tracks statistics
- Show in Local Library toggle
- Clear Downloads button
- Open Folder button
cp
Add UI for configuring download folder location in Settings:
- Add downloadRoot state variable
- Add Downloads section in Settings with folder picker
- Move show_in_library toggle to Downloads section
- Add handleChangeDownloadFolder() function with dialog picker
- Validate path before applying
- Prompt to move existing downloads on path change
- Display current download folder path
- Use @tauri-apps/plugin-dialog for folder selection
- Fix property name (readyTracks vs ready_tracks)
Users can now configure where downloads are stored and
optionally move existing downloads to new location.
cp
Move download visibility toggle from LocalLibrary settings to general Settings view:
- Add showQobuzDownloadsInLibrary state in SettingsView
- Add loadDownloadSettings() function
- Add handleShowDownloadsChange() function
- Add toggle in Library section of Settings
- Remove toggle from LocalLibrary settings panel
- Remove toggleShowQobuzDownloads function from LocalLibrary
- Remove showQobuzDownloads state from LocalLibrary
- Restore settings-actions original flex layout
Qobuz downloads are now controlled from Settings > Library section,
not from LocalLibrary settings. LocalLibrary only handles hide/show
of individual albums.
cp
- Remove Compact Mode toggle (feature was not implemented)
- Remove Storage Limit dropdown from Downloads (always 2GB, not functional)
- Connect language dropdown to svelte-i18n system
- Language setting now properly persists and changes app locale
- Add comprehensive translations for en and es locales
- Settings view now uses $t() for all translatable strings
- Support for Auto language detection based on browser locale
- Add Library section in Settings with toggle for artist images
- Check localStorage setting before fetching images
- Enabled by default, persists user preference
- Split "Notifications" setting into "In-app Toasts" and "System Notifications"
- In-app toasts control the toast messages within the app
- System notifications control desktop notifications on track change
- Both settings persist to localStorage and load on app startup
- Migrates old 'qbz-notifications-enabled' key to new 'qbz-toasts-enabled'
feat(library): add stop scanning button
- Add library_stop_scan command in Rust backend
- Add cancel flag (AtomicBool) to LibraryState
- Check cancel flag during scan loop for both CUE and audio files
- Add "Cancelled" status to ScanStatus enum
- Add stop button in LocalLibraryView scan progress UI
- Button appears red on hover for clear visibility
cc
- Add api_keys module with store for user-provided credentials (Spotify, Tidal, Discogs)
- Add commands to get/set/clear credentials for each provider
- Update providers to check user credentials first (priority: user > embedded > env)
- Add collapsible API Keys section to SettingsView
- Show status badges (Active, Custom, Not configured) for each provider
- Store user credentials in localStorage with backend sync
- Add AudioOutputBadges component showing DAC/Exclusive mode status
- Badges are reactive to actual player state, not just settings
- Add device tooltip on hover showing current output device
- Create audioDeviceNames helper for ALSA name to friendly name mapping
- Use pretty names in Settings dropdown while storing raw names
- Add get_audio_output_status backend command
- Store current device name in player SharedState
- Player::new() now accepts optional device name
- Uses OutputStream::try_from_device() for specific device
- AppState reads saved device from audio settings on startup
- SettingsView loads/saves audio settings to backend
- Changes take effect on app restart
- Add support for build-time credentials via LASTFM_API_KEY/LASTFM_API_SECRET env vars
- Add lastfm_has_embedded_credentials command to check for embedded keys
- Add lastfm_open_auth_url command to open browser via native opener
- Simplify UI flow: if embedded credentials exist, just click Connect
- Add cancel button during authorization flow
- Clean up UI when waiting for user to authorize in browser
Settings:
- Add language dropdown (Auto, English, Español, etc.) with persistence
Last.fm:
- Create lastfm module with API client for authentication and scrobbling
- Add commands for auth flow, now playing, and scrobbling
- Full OAuth-style authentication with token exchange
- UI for entering API credentials and authorizing
- Automatic scrobbling after 50% of track or 4 minutes
- Update 'now playing' when tracks start
- Session persistence in localStorage
- Add get_audio_devices command to list available output devices
- Show real audio devices in Settings dropdown
- Persist streaming quality preference in localStorage
- Persist 'prefer highest available' setting
- Account section now shows real user name and subscription
- Logout button connected to logout handler
- Theme switching with persistence (Dark/Light/OLED Black/Warm)
- Theme loads on app startup from localStorage
- Cache stats display (size, max, track count)
- Clear cache functionality with disabled state
- Add app.css import to +layout.svelte (fixes broken/light UI)
- Add logging for audio debugging
- Add image fallbacks for album and track artwork
- Fix sidebar/main-content layout (flex-shrink, min-width)
- Remove placeholder data from HomeView
- Add LoginView and SearchView components
- Update window title and branding to QBZ