Commit Graph
5272 Commits
Author SHA1 Message Date
vicrodh 8ab8fc5dea fix(offline-cache): emit progress events from CMAF download path
The UI's offline-download progress ring listens to
'offline:caching_progress' events. The legacy StreamFetcher::fetch_to_file
emits those per HTTP chunk via app_handle. The new CMAF path went
silent because cmaf_download_raw lives in the qbz-qobuz crate with no
Tauri access — the user saw the completion toast but never saw the
ring fill.

Fix:
- Add an optional CmafProgressCallback to the qbz_qobuz::cmaf public
  API. Typed as Arc<dyn Fn(CmafProgressUpdate) + Send + Sync>.
- New download_full_with_progress and download_raw_with_progress
  variants; the callback-less versions delegate to them with None.
- fetch_all_segments fires the callback once per completed segment
  with cumulative (k, n, bytes_this_segment). Callback is invoked on
  the worker thread after the bytes land, before the rate-limit
  cooldown.
- try_cmaf_offline_download passes a callback that emits
  'offline:caching_progress' events in the exact shape the UI already
  expects (trackId, progressPercent 0..100, bytesDownloaded,
  totalBytes: null, status: 'downloading'). Also emits one
  zero-progress event up front so the ring doesn't sit at "queued"
  while the first segment fetches.

Percentage is computed as (segments_completed / n_segments) * 100,
rounded and clamped. It's segment-granular rather than byte-granular
so the ring advances in N discrete steps (typically 8-20 for a 4-min
track) rather than smoothly — matching what the CMAF pipeline can
actually observe, which is segment-complete events.

cc
2026-04-17 09:01:22 -06:00
vicrodh aa111e15b3 feat(offline-cache): route library playback through CMAF + full purge
Two loose ends after v2 landed:

1. Local Library integration. Qobuz-cached offline tracks already show
   up in the Local Library view (via insert_qobuz_cached_track_with_
   grouping with source='qobuz_download'). v2_library_play_track was
   reading track.file_path and doing std::fs::read() — that works for
   plain-FLAC v1 entries, but for v2 the path is the bundle directory,
   not a playable file. Fixed:
   - Extract the CMAF-load-and-decrypt logic into a shared module
     (offline_cache::playback::load_cmaf_bundle) used by both
     v2_play_track and v2_library_play_track.
   - v2_library_play_track checks source='qobuz_download' +
     cache_format=2 on the row and routes through the shared helper.
     Legacy v1 entries and regular user local files unchanged.

2. purge_all_cached_files. Previously deleted individual file_path
   entries only. For v2 the file_path points inside a track dir
   (segments.bin) — removing just that file orphans init.mp4 and
   manifest.json. Fixed:
   - When the file_path looks like tracks-cmaf/<id>/segments.bin
     (matched by the path shape, not a schema flag), remove the whole
     enclosing <id>/ directory.
   - Belt-and-suspenders: also delete the top-level tracks-cmaf/ dir
     after the per-row pass, so orphaned bundles from corrupted rows
     are swept up too.

Net: Local Library view preserves the "cached Qobuz tracks appear
here" UX, AND the 30-day grace wipe still removes every encrypted
segment + every library row in one atomic operation. No contradiction
between the two behaviors.

Also extends the compliance whitepaper with a section explaining the
Local Library integration so Franck's team can see that the wipe
contract isn't worked around by the UX shortcut.

cc
2026-04-17 08:53:13 -06:00
vicrodh b3ad548a9c feat(subscription-gate): extend offline grace window 3 → 30 days
Matches Qobuz's own mobile app posture. The previous 3-day window was
both user-hostile (punishes anyone on a flaky network) and a compliance
red flag (shorter windows read as 'we're hiding something', longer
windows read as 'we're lenient for a reason'). 30 days is the exact
parity answer.

The useful protection against bulk-download-and-ghost attacks comes
from the CMAF-at-rest offline cache (v2 format), not from aggressive
revalidation. This grace window is a belt over the suspenders.

Changes:
- GRACE_PERIOD_SECS: 3 → 30 days in config/subscription_state.rs, with
  a comment explaining the reasoning for future readers.
- Log message in session_lifecycle no longer says "3 days" (it quoted
  a constant, now says "grace window").
- Disclaimer string in all 5 locales (en/es/de/fr/pt) updated from
  "3 days" to "30 days" so the Offline Playback settings screen
  reflects the actual behavior.

No behavior changes for users with an active subscription. Users who
were within the old 3-day window don't lose cache — the window
extended, not contracted.

cc
2026-04-17 08:28:00 -06:00
vicrodh db6e7021ec feat(offline-cache): play v2 CMAF bundles from disk
Closes the playback side of the offline hardening. v2_play_track's
offline-cache-hit branch now queries the new CMAF bundle columns via
get_cmaf_bundle(), branches on cache_format:

- cache_format = 2 (new): read init.mp4 + segments.bin + manifest.json,
  unwrap the content_key through qbz-secrets, decrypt frames via the
  shared qbz_qobuz::cmaf::decrypt_segments_into, assemble into a
  plain-FLAC Vec<u8>, and feed it to player.play_data — exactly the
  same interface the player has always seen for cache hits.

- cache_format = 1 (legacy): unchanged — read the plain FLAC file at
  segments_path (the old file_path column) and play directly.

Any failure on the v2 path (missing init, wrong-size unwrap, decrypt
error, vault init failure) logs a warning and falls through to the
next cache tier (memory, disk playback cache) or the network — same
degradation model as a stale legacy entry.

load_cmaf_offline_bundle() is isolated in playback.rs so the hot
v2_play_track body stays readable; it owns the "convert a CmafBundleRow
from the DB into audio_data for the player" pipeline.

LoadedBundle in offline_cache/cmaf_store gets a decrypt_to_flac method
so the caller doesn't have to duplicate the "parse init + concat header
+ decrypt segments" dance the streaming path already does.

End-to-end for v2:
  download  → cmaf::download_raw → persist_bundle + wrap key → DB
  play      → get_cmaf_bundle   → read_bundle → unwrap key → decrypt

cc
2026-04-17 08:22:47 -06:00
vicrodh 8d9705dea0 feat(offline-cache): rewire download path to CMAF-first
Closes the last legacy /track/getFileUrl user-facing hole flagged by
the CMAF audit. spawn_track_cache_download now tries the CMAF path
first; only falls through to /track/getFileUrl if any of the CMAF
steps fail (no CoreBridge yet, /file/url returns a non-CMAF response,
network hiccup, SecretBox init failure, etc.).

On CMAF success the on-disk layout is:

    <offline_root>/tracks-cmaf/<track_id>/
        init.mp4        — unencrypted container with FLAC header
        segments.bin    — concatenated encrypted audio segments
        manifest.json   — segment offsets (belt-and-suspenders recovery)

The per-track AES content key and session infos are wrapped via
qbz-secrets::SecretBox before they touch the SQLite row
(content_key_wrapped, infos_wrapped columns from the previous commit).
cache_format flips to 2 on the row; the library-index entry lands
with the same title/artist/album the legacy path used, so the UI is
unchanged.

What is deliberately NOT done on the CMAF path:
- No write_flac_tags / embed_artwork: the bundle on disk is encrypted,
  writing FLAC tags would corrupt it. The library row carries the
  metadata the UI actually reads.
- No organize_cached_file: v2 bundles live under tracks-cmaf/<id>/
  by design, no per-artist/album tree (the files aren't standalone
  playable FLACs anyway).

Two new modules in src-tauri/src/offline_cache/:
- cmaf_store: persist/load/remove the on-disk bundle layout + the
  recovery manifest. I/O only, no crypto, no network.
- secret_vault: lazy SecretBox singleton scoped to the offline-root
  directory. The SecretBox handle is cached in OnceLock so every
  download shares the same keyring entry (or KDF master key).

Existing offline entries keep working — they're cache_format=1, so
they read from the plain-FLAC file_path unchanged. Playback-from-v2
comes in the next commit (task #20).

Legacy fallback still writes tags + organizes files exactly like
before. This keeps users whose v1 cache is still useful unblocked
while the v2 path takes over fresh downloads.

cc
2026-04-17 08:17:18 -06:00
vicrodh 935b3f81e0 feat(offline-cache): schema migration for v2 CMAF bundle storage
Adds columns to cached_tracks for the v2 format that stores Qobuz's raw
CMAF segments bit-identical on disk, with the per-track AES content key
wrapped via qbz-secrets (OS keyring or KDF fallback).

New columns (added via idempotent ALTER TABLE, safe to re-run):
- cache_format    INTEGER DEFAULT 1   — 1 = legacy plain FLAC (existing),
                                          2 = raw CMAF bundle (new)
- init_path       TEXT                — path to init.mp4 (FLAC header +
                                          segment table)
- content_key_wrapped BLOB            — wrapped 16-byte AES content key
- infos_wrapped       BLOB            — wrapped session infos salt
- format_id       INTEGER             — Qobuz format id (5/6/7/27)
- n_segments      INTEGER             — number of audio segments

Existing rows keep cache_format=1 and continue to play from the plain
FLAC at file_path — zero regression for users with populated caches
when the upgrade ships. New downloads will land as cache_format=2. The
two formats coexist until v1 rows age out naturally (user re-download
or subscription-lapse cache wipe).

Adds set_cmaf_bundle() / get_cmaf_bundle() helpers + a CmafBundleRow
struct so the download path and the playback path have one authoritative
DB surface to talk to.

Also adds qbz-secrets as a direct src-tauri dep so the next commit
(rewiring spawn_track_cache_download) can wrap keys right at the
download site.

cc
2026-04-17 07:30:50 -06:00
vicrodh 1743c9e5ec feat(secrets): add qbz-secrets crate for device-bound secret wrapping
Foundation for the offline-cache hardening story. The offline cache
needs to persist per-track AES content keys to disk, but storing them
plaintext would make copying the SQLite DB enough to decrypt the
cached audio on another machine.

qbz-secrets provides a uniform wrap/unwrap API backed by:

1. **OS keyring** (preferred): libsecret/gnome-keyring on Linux,
   Keychain on macOS, DPAPI on Windows. A 256-bit master AES key
   lives inside the OS secure store; all wraps go through it. This
   is the gold-standard device binding used by commercial music
   apps (Spotify, Apple Music, Tidal) for the same class of data.

2. **HKDF fallback**: when the OS keyring is not reachable (headless
   setups — Raspberry Pi, Docker, the future qbzd daemon on a
   server), the master key is derived on demand via HKDF-SHA256
   over service_name + machine_id + a persistent per-install UUID.
   Weaker than keyring (reversible by anyone with filesystem access
   to both sources) but still device-bound against cross-machine
   copy attacks, and lets daemon/headless variants work at all.

Every wrap uses AES-256-GCM with a fresh random 12-byte nonce. The
on-disk envelope carries a version byte + backend marker + nonce +
ciphertext+tag, so (a) we detect tampering via GCM, (b) we refuse to
silently unwrap a blob produced by a backend we can't reach, and (c)
we have a forward-compat path for future key rotation.

4 unit tests cover: small-secret round-trip, 16-byte content-key
round-trip (the exact CMAF use case), GCM tamper detection, and
nonce-randomness (two wraps of the same input differ).

This crate intentionally has zero QBZ dependencies — it's a generic
primitive. Next commits wire it into the offline cache schema + the
DB migration.

cc
2026-04-17 00:53:01 -06:00
vicrodh 391e797c9a refactor(cmaf): lift pipeline into qbz-qobuz + add download_raw
Prep work for offline-cache CMAF hardening. The full CMAF pipeline
(init-segment setup, full-download, decrypt) used to live in
src-tauri/src/commands_v2/helpers.rs — fine for playback but unreachable
from the offline-cache code without dragging Tauri deps around.

Moves:
- try_cmaf_full_download → qbz_qobuz::cmaf::download_full
- try_cmaf_streaming_setup → qbz_qobuz::cmaf::setup_streaming
- CmafStreamingInfo struct → qbz_qobuz::cmaf

Adds:
- qbz_qobuz::cmaf::download_raw + CmafRawBundle — fetches the same track
  but returns the ENCRYPTED segments + init bytes + the unwrapped
  content_key + the session infos, ready to be persisted to disk as-is.
  The offline cache will use this so that cached files are bit-identical
  to what Qobuz delivered (no decrypt-to-disk), with the content key
  stored separately under an OS-keyring-wrapped blob. Coming in next
  commits.
- qbz_qobuz::cmaf::decrypt_segments_into — shared decrypt helper used by
  download_full and (in the next commits) by the offline-playback path
  that reads encrypted segments from disk instead of CDN.

In-tree behaviour is unchanged: try_cmaf_full_download /
try_cmaf_streaming_setup in helpers.rs are now thin wrappers that hand
the CoreBridge's QobuzClient to the crate functions. Same API surface
for playback.rs callers, same log tags, same on-wire behaviour.

v2_cmaf_stream stays in src-tauri because it binds to qbz-player's
BufferWriter + qbz-cache's AudioCache — those are playback-only deps
that don't belong in qbz-qobuz.

Net: -100 LOC out of src-tauri, +390 LOC in a properly-layered crate
module with docs explaining the two variants and why the raw one exists.

cc
2026-04-17 00:46:31 -06:00
vicrodh 19fa779063 Merge branch 'feature/internal/label-endpoints-expansion' into pre-release
Expand label API coverage to the v9.7.0.3 Qobuz Android spec and
retire the legacy /label/get one-shot before Qobuz starts deprecating
endpoints with the web beta rollout.

- 7 new endpoints: getAlbums, getNextReleases, getAwardedReleases,
  getPlaylists, getTopArtists, story, getList (POST)
- Full stack: qbz-qobuz client + qbz-models + qbz-core + CoreBridge +
  v2 tauri commands + lib.rs registration
- LabelView + LabelReleasesView migrated to /label/page + /label/getAlbums
- Legacy /label/get + LabelDetail + v2_get_label purged; qbzd's
  /api/labels/{id} HTTP route recomposes the old shape internally
- Quality badge homologated: swept every track/album row (LabelView
  popular tracks, SearchView track rows ×2, PurchasesView album rows,
  PurchaseAlbumDetailView header, VirtualizedFavoritesAlbumGrid rows)
  to use formatQuality() text instead of the bulky <QualityBadge>.
2026-04-16 23:30:00 -06:00
vicrodh 56041235af style: homologate quality badge in all track/album rows
Sweep of remaining <QualityBadge compact> usages in row/list contexts.
Same fix as the label popular-tracks one: switch to the formatQuality
text representation so every row lines up visually.

Replaced in:
- SearchView.svelte — track rows in track tab & album tab
- PurchasesView.svelte — album list rows
- PurchaseAlbumDetailView.svelte — album metadata header (matches the
  text-only treatment already used by AlbumDetailView)
- VirtualizedFavoritesAlbumGrid.svelte — favorites album list rows

Kept as-is (the badge is a first-class visual element, not a text
indicator in a list):
- Player widgets — NowPlayingBar, ExpandedPlayer, ImmersiveControls,
  ImmersivePlayer
- Immersive visualizer panels (all 13)
- SearchView "Most Popular" promoted card
- AlbumReactivePanel

cc
2026-04-16 23:06:26 -06:00
vicrodh cdd02197ad style(label): homologate quality badge in popular tracks
LabelView's popular tracks section was rendering the <QualityBadge>
component with compact mode — same one we dropped elsewhere. Switch
to the formatQuality() text representation used by ArtistDetailView's
popular tracks so both views look identical.

Also align .track-quality CSS (font-size / color / min-width) with
ArtistDetailView's rules.

cc
2026-04-16 23:01:23 -06:00
vicrodh 6de109b3b8 refactor(labels): purge legacy /label/get stack
/label/get is gone from the Qobuz v9.7.0.3 Android app (source:
c30/b.java doesn't declare it anymore). With the Qobuz beta rollout
the server-side deprecation timer is probably running, so we yank our
dependency now.

Removed:
- LABEL_GET path constant (qbz-qobuz + src-tauri/api)
- get_label() client method (qbz-qobuz + src-tauri/api)
- get_label() wrapper in QbzCore + CoreBridge
- v2_get_label tauri command + its lib.rs registration
- LabelDetail backend type (qbz-models + src-tauri/api/models)
- commands::search::get_label (dead, was never registered)
- Unused LabelDetail import in src/routes/+page.svelte

Preserved:
- Frontend LabelDetail interface (it's a UI view-model shaped by
  LabelReleasesView, not a backend contract)
- /api/labels/{id} HTTP route on qbzd — now composes /label/page +
  /label/getAlbums internally so external HTTP clients still see the
  same { id, name, description, image, albums: { items, total, ... } }
  shape

cc
2026-04-16 22:59:31 -06:00
vicrodh df99e97d2a refactor(labels): migrate LabelView + LabelReleasesView off v2_get_label
LabelReleasesView now fetches /label/page (metadata) + /label/getAlbums
(paginated catalog) in parallel instead of hitting the legacy
/label/get one-shot. loadMore() paginates through /label/getAlbums.

LabelView's loadLabelAlbumsAndDescription() now only fetches the album
list via /label/getAlbums; the description comes exclusively from the
already-in-flight /label/page call (loadLabelPage).

Both views still present the same LabelDetail-shaped view-model;
nothing UI-visible should change. Prepares for deletion of the legacy
/label/get stack in the next commit.

cc
2026-04-16 22:50:39 -06:00
vicrodh 595b71e4eb feat(api): add 7 label endpoints from v9.7.0.3 spec
Closes the gap between our client and the Qobuz Android app's current
label API (source: c30/b.java). Qobuz is rolling out a web beta so the
legacy /label/get is likely on borrowed time — adding the v9.7.0.3
endpoints now so the migration can happen in follow-up commits.

New endpoints (paths + client + core + bridge + v2 command + registered):
- /label/getAlbums           → v2_get_label_albums
    paginated catalog with sort/order/genre_ids/from_date/to_date
- /label/getNextReleases     → v2_get_label_next_releases
- /label/getAwardedReleases  → v2_get_label_awarded_releases
- /label/getPlaylists        → v2_get_label_playlists
- /label/getTopArtists       → v2_get_label_top_artists
- /label/story               → v2_get_label_story
- /label/getList             → v2_get_label_list (POST, mirrors
    track/getList signing)

New response types in qbz-models:
- LabelListPage<T> — generic { has_more, items: [T], total?, offset?,
  limit? } envelope, tolerant to either V2 list or SearchResultsPage
  shapes until samples land
- LabelStoryResponse, LabelGetListResponse — best-effort with optional
  fields so a shape mismatch is non-fatal

The legacy /label/get + get_label() + v2_get_label + LabelDetail are
retained untouched for now; frontend migration and deletion come next.

cc
2026-04-16 22:48:38 -06:00
vicrodh e83caa7648 Merge branch 'feature/internal/local-library-multiselect-326' into pre-release
Fix #326 — multi-track selection in Local Library. Works on the tracks
tab and inside the album detail view (the more useful context per user
feedback). Bulk play next / play later / add to playlist.
2026-04-16 22:26:15 -06:00
vicrodh be70fd4eab Merge branch 'bugfix/internal/queue-shuffle-click-327' into pre-release
Fix #327 — clicking a track in the queue panel now plays that exact
track even under shuffle. Adds play_upcoming_at with shuffle-aware
index resolution, plus dead From-impl cleanup.
2026-04-16 22:26:06 -06:00
vicrodh 950b7829fd Merge branch 'bugfix/internal/sonarqube-promise-in-boolean' into pre-release
SonarQube quick wins + numeric/string globals modernization +
v2_search_all decomposition + AirPlay subsystem purge.
2026-04-16 22:25:56 -06:00
vicrodh a37d12f824 fix(local-library): multi-select button now works (#326)
The reset `$effect` was tracking its own writes. When the select-mode
button set `trackSelectMode = true`, the effect re-ran (because
`resetMultiSelect()` reads both `trackSelectMode` and `selectedTrackIds`
inside the effect body) and immediately cleared the state again — so
the button visibly did nothing.

Wrap the reset call in `untrack()` so the effect only rebinds on tab /
album changes, not on its own output.

cc
2026-04-16 21:40:26 -06:00
vicrodh 1c170bfd67 feat(local-library): multi-select inside album detail too (#326)
Extends the tracks-tab multi-select to the album detail view. User
requested this because it's actually more useful there (picking a
subset of an album's tracks for a playlist is the common case).

- Select toggle button added to the album-actions row (next to play /
  shuffle), using the same `action-btn-circle` style so it sits with
  the existing circular actions.
- TrackRow inside `albumSections` now receives `selectable`,
  `selected`, `onToggleSelect` — TrackRow already supports these, they
  were just not wired here.
- Same BulkActionBar rendered below the track list; the existing bulk
  handlers (`handleBulkPlayNext` / `handleBulkPlayLater` /
  `handleBulkAddToPlaylist`) were updated to look up selected ids from
  both `tracks` and `albumTracks`, so it works in either context.
- $effect watches `activeTab` and `selectedAlbum?.id`, clearing
  selection whenever the user switches tab or enters/leaves an album.
  Prevents stale selection bleeding across views.

cc
2026-04-16 21:35:38 -06:00
vicrodh 261676550c feat(local-library): multi-track selection on tracks tab (#326)
Mirrors the pattern already used in FavoritesView so users can select
multiple local tracks and bulk-add them to the queue (play next / play
later) or to a playlist — the same way it works for Qobuz favorites
and playlists.

- New `trackSelectMode` + `selectedTrackIds` state + handlers (toggle
  mode, toggle row, bulk play next/later, bulk add to playlist).
- New `SquareCheckBig` toolbar button on the tracks tab (matches the
  one in FavoritesView).
- VirtualizedTrackList wired with `selectable`, `selectedIds`,
  `onToggleSelect` props (already supported, just unused here).
- `<BulkActionBar>` rendered below the list when selection is active.
- New `onBulkAddToPlaylist` prop, wired in +page.svelte to
  `openAddToPlaylist(trackIds, true)` so the existing playlist picker
  modal handles the rest.
- Bulk play next/later go through `cmdAddTracksToQueue` /
  `cmdAddTracksToQueueNext` (route to qbzd when remote, otherwise local
  bulk command). Plex tracks are filtered out only for "add to
  playlist" (per existing per-row guard); they're fine in the queue.

cc
2026-04-16 20:16:02 -06:00
vicrodh 5656bbe2ab fix(queue): clicking a track respects shuffle order (#327)
The frontend was resolving queue-panel clicks via
`actualIndex = current_index + trackIndex`, mixing the unshuffled
canonical position with the shuffle-aware display position. On shuffle
mode, the resulting index pointed at a different track than the one
the user clicked, which is exactly what issue #327 reports.

Solution:
- New `QueueManager::play_upcoming_at(upcoming_index)` resolves the
  click position through `shuffle_order` + `shuffle_position` when
  shuffle is on, and falls back to `current_index + upcoming_index + 1`
  otherwise.
- Exposed through `QbzCore::play_upcoming_at` (emits QueueUpdated) and
  `CoreBridge::play_upcoming_at`.
- New `v2_play_queue_upcoming_at` tauri command.
- `QueuePanel.onPlayTrack` now carries the `originalIndex` so the
  caller knows the exact upcoming-list position the user clicked.
- `handleQueueTrackPlay` calls the new command directly — no more
  client-side index arithmetic.

Also deletes the two dead `From<crate::queue::QueueTrack>` impls in
commands_v2/queue.rs (canonical queue lives in qbz-player now), per
the zero-legacy V2 policy.

Tests: two new unit tests cover the linear and shuffle-aware paths.
Session persistence is untouched — the new method only consults
existing state.

cc
2026-04-16 20:04:24 -06:00
vicrodh edededcf8c chore(cast): remove AirPlay subsystem (dead code)
AirPlay was scaffolded in both crates/qbz-cast/src/airplay and
src-tauri/src/cast/airplay but never worked at runtime: the RAOP
sender required an Apple MFi-licensed stack with no free/open
alternative, and the backend state was already disabled via the
commented `.manage(airplay_state)` line in src-tauri/src/lib.rs.
The CastPicker UI already hid the AirPlay tab pending streaming
support that was never going to ship.

Delete:
- crates/qbz-cast/src/airplay/        (entire directory)
- src-tauri/src/cast/airplay/         (entire directory)
- 10x v2_airplay_* commands from commands_v2/library.rs + their
  tauri::generate_handler entries
- AirPlayError from qbz-cast errors
- 'airplay' from CastProtocol + every case arm in castStore.ts,
  CastPicker.svelte, AudioOutputBadges.svelte
- Corresponding i18n keys if present

Zero behavior change for Chromecast / DLNA / QConnect / MPRIS. If
AirPlay ever becomes feasible we'll revisit from scratch with a
real streaming backend.

cc
2026-04-16 19:04:56 -06:00
vicrodh 27ab2c8bea refactor(search): decompose v2_search_all (Sonar S3776 — complexity 44 -> <15)
Split the monolithic v2_search_all command (44 cognitive complexity,
critical on Sonar) into four small single-purpose helpers:

- parse_results_page<T>(response, key, limit) — generic DeserializeOwned
  accessor that replaces four copy-pasted .get().and_then().unwrap_or
  blocks returning an empty SearchResultsPage.
- filter_page<T, F>(page, keep) — closure-based retain-with-total-
  adjustment that replaces three near-identical post-filter blocks.
- most_popular_from_item(item, blacklist) — per-item match over the
  three supported types; each arm is a flat parse + single blacklist
  check, no nested continues.
- pick_most_popular(response, blacklist) — traverses the items array
  via find_map, replacing the deeply-nested and_then/for/match/return
  stack that tripped the cognitive-complexity threshold.

Semantics are preserved: same filter criteria (including the track
"no performer" edge case), same skip-on-blacklist behaviour, same
return shape. v2_search_all itself is now ~30 lines, each helper is
<15 complexity.

cc
2026-04-16 18:39:57 -06:00
vicrodh 416ac513fd chore(code-quality): modernize numeric/string globals (Sonar S7773/S7781/S7758)
Replace bare globals with their Number.* / String.prototype namespace
equivalents across 11 frontend files:

- parseInt / parseFloat / isNaN  -> Number.parseInt / Number.parseFloat / Number.isNaN
- str.replace(/foo/g, x)         -> str.replaceAll('foo', x)
- str.charCodeAt(i)              -> str.codePointAt(i)

Closes 32 Reliability-impacting Sonar issues. Semantics preserved:
Number.* are strict-mode friendly; .replaceAll matches literal strings
without regex escaping; codePointAt returns BMP-equivalent values for
the ASCII paths we use (no surrogate data).

cc
2026-04-16 18:25:51 -06:00
vicrodh 719566cfb2 fix(code-quality): SonarQube quick wins (bugs + hotspots)
Bugs (3, all same pattern): Promise-typed variables were used as
boolean conditions, which is always truthy regardless of the resolved
value. Make the nullness check explicit:

- src/lib/services/imageCacheService.ts:36 (Map.get result)
- src/lib/stores/awardCatalogStore.ts:108  (inflight Promise|null)
- src/lib/stores/windowControlsStore.ts:228 (detectInFlight)

Hotspots:
- playerStore.test.ts, queueStore.test.ts: http -> https in test
  fixtures (harmless in-memory fixtures, but keeps the linter quiet)
- playbackTargetStore.ts:30: replaced the trailing-slash trim regex
  with a bounded while-endsWith loop to drop the ReDoS warning
- playlistSuggestionsService.ts:181 & trackActions.ts:551: kept
  Math.random for shuffle/seed (non-cryptographic by design); added
  explanatory comments and marked the Sonar hotspots as SAFE.

Closes Reliability delta from 3.0 (C) to 1.0 (A) on next scan.

cc
2026-04-16 18:04:27 -06:00
vicrodh 6775d3a474 docs(release): restructure 1.2.7 notes — one-line preamble + 1.2.6 body
Per the original instruction: single line for 1.2.7 + the full 1.2.6
body (which already carries the 1.2.5 content below it). The previous
version over-expanded the 1.2.7 section into three paragraphs.

cc
2026-04-16 14:37:59 -06:00
vicrodh b17c72d7ff chore(nix): set srcHash + npmHash for v1.2.7 flake
Resolved via two `nix build` iterations against the v1.2.7 tag.
Users tracking main get a zero-friction build; users pinning to the
v1.2.7 git tag still need to substitute the hashes themselves since
the hashes were unknown at tag time (same as every prior release).

cc
2026-04-16 14:34:53 -06:00
vicrodh ab31f6de97 fix(tray): use final matte-vinyl logo with blue rim for tray icon
The v1.2.6 regenerated tray glyphs were monochrome outlines of the Q:
the selection logic (prefer_dark_tray() -> dark-variant) picks
tray-dark.png on dark panels, which rendered as a black Q on dark
bg (issue visible in Plasma on emerge qbz-bin install).

Switch to a full-colour render of the final icon.svg (matte-vinyl
disc + blue rim + inner highlight). Full-colour rim gives definition
on both light and dark panels, so one PNG works for every variant:
the three tray files (tray.png, tray-light.png, tray-dark.png) now
point to the same render and the selection logic becomes a no-op.

cc
2026-04-16 12:34:24 -06:00
vicrodh 5dc2a26e1c fix(security): demote infinite-radio session_id log to debug level
CodeQL rust/cleartext-logging (alert #69) flagged the info-level log
that prints the radio session id on creation. The value is only
useful for local troubleshooting; demote to debug! so it stays out
of default-level logs (same treatment as the qbzd user_id logs).

cc
2026-04-16 12:12:47 -06:00
vicrodh 7b2b58a5d0 chore(deps): bump rand 0.9.2 -> 0.9.3 to fix GHSA-cq8v-f236-94qc (0.9.x line)
The 0.10.x advisory was fixed in v1.2.7 by bumping 0.10.0 -> 0.10.1.
The same advisory also applies to 0.9.x with a separate patched
version (0.9.3). Applying the bump to both lockfiles so the alerts
for the transitive 0.9.x deps close too.

cc
2026-04-16 12:08:14 -06:00
vicrodh 4d7fb8a4a4 Merge pre-release into main for v1.2.7 'Accolade Watch (diagnostics + carousel fix)' 2026-04-16 12:03:29 -06:00
vicrodh 2a870e619a chore(release): bump version to 1.2.7 + release notes
Bumped:
- src-tauri/Cargo.toml + Cargo.lock
- src-tauri/tauri.conf.json
- package.json + package-lock.json
- snapcraft.yaml
- flake.nix (qbzVersion, hashes cleared for nix users to regenerate)

Added:
- packaging/flatpak/com.blitzfc.qbz.metainfo.xml (1.2.7 entry)
- docs/release-1.2.7/TAG_DETAILS.md (release notes — 1.2.7 preamble
  on top of the full 1.2.6 + 1.2.5 content)

cc
2026-04-16 12:03:18 -06:00
vicrodh 16af395356 feat(report-issue): confirmation modal with logs redirect + opt-out
Settings menu > Report Issue now opens a modal instead of jumping
straight to the GitHub new-issue page. The modal explains that
sharing the (manually masked) logs speeds up triage and offers two
actions:

- Go to logs → navigates to Settings > Developer Mode and
  auto-opens the Logs modal so the user can review and upload.
- Create issue report → opens the GitHub issues page.

A persistent "Do not show this again" checkbox stores the preference
in localStorage (qbz-hide-report-issue-modal). When the flag is set,
the menu item skips the modal and goes straight to GitHub, matching
the previous behaviour.

Wiring: new settingsIntentStore lets UserCard cue SettingsView to
open at the `developer` section with showLogsModal=true, consumed and
cleared on mount so a plain Settings navigation afterwards uses the
normal default section.

i18n: new reportIssue block added to all 5 locales (en/es/de/fr/pt).

cc
2026-04-16 11:47:49 -06:00
vicrodh 9e79334dc4 fix(ui): primary button ring down to 1px (both resting and hover)
cc
2026-04-16 11:36:17 -06:00
vicrodh 668681f795 fix(ui): invert primary action button normal vs hover
New resting state (= previous hover):
  fill     --accent-hover
  glyph    --text-primary
  ring     --text-primary (2px)

New hover state (= previous resting):
  fill     --accent-primary
  glyph    --accent-hover
  ring     --text-primary (2px)

Ring colour/thickness stays constant across both states; only fill
and glyph flip.

cc
2026-04-16 11:33:20 -06:00
vicrodh 0641b50263 revert(ui): resting ring back to --text-primary
Reverts the trial from 047b192a. Ring is --text-primary again; glyph
stays --accent-hover.

cc
2026-04-16 11:32:36 -06:00
vicrodh 047b192a8f chore(ui): primary button resting ring shares glyph colour (trial)
Both the resting glyph and the 2px inset ring now use --accent-hover,
matching the requested "test" direction. Hover unchanged.

cc
2026-04-16 11:32:04 -06:00
vicrodh 48a3fd9f7a fix(ui): primary button glyph uses hover fill colour in resting state
Glyph colour in normal/inactive state is now var(--accent-hover) —
i.e. the same colour the button fills to on hover. Explicit color:
var(--text-primary) on the hover rule to keep the hover path intact
after inverting the resting glyph colour.

cc
2026-04-16 11:31:09 -06:00
vicrodh be4c84e54f fix(ui): primary button resting ring matches hover (only fill differs)
Per design direction: normal/inactive state of .action-btn-circle.primary
now uses the exact same stroke as the hover state (2px inset
--text-primary). The sole visual difference between resting and hover
is now the background fill (--accent-primary vs --accent-hover).

cc
2026-04-16 11:29:22 -06:00
vicrodh 5f7cb55063 revert(ui): full rollback of action-btn-circle tweaks from this session
Revert the four commits that touched .action-btn-circle since 1.2.6:
- d673dc20 thicken stroke 1->2px (3px primary)
- a9eaf646 thicken only resting stroke of primary
- eb9f82ea bump primary resting stroke to 5px
- 5a52ef55 switch primary to real border

All rules back to their pre-1.2.6-release state. Awaiting a new
direction from the user.

cc
2026-04-16 11:27:00 -06:00
vicrodh 5a52ef5588 fix(ui): primary play button uses real border instead of inset shadow
Inset box-shadow renders the circular stroke as a stair-stepped /
hairline edge on WebKitGTK — no matter how thick we set it, sub-pixel
AA eats most of it and on HiDPI it disappears entirely. Switch the
primary .action-btn-circle to an actual 5px border with
box-sizing: border-box so the outer dimensions stay 44x44 but the
stroke is rasterised through border AA (which respects border-radius
cleanly).

Also swap --border-subtle for --alpha-40 so the ring has guaranteed
contrast against the accent colour in every theme.

Secondary buttons and is-active stay on inset box-shadow — they're
thinner and the background contrast is higher there, so the shadow
path still reads fine.

cc
2026-04-16 11:25:01 -06:00
vicrodh 321c87f353 feat(logs): opt-out toggle to bundle diagnostics into terminal paste
Settings > Developer Mode > View Logs now has a toggle (default ON,
persisted to localStorage as qbz-paste-bundle-diagnostics) that
prepends the full System Diagnostics snapshot plus a 10-second cast
scan to the terminal paste upload, so bug reporters share one link
instead of two. Console-tab uploads are unaffected.

- New service module diagnosticsSnapshot.ts centralises the snapshot
  payload (runtime + system + playback + qconnect + optional cast
  scan) so the panel and the paste flow don't drift apart.
- LogsModal shows "Collecting diagnostics..." while the scan is
  running, then "Uploading..." once it hands off to the paste server.

Also revert the auto-run cast scan on the diagnostics panel: bundling
into the paste covers the "one-shot bug report" use case, and the
panel opens instantly again.

cc
2026-04-16 11:20:50 -06:00
vicrodh d5e3fff45c feat(diagnostics): add OS / distro / install method / deps section
New v2_get_system_info command and matching UI section in the
System Diagnostics panel. What it reports:

- os (linux/macos/windows)
- arch (x86_64, aarch64)
- kernel_version from /proc/sys/kernel/osrelease
- Linux distro: id, version_id, pretty_name from /etc/os-release
  (falls back to /run/host/os-release so it works inside Flatpak)
- install_method: flatpak / snap / appimage / dev / native, detected
  via FLATPAK_ID + /.flatpak-info, SNAP, APPIMAGE env vars, and
  debug_assertions as the last fallback
- flatpak_runtime + version: parsed from /.flatpak-info
- loaded library versions (from /proc/self/maps, symlink-resolved):
  webkit2gtk-4.1, gtk-3 (or 4), glibc, alsa, pipewire, pulseaudio

All info is derived from local files/env; no sensitive data, no IDs,
no hashes. Included in the clipboard export.

cc
2026-04-16 11:14:26 -06:00
vicrodh 85057589e6 fix(diagnostics): volume %, auto cast scan, snapshot-on-demand track
- Volume: playerStore.getVolume() already returns 0-100, the extra *100
  was reporting "10000%". Just Math.round() the stored value.
- Cast scan: run automatically the first time the panel is opened so
  the user doesn't have to press the button. Button now doubles as
  "re-scan" while disabled during an in-flight scan. A spinner
  placeholder shows while the initial scan is in progress.
- Track info: capture a single snapshot on open/refresh instead of
  live-subscribing to the player store — live updates were unnecessary
  for a diagnostic dump and slowed the settings page. Use "Refresh"
  to take a fresh snapshot.

cc
2026-04-16 11:08:07 -06:00
vicrodh d9b1efc091 feat(diagnostics): add Playback, Qobuz Connect, and Cast Discovery
Extend the System Diagnostics panel with three new sections aimed at
what debug tickets usually ask for, and include them in the clipboard
export:

- Playback: is-playing, volume, position/duration, current track
  (title, artist, album, source, local flag, quality/format/bit-depth/
  sample-rate). No track IDs or UUIDs — defensive regex redacts any
  hex/UUID-shaped strings before export so paste sites and CodeQL
  don't flag them as secrets.

- Qobuz Connect: running/transport_connected, role (controller /
  local-renderer / observer / none), active renderer friendly
  name/brand/model (no UUIDs or IPs), visible renderer count, last
  error (id-redacted).

- Cast Discovery: on-demand 10-second multicast scan for Chromecast
  and DLNA; reports per-protocol count and the friendly names that
  were discovered. No hosts, no ports, no UUIDs.

Playback rows stay live via a player-store subscription while the
panel is open.

cc
2026-04-16 11:05:07 -06:00
vicrodh eb9f82ea96 fix(ui): bump primary resting stroke to 5px for visibility
3px was still not enough against a low-contrast --border-subtle ring.
Push it to 5px so the stroke is unmistakable at default resolution
and survives HiDPI scaling.

cc
2026-04-16 10:48:57 -06:00
vicrodh a9eaf64612 fix(ui): thicken only the resting stroke of the primary action button
Previous commit bumped every stroke state to the same thickness. The
hover and secondary-button states were fine; only the primary's
resting stroke (using --border-subtle, a low-contrast colour) read as
jagged from sub-pixel AA and disappeared on HiDPI.

Revert secondary buttons, is-active, and primary-hover to their
original 1-2px. Keep the primary resting state at 3px so it survives
AA at the default resolution and stays visible on HiDPI.

cc
2026-04-16 10:48:37 -06:00
vicrodh d673dc206a fix(ui): thicken action-btn-circle stroke from 1px to 2px (3px primary)
The 1px inset stroke on .action-btn-circle read as jagged at standard
resolution (sub-pixel antialiasing artifacts) and effectively invisible
on HiDPI displays. Bump the resting stroke to 2px (secondary) and 3px
(primary play button) so it survives both; hover states scale with it
to keep the visual hierarchy. The extra pixels eat slightly into the
concentric fill, per the requested trade-off.

Applies to all reuse sites: Album/Artist/Playlist/Label/FavQ detail
headers, DynamicSuggest, ForYouTab, LocalLibrary, etc.

cc
2026-04-16 10:46:53 -06:00
vicrodh 0d852410f2 fix(carousel): disable text selection in horizontal rows
The previous CSS only disabled user-select while .dragging was active,
but the drag class only gets applied after crossing the 5px threshold
in onPointerMove. During those first few pixels the browser's default
selection behaviour would highlight card titles and artist names,
which the user then has to click away to clear.

Disable user-select on the scroll-container permanently. Text is
still selectable in the album/artist/playlist detail views — only the
carousel rows themselves are locked.

cc
2026-04-16 10:42:43 -06:00
vicrodh f4738669a6 Merge feat/window-title-metadata into pre-release
Includes:
- feat(window): optional track metadata in window title (#324)
- fix(window,login): grant set-title capability + shrink login logo 20%
- fix(cast): keep scanning spinner visible for the full discovery window
2026-04-16 10:26:30 -06:00