Commit Graph
5734 Commits
Author SHA1 Message Date
vicrodh 4210ec088a fix(playback): honor the streaming-quality setting
The Settings streaming-quality dropdown persisted the pref but playback used a hardcoded UltraHiRes const, so the setting did nothing. Resolve the pref (via a new streaming_quality_for_key mapping to the Quality format ids) at playback time for the normal, prefetch and gapless paths. Resolves #590.

cc
2026-07-13 00:19:51 -06:00
vicrodh c85686c473 feat(media-controls): inhibit system sleep/idle while playing (Linux)
QBZ let the machine suspend mid-playback. Take an org.freedesktop.login1 Inhibit (sleep:idle, block) fd while the MPRIS status is Playing and drop it on pause/stop, hooked to the same play-state channel MPRIS already uses. Linux-only, all failures log-and-continue. Resolves #522.

cc
2026-07-13 00:19:51 -06:00
vicrodh b3f866d933 fix(audio): treat D-Bus device-reservation name failure as non-fatal
Under Snap's mediated session bus, requesting the org.freedesktop.ReserveDevice name is denied and the error aborted ALSA Direct stream creation, so there was no audio. Fall back to the existing Degraded state (proceed without the reservation) on acquire failure, reusing the same non-fatal path the card-index / no-bus cases already take. Audio sample path untouched. Resolves #534.

cc
2026-07-13 00:19:51 -06:00
vicrodh 3174488d8e fix(renderer): classify Intel UHD 600 (Gemini Lake) as weak -> GL tier
It flickers on the wgpu tier; the reporter confirmed QBZ_RENDERER=gl fixes it. Added the uhd-600 markers to WEAK_GPU_MARKERS so it auto-selects the stable GL renderer. Resolves #578.

cc
2026-07-13 00:19:51 -06:00
vicrodh 256b0d36a0 fix(volume): kill the slider rubberband on release
The live-drag thumb reverted to the round-tripped bound value on release; because that value echoes back asynchronously the thumb snapped to the stale position then to the fresh one (a rubberband bounce). The thumb now tracks drag-fraction, which stays put on release and re-syncs to the external value only when it changes on its own (MPRIS / keyboard) while not dragging.

cc
2026-07-13 00:19:51 -06:00
vicrodh a0cca35810 fix(volume): live drag state on the slider primitives so the thumb follows the pointer
The de-quantization (0.1% scale + f32-bits atomic) removed the stepping in the VALUE, but the thumb still derived from the round-tripped bound value, so it felt snappy/laggy during a drag. Give QbzSlider/QbzVerticalSlider a live drag fraction: while held, the thumb tracks the pointer position directly (continuous, no round-trip); on release it reverts to the bound value. The emitted value is still the nearest step to the pointer (round), now imperceptible at the 0.1% scale.

cc
2026-07-12 23:38:34 -06:00
vicrodh e369f4bb3a chore(issue-template): require a logs checklist on bug reports
Adds a prominent 'bug reports need logs' banner and a required pre-flight checklist (attach logs or explain why not, searched duplicates, included repro steps). Without logs most reports stall on needs-info.

cc
2026-07-12 20:17:12 -06:00
vicrodh 42105eaf46 fix(volume): make the volume control fully fluid (de-quantize)
Volume snapped between 1% steps from two integer quantizers. UI: the volume sliders now use a 0..1000 scale so the shared int slider's round() lands on 0.1% (imperceptible). Runtime: the player volume atomic widened from integer-percent AtomicU64 to f32-bits AtomicU32 (same idiom as normalization_gain) so a continuous value no longer re-snaps on track restart / device switch / gapless. Bit-perfect untouched: 1.0f32 round-trips its bits, no gain multiply or ramp added to the protected ALSA-direct / DoP / JACK paths.

cc
2026-07-12 20:17:12 -06:00
vicrodh 2103bbd3eb feat(playlist): drag-and-drop reorder for custom-order tracks
Adds a dedicated drag HANDLE (grip) in the reorder gutter with the queue's drag gesture (6px threshold, absolute-position - root.y correction, three end paths incl. the changed-pressed safety net), so the row-body drag-to-sidebar stays intact. PlaylistView keeps component-local reorder state (slot math folds in the ListView viewport-y), a drop indicator and a floating ghost; commit fires PlaylistActions.reorder-track(from,to). Rust reuses the arbitrary-index persist path (repo::reorder for local, persist_custom for Qobuz) the arrows already back. Edge auto-scroll during drag is a follow-up TODO. Resolves #589.

cc
2026-07-12 20:17:12 -06:00
Victor RH 02cf9ad011 Merge pull request #586 from afonsojramos/bugfix/internal/cast-csprng-tokens
fix(cast): use CSPRNG media path tokens and redact URIs in logs
2026-07-12 19:40:03 -06:00
Victor RH 22a69a1db8 Merge pull request #585 from afonsojramos/bugfix/internal/dop-write-errors
fix(player): stop DoP writer on ALSA write failure
2026-07-12 19:40:00 -06:00
Victor RH db2f21289c Merge pull request #584 from afonsojramos/bugfix/internal/seek-engine-restore
fix(player): clear playing state when seek rebuild fails
2026-07-12 19:39:57 -06:00
Victor RH 287c3e93b5 Merge pull request #583 from afonsojramos/bugfix/internal/cancel-superseded-play
fix(player): cancel superseded play_track completions
2026-07-12 19:39:54 -06:00
Victor RH b99598e122 Merge pull request #582 from afonsojramos/bugfix/internal/log-redaction-all-sinks
fix(log): redact secrets on stderr and stop Last.fm body dumps
2026-07-12 19:39:51 -06:00
Victor RH 7fcbe1255a Merge pull request #581 from afonsojramos/bugfix/internal/queue-clear-keep-current
fix(queue): keep current_index track on clear(true)
2026-07-12 19:39:47 -06:00
Victor RH 9352a498a7 Merge pull request #574 from afonsojramos/ci/test-crates
ci: add test-crates workflow for workspace unit tests
2026-07-12 19:39:44 -06:00
vicrodh f4a6858f6b merge: kiosk profile (2.0.2 frente #3) into pre-release
Lightweight kiosk shell — profile boot (windowed default, fullscreen opt-in),
immersive mount, Now Playing redesign, Search All dashboard, lyrics lite-fill,
plus the owned-playlists Library fix.

cc
2026-07-12 19:39:17 -06:00
vicrodh d61b59223e fix(favorites): show owned playlists in the Library playlists tab
load_favorites built the Playlists Library sub-tab only from locally-hearted ids and the Following list excludes owner.id == uid, so the user's own playlists appeared nowhere. Seed the Library list with owned playlists first, then hearted-but-not-owned (dedup). Fixes desktop and kiosk.

cc
2026-07-12 19:38:43 -06:00
vicrodh ec8c487564 feat(lyrics): lite-fill display pref — static active-line highlight to cut CPU
The per-word karaoke sweep animates a clip rect ~60x/s, driving continuous full-window repaints (~4% CPU). Lite fill highlights the active line whole (no per-frame animation) so the surface only repaints on line changes. New toggle in the lyrics controls flyout, persisted via lyrics_prefs; default off (smooth karaoke). Kiosk / weak-GPU tiers force it on via ShellState.reduce-motion.

cc
2026-07-12 19:38:43 -06:00
vicrodh 5fa4e8bdd5 feat(kiosk): redesign Now Playing panel — dominant contain cover, compact meta, floating quality stamp
The cover is image-fit:contain filling the flex art area (no fragile parent-geometry math), so it is large and scales with the window. Toggle and meta rows get vertical-stretch:0 so only the art area takes the slack (nested layouts stretch greedily) — kills the dead space and the ~55px cover. Title toned to 20px, quality stamp floats on the transport row instead of owning a line. Cover<->Lyrics toggle; lyrics fill the panel width.

cc
2026-07-12 19:38:43 -06:00
Afonso Jorge Ramos 0ff3fc7f40 fix(scrobble): host delay gate in qbz-app for unit testing
Extract scrobble_delay_secs so cargo test -p qbz-app covers unknown
duration without compiling the Slint binary.
2026-07-13 00:08:18 +02:00
Afonso Jorge Ramos 41daffdf71 fix(scrobble): do not scrobble when track duration is unknown
duration_secs == 0 used to arm an immediate scrobble; skip delayed
scrobble instead while still allowing now-playing when online.
2026-07-13 00:01:11 +02:00
Afonso Jorge Ramos 7e824bd65a fix(offline): place download size validator at module scope 2026-07-12 23:57:18 +02:00
Afonso Jorge Ramos f507b5c214 fix(offline): reject truncated downloads when Content-Length is known
Fail closed on short bodies and empty payloads so partial files never
become complete cache entries.
2026-07-12 23:56:59 +02:00
Afonso Jorge Ramos 19b1c2bead fix(cmaf): fail closed on invalid session-key seed hex
Reject odd length and non-hex digits instead of zero-filling bad nibbles.
2026-07-12 23:33:14 +02:00
vicrodh 5be0e2233a feat(kiosk): hide NPB layout/lyrics/queue controls; layout button toggles Desktop mode
In kiosk the layout-flyout would carry a single Desktop mode row that the fixed-height popup floats high above the button, so the layout button toggles straight to Desktop mode instead. Lyrics/Queue toggles are hidden (their panels aren't mounted in the kiosk shell; the queue lives in Now Playing).

cc
2026-07-12 13:07:40 -06:00
vicrodh 772fe42df2 feat(kiosk): Search "All" dashboard — most-popular hero + per-type previews
All is no longer a flat album grid: a polymorphic most-popular hero (artist/album/track) plus Artists/Albums/Tracks(6)/Playlists previews, each with a View all that jumps to that tab. Reads SearchState verbatim, mirroring the desktop hierarchy.

cc
2026-07-12 12:43:56 -06:00
vicrodh dabf4a88c8 feat(kiosk): Now Playing — queue/history tabs, cover<->lyrics toggle with synced follow
Left panel toggles cover/synced lyrics (reuses LyricsLinesView, gated on status==2 to dodge the geometry recursion footgun); right panel is a Queue/History list (Flickable+VerticalLayout so rows top-anchor). The lyrics-sync engine bailed unless a desktop/immersive surface was open, so a kiosk-lyrics-follow flag on ShellState widens lyrics_surface_open().

cc
2026-07-12 12:43:56 -06:00
vicrodh 8cdf26cd34 perf(kiosk): window the album grid so only visible cards mount
cc
2026-07-12 12:43:56 -06:00
vicrodh 26f9e3e1a2 feat(kiosk): shell — mount immersive overlay, hide transport on Now Playing, fixed footer, drop Search tile
The immersive overlay hangs inside AppShell, so the kiosk shell mounts its own copy. The transport bar is hidden on Now Playing (redundant there) and the content height no longer subtracts it then, so the NavRail stays pinned. Footer Search tile removed — the back-bar carries a persistent search field.

cc
2026-07-12 12:43:56 -06:00
vicrodh 67d81ea415 feat(kiosk): boot windowed by default, fullscreen opt-in via QBZ_KIOSK_FULLSCREEN
Forcing fullscreen at kiosk boot trapped the user with no way out (Esc/F11 don't leave it, the kiosk shell has no titlebar control). Fullscreen is now opt-in for a real appliance image; the persisted-kiosk-profile case opens in a normal window.

cc
2026-07-12 12:43:56 -06:00
Afonso Jorge Ramos a0bf1328d6 fix(cast): use CSPRNG media path tokens and redact URIs in logs
Replace RandomState-based tokens with getrandom, avoid logging full
media base URLs, and redact /audio/<token>/… in DLNA info logs.
2026-07-11 23:01:05 +02:00
Afonso Jorge Ramos 3dc54a751d fix(player): stop DoP writer on ALSA write failure
Match the PCM ALSA path: on write_dop_i32 Err, stop the writer thread
instead of logging and advancing position (which desyncs DoP markers).
2026-07-11 23:01:05 +02:00
Afonso Jorge Ramos 101490043d fix(player): cancel superseded play_track completions
Bump a play generation on each play intent so a slow CMAF/legacy fetch
cannot apply AudioCommand::Play after the user has already started another
track. play_data still bumps generation for standalone offline/cache calls.
2026-07-11 23:01:04 +02:00
Afonso Jorge Ramos 12a278fc28 fix(player): clear playing state when seek rebuild fails
After current_engine.take(), seek error paths used to return with no
engine while is_playing stayed true. Abort now sets stream_error and
stops the playing flag so the UI cannot show silent "playing".
2026-07-11 23:01:04 +02:00
Afonso Jorge Ramos 66e6efeffd fix(log): redact secrets on stderr and stop Last.fm body dumps
TeeLogger no longer forwards the original Record to env_logger (which
bypassed redaction). Register restored OAuth tokens for literal scrubbing,
and never debug-log the auth.getSession response body.
2026-07-11 23:01:04 +02:00
Afonso Jorge Ramos acc033915e fix(queue): keep current_index track on clear(true)
truncate(1) always preserved tracks[0], so Clear queue mid-album left the
wrong now-playing row. Keep the track at current_index and remap history
by id so removed rows do not leave stale indices.
2026-07-11 23:01:04 +02:00
vicrodh c36cea7445 feat(kiosk): lightweight KioskLocalLibrary + KioskMyQBZ views
KioskLocalLibrary (tabs Albums/Artists/Folders/Tracks, reading
LocalLibraryState, driving LocalLibraryActions; open-album routes to the
local-album detail) and KioskMyQBZ (Mixtapes/Collections tabs over
MyQbzState, MyQbzActions.open-card). Both reuse the shared kiosk cards/grid
+ ListView for tracks. Wired onto the local-library / mixtapes / collections
routes. With this every kiosk content view is the light version. Validated
via slintcheck. (v1: no album-window / tracks-load-more hooks yet.)

cc
2026-07-11 08:39:38 -06:00
vicrodh 9041b0e749 feat(kiosk): forward nav, window chrome, NPB gating, list windowing
- Add the forward nav button beside back (NavState.can-forward/request-forward).
- The kiosk back bar owns the window chrome (no HeaderBar): macOS leaves the
  ~78px traffic-light inset, Linux frameless draws the custom WindowControls
  on the right. OS-agnostic (the kiosk is not restricted to any platform).
- Hide ALL NPB view modes not compatible with kiosk (New/Classic/Small/Large
  + Miniplayer + Immersive) while in the kiosk profile; only the profile
  toggle remains.
- Track lists (Library/Search) use ListView so only the visible band mounts
  — the plain VerticalLayout spiked CPU on entry, which a Pi cannot afford.

cc
2026-07-11 08:16:24 -06:00
vicrodh 6032791be4 feat(kiosk): Now Playing centerpiece + NPB miniplayer/immersive consistency
KioskNowPlaying: a 50/50 full screen (big cover + title/artist + AudioStamp
+ SeekBar + the reused 7-control TransportControls on the left, the Up-Next
queue on the right), reading NowPlayingState/QueueState and calling
QueueState.panel-opened() on init. New ContentView.now-playing route; the
NavRail Now Playing tile navigates there instead of opening immersive. Also
hide the Miniplayer + Immersive items from the NPB view menu while in the
kiosk profile (todos o ninguno) so it is not a second-window/overlay mix.
Validated via slintcheck.

cc
2026-07-10 21:38:57 -06:00
vicrodh f1d965b04e feat(kiosk): live Kiosk<->Desktop toggle in the NPB layout menu
Add a "Kiosk mode" / "Desktop mode" item to both PlayerBarSmall and
PlayerBar view menus (label from the new ShellState.kiosk-profile flag).
It fires media-action("npb-view","","toggle-profile"); Rust flips the
persisted ui_prefs.profile and swaps the shell in place via set_screen
(KioskShell/AppShell share state, so no restart). The toggle keys off the
current screen, not kiosk_profile_active(), so a QBZ_PROFILE env override
doesnt pin it. ShellState.kiosk-profile is seeded at window setup.

cc
2026-07-10 21:17:12 -06:00
vicrodh dc51c62c7f feat(kiosk): add Local Library + MyQBZ tiles, center NavRail icons
NavRail grows to 8 tiles (Discover, Library, Local Library, MyQBZ, Search,
Now Playing, Visualizer, Settings) routing through the same header-menu
routes. Also center each tile's icon: a fixed-size Image does not center
itself in a VerticalLayout, so wrap it in a centering HorizontalLayout.

cc
2026-07-10 20:34:49 -06:00
vicrodh ad9a23bab6 feat(kiosk): lightweight KioskAlbum + KioskArtist detail views
Replace the reused AlbumPageView/ArtistPageView on the kiosk album/artist
routes with Pi-light detail: KioskAlbum (cover + title + tappable artist +
Play/Shuffle + number/title/duration track list, reading AlbumState) and
KioskArtist (round portrait + Play/Radio + discography as KioskCard shelves
per release section, skipping the \"other\" bucket, reading ArtistState). Both
bind the shared state so covers push in. Validated via slintcheck.

cc
2026-07-10 19:54:56 -06:00
vicrodh 172dbf8eb6 fix(kiosk): position NavRail tiles manually so they distribute
Layout-based attempts (child stretch, mount stretch, explicit HL width) all
left the tiles collapsed to icon width packed on the left. Position the 6
tiles by absolute x + explicit width derived from root.width instead; the
rail width comes from the KioskShell VerticalLayout, so the tiles now span
the panel evenly.

cc
2026-07-10 19:49:50 -06:00
vicrodh 45cbe24206 feat(kiosk): lightweight KioskSearch + KioskLibrary views
Replace the heavy reused SearchResultsView and FavoritesView on the kiosk
search/favorites routes with Pi-light versions built from the shared kiosk
cards: KioskAlbumGrid (wrapping grid of KioskCard), KioskArtistCard (round),
KioskTrackRow. KioskSearch tabs All/Albums/Tracks/Artists/Playlists reading
SearchState; KioskLibrary tabs Tracks/Albums/Artists/Playlists/Labels reading
FavoritesState. Both bind the shared models so the artwork pipeline pushes
covers in with no request hook (album covers windowed = first ~60 for now).
Validated via slintcheck.

cc
2026-07-10 19:21:48 -06:00
vicrodh f27d5e864c fix(kiosk): pin NavRail row to root.width so tiles distribute
The tiles still collapsed to the bottom-left even with per-tile
horizontal-stretch: a HorizontalLayout nested in the rail's VerticalLayout
was taking its preferred (content) width, not the rail width. Drop the
wrapper, make the tile row an explicit width: root.width child with the
hairline as an overlay, and the 6 tiles now spread evenly across the panel.

cc
2026-07-10 19:21:48 -06:00
vicrodh ce2db8cb54 feat(kiosk): lightweight KioskDiscover with simple cards
Replace the heavy reused HomeView on the kiosk home route with a Pi-light
Discover: KioskCard (square art + quality badge + title + artist, tap-to-
open, no hover/context-menu chrome) in horizontal shelves, reading the SAME
DiscoverState model so the artwork pipeline pushes covers in with no request
hook. Tab pill (Home/Editor's Picks/For You). First of the mockup-matching
lightweight views; also guards single-key hotkeys while typing in the kiosk
search field. Validated via slintcheck.

cc
2026-07-10 18:39:24 -06:00
vicrodh 01311db29c fix(kiosk): stretch NavRail tiles across the full width
The tiles collapsed to icon width, packed bottom-left with truncated labels
(a horizontal-stretch set only on the child component root is not honored by
the parent layout). Set horizontal-stretch at each mount site + fill the rail
height so the 6 tiles distribute evenly as full-height touch targets.

cc
2026-07-10 18:39:24 -06:00
vicrodh dc32cafbd5 fix(kiosk): resolve is_creating_mini() at window setup
The P0 kiosk block read a creating_mini local that only exists inside
select_slint_backend(); at the main-window setup site it is out of scope.
Call crate::miniplayer::is_creating_mini() directly (same source the backend
hook uses) so the qbz bin compiles. Confirmed: the kiosk shell builds
(release) and launches.

cc
2026-07-10 17:21:53 -06:00
vicrodh 93e523f51b feat(kiosk): QBZ_KIOSK_NO_FULLSCREEN dev escape hatch
Skip fullscreen-at-boot when QBZ_KIOSK_NO_FULLSCREEN is set so the kiosk
layout can be previewed in a normal window (the kiosk shell exposes no
titlebar control to leave fullscreen). reduce-motion still applies.

cc
2026-07-10 16:39:06 -06:00