fix: eliminate double-brain session lifecycle (legacy vs V2)
Backend: - v2_auto_login/v2_manual_login now FAIL if activate_session fails (was: log and continue with success:true, causing "logged in but not ready") - Session activation is now REQUIRED, not optional Frontend: - Remove duplicate activate_user_session call from handleLoginSuccess (V2 login already activates session internally) - Remove duplicate deactivate_user_session call from handleLogout (v2_logout already deactivates session internally) - LoginView now uses runtime_bootstrap as SINGLE SOURCE OF TRUTH (was: v2_init_client + legacy is_logged_in/get_user_info checks) - PlaylistDetailView uses runtime_get_status for user_id (was: legacy get_current_user_id) This eliminates the "double-brain" where frontend used both legacy and V2 paths, causing state divergence and intermittent failures.
This commit is contained in:
1 parent
59e3141aa6
commit
deece54bcb
4 files changed
+81
-102
No files matched your search
@@ -394,9 +394,18 @@ pub async fn v2_auto_login(
|
||||
}
|
||||
|
||||
// Activate per-user session (initializes all per-user stores)
|
||||
// This is REQUIRED - without it, user has auth but no stores, causing UserSessionNotActivated errors
|
||||
if let Err(e) = crate::session_lifecycle::activate_session(&app, session.user_id).await {
|
||||
log::error!("[V2] Session activation failed: {}", e);
|
||||
// Non-fatal - consider login successful, stores can be initialized later
|
||||
return Ok(V2LoginResponse {
|
||||
success: false,
|
||||
user_name: Some(session.display_name.clone()),
|
||||
user_id: Some(session.user_id),
|
||||
subscription: Some(session.subscription_label.clone()),
|
||||
subscription_valid_until: session.subscription_valid_until.clone(),
|
||||
error: Some(format!("Session activation failed: {}", e)),
|
||||
error_code: Some("session_activation_failed".to_string()),
|
||||
});
|
||||
}
|
||||
|
||||
// Emit ready event
|
||||
@@ -504,9 +513,18 @@ pub async fn v2_manual_login(
|
||||
}
|
||||
|
||||
// Activate per-user session (initializes all per-user stores)
|
||||
// This is REQUIRED - without it, user has auth but no stores, causing UserSessionNotActivated errors
|
||||
if let Err(e) = crate::session_lifecycle::activate_session(&app, session.user_id).await {
|
||||
log::error!("[V2] Session activation failed: {}", e);
|
||||
// Non-fatal - consider login successful, stores can be initialized later
|
||||
return Ok(V2LoginResponse {
|
||||
success: false,
|
||||
user_name: Some(session.display_name.clone()),
|
||||
user_id: Some(session.user_id),
|
||||
subscription: Some(session.subscription_label.clone()),
|
||||
subscription_valid_until: session.subscription_valid_until.clone(),
|
||||
error: Some(format!("Session activation failed: {}", e)),
|
||||
error_code: Some("session_activation_failed".to_string()),
|
||||
});
|
||||
}
|
||||
|
||||
// Emit ready event
|
||||
|
||||
Reference in new issue
Block a user