From ddedca1b5e8bd2d89f5b410bedf890aebbdfcd64 Mon Sep 17 00:00:00 2001 From: vicrodh <103399283+vicrodh@users.noreply.github.com> Date: Wed, 25 Feb 2026 20:57:30 -0600 Subject: [PATCH] chore: fix remaining Rust warnings - Allow dead_code on TokenValidationResponse.code (deserialized but not read) - Remove unused MusicProvider import in commands_v2.rs - Restore #[allow(non_snake_case)] on v2_plex_cache_get_tracks - Replace drop(tokens) with let _ = tokens (drop on reference is no-op) --- crates/qbz-integrations/src/listenbrainz/models.rs | 1 + src-tauri/src/api/client.rs | 4 ++-- src-tauri/src/commands_v2.rs | 2 -- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/qbz-integrations/src/listenbrainz/models.rs b/crates/qbz-integrations/src/listenbrainz/models.rs index 9be5be863..7331a0f9c 100644 --- a/crates/qbz-integrations/src/listenbrainz/models.rs +++ b/crates/qbz-integrations/src/listenbrainz/models.rs @@ -116,6 +116,7 @@ pub struct UserInfo { /// Token validation response #[derive(Debug, Deserialize)] +#[allow(dead_code)] pub struct TokenValidationResponse { pub code: i32, pub message: String, diff --git a/src-tauri/src/api/client.rs b/src-tauri/src/api/client.rs index 0723b9666..736024e7a 100644 --- a/src-tauri/src/api/client.rs +++ b/src-tauri/src/api/client.rs @@ -196,7 +196,7 @@ impl QobuzClient { "OAuth private key not available — bundle may be outdated".to_string(), ) })?; - drop(tokens); + let _ = tokens; // Step 1: Exchange code for token via /oauth/callback let callback_url = endpoints::build_url(paths::OAUTH_CALLBACK); @@ -294,7 +294,7 @@ impl QobuzClient { .ok_or_else(|| ApiError::BundleExtractionError("Client not initialized".to_string()))? .app_id .clone(); - drop(tokens); + let _ = tokens; let user_login_url = endpoints::build_url(paths::USER_LOGIN); let mut headers = HeaderMap::new(); diff --git a/src-tauri/src/commands_v2.rs b/src-tauri/src/commands_v2.rs index 4e2aeb5eb..650a8e5f6 100644 --- a/src-tauri/src/commands_v2.rs +++ b/src-tauri/src/commands_v2.rs @@ -1993,8 +1993,6 @@ async fn resolve_via_odesli_and_search( bridge: &State<'_, CoreBridgeState>, runtime: &State<'_, RuntimeManagerState>, ) -> Result { - use crate::playlist_import::providers::MusicProvider; - let provider_name = provider.map(|p| format!("{:?}", p)); // 1. Get title + artist: try direct platform API first (fast), fall back to Odesli