From d731805ecaf620feb87fd640a3aa9aea190791c3 Mon Sep 17 00:00:00 2001 From: vicrodh <103399283+vicrodh@users.noreply.github.com> Date: Fri, 16 Jan 2026 06:18:32 -0600 Subject: [PATCH] refactor(playlists): unify track row appearance and add remove option - Move local track indicator from quality column to favorite button position for consistent row alignment with Qobuz tracks - Remove explicit delete button from playlist track rows (was easy to accidentally click) - Add "Remove from playlist" option to TrackMenu for all tracks (local and Qobuz) - Qobuz track removal uses playlist_track_id from API response - Clean up unused CSS and imports from PlaylistDetailView cc --- src/lib/components/TrackMenu.svelte | 22 +++++- src/lib/components/TrackRow.svelte | 30 ++++---- .../views/PlaylistDetailView.svelte | 76 +++++-------------- 3 files changed, 55 insertions(+), 73 deletions(-) diff --git a/src/lib/components/TrackMenu.svelte b/src/lib/components/TrackMenu.svelte index 7c0302f9b..f7f3527b9 100644 --- a/src/lib/components/TrackMenu.svelte +++ b/src/lib/components/TrackMenu.svelte @@ -11,7 +11,8 @@ Share2, Disc3, User, - Link + Link, + Trash2 } from 'lucide-svelte'; interface Props { @@ -20,6 +21,7 @@ onPlayLater?: () => void; onAddFavorite?: () => void; onAddToPlaylist?: () => void; + onRemoveFromPlaylist?: () => void; onShareQobuz?: () => void; onShareSonglink?: () => void; onGoToAlbum?: () => void; @@ -32,6 +34,7 @@ onPlayLater, onAddFavorite, onAddToPlaylist, + onRemoveFromPlaylist, onShareQobuz, onShareSonglink, onGoToAlbum, @@ -49,7 +52,7 @@ let submenuStyle = $state(''); const hasPlayback = $derived(!!(onPlayNow || onPlayNext || onPlayLater)); - const hasLibrary = $derived(!!(onAddFavorite || onAddToPlaylist)); + const hasLibrary = $derived(!!(onAddFavorite || onAddToPlaylist || onRemoveFromPlaylist)); const hasShare = $derived(!!(onShareQobuz || onShareSonglink)); const hasNav = $derived(!!(onGoToAlbum || onGoToArtist)); const hasMenu = $derived(hasPlayback || hasLibrary || hasShare || hasNav); @@ -205,6 +208,12 @@ Add to playlist {/if} + {#if onRemoveFromPlaylist} + + {/if} {/if} {#if hasLibrary && (hasShare || hasNav)} @@ -333,6 +342,15 @@ color: var(--text-primary); } + .menu-item.danger { + color: #ef4444; + } + + .menu-item.danger:hover { + background-color: rgba(239, 68, 68, 0.1); + color: #ef4444; + } + .separator { height: 1px; background-color: var(--bg-hover); diff --git a/src/lib/components/TrackRow.svelte b/src/lib/components/TrackRow.svelte index e8d9a27ea..7fa93c2b4 100644 --- a/src/lib/components/TrackRow.svelte +++ b/src/lib/components/TrackRow.svelte @@ -40,6 +40,7 @@ onPlayNext?: () => void; onPlayLater?: () => void; onAddToPlaylist?: () => void; + onRemoveFromPlaylist?: () => void; onShareQobuz?: () => void; onShareSonglink?: () => void; onGoToAlbum?: () => void; @@ -176,17 +177,14 @@
{duration}
-
- {#if isLocal} - - - - {/if} - {quality ?? ''} -
+
{quality ?? ''}
- - {#if !hideFavorite} + + {#if isLocal} +
+ +
+ {:else if !hideFavorite}