fix(reco): Weekly rows resolve fast, cache per-week, show per-row skeletons
Discover > Recommendations Weekly Exploration/Jams kept vanishing and loaded slowly. Three root causes: - Weekly track resolution ran every track through MusicBrainz's serial 1.1s/req rate limiter (~110s for 100 tracks), so the rows never painted in practice (Fresh Releases, album-based with no MusicBrainz, returned fine). Resolve weekly tracks via fuzzy Qobuz search instead (skip_mb) -- fast and reliable for these mainstream playlists. - The external-reco cache was only initialized on the offline entry path; the two online login paths (auth.rs) never bound it, so nothing cached online (0-byte db). Initialize it there too. - Weeklies were bundled in the shared 48h results blob keyed only on auth-presence. Give them their own per-week cache (keyed by the ListenBrainz playlist mbid, 9d TTL, written only when non-empty, with a stale-fallback to the last good week) and rebuild them independently of the blob, so a transient empty build cannot hide them. Skip the 7d negative cache for weekly tracks so a throttle does not lock a row empty. Per-row skeletons: the progressive paint now marks each expected row pending at spawn and clears it as its builder resolves, so a slow row shows its own skeleton instead of silently missing. Adds [reco] diagnostics. cc
This commit is contained in:
8 files changed
+563
-48
No files matched your search
@@ -68,3 +68,96 @@ export component HomeSkeleton inherits VerticalLayout {
|
||||
SkeletonRow { phase: root.phase; }
|
||||
SkeletonRow { phase: root.phase; }
|
||||
}
|
||||
|
||||
// ── Standalone per-row skeletons (Discover > Recommendations) ───────────────
|
||||
//
|
||||
// Each owns its breathing Timer so it can drop into a layout in place of a row
|
||||
// whose builder has not resolved yet. Shapes mirror the real rows: a card
|
||||
// carousel (artists/albums) and a slim 4-wide track grid (Weekly playlists).
|
||||
|
||||
// Card-carousel placeholder: title bar + a row of card blocks (art + 2 lines).
|
||||
export component SkeletonCarouselRow inherits VerticalLayout {
|
||||
in property <length> card-size: 180px;
|
||||
property <bool> phase: false;
|
||||
spacing: 12px;
|
||||
|
||||
Timer {
|
||||
interval: 900ms;
|
||||
running: true;
|
||||
triggered => {
|
||||
root.phase = !root.phase;
|
||||
}
|
||||
}
|
||||
|
||||
Shimmer {
|
||||
phase: root.phase;
|
||||
width: 180px;
|
||||
height: 22px;
|
||||
}
|
||||
HorizontalLayout {
|
||||
spacing: 24px;
|
||||
for _ in [0, 1, 2, 3, 4, 5]: VerticalLayout {
|
||||
spacing: 8px;
|
||||
Shimmer {
|
||||
phase: root.phase;
|
||||
width: root.card-size;
|
||||
height: root.card-size;
|
||||
}
|
||||
Shimmer {
|
||||
phase: root.phase;
|
||||
width: root.card-size * 0.7;
|
||||
height: 14px;
|
||||
}
|
||||
Shimmer {
|
||||
phase: root.phase;
|
||||
width: root.card-size * 0.45;
|
||||
height: 12px;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Slim-grid placeholder: title bar + a 4-column x 3-row grid of slim row
|
||||
// blocks, matching SlimCarousel's 4x3 layout (the Weekly Exploration/Jams rows).
|
||||
export component SkeletonSlimRow inherits VerticalLayout {
|
||||
property <bool> phase: false;
|
||||
spacing: 12px;
|
||||
|
||||
Timer {
|
||||
interval: 900ms;
|
||||
running: true;
|
||||
triggered => {
|
||||
root.phase = !root.phase;
|
||||
}
|
||||
}
|
||||
|
||||
Shimmer {
|
||||
phase: root.phase;
|
||||
width: 180px;
|
||||
height: 22px;
|
||||
}
|
||||
HorizontalLayout {
|
||||
spacing: 8px;
|
||||
for _ in [0, 1, 2, 3]: Shimmer {
|
||||
phase: root.phase;
|
||||
height: 60px;
|
||||
horizontal-stretch: 1;
|
||||
}
|
||||
}
|
||||
HorizontalLayout {
|
||||
spacing: 8px;
|
||||
for _ in [0, 1, 2, 3]: Shimmer {
|
||||
phase: root.phase;
|
||||
height: 60px;
|
||||
horizontal-stretch: 1;
|
||||
}
|
||||
}
|
||||
HorizontalLayout {
|
||||
spacing: 8px;
|
||||
for _ in [0, 1, 2, 3]: Shimmer {
|
||||
phase: root.phase;
|
||||
height: 60px;
|
||||
horizontal-stretch: 1;
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user