fix(qt): Shift and Ctrl work on every select-mode click target, not only the row body
Excel-style selection (750c59034) read the modifiers only where a row BODY took the click. Every other target a select-mode surface draws dropped them, so a Shift-click there was a plain toggle: - the track row's checkbox disc passed Qt.NoModifier; - QbzCheckbox and SelectCheck emitted toggled() with no argument, so the Library album rows, the local album rows and the folder rows, which already expected `function (mods)`, received undefined; - AlbumCard emitted selectToggled() with no argument, and the paged local albums grid (299dcde5b) spelled the drop out as Qt.NoModifier. Some targets were never selection targets at all: in select mode the artist and album names on a track row, the artist and label on a Library album row and the artist line of an album card still navigated, leaving the page and the selection mid-gesture. The row links stand down in select mode so the click reaches the row body with its modifiers, and the card's artist line toggles like its artwork and title. A hover-only tooltip on the pulled but cached glyph no longer eats the row's click. Reproduced on the release binary in a nested KWin with injected input: in Local Library Tracks, the checkbox discs of rows 1, Shift 4 and Ctrl 6 selected 3 rows; the same clicks on the row bodies selected 5. No list view, Flickable or wheel code changes; tst_wheel passes unchanged. tst_multi_select clicks each of these targets through the real TrackRow, AlbumListRow, AlbumCard, QbzCheckbox and SelectCheck. cc
This commit is contained in:
12 files changed
+360
-23
No files matched your search
@@ -304,8 +304,11 @@ Rectangle {
|
||||
id: artistArea
|
||||
anchors.fill: parent
|
||||
// Only a real artist id is clickable — otherwise the
|
||||
// pointer promises a page that cannot open.
|
||||
enabled: (root.item.artistId || "") !== ""
|
||||
// pointer promises a page that cannot open. In select
|
||||
// mode the whole row selects (Shift / Ctrl included), so
|
||||
// the name stops being a link and the click falls to the
|
||||
// row body underneath.
|
||||
enabled: !root.selectMode && (root.item.artistId || "") !== ""
|
||||
hoverEnabled: true
|
||||
cursorShape: Qt.PointingHandCursor
|
||||
onClicked: QbzArtist.openArtist(root.item.artistId)
|
||||
@@ -331,7 +334,8 @@ Rectangle {
|
||||
MouseArea {
|
||||
id: labelArea
|
||||
anchors.fill: parent
|
||||
enabled: (root.item.labelId || "") !== ""
|
||||
// Not a link in select mode, for the artist name's reason.
|
||||
enabled: !root.selectMode && (root.item.labelId || "") !== ""
|
||||
hoverEnabled: true
|
||||
cursorShape: Qt.PointingHandCursor
|
||||
onClicked: QbzHome.openLabel(root.item.labelId)
|
||||
|
||||
Reference in new issue
Block a user