From 7753d2520e8518ea82f0ec352ad5c5b0ac154681 Mon Sep 17 00:00:00 2001 From: vicrodh <103399283+vicrodh@users.noreply.github.com> Date: Sun, 1 Mar 2026 16:19:12 -0600 Subject: [PATCH] fix: multi-select add to playlist sends all tracks in one call The broken views called onTrackAddToPlaylist in a loop (once per selected track), causing each call to overwrite the previous track IDs in the playlist modal. Only the last track survived. Now all 6 views collect IDs first and call onBulkAddToPlaylist once with the full array. Views fixed: ArtistDetailView, AlbumDetailView, LabelView, FavoritesView, WeeklySuggestView, PlaylistDetailView. --- src/lib/components/views/AlbumDetailView.svelte | 4 +++- src/lib/components/views/ArtistDetailView.svelte | 4 +++- src/lib/components/views/FavoritesView.svelte | 6 +++--- src/lib/components/views/LabelView.svelte | 4 +++- src/lib/components/views/PlaylistDetailView.svelte | 11 ++++++----- src/lib/components/views/WeeklySuggestView.svelte | 4 +++- src/routes/+page.svelte | 6 ++++++ 7 files changed, 27 insertions(+), 12 deletions(-) diff --git a/src/lib/components/views/AlbumDetailView.svelte b/src/lib/components/views/AlbumDetailView.svelte index e3d6e3fcf..888b66db1 100644 --- a/src/lib/components/views/AlbumDetailView.svelte +++ b/src/lib/components/views/AlbumDetailView.svelte @@ -89,6 +89,7 @@ onPlayAllNext?: () => void; onPlayAllLater?: () => void; onAddTrackToPlaylist?: (trackId: number) => void; + onBulkAddToPlaylist?: (trackIds: number[]) => void; onAddAlbumToPlaylist?: () => void; onTrackDownload?: (track: Track) => void; onTrackRemoveDownload?: (trackId: number) => void; @@ -137,6 +138,7 @@ onPlayAllNext, onPlayAllLater, onAddTrackToPlaylist, + onBulkAddToPlaylist, onAddAlbumToPlaylist, onTrackDownload, onTrackRemoveDownload, @@ -227,7 +229,7 @@ } async function handleBulkAddToPlaylist() { - for (const id of multiSelectedIds) { onAddTrackToPlaylist?.(id); } + onBulkAddToPlaylist?.([...multiSelectedIds]); multiSelectMode = false; multiSelectedIds = new Set(); } diff --git a/src/lib/components/views/ArtistDetailView.svelte b/src/lib/components/views/ArtistDetailView.svelte index ef5fa680b..2b59d33dc 100644 --- a/src/lib/components/views/ArtistDetailView.svelte +++ b/src/lib/components/views/ArtistDetailView.svelte @@ -93,6 +93,7 @@ onTrackPlayLater?: (track: Track) => void; onTrackAddFavorite?: (trackId: number) => void; onTrackAddToPlaylist?: (trackId: number) => void; + onBulkAddToPlaylist?: (trackIds: number[]) => void; onAddAlbumToPlaylist?: (albumId: string) => void; onTrackShareQobuz?: (trackId: number) => void; onTrackShareSonglink?: (track: Track) => void; @@ -128,6 +129,7 @@ onTrackPlayLater, onTrackAddFavorite, onTrackAddToPlaylist, + onBulkAddToPlaylist, onAddAlbumToPlaylist, onTrackShareQobuz, onTrackShareSonglink, @@ -355,7 +357,7 @@ } async function handleBulkAddToPlaylist() { - for (const id of multiSelectedIds) { onTrackAddToPlaylist?.(id); } + onBulkAddToPlaylist?.([...multiSelectedIds]); multiSelectMode = false; multiSelectedIds = new Set(); } diff --git a/src/lib/components/views/FavoritesView.svelte b/src/lib/components/views/FavoritesView.svelte index 0d516ac8d..a4bed330f 100644 --- a/src/lib/components/views/FavoritesView.svelte +++ b/src/lib/components/views/FavoritesView.svelte @@ -95,6 +95,7 @@ onTrackPlayLater?: (track: DisplayTrack) => void; onTrackAddFavorite?: (trackId: number) => void; onTrackAddToPlaylist?: (trackId: number) => void; + onBulkAddToPlaylist?: (trackIds: number[]) => void; onTrackShareQobuz?: (trackId: number) => void; onTrackShareSonglink?: (track: DisplayTrack) => void; onTrackGoToAlbum?: (albumId: string) => void; @@ -155,6 +156,7 @@ onTrackPlayLater, onTrackAddFavorite, onTrackAddToPlaylist, + onBulkAddToPlaylist, onTrackShareQobuz, onTrackShareSonglink, onTrackGoToAlbum, @@ -275,9 +277,7 @@ } async function handleBulkAddToPlaylist() { - for (const id of selectedTrackIds) { - onTrackAddToPlaylist?.(id); - } + onBulkAddToPlaylist?.([...selectedTrackIds]); trackSelectMode = false; selectedTrackIds = new Set(); } diff --git a/src/lib/components/views/LabelView.svelte b/src/lib/components/views/LabelView.svelte index ec7d76add..790ed7666 100644 --- a/src/lib/components/views/LabelView.svelte +++ b/src/lib/components/views/LabelView.svelte @@ -66,6 +66,7 @@ onTrackPlayLater?: (track: Track) => void; onTrackAddFavorite?: (trackId: number) => void; onTrackAddToPlaylist?: (trackId: number) => void; + onBulkAddToPlaylist?: (trackIds: number[]) => void; onTrackGoToAlbum?: (albumId: string) => void; activeTrackId?: number | null; isPlaybackActive?: boolean; @@ -101,6 +102,7 @@ onTrackPlayLater, onTrackAddFavorite, onTrackAddToPlaylist, + onBulkAddToPlaylist, onTrackGoToAlbum, activeTrackId = null, isPlaybackActive = false, @@ -213,7 +215,7 @@ } async function handleBulkAddToPlaylist() { - for (const id of multiSelectedIds) { onTrackAddToPlaylist?.(id); } + onBulkAddToPlaylist?.([...multiSelectedIds]); multiSelectMode = false; multiSelectedIds = new Set(); } diff --git a/src/lib/components/views/PlaylistDetailView.svelte b/src/lib/components/views/PlaylistDetailView.svelte index 3237a2ef7..16e207b12 100644 --- a/src/lib/components/views/PlaylistDetailView.svelte +++ b/src/lib/components/views/PlaylistDetailView.svelte @@ -157,6 +157,7 @@ onTrackPlayLater?: (track: DisplayTrack) => void; onTrackAddFavorite?: (trackId: number) => void; onTrackAddToPlaylist?: (trackId: number) => void; + onBulkAddToPlaylist?: (trackIds: number[]) => void; onTrackShareQobuz?: (trackId: number) => void; onTrackShareSonglink?: (track: DisplayTrack) => void; onTrackGoToAlbum?: (albumId: string) => void; @@ -188,6 +189,7 @@ onTrackPlayLater, onTrackAddFavorite, onTrackAddToPlaylist, + onBulkAddToPlaylist, onTrackShareQobuz, onTrackShareSonglink, onTrackGoToAlbum, @@ -1160,11 +1162,10 @@ } async function handleBulkAddToPlaylist() { - for (const trk of displayTracks) { - if (multiSelectedKeys.has(getTrackKey(trk)) && !trk.isLocal) { - onTrackAddToPlaylist?.(trk.id); - } - } + const trackIds = displayTracks + .filter(trk => multiSelectedKeys.has(getTrackKey(trk)) && !trk.isLocal) + .map(trk => trk.id); + if (trackIds.length > 0) onBulkAddToPlaylist?.(trackIds); multiSelectedKeys = new Set(); multiSelectMode = false; } diff --git a/src/lib/components/views/WeeklySuggestView.svelte b/src/lib/components/views/WeeklySuggestView.svelte index 73dcd711a..90e0af629 100644 --- a/src/lib/components/views/WeeklySuggestView.svelte +++ b/src/lib/components/views/WeeklySuggestView.svelte @@ -27,6 +27,7 @@ onTrackPlayNext?: (track: DisplayTrack) => void; onTrackPlayLater?: (track: DisplayTrack) => void; onTrackAddToPlaylist?: (trackId: number) => void; + onBulkAddToPlaylist?: (trackIds: number[]) => void; onTrackShareQobuz?: (trackId: number) => void; onTrackShareSonglink?: (track: DisplayTrack) => void; onTrackGoToAlbum?: (albumId: string) => void; @@ -46,6 +47,7 @@ onTrackPlayNext, onTrackPlayLater, onTrackAddToPlaylist, + onBulkAddToPlaylist, onTrackShareQobuz, onTrackShareSonglink, onTrackGoToAlbum, @@ -116,7 +118,7 @@ } async function handleBulkAddToPlaylist() { - for (const id of multiSelectedIds) { onTrackAddToPlaylist?.(id); } + onBulkAddToPlaylist?.([...multiSelectedIds]); multiSelectMode = false; multiSelectedIds = new Set(); } let userPlaylists = $state([]); diff --git a/src/routes/+page.svelte b/src/routes/+page.svelte index 3be65b479..4c76c0766 100644 --- a/src/routes/+page.svelte +++ b/src/routes/+page.svelte @@ -3830,6 +3830,7 @@ onPlayAllNext={handleAddAlbumToQueueNext} onPlayAllLater={handleAddAlbumToQueueLater} onAddTrackToPlaylist={(trackId) => openAddToPlaylist([trackId])} + onBulkAddToPlaylist={(trackIds) => openAddToPlaylist(trackIds)} onAddAlbumToPlaylist={() => addAlbumToPlaylist(selectedAlbum)} onTrackDownload={handleTrackDownload} onTrackRemoveDownload={handleTrackRemoveDownload} @@ -3879,6 +3880,7 @@ onTrackPlayLater={queueQobuzTrackLater} onTrackAddFavorite={handleAddToFavorites} onTrackAddToPlaylist={(trackId) => openAddToPlaylist([trackId])} + onBulkAddToPlaylist={(trackIds) => openAddToPlaylist(trackIds)} onAddAlbumToPlaylist={addAlbumToPlaylistById} onTrackShareQobuz={shareQobuzTrackLink} onTrackShareSonglink={(track) => shareSonglinkTrack(track.id, track.isrc)} @@ -3927,6 +3929,7 @@ onTrackPlayNext={queueQobuzTrackNext} onTrackPlayLater={queueQobuzTrackLater} onTrackAddToPlaylist={(trackId) => openAddToPlaylist([trackId])} + onBulkAddToPlaylist={(trackIds) => openAddToPlaylist(trackIds)} onTrackAddFavorite={handleAddToFavorites} onTrackGoToAlbum={handleAlbumClick} activeTrackId={currentTrack?.id ?? null} @@ -3973,6 +3976,7 @@ onTrackPlayLater={queuePlaylistTrackLater} onTrackAddFavorite={handleAddToFavorites} onTrackAddToPlaylist={(trackId) => openAddToPlaylist([trackId])} + onBulkAddToPlaylist={(trackIds) => openAddToPlaylist(trackIds)} onTrackShareQobuz={shareQobuzTrackLink} onTrackShareSonglink={(track) => shareSonglinkTrack(track.id, track.isrc)} onTrackGoToAlbum={handleAlbumClick} @@ -4029,6 +4033,7 @@ onTrackPlayLater={queuePlaylistTrackLater} onTrackAddFavorite={handleAddToFavorites} onTrackAddToPlaylist={(trackId) => openAddToPlaylist([trackId])} + onBulkAddToPlaylist={(trackIds) => openAddToPlaylist(trackIds)} onTrackShareQobuz={shareQobuzTrackLink} onTrackShareSonglink={(track) => shareSonglinkTrack(track.id, track.isrc)} onTrackGoToAlbum={handleAlbumClick} @@ -4219,6 +4224,7 @@ onTrackPlayNext={queueDisplayTrackNext} onTrackPlayLater={queueDisplayTrackLater} onTrackAddToPlaylist={(trackId) => openAddToPlaylist([trackId])} + onBulkAddToPlaylist={(trackIds) => openAddToPlaylist(trackIds)} onTrackShareQobuz={shareQobuzTrackLink} onTrackShareSonglink={(track) => shareSonglinkTrack(track.id, track.isrc)} onTrackGoToAlbum={handleAlbumClick}