fix: validate genre filter to prevent empty home sections
Add validateAndCleanStoredGenreIds() to detect and remove stale genre IDs from localStorage that do not exist in the loaded genre list. This prevents the Qobuz API from returning empty results when localStorage contains outdated genre IDs from previous sessions. The validation runs after loading genres from both cache and API paths.
This commit is contained in:
1 parent
25e91425bc
commit
71bbc42bcf
1 file changed
+37
@@ -157,6 +157,39 @@ export function getContext(): GenreFilterContext {
|
||||
}
|
||||
|
||||
/** Initial load: use cache if valid, otherwise fetch from API */
|
||||
/**
|
||||
* Validate and clean stored genre IDs, removing any that don't exist in loaded genres.
|
||||
* This prevents stale localStorage data from causing empty API results.
|
||||
*/
|
||||
function validateAndCleanStoredGenreIds(): void {
|
||||
const validIds = new Set(state.allGenres.map(g => g.id));
|
||||
let cleaned = false;
|
||||
|
||||
for (const context of ['home', 'favorites'] as const) {
|
||||
const ctxState = state.contexts[context];
|
||||
const invalidIds: number[] = [];
|
||||
|
||||
for (const id of ctxState.selectedGenreIds) {
|
||||
if (!validIds.has(id)) {
|
||||
invalidIds.push(id);
|
||||
}
|
||||
}
|
||||
|
||||
if (invalidIds.length > 0) {
|
||||
console.warn(`[DEBUG-43] Found ${invalidIds.length} stale genre ID(s) in ${context} context:`, invalidIds);
|
||||
for (const id of invalidIds) {
|
||||
ctxState.selectedGenreIds.delete(id);
|
||||
}
|
||||
cleaned = true;
|
||||
saveToStorage(context);
|
||||
}
|
||||
}
|
||||
|
||||
if (cleaned) {
|
||||
console.warn('[DEBUG-43] Cleaned stale genre IDs from localStorage');
|
||||
}
|
||||
}
|
||||
|
||||
export async function loadGenres(): Promise<void> {
|
||||
if (state.parentGenres.length > 0) return;
|
||||
|
||||
@@ -169,6 +202,8 @@ export async function loadGenres(): Promise<void> {
|
||||
state.genreTree = buildTreeFromCache(cache);
|
||||
loadFromStorage('home');
|
||||
loadFromStorage('favorites');
|
||||
// Validate stored genre IDs against loaded genres
|
||||
validateAndCleanStoredGenreIds();
|
||||
notifyAll();
|
||||
return;
|
||||
}
|
||||
@@ -237,6 +272,8 @@ export async function loadGenres(): Promise<void> {
|
||||
saveGenreCache();
|
||||
loadFromStorage('home');
|
||||
loadFromStorage('favorites');
|
||||
// Validate stored genre IDs against loaded genres
|
||||
validateAndCleanStoredGenreIds();
|
||||
} catch (e) {
|
||||
console.error('Failed to load genres:', e);
|
||||
state.parentGenres = [];
|
||||
|
||||
Reference in new issue
Block a user