From 635b8b3a45910318f87d0a84e591566756f3c3bc Mon Sep 17 00:00:00 2001
From: vicrodh <103399283+vicrodh@users.noreply.github.com>
Date: Mon, 24 Aug 2026 22:00:22 -0600
Subject: [PATCH] fix(metadata): restore editor mounting

Remove an unsupported shared-button property that invalidated the
workspace type lazily in both AlbumView and ephemeral surfaces.

cx
---
 crates/qbz-qt/qml/controls/TagEditorWorkspace.qml | 1 -
 crates/qbz-qt/src/tag_editor_qt.rs                | 4 ++++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/crates/qbz-qt/qml/controls/TagEditorWorkspace.qml b/crates/qbz-qt/qml/controls/TagEditorWorkspace.qml
index bc743306b..c662ca465 100644
--- a/crates/qbz-qt/qml/controls/TagEditorWorkspace.qml
+++ b/crates/qbz-qt/qml/controls/TagEditorWorkspace.qml
@@ -912,7 +912,6 @@ Item {
                         SettingsButton {
                             text: workspace.editor.tr("Apply to form")
                             iconName: "download"
-                            primary: true
                             minWidth: 0
                             onClicked: workspace.editor.applyRemote()
                         }
diff --git a/crates/qbz-qt/src/tag_editor_qt.rs b/crates/qbz-qt/src/tag_editor_qt.rs
index e9da8d886..64a875bd6 100644
--- a/crates/qbz-qt/src/tag_editor_qt.rs
+++ b/crates/qbz-qt/src/tag_editor_qt.rs
@@ -1850,5 +1850,9 @@ mod tests {
         assert!(workspace
             .contains("visible: QbzTagEditor.artworkSearching || QbzTagEditor.artworkLoading"));
         assert!(workspace.contains("id: lookupCard"));
+        // SettingsButton is the shared secondary settings control and has no
+        // `primary` property. An unknown assignment invalidates the entire QML
+        // type lazily, so neither AlbumView nor ephemeral can mount the editor.
+        assert!(!workspace.contains("primary: true"));
     }
 }