fix: address 7 code review findings for V2 architecture
HIGH priority fixes: - Enable WAL mode in qbz-integrations caches (ADR-002) - v2_auto_login/v2_manual_login now call activate_session() - RequiresUserSession allows offline sessions (only checks session_activated) MEDIUM priority fixes: - Consolidate lifecycle: legacy commands delegate to session_lifecycle - ListenBrainz teardown now calls disconnect() to clear tokens - Add SessionActivationFailed degraded reason and emit event on failure
This commit is contained in:
1 parent
d6e4b3349b
commit
59e3141aa6
6 files changed
+46
-220
No files matched your search
@@ -205,8 +205,10 @@ pub async fn runtime_bootstrap(
|
||||
// This initializes all per-user stores and sets runtime state
|
||||
if let Err(e) = crate::session_lifecycle::activate_session(&app, session.user_id).await {
|
||||
log::error!("[Runtime] Session activation failed: {}", e);
|
||||
// Non-fatal for bootstrap - stores can be initialized later
|
||||
// But log it prominently
|
||||
// Non-fatal for bootstrap - user can still use app but some features may not work
|
||||
// Emit degraded event so frontend knows
|
||||
let reason = DegradedReason::SessionActivationFailed(e.clone());
|
||||
let _ = app.emit("runtime:event", RuntimeEvent::RuntimeDegraded { reason });
|
||||
}
|
||||
}
|
||||
Err(e) => {
|
||||
@@ -391,6 +393,12 @@ pub async fn v2_auto_login(
|
||||
});
|
||||
}
|
||||
|
||||
// Activate per-user session (initializes all per-user stores)
|
||||
if let Err(e) = crate::session_lifecycle::activate_session(&app, session.user_id).await {
|
||||
log::error!("[V2] Session activation failed: {}", e);
|
||||
// Non-fatal - consider login successful, stores can be initialized later
|
||||
}
|
||||
|
||||
// Emit ready event
|
||||
let _ = app.emit("runtime:event", RuntimeEvent::RuntimeReady {
|
||||
user_id: session.user_id,
|
||||
@@ -495,6 +503,12 @@ pub async fn v2_manual_login(
|
||||
});
|
||||
}
|
||||
|
||||
// Activate per-user session (initializes all per-user stores)
|
||||
if let Err(e) = crate::session_lifecycle::activate_session(&app, session.user_id).await {
|
||||
log::error!("[V2] Session activation failed: {}", e);
|
||||
// Non-fatal - consider login successful, stores can be initialized later
|
||||
}
|
||||
|
||||
// Emit ready event
|
||||
let _ = app.emit("runtime:event", RuntimeEvent::RuntimeReady {
|
||||
user_id: session.user_id,
|
||||
|
||||
Reference in new issue
Block a user