Joren/qbz
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(slint): correct absolute-position double-count inside Flickable

Browse Source 
absolute-position of an element nested in a Flickable double-counts the
element's own layout offset (measured: abs.y = true_y + root.y), so the
collapsed-sidebar folder flyout drifted down by one row-pitch per row
(lower folders left the viewport) and the track drag ghost plus the
playlist drop-target hit box drifted the same way. Subtract root.{x,y}
to recover the true window position; scroll-safe because root.{x,y} is
the row's fixed in-layout offset, not the viewport scroll. Rows outside
a Flickable (the section nav rows) are unaffected and left as-is.

Sites: SidebarRow folder-flyout anchor + recompute-drop hit box;
TrackRow drag down/threshold/start/move coordinates.

cc
This commit is contained in:
vicrodh committed 2026-05-30 19:03:11 -06:00
1 parent 89734ae3ab
commit 4c0a849371
2 files changed
+34 -16
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

crates/qbz-slint/ui/primitives/TrackRow.slint
+13 -10
View File
@@ -91,8 +91,13 @@ export component TrackRow inherits Rectangle {
NavState.request-forward();
}
if (e.kind == PointerEventKind.down) {
ta.down-x = root.absolute-position.x + ta.mouse-x;
ta.down-y = root.absolute-position.y + ta.mouse-y;
// absolute-position double-counts this row's own layout offset
// when the row sits inside a Flickable (the track list), so the
// global pointer drifted down by the row's offset. Subtract
// root.{x,y} to recover the true window position (scroll-safe:
// root.{x,y} is the fixed in-layout offset, not the scroll).
ta.down-x = root.absolute-position.x - root.x + ta.mouse-x;
ta.down-y = root.absolute-position.y - root.y + ta.mouse-y;
ta.dragging = false;
}
if (e.kind == PointerEventKind.up && ta.dragging) {
@@ -103,24 +108,22 @@ export component TrackRow inherits Rectangle {
moved => {
if (ta.pressed && root.draggable) {
if (!ta.dragging
&& (Math.abs(root.absolute-position.x + ta.mouse-x - ta.down-x) > 6px
|| Math.abs(root.absolute-position.y + ta.mouse-y - ta.down-y) > 6px)) {
&& (Math.abs(root.absolute-position.x - root.x + ta.mouse-x - ta.down-x) > 6px
|| Math.abs(root.absolute-position.y - root.y + ta.mouse-y - ta.down-y) > 6px)) {
ta.dragging = true;
debug("DRAG absx=", root.absolute-position.x, " absy=", root.absolute-position.y,
" mx=", ta.mouse-x, " my=", ta.mouse-y);
DragActions.start(
root.track.id,
root.track.title,
root.track.album != ""
? root.track.artist + " · " + root.track.album
: root.track.artist,
root.absolute-position.x + ta.mouse-x,
root.absolute-position.y + ta.mouse-y);
root.absolute-position.x - root.x + ta.mouse-x,
root.absolute-position.y - root.y + ta.mouse-y);
}
if (ta.dragging) {
DragActions.move(
root.absolute-position.x + ta.mouse-x,
root.absolute-position.y + ta.mouse-y);
root.absolute-position.x - root.x + ta.mouse-x,
root.absolute-position.y - root.y + ta.mouse-y);
}
}
}