Joren/qbz
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(player): stop DoP writer on ALSA write failure

Browse Source 
Match the PCM ALSA path: on write_dop_i32 Err, stop the writer thread
instead of logging and advancing position (which desyncs DoP markers).
This commit is contained in:
Afonso Jorge Ramos committed 2026-07-11 23:01:05 +02:00
1 parent a9949b8cf2
commit 3dc54a751d
1 file changed
+7 -1
Download Patch File Download Diff File Expand all files Collapse all files
crates/qbz-player/src/player/playback_engine.rs
+7 -1
View File
@@ -956,7 +956,13 @@ fn dop_writer_thread(
if !buf.is_empty() { if !buf.is_empty() {
if let Err(e) = stream.write_dop_i32(&buf) { if let Err(e) = stream.write_dop_i32(&buf) {
log::error!("[DoP Engine] Write failed: {}", e); // Match PCM ALSA: a hard write failure must stop the writer.
// Continuing would desync DoP markers (harsh noise) and leave
// exclusive mode stuck while position still advances.
log::error!("[DoP Engine] Write failed: {e} — stopping writer");
is_playing.store(false, Ordering::SeqCst);
should_stop.store(true, Ordering::SeqCst);
break 'thread;
} }
position_frames.fetch_add((buf.len() / channels as usize) as u64, Ordering::SeqCst); position_frames.fetch_add((buf.len() / channels as usize) as u64, Ordering::SeqCst);
} }