fix(build): drop compile-time x86 target-features — runtime AES dispatch

Users on CPUs without AES-NI (Nehalem i7-860, pre-2010 Intel Macs) or
without SSSE3 (AMD Phenom II) crashed at launch with SIGILL. The
global `-C target-feature=+aes,+ssse3` was kept after the #353/#343
x86-64-v3 incident on the belief that the aes crate's cpufeatures
runtime check would protect CPUs without AES-NI — but a compile-time
target feature makes cpufeatures compile its check to a constant, so
the AES-NI intrinsics ran unconditionally (credentials AES-GCM decrypt
at startup), and +ssse3 let LLVM autovectorize anywhere, breaking
Phenom II. Measured on the qbz-cmaf hot path (Ctr128BE<Aes128>
apply_keystream, 256 MB, release): 2145 MB/s compiled-in vs 2162 MB/s
runtime-dispatched, identical output — the flags bought nothing on
capable CPUs. Removed from .cargo/config.toml, all dev/build scripts
and the release/build workflows; old CPUs now get the software AES
fallback instead of a crash.

Fixes #549

cc
This commit is contained in:
vicrodh committed 2026-07-05 14:17:46 -06:00
1 parent 444b21f0c1
commit 395e537b59
9 files changed
+104 -68

No files matched your search

+1 -4
View File
@@ -15,12 +15,9 @@
# DO NOT use this to judge performance — the binary is unoptimised. Always do a
# final pass with ./slint-dev.sh (release) before trusting runtime behaviour.
#
# RUSTFLAGS overrides .cargo/config.toml, so the AES-NI/SSSE3 features are
# re-listed here (keep in sync with slint-dev.sh / .cargo/config.toml).
#
# Usage: ./scripts/slint-dev-fast.sh [extra cargo args]
# THREADS=22 ./scripts/slint-dev-fast.sh # override frontend threads
set -euo pipefail
cd "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/.."
export RUSTFLAGS="-C target-feature=+aes,+ssse3 -C link-arg=-fuse-ld=mold -C debuginfo=0 -Z threads=${THREADS:-16}"
export RUSTFLAGS="-C link-arg=-fuse-ld=mold -C debuginfo=0 -Z threads=${THREADS:-16}"
exec cargo +nightly run --manifest-path crates/Cargo.toml -p qbz "$@"