From 269cae3db852d37762ec7d7c4923fca5e89d9dc5 Mon Sep 17 00:00:00 2001 From: vicrodh <103399283+vicrodh@users.noreply.github.com> Date: Sat, 20 Jun 2026 15:52:22 -0600 Subject: [PATCH] feat(a11y): tokenize inline disabled-warning banner to Theme.warning The BlacklistManagerView disabled-filter banner hardcoded the Dark-theme warning hex (#fbbf24 / #fbbf241a / #fbbf244d) for fill, border, icon tint and label. These resolve to no other cluster (item #6's named-file list excludes this view; item #7 owns the WarningBanner.slint primitive, a different file), so without this swap accessible themes (wcag-dark, high-contrast) would render the wrong amber here, defeating P4's 'accessible themes take effect everywhere' goal. The hex equal the Dark warning family exactly, so the swap is identity-preserving on the default theme. cc --- crates/qbz-slint/ui/settings/BlacklistManagerView.slint | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/qbz-slint/ui/settings/BlacklistManagerView.slint b/crates/qbz-slint/ui/settings/BlacklistManagerView.slint index de3dc7b8f..d28055bd6 100644 --- a/crates/qbz-slint/ui/settings/BlacklistManagerView.slint +++ b/crates/qbz-slint/ui/settings/BlacklistManagerView.slint @@ -352,9 +352,9 @@ export component BlacklistManagerView inherits Rectangle { vertical-stretch: 0; height: warn-row.preferred-height + 24px; border-radius: Radius.md; - background: #fbbf241a; + background: Theme.warning-bg; border-width: 1px; - border-color: #fbbf244d; + border-color: Theme.warning-border; warn-row := HorizontalLayout { padding: 12px; spacing: 10px; @@ -364,14 +364,14 @@ export component BlacklistManagerView inherits Rectangle { source: @image-url("../assets/icons/circle-alert.svg"); width: 16px; height: 16px; - tint: #fbbf24; + tint: Theme.warning; } } VerticalLayout { alignment: center; Text { text: @tr("Blacklist filtering is disabled. Blacklisted artists are shown everywhere until you re-enable it."); - color: #fbbf24; + color: Theme.warning; font-size: Typography.legal; wrap: word-wrap; }