From 20eac2f578a1026b3f1f3f4f323abeba13f290e8 Mon Sep 17 00:00:00 2001 From: vicrodh <103399283+vicrodh@users.noreply.github.com> Date: Mon, 19 Jan 2026 20:41:57 -0600 Subject: [PATCH] Speed up ALAC playback by using streaming decoder Removed special case that forced ALAC to use symphonia fallback which decoded the entire file (~30MB) before playback, causing 6+ second delays. Now ALAC uses rodio's Decoder first (supports ALAC via symphonia-all feature) which streams instead of decoding everything upfront. Fallback chain is now: 1. Rodio Decoder (streaming) - instant 2. MP4 fallback (streaming) - instant 3. Symphonia (full decode) - slow, last resort This brings ALAC playback start time from ~6 seconds to instant, matching FLAC and other formats. --- src-tauri/src/player/mod.rs | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src-tauri/src/player/mod.rs b/src-tauri/src/player/mod.rs index e2256a245..d63fa48e2 100644 --- a/src-tauri/src/player/mod.rs +++ b/src-tauri/src/player/mod.rs @@ -235,14 +235,8 @@ fn extract_audio_metadata(data: &[u8]) -> Result<(u32, u16), String> { fn decode_with_fallback( data: &[u8], ) -> Result + Send>, String> { - if is_isomp4(data) { - return decode_with_symphonia(data) - .map(|specs| { - log::info!("Decoded audio using symphonia fallback (isomp4)"); - Box::new(specs.samples) as Box + Send> - }); - } - + // Try rodio's Decoder first (supports ALAC via symphonia-all feature) + // This streams instead of decoding everything upfront let primary = panic::catch_unwind(AssertUnwindSafe(|| { Decoder::new(BufReader::new(Cursor::new(data.to_vec()))) }));