chore: log the three failures that were silently discarded

Volume restore (desktop session and qbzd driver), a playback-thread panic
at stop, and a credentials decrypt failure (now naming the file and the
likely cause, without the inert legacy retry).

cc
This commit is contained in:
vicrodh committed 2026-09-13 03:36:51 -06:00
1 parent aff24e598b
commit 196887534a
4 files changed
+24 -11

No files matched your search

@@ -568,7 +568,9 @@ impl PlaybackEngine {
is_playing.store(false, Ordering::SeqCst);
if let Some(handle) = playback_thread.take() {
let _ = handle.join();
if handle.join().is_err() {
log::error!("[{label}] playback thread panicked before stop completed");
}
}
if let Err(e) = stream.stop() {
@@ -589,7 +591,9 @@ impl PlaybackEngine {
should_stop.store(true, Ordering::SeqCst);
is_playing.store(false, Ordering::SeqCst);
if let Some(handle) = feeder_thread.take() {
let _ = handle.join();
if handle.join().is_err() {
log::error!("[JACK Engine] feeder thread panicked before stop completed");
}
}
// JackStream's Drop deactivates the client + unregisters the ports.
}
@@ -608,7 +612,9 @@ impl PlaybackEngine {
should_stop.store(true, Ordering::SeqCst);
is_playing.store(false, Ordering::SeqCst);
if let Some(handle) = writer_thread.take() {
let _ = handle.join();
if handle.join().is_err() {
log::error!("[DoP Engine] writer thread panicked before stop completed");
}
}
if let Err(e) = stream.stop() {
log::warn!("[DoP Engine] Stop failed: {}", e);