From 1666672f0c1f95c712d59bba152df5ce650dc147 Mon Sep 17 00:00:00 2001 From: vicrodh <103399283+vicrodh@users.noreply.github.com> Date: Sat, 7 Feb 2026 03:33:52 -0600 Subject: [PATCH] fix: version unavailable in changelog button initUpdatesStore used Promise.all for get_current_version and get_update_preferences. Since preferences need the SQLite store (only available after login), the failure killed both promises, leaving currentVersion as empty string. Split into independent calls so the version (a compile-time constant that never needs a session) is always available regardless of preference store state. --- src/lib/stores/updatesStore.ts | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/src/lib/stores/updatesStore.ts b/src/lib/stores/updatesStore.ts index 0d3aaca68..91dae276e 100644 --- a/src/lib/stores/updatesStore.ts +++ b/src/lib/stores/updatesStore.ts @@ -57,17 +57,24 @@ export function getCurrentVersion(): string { export async function initUpdatesStore(): Promise { if (initialized) return; initialized = true; + + // get_current_version never needs a session (compile-time value). + // get_update_preferences needs the SQLite store which is only + // available after login. Fetch them independently so a preference + // failure doesn't lose the version. try { - const [prefs, version] = await Promise.all([ - invoke('get_update_preferences'), - invoke('get_current_version'), - ]); - preferences = prefs; - currentVersion = version; - notify(); + currentVersion = await invoke('get_current_version'); } catch (error) { - console.debug('[Updates] Failed to initialize updates store:', error); + console.error('[Updates] Failed to get current version:', error); } + + try { + preferences = await invoke('get_update_preferences'); + } catch { + // Expected before login — store not initialised yet. + } + + notify(); } export async function refreshUpdatePreferences(): Promise {