chore: clean svelte-check warnings (CSS, a11y, types)

Drains the wiki "23 warnings" baseline back to zero so future regressions
stand out:

* Drop 16 unprefixed \`app-region\` CSS lines across TitleBar, TitleBarNav,
  ImmersiveHeader, ImmersivePlayer, MiniPlayerFooter and MiniPlayerWindowControls.
  Tauri's webview is WebKit / Chromium on every platform we ship to, so
  \`-webkit-app-region\` already covers the chrome-drag region; the
  unprefixed property only existed to keep stylelint quiet but the CSS
  spec doesn't define it and svelte-check warns on every site.
* Remove 2 empty rulesets in AlbumCreditsModal and NowPlayingBar (leftover
  comment-only blocks from earlier refactors).
* Pair \`-moz-appearance: textfield\` with the standard \`appearance: textfield\`
  in LocalLibraryTagEditorModal so the rule no longer trips the
  property-companion warning.
* Delete the unused \`.quality-text\` selector in NowPlayingBar.backup.svelte
  (file is a frozen snapshot of an older NPB iteration; the live NPB
  doesn't use that class).
* Annotate Tooltip.svelte and immersive/panels/VinylPanel.svelte with
  \`svelte-ignore a11y_no_static_element_interactions\` plus a comment
  explaining the context — both are decorative wrappers (a tooltip hit
  area; a 3D tilt effect on artwork) where adding an ARIA role would
  misrepresent the semantics.
* Add \`@types/node\` as a devDependency (^22) so the tsconfig resolution
  for the SvelteKit-extended config stops complaining about the missing
  type definition.

cc
This commit is contained in:
vicrodh committed 2026-05-09 09:46:43 -06:00
1 parent 055b76bfbe
commit 0274f2b030
14 files changed
+29 -28

No files matched your search

+18
View File
@@ -28,6 +28,7 @@
"@sveltejs/vite-plugin-svelte": "^7.0.0",
"@tauri-apps/cli": "^2",
"@testing-library/svelte": "^5.3.1",
"@types/node": "^22.19.18",
"jsdom": "^29.1.1",
"svelte": "^5.55.5",
"svelte-check": "^4.4.8",
@@ -1744,6 +1745,16 @@
"integrity": "sha512-dWHzHa2WqEXI/O1E9OjrocMTKJl2mSrEolh1Iomrv6U+JuNwaHXsXx9bLu5gG7BUWFIN0skIQJQ/L1rIex4X6w==",
"license": "MIT"
},
"node_modules/@types/node": {
"version": "22.19.18",
"resolved": "https://registry.npmjs.org/@types/node/-/node-22.19.18.tgz",
"integrity": "sha512-9v00a+dn2yWVsYDEunWC4g/TcRKVq3r8N5FuZp7u0SGrPvdN9c2yXI9bBuf5Fl0hNCb+QTIePTn5pJs2pwBOQQ==",
"devOptional": true,
"license": "MIT",
"dependencies": {
"undici-types": "~6.21.0"
}
},
"node_modules/@types/trusted-types": {
"version": "2.0.7",
"resolved": "https://registry.npmjs.org/@types/trusted-types/-/trusted-types-2.0.7.tgz",
@@ -3894,6 +3905,13 @@
"node": ">=20.18.1"
}
},
"node_modules/undici-types": {
"version": "6.21.0",
"resolved": "https://registry.npmjs.org/undici-types/-/undici-types-6.21.0.tgz",
"integrity": "sha512-iwDZqg0QAGrg9Rav5H4n0M64c3mkR59cJ6wQp+7C4nI0gsmExaedaYLNO44eT4AtBBwjbTiGPMlt2Md0T9H9JQ==",
"devOptional": true,
"license": "MIT"
},
"node_modules/utif2": {
"version": "4.1.0",
"resolved": "https://registry.npmjs.org/utif2/-/utif2-4.1.0.tgz",
+1
View File
@@ -45,6 +45,7 @@
"@sveltejs/vite-plugin-svelte": "^7.0.0",
"@tauri-apps/cli": "^2",
"@testing-library/svelte": "^5.3.1",
"@types/node": "^22.19.18",
"jsdom": "^29.1.1",
"svelte": "^5.55.5",
"svelte-check": "^4.4.8",
@@ -635,10 +635,6 @@
padding-right: 8px;
}
.track-item {
/* No background */
}
.track-divider {
height: 1px;
background: rgba(255, 255, 255, 0.06);
@@ -780,6 +780,7 @@ input[type="number"]::-webkit-inner-spin-button {
input[type="number"] {
-moz-appearance: textfield;
appearance: textfield;
}
.ref-inline {
@@ -388,10 +388,6 @@
margin-top: 2px;
}
.quality-text {
font-size: 11px;
color: #666666;
}
/* Controls */
.controls-section {
-4
View File
@@ -1068,10 +1068,6 @@
}
}
.seekbar:hover .seekbar-track {
/* keep both layers stable on hover */
}
/* ===== Controls Row ===== */
.controls-row {
flex: 1;
-7
View File
@@ -310,7 +310,6 @@
user-select: none;
-webkit-user-select: none;
-webkit-app-region: drag;
app-region: drag;
}
/* Full variant: keeps the default chrome (drag, dblclick, controls). */
@@ -327,7 +326,6 @@
border-radius: 0;
box-shadow: none;
-webkit-app-region: no-drag;
app-region: no-drag;
}
/* 3-zone layout: left and right zones are equal width, center is fixed */
@@ -375,7 +373,6 @@
transition: background-color 150ms ease, border-color 150ms ease;
flex-shrink: 0;
-webkit-app-region: no-drag;
app-region: no-drag;
color: var(--text-muted);
}
@@ -402,7 +399,6 @@
padding: 0;
min-width: 0;
-webkit-app-region: no-drag;
app-region: no-drag;
}
.titlebar-search-input::placeholder {
@@ -424,7 +420,6 @@
flex-shrink: 0;
transition: background-color 150ms ease, color 150ms ease;
-webkit-app-region: no-drag;
app-region: no-drag;
}
.titlebar-search-clear:hover {
@@ -439,7 +434,6 @@
align-items: stretch;
height: 100%;
-webkit-app-region: no-drag;
app-region: no-drag;
flex-shrink: 0;
}
@@ -488,7 +482,6 @@
cursor: pointer;
transition: background-color 150ms ease, color 150ms ease;
-webkit-app-region: no-drag;
app-region: no-drag;
}
/* --- Rectangular --- */
-2
View File
@@ -461,7 +461,6 @@
gap: 6px;
height: 100%;
-webkit-app-region: no-drag;
app-region: no-drag;
flex-shrink: 0;
}
@@ -499,7 +498,6 @@
transition: background-color 150ms ease, opacity 150ms ease;
white-space: nowrap;
-webkit-app-region: no-drag;
app-region: no-drag;
}
.nav-btn:hover {
+4
View File
@@ -10,6 +10,10 @@
let isVisible = $state(false);
</script>
<!-- The tooltip wrapper is a purely visual hit area; the inner popover
carries the actual tooltip semantics. The linter doesn't recognise
this pattern, hence the local ignore. -->
<!-- svelte-ignore a11y_no_static_element_interactions -->
<div
class="tooltip-container"
onmouseenter={() => (isVisible = true)}
@@ -415,7 +415,6 @@
height: 100%;
cursor: grab;
-webkit-app-region: drag;
app-region: drag;
}
.mode-toggle {
@@ -463,7 +462,6 @@
border: 1px solid rgba(255, 255, 255, 0.15);
border-radius: 12px;
-webkit-app-region: no-drag;
app-region: no-drag;
}
.tab {
@@ -624,7 +622,6 @@
justify-content: flex-end;
gap: 8px;
-webkit-app-region: no-drag;
app-region: no-drag;
}
/* Expandable Window Controls */
@@ -872,7 +872,6 @@
height: 32px;
z-index: 15; /* Above content (1-5), below header controls (20) */
-webkit-app-region: drag;
app-region: drag;
}
/* macOS: overlay titlebar needs drag region above all UI (matches homepage pattern) */
@@ -298,6 +298,11 @@
});
</script>
<!-- Purely decorative tilt-on-mousemove effect over a vinyl artwork
visualisation; nothing here is interactive in the assistive-tech
sense, so the linter rule about ARIA roles on event-wired divs
doesn't apply. -->
<!-- svelte-ignore a11y_no_static_element_interactions -->
<div
class="vinyl-panel"
bind:this={containerRef}
@@ -587,7 +587,6 @@
opacity: 0;
pointer-events: none;
-webkit-app-region: no-drag;
app-region: no-drag;
transition: opacity 120ms ease;
z-index: 12;
}
@@ -607,7 +606,6 @@
opacity: 0;
pointer-events: none;
-webkit-app-region: no-drag;
app-region: no-drag;
transition: opacity 120ms ease;
z-index: 14;
}
@@ -132,7 +132,6 @@
padding: 2px;
overflow: hidden;
-webkit-app-region: no-drag;
app-region: no-drag;
transition: box-shadow 180ms ease, opacity 140ms ease, transform 140ms ease;
}